Skip to content

PWGHF: Add Topology Tag kinematic and topology table HFTag and probe - #4844

Merged
mfaggin merged 10 commits into
AliceO2Group:masterfrom
DanielMorris13:master
Feb 23, 2024
Merged

PWGHF: Add Topology Tag kinematic and topology table HFTag and probe#4844
mfaggin merged 10 commits into
AliceO2Group:masterfrom
DanielMorris13:master

Conversation

@DanielMorris13

@DanielMorris13DanielMorris13 commented Feb 23, 2024

Copy link
Copy Markdown
Contributor

This PR contains:

  • additional process function to collect tag topological and kinematic info in data and MC for DsPlus, Dstar
  • helper function to collect tag pdg mother in MC and store topo. variables into the table

mfaggin
mfaggin requested changes Feb 23, 2024
View reviewed changes

@mfagginmfaggin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Daniel for the work! Please find here my suggestions

Comment threadDPG/Tasks/AOTTrack/tagAndProbeDmesons.cxx Outdated
Comment threadDPG/Tasks/AOTTrack/tagAndProbeDmesons.cxx Outdated
Comment threadDPG/Tasks/AOTTrack/tagAndProbeDmesons.cxx Outdated
Comment threadDPG/Tasks/AOTTrack/tagAndProbeDmesons.cxx Outdated
Comment threadDPG/Tasks/AOTTrack/tagAndProbeDmesons.cxx Outdated
Comment threadDPG/Tasks/AOTTrack/tagAndProbeDmesons.cxx Outdated
Comment threadDPG/Tasks/AOTTrack/tagAndProbeDmesons.cxx Outdated
Comment threadDPG/Tasks/AOTTrack/tagAndProbeDmesons.cxx Outdated
if (!isSelectedTopology(primVtx, secVtx, covMatrixPCA, pVec, trackDcaXy, channel)) {
if (fillTagTable) {
getTagInfo<doMc>(primVtx, secVtx, covMatrixPCA, pVec, trackDcaXy, channel, trackPos, trackNeg, invMass2, pdgDecayMothers, particlesMc);
continue;

@mfagginmfagginFeb 23, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you really need it? Aren't you at the end of the iteration?

@DanielMorris13DanielMorris13Feb 23, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, thank you.
I've implemented the correction.

Comment threadDPG/Tasks/AOTTrack/tagAndProbeDmesons.cxx Outdated
if (!isSelectedTopology(primVtx, secVtx, covMatrixPCA, pVec, trackDcaXy, channel)) {
if (fillTagTable) {
getTagInfo<doMc>(primVtx, secVtx, covMatrixPCA, pVec, trackDcaXy, channel, trackFirst, trackSecond, invMass2, pdgDecayMothers, particlesMc);
continue;

@mfagginmfagginFeb 23, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you really need it? Aren't you at the end of the iteration?

@DanielMorris13DanielMorris13Feb 23, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Comment threadDPG/Tasks/AOTTrack/tagAndProbeDmesons.cxx
/// K∓K± for φ from Ds± or D± → φπ± decays
/// K∓π± for D0 from D±* → D0π± decays
else {
for (auto pdgGrandMother : pdgDecayMothers) {

@mfagginmfagginFeb 23, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case you use DsOrDplusToKKPi you return 1 either if the kaon has a Ds or a D+ as mother, but in this way is not distinguishable. Is it what you want?

@DanielMorris13DanielMorris13Feb 23, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the comment!
For the time being we are following the Fabrizio Grosa recipe where he does not make any selection on the mother for this particular decay channel. Here we are just looking that both Kaons come from the Phi.
https://indico.cern.ch/event/1371921/contributions/5773861/attachments/2787104/4859629/AOTTrack_Dmeson_TagAndProbe.pdf

@DanielMorris13

DanielMorris13 commented Feb 23, 2024

Copy link
Copy Markdown
ContributorAuthor

Hi Mattia!
Thank you for the comments. I implemented the correction.

Daniel.

@mfaggin

mfaggin commented Feb 23, 2024

Copy link
Copy Markdown
Collaborator

Hi Mattia! Thank you for the comments. I implemented the correction.

Daniel.

Thanks Daniel, once you fix the formatting issues I approve it

@DanielMorris13
Merge pull request#2from alibuild/alibot-cleanup-4844
68ce0aa
Please consider the following formatting changes to AliceO2Group#4844
@mfaggin
mfaggin enabled auto-merge (squash) February 23, 2024 15:34
mfaggin
mfaggin previously approved these changes Feb 23, 2024
View reviewed changes
auto-merge was automatically disabled February 23, 2024 15:43

Head branch was pushed to by a user without write access

@DanielMorris13

DanielMorris13 commented Feb 23, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks Mattia, due to formatting issues in one of the automatic test I pushed agin. Can you approve it again?

@mfaggin
mfaggin enabled auto-merge (squash) February 23, 2024 16:49
@mfaggin
mfaggin merged commit 7999fb4 into AliceO2Group:masterFeb 23, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfagginmfagginmfaggin approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@njacazionjacazioAwaiting requested review from njacazionjacazio is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DanielMorris13@mfaggin@alibuild