Uh oh!
There was an error while loading. Please reload this page.
PWGHF: Adding D0 to taskFlowCharmHadrons, including Ml. - #5087
Conversation
Please consider the following formatting changes to AliceO2Group#5087
| tracksQx.push_back(cos(harmonic * phiTrack2) * pTtrack2 / ampl); | ||
| tracksQy.push_back(sin(harmonic * phiTrack2) * pTtrack2 / ampl); | ||
| if constexpr (DecayChannel != DecayChannel::D0ToPiK) { |
There was a problem hiding this comment.
Please avoid this kind of confusing naming patterns. DecayChannel on the left is a variable, DecayChannel on the right is a type.
There was a problem hiding this comment.
Sorry, I have closed this PR due to a failed submission and will resubmit. I'll change or explain existing comments.
| tracksQx.push_back(cos(harmonic * phiTrack2) * pTtrack2 / ampl); | ||
| tracksQy.push_back(sin(harmonic * phiTrack2) * pTtrack2 / ampl); |
There was a problem hiding this comment.
Explicitly state the namespace you use.
| Configurable<int> centDetector{"centDetector", 0, "Detector for centrality estimation (V0A: 0, T0M: 1, T0A: 2, T0C: 3"}; | ||
| Configurable<int> centDetector{"centDetector", 0, "Detector for centrality estimation (V0A: 0, T0M: 1, T0A: 2, T0C: 3)"}; | ||
| Configurable<int> selectionFlag{"selectionFlag", 1, "Selection Flag for hadron (e.g. 1 for skimming, 3 for topo. and kine., 7 for PID)"}; | ||
| Configurable<int> prongNum{"prongNum", 3, "Number of candidate's prong (For D0, set selectionFlag = 1 and prongNum = 2)"}; |
There was a problem hiding this comment.
| Configurable<int> prongNum{"prongNum", 3, "Number of candidate's prong (For D0, set selectionFlag = 1 and prongNum = 2)"}; | |
| Configurable<int> nProngs{"nProngs", 3, "Number of candidate's prong (For D0, set selectionFlag = 1 and nProngs = 2)"}; |
Why does this have to be set manually?
This is the new https://github.com/AliceO2Group/O2Physics/pull/5089@vkucera. Thank you for the comment. |
vkucera
commented
Mar 11, 2024
@Libeiyu In general, there is no reason to close a PR and open a new one from the same branch. The new PR will be identical with the closed one. |
No description provided.