Skip to content

V0: use collinear fit from DCAFitter - #5204

Merged
fmazzasc merged 4 commits into
AliceO2Group:masterfrom
f3sch:v0/collinear
Apr 5, 2024
Merged

V0: use collinear fit from DCAFitter#5204
fmazzasc merged 4 commits into
AliceO2Group:masterfrom
f3sch:v0/collinear

Conversation

@f3sch

@f3schf3sch commented Mar 16, 2024

Copy link
Copy Markdown
Contributor

For photons the position is better resolved using a specialized collinear method in DCAFitter.
Corresponding change in O2 AliceO2Group/AliceO2#12770

For photons the position is better resolved using a specialized
collinear method in DCAFitter.
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch

Copy link
Copy Markdown
ContributorAuthor

Linter fails with:

 --Error detail:
PWGLF/DataModel/LFStrangenessTables.h:762: Add #include <vector> for vector<> [build/include_what_you_use] [4]

Since the changes to this file are unrelated to this, should I actually make this change?

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for add0601 at 2024-03-16 14:26:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/5204-slc7_x86-64/0/PWGLF/TableProducer/lambdakzerobuilder.cxx:667:12: error: 'class o2::vertexing::DCAFitterN<2>' has no member named 'setCollinear'
ninja: build stopped: subcommand failed.

Full log here.

Satisfy MegaLinter flag.
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@ddobrigk

ddobrigk commented Mar 17, 2024

Copy link
Copy Markdown
Collaborator

@f3sch thanks a lot, this is very nice ! About the possible use cases, I wonder if it would additionally also not be useful to have all V0s (regardless of being TPConly) use this alternate fit path if a certain option is enabled (false by default). This way, conversions could also be studied if both tracks have ITS hits in case of a conversion e.g. in the ITS IB.

One more thing, just out of curiosity: would TPC-TOF matches also fall under your special path? I guess not - it's really just for TPC-only - but I wanted to be sure. Thanks! :-D

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 6799384 at 2024-03-17 17:36:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/5204-slc7_x86-64/0/PWGLF/TableProducer/lambdakzerobuilder.cxx:667:12: error: 'class o2::vertexing::DCAFitterN<2>' has no member named 'setCollinear'
ninja: build stopped: subcommand failed.

Full log here.

@f3sch

Copy link
Copy Markdown
ContributorAuthor

Hi @ddobrigk, thanks for taking the time. I will implement your suggestion for the additional switch. For now it is TPC-only only :). BTW why does CI fail here or rather I was under the impression that always the new nightly tag would be available but from the build log it seems to be the O2 version is daily-20240312-0130-local?

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 28ecd4c at 2024-03-18 08:29:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/5204-slc7_x86-64/0/PWGLF/TableProducer/lambdakzerobuilder.cxx:668:12: error: 'class o2::vertexing::DCAFitterN<2>' has no member named 'setCollinear'
ninja: build stopped: subcommand failed.

Full log here.

@f3sch

Copy link
Copy Markdown
ContributorAuthor

@njacazio can this please be merged? cheers

@fmazzasc
fmazzasc enabled auto-merge (squash) April 5, 2024 11:37
@fmazzasc
fmazzasc merged commit 07c7ff2 into AliceO2Group:masterApr 5, 2024
@f3sch
f3sch deleted the v0/collinear branch April 29, 2024 20:16
christianreckziegel pushed a commit to christianreckziegel/O2Physics that referenced this pull request May 2, 2024
* V0: use collinear fit from DCAFitter
For photons the position is better resolved using a specialized
collinear method in DCAFitter.
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
* LF: Add <vector> include to strangenesstable
Satisfy MegaLinter flag.
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
* V0: Add switch to force all V0s to use the collinear Fit
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
* restart CI
---------
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
f3sch restored the v0/collinear branch May 9, 2024 09:51
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request May 17, 2024
* V0: use collinear fit from DCAFitter
For photons the position is better resolved using a specialized
collinear method in DCAFitter.
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
* LF: Add <vector> include to strangenesstable
Satisfy MegaLinter flag.
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
* V0: Add switch to force all V0s to use the collinear Fit
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
* restart CI
---------
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@f3sch@alibuild@ddobrigk@fmazzasc