Skip to content

PWGHF: Changed PID logic in Dplus candidate selector and added nSigmaCombined to Dplus tree creator - #5293

Merged
fgrosa merged 25 commits into
AliceO2Group:masterfrom
Luca610:Dplus_selector
Mar 25, 2024
Merged

PWGHF: Changed PID logic in Dplus candidate selector and added nSigmaCombined to Dplus tree creator#5293
fgrosa merged 25 commits into
AliceO2Group:masterfrom
Luca610:Dplus_selector

Conversation

@Luca610

@Luca610Luca610 commented Mar 22, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Luca610and others added 15 commits March 18, 2024 17:06
@Luca610
candidate creator for charmed resonances
783465c
@Luca610
minor fix
01a0c6f
@alibuild@Luca610
Please consider the following formatting changes
5ee7cc9
@Luca610@vkucera
Apply suggestions from code review
9085230
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
@Luca610
Improving readability with suggested changes
b9491ac
@Luca610
fixed typo
4a55b1c
@Luca610@vkucera@fgrosa
Apply suggestions from code review
9d9bbc2
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
@Luca610
changed task names and implemented suggested changes
4fba39f
@Luca610
implemented suggested changes on dataCreatorCharmResoReduced
deae9e5
@alibuild
Please consider the following formatting changes
3649d98
@Luca610
Merge pull request#11from alibuild/alibot-cleanup-5143
af15b68
Please consider the following formatting changes to AliceO2Group#5143
luagliet
Merge branch 'master' ofhttps://github.com/AliceO2Group/O2Physicsin…
2ed19e4
…to Dplus_selector
luagliet
Merge branch 'master' ofhttps://github.com/AliceO2Group/O2Physicsin…
09a11ac
…to Dplus_selector
luagliet
changed PID logic in Dplus Candidate Creator from TPC and TOF to TPC …
5ab1c71
…or TOF, added nSigmaCombined to Dplus Tree creator
@Luca610
Merge branch 'AliceO2Group:master' into Dplus_selector
3c313df
fgrosa
fgrosa requested changes Mar 22, 2024
View reviewed changes

@fgrosafgrosa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Luca610 thanks! I just have two minor comments, then it can be merged.

Comment threadPWGHF/TableProducer/candidateSelectorDplusToPiKPi.cxx
Comment threadPWGHF/TableProducer/candidateSelectorDplusToPiKPi.cxx Outdated
@Luca610

Luca610 commented Mar 22, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks @fgrosa! I added the same configurables to the Ds candidate selector as well!

vkucera
vkucera requested changes Mar 25, 2024
View reviewed changes
Comment threadPWGHF/TableProducer/candidateSelectorDsToKKPi.cxx
fgrosa
fgrosa approved these changes Mar 25, 2024
View reviewed changes

@fgrosafgrosa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, thanks @Luca610!

@fgrosa
fgrosa enabled auto-merge (squash) March 25, 2024 14:11
@fgrosa
fgrosa merged commit d0468dc into AliceO2Group:masterMar 25, 2024
@Luca610
Luca610 deleted the Dplus_selector branch March 26, 2024 14:29
christianreckziegel pushed a commit to christianreckziegel/O2Physics that referenced this pull request May 2, 2024
@Luca610@alibuild
@vkucera@fgrosaluagliet@christianreckziegel
PWGHF: Changed PID logic in Dplus candidate selector and added nSigma…
f2ff3ba
…Combined to Dplus tree creator (AliceO2Group#5293)
* candidate creator for charmed resonances
* minor fix
* Please consider the following formatting changes
* Apply suggestions from code review
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
* Improving readability with suggested changes
* fixed typo
* Apply suggestions from code review
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
* changed task names and implemented suggested changes
* implemented suggested changes on dataCreatorCharmResoReduced
* Please consider the following formatting changes
* changed PID logic in Dplus Candidate Creator from TPC and TOF to TPC or TOF, added nSigmaCombined to Dplus Tree creator
* candidate creator for charmed resonances
* Please consider the following formatting changes
* Apply suggestions from code review
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
* added configurable to select PID logic in Dplus and Ds candidate selector
* Please consider the following formatting changes
* Delete PWGHF/D2H/TableProducer/candidateCreatorDV0Reduced.cxx
* fixed error
* Please consider the following formatting changes
---------
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
Co-authored-by: luagliet <luca.aglietta@cern.ch>
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request May 17, 2024
@Luca610@alibuild
@vkucera@fgrosaluagliet@hahassan7
PWGHF: Changed PID logic in Dplus candidate selector and added nSigma…
f0fb42d
…Combined to Dplus tree creator (AliceO2Group#5293)
* candidate creator for charmed resonances
* minor fix
* Please consider the following formatting changes
* Apply suggestions from code review
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
* Improving readability with suggested changes
* fixed typo
* Apply suggestions from code review
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
* changed task names and implemented suggested changes
* implemented suggested changes on dataCreatorCharmResoReduced
* Please consider the following formatting changes
* changed PID logic in Dplus Candidate Creator from TPC and TOF to TPC or TOF, added nSigmaCombined to Dplus Tree creator
* candidate creator for charmed resonances
* Please consider the following formatting changes
* Apply suggestions from code review
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
* added configurable to select PID logic in Dplus and Ds candidate selector
* Please consider the following formatting changes
* Delete PWGHF/D2H/TableProducer/candidateCreatorDV0Reduced.cxx
* fixed error
* Please consider the following formatting changes
---------
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
Co-authored-by: luagliet <luca.aglietta@cern.ch>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgrosafgrosafgrosa approved these changes
@vkuceravkuceravkucera approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner
@fcatalan92fcatalan92Awaiting requested review from fcatalan92fcatalan92 is a code owner
@mfagginmfagginAwaiting requested review from mfagginmfaggin is a code owner
@mmazzillimmazzilliAwaiting requested review from mmazzillimmazzilli is a code owner
@deepathomsdeepathomsAwaiting requested review from deepathomsdeepathoms is a code owner
@nzardoshnzardoshAwaiting requested review from nzardosh
@NicoleBastidNicoleBastidAwaiting requested review from NicoleBastidNicoleBastid is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Luca610@fgrosa@vkucera@alibuild