Skip to content

PWGHF: Modified Task Dplus adding THnSparse for ML - #5460

Merged
fcatalan92 merged 12 commits into
AliceO2Group:masterfrom
Luca610:Task
Apr 10, 2024
Merged

PWGHF: Modified Task Dplus adding THnSparse for ML#5460
fcatalan92 merged 12 commits into
AliceO2Group:masterfrom
Luca610:Task

Conversation

@Luca610

@Luca610Luca610 commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

This PR introduces two process functions to the Dplus Task to fill THnSparse objects with candidate Mass, Pt and BDT scores for ML analysis .

The task's architecture now includes template functions for histogram filling, aiming to simplify future modifications and expansions.

fcatalan92
fcatalan92 requested changes Apr 3, 2024
View reviewed changes

@fcatalan92fcatalan92 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Luca610, thanks for the developments! I added some comments, mainly on the possibility to better use Filters and Partitions (the task was written some time ago and the capabilities of the framework were different). Another general comment is on the fillHisto functions: I would keep in there only the histogram filling and move all the other logic outside. In this way you can avoid something like this fillHistoMCRec(const T1& candidate, const T2& mcParticles) which looks odd.

Comment threadPWGHF/D2H/Tasks/taskDplus.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskDplus.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskDplus.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskDplus.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskDplus.cxx Outdated
@Luca610

Luca610 commented Apr 5, 2024

Copy link
Copy Markdown
ContributorAuthor

Hi @fcatalan92, thank you for your comments!
I implemented them in a new version of the task. I added some runAnalysis functions to remove logic checks from the fillHisto functions and added the filter on the hfflag.
Let me know if you have other comments!

Thanks again!

@Luca610
Merge pull request#17from alibuild/alibot-cleanup-5460
eaaa32a
Please consider the following formatting changes to AliceO2Group#5460
@Luca610
Luca610 requested a review from fcatalan92April 8, 2024 08:43
fcatalan92
fcatalan92 requested changes Apr 9, 2024
View reviewed changes

@fcatalan92fcatalan92 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Luca610, thanks for implementing my suggestions. I have still a small comment.

Comment threadPWGHF/D2H/Tasks/taskDplus.cxx
@Luca610@fcatalan92
Update PWGHF/D2H/Tasks/taskDplus.cxx
1f8e949
Co-authored-by: Fabio Catalano <fabio.catalano372@gmail.com>
@fcatalan92
fcatalan92 merged commit 836d4e1 into AliceO2Group:masterApr 10, 2024
ddobrigk pushed a commit to gianniliveraro/O2Physics that referenced this pull request Apr 10, 2024
@Luca610luagliet
@alibuild@fcatalan92@ddobrigk
PWGHF: Modified Task Dplus adding THnSparse for ML (AliceO2Group#5460)
7d43cb3
* Modified Dplus adding THnSparse for ML
* marginal change
* Please consider the following formatting changes
* Please consider the following formatting changes
* Please consider the following formatting changes
* implemented suggested changes
* Please consider the following formatting changes
* Update PWGHF/D2H/Tasks/taskDplus.cxx
Co-authored-by: Fabio Catalano <fabio.catalano372@gmail.com>
---------
Co-authored-by: luagliet <luca.aglietta@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Fabio Catalano <fabio.catalano372@gmail.com>
christianreckziegel pushed a commit to christianreckziegel/O2Physics that referenced this pull request May 2, 2024
@Luca610luagliet
@alibuild@fcatalan92@christianreckziegel
PWGHF: Modified Task Dplus adding THnSparse for ML (AliceO2Group#5460)
a4d8629
* Modified Dplus adding THnSparse for ML
* marginal change
* Please consider the following formatting changes
* Please consider the following formatting changes
* Please consider the following formatting changes
* implemented suggested changes
* Please consider the following formatting changes
* Update PWGHF/D2H/Tasks/taskDplus.cxx
Co-authored-by: Fabio Catalano <fabio.catalano372@gmail.com>
---------
Co-authored-by: luagliet <luca.aglietta@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Fabio Catalano <fabio.catalano372@gmail.com>
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request May 17, 2024
@Luca610luagliet
@alibuild@fcatalan92@hahassan7
PWGHF: Modified Task Dplus adding THnSparse for ML (AliceO2Group#5460)
d5ff5dc
* Modified Dplus adding THnSparse for ML
* marginal change
* Please consider the following formatting changes
* Please consider the following formatting changes
* Please consider the following formatting changes
* implemented suggested changes
* Please consider the following formatting changes
* Update PWGHF/D2H/Tasks/taskDplus.cxx
Co-authored-by: Fabio Catalano <fabio.catalano372@gmail.com>
---------
Co-authored-by: luagliet <luca.aglietta@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Fabio Catalano <fabio.catalano372@gmail.com>
@Luca610
Luca610 deleted the Task branch October 7, 2024 14:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fcatalan92fcatalan92fcatalan92 approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@vkuceravkuceraAwaiting requested review from vkuceravkucera is a code owner
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner
@fgrosafgrosaAwaiting requested review from fgrosafgrosa is a code owner
@mfagginmfagginAwaiting requested review from mfagginmfaggin is a code owner
@mmazzillimmazzilliAwaiting requested review from mmazzillimmazzilli is a code owner
@deepathomsdeepathomsAwaiting requested review from deepathomsdeepathoms is a code owner
@nzardoshnzardoshAwaiting requested review from nzardosh
@NicoleBastidNicoleBastidAwaiting requested review from NicoleBastidNicoleBastid is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Luca610@fcatalan92@alibuild