Skip to content

PWGHF: Add raw prompt fraction to compute_fraction_cutvar.py output - #5581

Merged
fgrosa merged 8 commits into
AliceO2Group:masterfrom
fchinu:FD_fraction
Apr 12, 2024
Merged

PWGHF: Add raw prompt fraction to compute_fraction_cutvar.py output#5581
fgrosa merged 8 commits into
AliceO2Group:masterfrom
fchinu:FD_fraction

Conversation

@fchinu

@fchinufchinu commented Apr 11, 2024

Copy link
Copy Markdown
Contributor

This PR adds the raw prompt fraction to the output of the compute_fraction_cutvar.py script.

I have changed np.float to float as the former is now deprecated

@alibuildalibuild mentioned this pull request Apr 11, 2024
Merged
fgrosa
fgrosa requested changes Apr 12, 2024
View reviewed changes

@fgrosafgrosa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fchinu thanks a lot!
Apart from a couple of comments on the style, I would put this addition optional (see my suggestions below)

Comment threadPWGHF/D2H/Macros/config_cutvar_example.json Outdated
Comment threadPWGHF/D2H/Macros/compute_fraction_cutvar.py Outdated
Comment threadPWGHF/D2H/Macros/compute_fraction_cutvar.py Outdated
Comment threadPWGHF/D2H/Macros/compute_fraction_cutvar.py Outdated
Comment threadPWGHF/D2H/Macros/compute_fraction_cutvar.py Outdated
Comment threadPWGHF/D2H/Macros/compute_fraction_cutvar.py Outdated
Comment threadPWGHF/D2H/Macros/compute_fraction_cutvar.py Outdated
Comment threadPWGHF/D2H/Macros/compute_fraction_cutvar.py Outdated
@alibuildalibuild mentioned this pull request Apr 12, 2024
Closed
fgrosa
fgrosa reviewed Apr 12, 2024
View reviewed changes
Comment threadPWGHF/D2H/Macros/compute_fraction_cutvar.py
hist_corry_nonprompt.Write()
hist_covariance.Write()
hist_corrfrac_prompt.Write()
hist_corrfrac_nonprompt.Write()

@fgrosafgrosaApr 12, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this has been deleted by mistake

@fchinufchinuApr 12, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fgrosa, many thanks for spotting it! I have fixed it now

@fchinu
fchinu requested a review from hahassan7 as a code ownerApril 12, 2024 15:46
@fgrosa
fgrosa enabled auto-merge (squash) April 12, 2024 15:59
@fgrosa
fgrosa merged commit 58a56f1 into AliceO2Group:masterApr 12, 2024
christianreckziegel pushed a commit to christianreckziegel/O2Physics that referenced this pull request May 2, 2024
@fchinu@alibuild@christianreckziegel
PWGHF: Add raw prompt fraction to compute_fraction_cutvar.py output (A…
4714f83
…liceO2Group#5581)
* PWGHF: Add raw prompt fraction to compute_fraction_cutvar.py output
* Please consider the following formatting changes
* MegaLinter fixes
* Make raw prompt fraction evaluation optional
* Fix removed histogram
---------
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request May 17, 2024
@fchinu@alibuild@hahassan7
PWGHF: Add raw prompt fraction to compute_fraction_cutvar.py output (A…
8a3c7a2
…liceO2Group#5581)
* PWGHF: Add raw prompt fraction to compute_fraction_cutvar.py output
* Please consider the following formatting changes
* MegaLinter fixes
* Make raw prompt fraction evaluation optional
* Fix removed histogram
---------
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
@fchinu
fchinu deleted the FD_fraction branch August 8, 2024 08:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgrosafgrosafgrosa approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@vkuceravkuceraAwaiting requested review from vkuceravkucera is a code owner
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner
@fcatalan92fcatalan92Awaiting requested review from fcatalan92fcatalan92 is a code owner
@mfagginmfagginAwaiting requested review from mfagginmfaggin is a code owner
@mmazzillimmazzilliAwaiting requested review from mmazzillimmazzilli is a code owner
@deepathomsdeepathomsAwaiting requested review from deepathomsdeepathoms is a code owner
@nzardoshnzardoshAwaiting requested review from nzardosh
@NicoleBastidNicoleBastidAwaiting requested review from NicoleBastidNicoleBastid is a code owner
@hahassan7hahassan7Awaiting requested review from hahassan7hahassan7 is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fchinu@fgrosa@alibuild