Uh oh!
There was an error while loading. Please reload this page.
PWGEM: Fix compilation warnings: unused-parameter - #5655
Merged
Conversation
vkucera
requested review from
alibuild, dsekihat, feisenhu, ivorobye, m-c-danisch, mhemmer-cern, mikesas, novitzky and rbailhac
as code ownersApril 16, 2024 21:51
mhemmer-cern
previously approved these changes
Apr 17, 2024
mhemmer-cern
left a comment
Collaborator
There was a problem hiding this comment.
looks good from photon side
ivorobye
previously approved these changes
Apr 17, 2024
vkucera
commented
Apr 17, 2024
CollaboratorAuthor
Thanks @mhemmer-cern@ivorobye . Sorry, I need to resolve conflicts still. |
vkucera
marked this pull request as draft
April 17, 2024 08:22
vkucera
marked this pull request as ready for review
April 17, 2024 10:19
vkucera
commented
Apr 17, 2024
CollaboratorAuthor
Ready |
ivorobye
approved these changes
Apr 17, 2024
mhemmer-cern
commented
Apr 17, 2024
Collaborator
@vkucera MegaLinter is still complaining, should we wait? |
vkucera
commented
Apr 17, 2024
CollaboratorAuthor
@mhemmer-cern The errors reported by MegaLinter are not related to this PR and they were there before. It is not the purpose of this PR to fix them. But they are so trivial that I'm happy to fix them if you prefer. Let me know. |
Collaborator
If it does not block merging it's fine :) |
mhemmer-cern
approved these changes
Apr 17, 2024
feisenhu
approved these changes
Apr 17, 2024
christianreckziegel pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
May 2, 2024
* PWGEM: Fix compilation warnings: unused-parameter * Please consider the following formatting changes (AliceO2Group#55) * Resolve conflicts * Please consider the following formatting changes (AliceO2Group#56) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
hahassan7 pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
May 17, 2024
* PWGEM: Fix compilation warnings: unused-parameter * Please consider the following formatting changes (AliceO2Group#55) * Resolve conflicts * Please consider the following formatting changes (AliceO2Group#56) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.