Skip to content

PWGLF: Fix compilation warnings in rsnOutput.h - #5691

Merged
BongHwi merged 1 commit into
AliceO2Group:masterfrom
vbarbaso:master
Apr 18, 2024
Merged

PWGLF: Fix compilation warnings in rsnOutput.h#5691
BongHwi merged 1 commit into
AliceO2Group:masterfrom
vbarbaso:master

Conversation

@vbarbaso

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Veronika Barbasova <vernika.barbasova@cern.ch>
@BongHwi

Copy link
Copy Markdown
Collaborator

Thanks for the update! let's see if this clears the warning.

@BongHwi

Copy link
Copy Markdown
Collaborator

Great, now it's cleared. I'll merge it.

@BongHwi
BongHwi enabled auto-merge (squash) April 18, 2024 17:09
@BongHwi
BongHwi merged commit 0f87a82 into AliceO2Group:masterApr 18, 2024
@vkucera

Copy link
Copy Markdown
Collaborator

This PR also reverts fixes made in #5654. Please add them back.

@vkuceravkucera mentioned this pull request Apr 18, 2024
@vkucera

Copy link
Copy Markdown
Collaborator

@vbarbaso , please update your repository properly when you make a PR. I fixed this bug already two weeks ago in #5442 but then you put it back the next day in #5459.

@vbarbaso

Copy link
Copy Markdown
ContributorAuthor

@vkucera I'm really sorry about that. I did not notice. I've already reverted your changes in #5700. Hope everything is fine now. Please let me know if not.

@vkucera

vkucera commented Apr 19, 2024

Copy link
Copy Markdown
Collaborator

@vkucera I'm really sorry about that. I did not notice. I've already reverted your changes in #5700. Hope everything is fine now. Please let me know if not.

@vbarbaso Thanks, it looks good to me.

christianreckziegel pushed a commit to christianreckziegel/O2Physics that referenced this pull request May 2, 2024
Signed-off-by: Veronika Barbasova <vernika.barbasova@cern.ch>
Co-authored-by: Veronika Barbasova <vernika.barbasova@cern.ch>
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request May 17, 2024
Signed-off-by: Veronika Barbasova <vernika.barbasova@cern.ch>
Co-authored-by: Veronika Barbasova <vernika.barbasova@cern.ch>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vbarbaso@BongHwi@vkucera