Fix centrality config and remove POI

[ilikmeta]

No description provided.

[alibuild]

Error while checking build/O2Physics/o2 for 88f2d43 at 2024-05-10 07:45:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:458:17: error: 'corrconfigs' is not a type
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:458:28: error: expected ',' or '...' before '.' token
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:458:5: error: ISO C++ forbids declaration of 'FillProfile' with no type [-fpermissive]
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:459:17: error: 'corrconfigs' is not a type
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:459:28: error: expected ',' or '...' before '.' token
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:459:5: error: ISO C++ forbids declaration of 'FillProfile' with no type [-fpermissive]
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:459:5: error: 'int FlowGFWPbPb::FillProfile(int)' cannot be overloaded with 'int FlowGFWPbPb::FillProfile(int)'
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:460:17: error: 'corrconfigs' is not a type
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:460:28: error: expected ',' or '...' before '.' token
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:460:5: error: ISO C++ forbids declaration of 'FillProfile' with no type [-fpermissive]
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:460:5: error: 'int FlowGFWPbPb::FillProfile(int)' cannot be overloaded with 'int FlowGFWPbPb::FillProfile(int)'
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:461:17: error: 'corrconfigs' is not a type
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:461:28: error: expected ',' or '...' before '.' token
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:461:5: error: ISO C++ forbids declaration of 'FillProfile' with no type [-fpermissive]
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:461:5: error: 'int FlowGFWPbPb::FillProfile(int)' cannot be overloaded with 'int FlowGFWPbPb::FillProfile(int)'
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:462:17: error: 'corrconfigs' is not a type
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:462:28: error: expected ',' or '...' before '.' token
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:462:5: error: ISO C++ forbids declaration of 'FillProfile' with no type [-fpermissive]
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:462:5: error: 'int FlowGFWPbPb::FillProfile(int)' cannot be overloaded with 'int FlowGFWPbPb::FillProfile(int)'
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:466:17: error: 'corrconfigs' is not a type
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:466:28: error: expected ',' or '...' before '.' token
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:466:5: error: ISO C++ forbids declaration of 'FillProfile' with no type [-fpermissive]
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:466:5: error: 'int FlowGFWPbPb::FillProfile(int)' cannot be overloaded with 'int FlowGFWPbPb::FillProfile(int)'
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:467:17: error: 'corrconfigs' is not a type
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:467:28: error: expected ',' or '...' before '.' token
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:467:5: error: ISO C++ forbids declaration of 'FillProfile' with no type [-fpermissive]
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:467:5: error: 'int FlowGFWPbPb::FillProfile(int)' cannot be overloaded with 'int FlowGFWPbPb::FillProfile(int)'
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:468:17: error: 'corrconfigs' is not a type
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:468:28: error: expected ',' or '...' before '.' token
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:468:5: error: ISO C++ forbids declaration of 'FillProfile' with no type [-fpermissive]
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:468:5: error: 'int FlowGFWPbPb::FillProfile(int)' cannot be overloaded with 'int FlowGFWPbPb::FillProfile(int)'
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:469:17: error: 'corrconfigs' is not a type
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:469:28: error: expected ',' or '...' before '.' token
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:469:5: error: ISO C++ forbids declaration of 'FillProfile' with no type [-fpermissive]
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:469:5: error: 'int FlowGFWPbPb::FillProfile(int)' cannot be overloaded with 'int FlowGFWPbPb::FillProfile(int)'
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:470:17: error: 'corrconfigs' is not a type
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:470:28: error: expected ',' or '...' before '.' token
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:470:5: error: ISO C++ forbids declaration of 'FillProfile' with no type [-fpermissive]
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:470:5: error: 'int FlowGFWPbPb::FillProfile(int)' cannot be overloaded with 'int FlowGFWPbPb::FillProfile(int)'
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:473:5: error: expected unqualified-id before 'for'
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:473:34: error: invalid use of non-static data member 'FlowGFWPbPb::corrconfigs'
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:473:34: error: invalid use of non-static data member 'FlowGFWPbPb::corrconfigs'
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:473:34: error: invalid use of non-static data member 'FlowGFWPbPb::corrconfigs'
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:473:34: error: invalid use of non-static data member 'FlowGFWPbPb::corrconfigs'
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:473:34: error: invalid use of non-static data member 'FlowGFWPbPb::corrconfigs'
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:473:34: error: invalid use of non-static data member 'FlowGFWPbPb::corrconfigs'
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:473:34: error: invalid use of non-static data member 'FlowGFWPbPb::corrconfigs'
/sw/SOURCES/O2Physics/6094-slc7_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:473:34: error: invalid use of non-static data member 'FlowGFWPbPb::corrconfigs'
[0 more errors; see full log]

Full log here.

[ilikmeta]

Hello @victor-gonzalez
alibuilt showed many errors and I believe from line 446
fGFW->Fill(track.eta(), 1, track.phi(), wacc * weff, 1);
It should be :
fGFW->Fill(track.eta(), fPtAxis->FindBin(track.pt()) - 1, track.phi(), wacc * weff, 1);

However it was compiling locally, but here did not work.
Also, I cannot make a push do updated. It gives me this:

iris_antreas_likmeta@Iris-Antreass-MacBook-Pro O2Physics % git push -f origin
fatal: You are not currently on a branch.
To push the history leading to the current (detached HEAD)
state now, use

git push origin HEAD:<name-of-remote-branch>

[victor-gonzalez]

You have to fix it locally in your master at your local repository and push your master to the master of your fork in gitHub

[victor-gonzalez]

All compiler errors are correct compiler errors according to the current content of the FlowGFWPbPb.cxx source code file
Have in mind that you allowed merges in your gitHub fork which you don't have locally

[ilikmeta]

Whenever I do git status
`iris_antreas_likmeta@Iris-Antreass-MacBook-Pro O2Physics % git status
interactive rebase in progress; onto bf3eff8
Last command done (1 command done):
pick 4d32196 Add extra event/track cuts
Next command to do (1 remaining command):
pick d751ef6 Fix centrality config and remove POI
(use "git rebase --edit-todo" to view and edit)
You are currently editing a commit while rebasing branch 'master' on 'bf3eff8a'.
(use "git commit --amend" to amend the current commit)
(use "git rebase --continue" once you are satisfied with your changes)

Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git restore ..." to discard changes in working directory)
modified: PWGCF/Flow/Tasks/FlowGFWPbPb.cxx`

and is not letting me to push code. Do you have a suggestion on how to solve this?

[victor-gonzalez]

From where did you get the latest update on which you are trying to rebase?

[ilikmeta]

before I push the code I did: inside O2Physis
git pull --rebase upstream master

[victor-gonzalez]

But that did not fail because you were able to push for creating the pull request, right?

[ilikmeta]

Once I pushed the new changes for the first time, then there was a conflicing file that appeared below the checks which was showing the latest changes I did to my code. By opening the conflicting file, the FlowGFWPbPb.cxx , I removed the lines that I had deleted before I push and then I clicked on the Resolved button and merge. Then alibuilt returned with errors and now I cannot even do a hard reset:
`iris_antreas_likmeta@Iris-Antreass-MacBook-Pro O2Physics % git checkout master
git fetch --all
git reset --hard upstream/master

PWGCF/Flow/Tasks/FlowGFWPbPb.cxx: needs merge
error: you need to resolve your current index first
Fetching upstream
Fetching origin
HEAD is now at 1f2f492 Introducing a new util to get the OTS bits (ZORRO) (#6087)
`

[ilikmeta]

@victor-gonzalez Is it possible to discard this pull request and make a new one as now the git status is up to date?

[victor-gonzalez]

Two questions before

• what git remote -v gives you
• what you said here

By opening the conflicting file, the FlowGFWPbPb.cxx , I removed the lines that I had deleted before I push and then I clicked on the Resolved button and merge.

means you did the changes directly on gitHub?

If that is the case you should never do that unless they are really minor changes, i.e. the ones suggested by the formatter

[ilikmeta]

iris_antreas_likmeta@Iris-Antreass-MacBook-Pro O2Physics % git remote -v
origin git@github.com:ilikmeta/O2Physics.git (fetch)
origin git@github.com:ilikmeta/O2Physics.git (push)
upstream https://github.com/AliceO2Group/O2Physics (fetch)
upstream https://github.com/AliceO2Group/O2Physics (push)

Yes, I did changes on GitHub as I thought I will not let the checks to be done. Thanks for mentioning to avoid this!

I just pushed again after fixing my local repo. So far no errors occured.

My appologies for giving hard time with this.

[victor-gonzalez]

No problem!
But as a strict rule, one has to be always completely sure that what is in the PR compiles locally first
If the content of the PR is changed on gitHub that rule is broken