PWGHF: Add utility to apply event selection at the generated level by DelloStritto · Pull Request #6302 · AliceO2Group/O2Physics

DelloStritto · 2024-05-28T09:59:33Z

To be extended to candidateCreator2Prong.cxx and candidateCreatorDstar.cxx once reviewed.

mfaggin · 2024-05-28T10:14:25Z

thanks a lot @DelloStritto , a couple of comments from my side:

beware of this PR just merged, please rebase: PWGHF: new Pb-Pb event selections #6278
what about adding the same feature also in PWGHF/TableProducer/candidateCreatorCascade.cxx and PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx?

fcatalan92

Hi @DelloStritto, thanks for looking into the event selection on MC. I added a comment on the strategy here below. Moreover, I would not add the selection code directly in the creator, instead you could add an utility function in utilsEvSelHf.

Please consider the following formatting changes to AliceO2Group#6302

vkucera

Thanks @DelloStritto , see my minor suggestions.

Please consider the following formatting changes to AliceO2Group#6302

fcatalan92

Hi @DelloStritto, thanks for implementing the comments. I have just a few more.
Please also check that the event selection is added to all the candidate creators.

alibuild · 2024-06-03T16:04:30Z

Error while checking build/O2Physics/o2 for aec28df at 2024-06-03 18:04:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:85: error: no 'operator++(int)' declared for postfix '++' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:300:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:300:85: error: no 'operator++(int)' declared for postfix '++' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:85: error: no 'operator++(int)' declared for postfix '++' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:300:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:300:85: error: no 'operator++(int)' declared for postfix '++' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:85: error: no 'operator++(int)' declared for postfix '++' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:300:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:300:85: error: no 'operator++(int)' declared for postfix '++' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:85: error: no 'operator++(int)' declared for postfix '++' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:300:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:300:85: error: no 'operator++(int)' declared for postfix '++' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:85: error: no 'operator++(int)' declared for postfix '++' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:300:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:300:85: error: no 'operator++(int)' declared for postfix '++' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:85: error: no 'operator++(int)' declared for postfix '++' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:300:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:300:85: error: no 'operator++(int)' declared for postfix '++' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
/sw/SOURCES/O2Physics/6302-slc7_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:205:34: error: invalid conversion from 'int' to 'o2::hf_evsel::EventRejection' [-fpermissive]
ninja: build stopped: subcommand failed.

Full log here.

Co-authored-by: Fabio Catalano <fabio.catalano372@gmail.com>

alibuild · 2024-06-05T07:59:54Z

Error while checking build/O2Physics/o2 for 77064a5 at 2024-06-05 09:59:

## sw/BUILD/O2Physics-latest/log
/sw/slc7_x86-64/O2/daily-20240605-0200-local1/include/Framework/AnalysisHelpers.h:48:33: error: static assertion failed: Argument number mismatch
/sw/slc7_x86-64/O2/daily-20240605-0200-local1/include/Framework/AnalysisHelpers.h:50:11: error: no match for call to '(o2::framework::{anonymous}::memfun_type<void (o2::framework::TableBuilder::persist<signed char, signed char, signed char, int>(const std::array<const char*, 4>&)::<lambda(unsigned int, o2::framework::BuilderMaker<signed char>::FillType, o2::framework::BuilderMaker<signed char>::FillType, o2::framework::BuilderMaker<signed char>::FillType, o2::framework::BuilderMaker<int>::FillType)>::*)(unsigned int, signed char, signed char, signed char, int) const>::type {aka std::function<void(unsigned int, signed char, signed char, signed char, int)>}) (int, const signed char&, const signed char&, const signed char&)'
/sw/slc7_x86-64/O2/daily-20240605-0200-local1/include/Framework/AnalysisHelpers.h:48:33: error: static assertion failed: Argument number mismatch
/sw/slc7_x86-64/O2/daily-20240605-0200-local1/include/Framework/AnalysisHelpers.h:50:11: error: no match for call to '(o2::framework::{anonymous}::memfun_type<void (o2::framework::TableBuilder::persist<signed char, signed char, int>(const std::array<const char*, 3>&)::<lambda(unsigned int, o2::framework::BuilderMaker<signed char>::FillType, o2::framework::BuilderMaker<signed char>::FillType, o2::framework::BuilderMaker<int>::FillType)>::*)(unsigned int, signed char, signed char, int) const>::type {aka std::function<void(unsigned int, signed char, signed char, int)>}) (int, const signed char&, const signed char&)'
/sw/slc7_x86-64/O2/daily-20240605-0200-local1/include/Framework/AnalysisHelpers.h:48:33: error: static assertion failed: Argument number mismatch
/sw/slc7_x86-64/O2/daily-20240605-0200-local1/include/Framework/AnalysisHelpers.h:50:11: error: no match for call to '(o2::framework::{anonymous}::memfun_type<void (o2::framework::TableBuilder::persist<signed char, signed char, int>(const std::array<const char*, 3>&)::<lambda(unsigned int, o2::framework::BuilderMaker<signed char>::FillType, o2::framework::BuilderMaker<signed char>::FillType, o2::framework::BuilderMaker<int>::FillType)>::*)(unsigned int, signed char, signed char, int) const>::type {aka std::function<void(unsigned int, signed char, signed char, int)>}) (int, const signed char&, const signed char&)'
ninja: build stopped: subcommand failed.

Full log here.

…liceO2Group#6302) * PWGHF: add TF border cut at the particle generate level * Adding utility for the event selection at the generated level * fix clang * fix * Propagating PR to all candidate creators * Splitting sel8 in the reco part * Add monitoring * fix * fix * Fix type of loop variable * Revert bad idea * Update PWGHF/TableProducer/candidateCreator2Prong.cxx Co-authored-by: Fabio Catalano <fabio.catalano372@gmail.com> * Update PWGHF/TableProducer/candidateCreatorCascade.cxx Co-authored-by: Fabio Catalano <fabio.catalano372@gmail.com> * Update PWGHF/TableProducer/candidateCreator3Prong.cxx Co-authored-by: Fabio Catalano <fabio.catalano372@gmail.com> --------- Co-authored-by: Luigi Dello Stritto <ldellost@alicecerno2.cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch> Co-authored-by: Fabio Catalano <fabio.catalano372@gmail.com>

DelloStritto requested review from NicoleBastid, alibuild, deepathoms, fcatalan92, fcolamar, fgrosa, hahassan7, jpxrk, mfaggin, mmazzilli, nzardosh and vkucera as code owners May 28, 2024 09:59

DelloStritto changed the title ~~PWGHF: add TF border cut at the particle generate level~~PWGHF: add TF border cut at the generated particle levelMay 28, 2024

PWGHF: add TF border cut at the particle generate level
692e479

fcatalan92 requested changes May 28, 2024
View reviewed changes

Comment threadPWGHF/TableProducer/candidateCreator3Prong.cxx Outdated

Merge branch 'master' ofhttps://github.com/AliceO2Group/O2Physics
185a470

DelloStritto force-pushed the master branch from 12abc62 to 185a470Compare May 30, 2024 13:02

Luigi Dello Stritto added 3 commits May 30, 2024 15:06

Merge branch 'master' ofhttps://github.com/AliceO2Group/O2Physics
8a5fe97

Adding utility for the event selection at the generated level
5de9184

fix clang
fb1ab02

DelloStritto added a commit to DelloStritto/O2Physics that referenced this pull request May 30, 2024
Merge pull request#10from alibuild/alibot-cleanup-6302
02dccfd
Please consider the following formatting changes to AliceO2Group#6302

DelloStritto changed the title ~~PWGHF: add TF border cut at the generated particle level~~PWGHF: add utility to apply event selection at the generated levelMay 30, 2024

vkucera requested changes May 30, 2024
View reviewed changes

Comment threadPWGHF/TableProducer/candidateCreator3Prong.cxx Outdated
Comment threadPWGHF/Utils/utilsEvSelHf.h Outdated

mfaggin reviewed May 30, 2024
View reviewed changes

Comment threadPWGHF/Utils/utilsEvSelHf.h Outdated

fix
63ad2df

DelloStritto force-pushed the master branch from 8a4f865 to 63ad2dfCompare May 30, 2024 15:24

Propagating PR to all candidate creators
f56d4dc

DelloStritto added a commit to DelloStritto/O2Physics that referenced this pull request May 30, 2024
Merge pull request#11from alibuild/alibot-cleanup-6302
4e0515e
Please consider the following formatting changes to AliceO2Group#6302

vkucera requested changes May 31, 2024
View reviewed changes

Comment threadPWGHF/Utils/utilsEvSelHf.h Outdated
Comment threadPWGHF/Utils/utilsEvSelHf.h

fcatalan92 requested changes Jun 3, 2024
View reviewed changes

Comment threadPWGHF/Utils/utilsEvSelHf.h Outdated
Comment threadPWGHF/Utils/utilsEvSelHf.h Outdated
Comment threadPWGHF/Utils/utilsEvSelHf.h Outdated
Comment threadPWGHF/Utils/utilsEvSelHf.h Outdated

DelloStritto dismissed vkucera’s stale review via 9805ab8June 3, 2024 15:10

fix
f7ef1db

DelloStritto force-pushed the master branch from 58a563e to f7ef1dbCompare June 3, 2024 15:28

fcatalan92 previously approved these changes Jun 3, 2024
View reviewed changes

fcatalan92 enabled auto-merge (squash) June 3, 2024 15:34

Fix type of loop variable
aec28df

vkucera dismissed fcatalan92’s stale review via aec28dfJune 3, 2024 15:35

vkucera previously approved these changes Jun 3, 2024
View reviewed changes

Revert bad idea
4a2b212

vkucera dismissed their stale review via 4a2b212June 3, 2024 16:33

vkucera previously approved these changes Jun 3, 2024
View reviewed changes

vkucera disabled auto-merge June 3, 2024 16:34

vkucera enabled auto-merge (squash) June 3, 2024 16:34

vkucera changed the title ~~PWGHF: add utility to apply event selection at the generated level~~PWGHF: Add utility to apply event selection at the generated levelJun 3, 2024

fcatalan92 disabled auto-merge June 5, 2024 07:04

Merge branch 'master' into master
77064a5

DelloStritto dismissed vkucera’s stale review via 77064a5June 5, 2024 07:35

fcatalan92 requested changes Jun 5, 2024
View reviewed changes

Comment threadPWGHF/TableProducer/candidateCreator2Prong.cxx Outdated
Comment threadPWGHF/TableProducer/candidateCreator3Prong.cxx Outdated
Comment threadPWGHF/TableProducer/candidateCreatorCascade.cxx Outdated

DelloStrittoand others added 3 commits June 5, 2024 09:49

Update PWGHF/TableProducer/candidateCreator2Prong.cxx
17ceef1
Co-authored-by: Fabio Catalano <fabio.catalano372@gmail.com>

Update PWGHF/TableProducer/candidateCreatorCascade.cxx
bb0da60
Co-authored-by: Fabio Catalano <fabio.catalano372@gmail.com>

Update PWGHF/TableProducer/candidateCreator3Prong.cxx
5fba8e4
Co-authored-by: Fabio Catalano <fabio.catalano372@gmail.com>

fcatalan92 approved these changes Jun 5, 2024
View reviewed changes

fcatalan92 enabled auto-merge (squash) June 5, 2024 07:52

fcatalan92 merged commit 8d9eb4c into AliceO2Group:masterJun 5, 2024

Navigation Menu

Uh oh!

PWGHF: Add utility to apply event selection at the generated level - #6302

PWGHF: Add utility to apply event selection at the generated level#6302
fcatalan92 merged 18 commits into
AliceO2Group:masterfrom
DelloStritto:master

DelloStritto commented May 28, 2024

Uh oh!

mfaggin commented May 28, 2024•
edited
Loading

Uh oh!

fcatalan92 left a comment

Uh oh!

Uh oh!

vkucera left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fcatalan92 left a comment •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alibuild commented Jun 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alibuild commented Jun 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

DelloStritto commented May 28, 2024

Uh oh!

mfaggin commented May 28, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fcatalan92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vkucera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fcatalan92 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alibuild commented Jun 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alibuild commented Jun 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

mfaggin commented May 28, 2024•
edited
Loading

fcatalan92 left a comment •
edited
Loading