PWGHF: Add OmegaC0 workflows that use KFParticle by Yunfan-Liu · Pull Request #6327 · AliceO2Group/O2Physics

Yunfan-Liu · 2024-05-29T13:32:53Z

add candidateCreator, candidateSelector, and treeCreator for omegac0 -> omega pi with KFParticle.
add a machine learning header file, which is used in candidateSelector.

Please consider the following formatting changes to AliceO2Group#6327

…ToOmegaPi.h complete the documentation and change the file name.

complete the documentation, remove useless lines, and use the "registry"

Co-authored-by: Vít Kučera <vit.kucera@cern.ch>

Yunfan-Liu · 2024-07-11T16:52:33Z

Hi @Yunfan-Liu thanks a lot for considering my comments! I noticed that you deleted the class for the ML inference, was it intentional? If so, I am fine with the current version and, if good also for @vkucera, we can merge it.

Yes. now I am unsure what variables will be used in ML, so I deleted it.

fgrosa · 2024-07-11T17:15:00Z

Hi @Yunfan-Liu thanks a lot for considering my comments! I noticed that you deleted the class for the ML inference, was it intentional? If so, I am fine with the current version and, if good also for @vkucera, we can merge it.
Yes. now I am unsure what variables will be used in ML, so I deleted it.

Approved from my side, when also Vit approves it can be merged.

alibuild · 2024-07-11T17:33:44Z

Error while checking build/O2Physics/o2 for 64626cd at 2024-07-11 19:33:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/6327-slc7_x86-64/0/PWGHF/TableProducer/treeCreatorOmegacToOmegaPi.cxx:297:66: error: unused parameter 'debugMc' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

fgrosa · 2024-07-30T12:50:45Z

Hi @vkucera could you please check if this PR (which is stalled since a while) is good for you? Thanks a lot!

vkucera

@Yunfan-Liu thanks for addressing the comments. The PR looks good to me after fixing the remaining minor issues.

alibuild · 2024-07-30T17:25:01Z

Error while checking build/O2Physics/o2 for 4d023e4 at 2024-07-30 19:24:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/6327-slc7_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx:600:19: error: 'SetField' is not a member of 'KFParticle'
/sw/SOURCES/O2Physics/6327-slc7_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx:576:72: error: unused parameter 'bcWithTimeStamps' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

fixing the errors: error: 'SetField' is not a member of 'KFParticle' error: unused parameter 'bcWithTimeStamps' [-Werror=unused-parameter]

* add OmegaC0 table and kf table * add Tasks of reconstructing OmegaC0 with the KFParticle * add header file for OmegaC0 ML\ * Please consider the following formatting changes * Update CMakeLists.txt * Update HfMlResponseOmegaCToOmegaPi.h * Update candidateCreatorOmegacToOmegaPiWithKFP.cxx * Update treeCreatorOmegacToOmegaPiWithKFP.cxx * Please consider the following formatting changes * Update CMakeLists.txt * Update and rename HfMlResponseOmegaCToOmegaPi.h to HfMlResponseOmegacToOmegaPi.h complete the documentation and change the file name. * Update candidateSelectorOmegacToOmegaPiWithKFP.cxx complete the documentation, remove useless lines, and use the "registry" * Update HfMlResponseOmegacToOmegaPi.h * Update PWGHF/DataModel/CandidateReconstructionTables.h Co-authored-by: Vít Kučera <vit.kucera@cern.ch> * Update PWGHF/TableProducer/treeCreatorOmegacToOmegaPiWithKFP.cxx Co-authored-by: Vít Kučera <vit.kucera@cern.ch> * change CMakeLists.txt as requested. respect alphabetic ordering as requested. * change to use existing columns * Please consider the following formatting changes * Update candidateCreatorOmegacToOmegaPiWithKFP.cxx fill the documentation. * fixing some errors * Update CandidateReconstructionTables.h * Update CandidateReconstructionTables.h * Update CandidateReconstructionTables.h * changing some things as comment reqeust and fixing bugs * Delete unused tables * Please consider the following formatting changes * Update candidateCreatorOmegacToOmegaPiWithKFP.cxx using "static_cast<int>(..)" instead of "int(..)" * Update candidateCreatorOmegacToOmegaPiWithKFP.cxx * Please consider the following formatting changes * using exist table instead of duplication one * using exist table * deleting the DCAfitter * deleting the DCAfitter, unused header and fixing * Please consider the following formatting changes * Update candidateCreatorOmegacToOmegaPiWithKFP.cxx * Update treeCreatorOmegacToOmegaPiWithKFP.cxx * adding KFParticle for omegac in existing omegac0 to omega pi workflow(candidateCreatorXic0Omegac0, treeCreatorOmegacToOmegaPi.cxx) * adding KFParticle table for Omegac0 to Omega Pi and deleting duplication table added before * Delete PWGHF/TableProducer/treeCreatorOmegacToOmegaPiWithKFP.cxx now use existing workflow instead of duplication. * Delete PWGHF/TableProducer/candidateSelectorOmegacToOmegaPiWithKFP.cxx now use existing workflow instead of duplication. * Delete PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx now use existing workflow instead of duplication. * Delete PWGHF/TableProducer/candidateCreatorOmegacToOmegaPiWithKFP.cxx now use existing workflow instead of duplication. * Revert "Delete PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx" This reverts commit 8ac8b28. * Please consider the following formatting changes * Update candidateCreatorXic0Omegac0.cxx * Update CandidateSelectionTables.h * Please consider the following formatting changes * Update CandidateSelectionTables.h * Update PWGHF/Core/HfMlResponseOmegacToOmegaPi.h Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> * Update PWGHF/Core/HfMlResponseOmegacToOmegaPi.h Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> * Update PWGHF/Core/HfMlResponseOmegacToOmegaPi.h Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> * deleting duplication table * Delete PWGHF/Core/HfMlResponseOmegacToOmegaPi.h * Update candidateCreatorXic0Omegac0.cxx fixing bug: Incorrectly filling a variable into a table twice * Update candidateCreatorXic0Omegac0.cxx * Please consider the following formatting changes * Update candidateCreatorXic0Omegac0.cxx fixing errors * Update candidateCreatorXic0Omegac0.cxx keep all the cospa in the non-KF tables are referred to the PV. * Update CandidateReconstructionTables.h * Please consider the following formatting changes * Update treeCreatorOmegacToOmegaPi.cxx * no longer filling nSigma into KF-table in candidateCreator * Update candidateCreatorXic0Omegac0.cxx deleting unused variables * Update candidateCreatorXic0Omegac0.cxx deleting unused variables * Update treeCreatorOmegacToOmegaPi.cxx fixing bugs * Update treeCreatorOmegacToOmegaPi.cxx * Update candidateCreatorXic0Omegac0.cxx * Update candidateCreatorXic0Omegac0.cxx * Update treeCreatorOmegacToOmegaPi.cxx * Update candidateCreatorXic0Omegac0.cxx fixing the errors: error: 'SetField' is not a member of 'KFParticle' error: unused parameter 'bcWithTimeStamps' [-Werror=unused-parameter] * Update candidateCreatorXic0Omegac0.cxx --------- Co-authored-by: root <root@USER-20161104VR.localdomain> Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>

root added 3 commits May 29, 2024 19:43

add OmegaC0 table and kf table
ac5d0ca

add Tasks of reconstructing OmegaC0 with the KFParticle
1398021

add header file for OmegaC0 ML\
579856e

Yunfan-Liu requested review from NicoleBastid, alibuild, deepathoms, fcatalan92, fcolamar, fgrosa, hahassan7, jpxrk, mfaggin, mmazzilli, nzardosh and vkucera as code owners May 29, 2024 13:32

alibuildand others added 9 commits May 29, 2024 13:33

Please consider the following formatting changes
c157477

Merge pull request#1from alibuild/alibot-cleanup-6327
57588c2
Please consider the following formatting changes to AliceO2Group#6327

Update CMakeLists.txt
d49b0e5

Update HfMlResponseOmegaCToOmegaPi.h
f107781

Update candidateCreatorOmegacToOmegaPiWithKFP.cxx
6f86fd2

Update treeCreatorOmegacToOmegaPiWithKFP.cxx
74d57d5

Please consider the following formatting changes
0e454d9

Merge pull request#2from alibuild/alibot-cleanup-6327
2051466
Please consider the following formatting changes to AliceO2Group#6327

Update CMakeLists.txt
ad9ab1e

vkucera requested changes May 31, 2024
View reviewed changes

Yunfan-Liuand others added 5 commits May 31, 2024 19:24

Update and rename HfMlResponseOmegaCToOmegaPi.h to HfMlResponseOmegac…
8ed8d95
…ToOmegaPi.h complete the documentation and change the file name.

Update candidateSelectorOmegacToOmegaPiWithKFP.cxx
d49199e
complete the documentation, remove useless lines, and use the "registry"

Update HfMlResponseOmegacToOmegaPi.h
5393933

Update PWGHF/DataModel/CandidateReconstructionTables.h
430819d
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>

Update PWGHF/TableProducer/treeCreatorOmegacToOmegaPiWithKFP.cxx
3552716
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>

Yunfan-Liu requested a review from fgrosa July 11, 2024 16:49

Yunfan-Liu requested a review from vkucera July 11, 2024 16:52

fgrosa previously approved these changes Jul 11, 2024
View reviewed changes

Update treeCreatorOmegacToOmegaPi.cxx
a75a280

Yunfan-Liu dismissed fgrosa’s stale review via a75a280July 11, 2024 17:40

vkucera requested changes Jul 30, 2024
View reviewed changes

Comment threadPWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Outdated
Comment threadPWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Outdated

Update candidateCreatorXic0Omegac0.cxx
b2e65f3

vkucera requested changes Jul 30, 2024
View reviewed changes

Comment threadPWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx
Comment threadPWGHF/TableProducer/treeCreatorOmegacToOmegaPi.cxx

Yunfan-Liu added 2 commits July 30, 2024 22:52

Update candidateCreatorXic0Omegac0.cxx
e02f5c4

Update treeCreatorOmegacToOmegaPi.cxx
4d023e4

vkucera previously approved these changes Jul 30, 2024
View reviewed changes

vkucera changed the title ~~PWGHF: add OmegaC0 reconstruction workflows that used KFParticle.~~PWGHF: Add OmegaC0 workflows that use KFParticleJul 30, 2024

vkucera enabled auto-merge (squash) July 30, 2024 15:30

vkucera disabled auto-merge July 30, 2024 21:01

Update candidateCreatorXic0Omegac0.cxx
d2f6e0f
fixing the errors: error: 'SetField' is not a member of 'KFParticle' error: unused parameter 'bcWithTimeStamps' [-Werror=unused-parameter]

Yunfan-Liu dismissed vkucera’s stale review via d2f6e0fJuly 31, 2024 01:02

Yunfan-Liu requested a review from vkucera July 31, 2024 01:16

vkucera reviewed Jul 31, 2024
View reviewed changes

Comment threadPWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Outdated

Update candidateCreatorXic0Omegac0.cxx
8e469ae

vkucera approved these changes Jul 31, 2024
View reviewed changes

fgrosa merged commit 6bc7933 into AliceO2Group:masterJul 31, 2024

Yunfan-Liu deleted the omegac-reconstruction-with-kf branch February 13, 2025 10:08

Navigation Menu

Uh oh!

PWGHF: Add OmegaC0 workflows that use KFParticle - #6327

PWGHF: Add OmegaC0 workflows that use KFParticle#6327
fgrosa merged 92 commits into
AliceO2Group:masterfrom
Yunfan-Liu:omegac-reconstruction-with-kf

Yunfan-Liu commented May 29, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Yunfan-Liu commented Jul 11, 2024

Uh oh!

fgrosa commented Jul 11, 2024

Uh oh!

alibuild commented Jul 11, 2024

Uh oh!

fgrosa commented Jul 30, 2024

Uh oh!

vkucera left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alibuild commented Jul 30, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Yunfan-Liu commented May 29, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Yunfan-Liu commented Jul 11, 2024

Uh oh!

fgrosa commented Jul 11, 2024

Uh oh!

alibuild commented Jul 11, 2024

Uh oh!

fgrosa commented Jul 30, 2024

Uh oh!

vkucera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alibuild commented Jul 30, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants