Skip to content

PWGHF, PWGCF: charm hadron MC implementation - #6832

Merged
vkucera merged 28 commits into
AliceO2Group:masterfrom
singhra1994:newbranchMc1
Jul 30, 2024
Merged

PWGHF, PWGCF: charm hadron MC implementation#6832
vkucera merged 28 commits into
AliceO2Group:masterfrom
singhra1994:newbranchMc1

Conversation

@singhra1994

@singhra1994singhra1994 commented Jul 11, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@alibuildalibuild mentioned this pull request Jul 11, 2024
Closed
@fgrosafgrosa changed the title charm hadron MC implementationPWGHF, PWGCF: charm hadron MC implementationJul 11, 2024
vkucera
vkucera requested changes Jul 11, 2024
View reviewed changes

@vkuceravkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1994ra In #5631 you promised to address my remaining comments. Please do.

Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
mfaggin
mfaggin reviewed Jul 17, 2024
View reviewed changes

@mfagginmfaggin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @1994ra thanks a lot for the implementation. I have a few minor points, see the detailed comments.

Best.

Mattia

Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
@alibuildalibuild mentioned this pull request Jul 18, 2024
Merged
@singhra1994
Merge pull request#16from alibuild/alibot-cleanup-6832
a34224c
Please consider the following formatting changes to AliceO2Group#6832
@alibuild

alibuild commented Jul 18, 2024

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for a34224c at 2024-07-18 13:53:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/6832-slc7_x86-64/0/PWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx:381:117: error: unused parameter 'candidates' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@victor-gonzalez

victor-gonzalez commented Jul 18, 2024

Copy link
Copy Markdown
Collaborator

@ariedel-cern@sartozza To me it does not affect the pure CF FemtoDream functionality, what do you think?

@ariedel-cern

ariedel-cern commented Jul 19, 2024

Copy link
Copy Markdown
Collaborator

Hi @victor-gonzalez ,
I am sorry for the late reply. Yes, this PR does not seem to affect FemtoDream. So a +1 from me for the merging. Valentina is on vacation until next week. But I think she would not have any issue with this PR as well.

victor-gonzalez
victor-gonzalez previously approved these changes Jul 19, 2024
View reviewed changes
vkucera
vkucera requested changes Jul 29, 2024
View reviewed changes

@vkuceravkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @1994ra , thanks for the updates. Please see my remarks.

Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
vkucera
vkucera requested changes Jul 29, 2024
View reviewed changes
Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
vkucera
vkucera requested changes Jul 29, 2024
View reviewed changes
Comment threadPWGHF/HFC/Tasks/femtoDreamPairTaskCharmHadrons.cxx Outdated
@alibuildalibuild mentioned this pull request Jul 29, 2024
Merged
vkucera
vkucera approved these changes Jul 30, 2024
View reviewed changes

@vkuceravkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1994ra Thanks for addressing the remaining comments.

@vkucera
vkucera merged commit bf4d57b into AliceO2Group:masterJul 30, 2024
MaximVirta pushed a commit to MaximVirta/O2Physics that referenced this pull request Aug 5, 2024
@singhra1994MaximVirta
PWGHF, PWGCF: Charm hadron MC implementation (AliceO2Group#6832)
f487322
Luca610 pushed a commit to Luca610/O2Physics that referenced this pull request Aug 13, 2024
@singhra1994@Luca610
PWGHF, PWGCF: Charm hadron MC implementation (AliceO2Group#6832)
fded43b
@singhra1994
singhra1994 deleted the newbranchMc1 branch November 15, 2024 14:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfagginmfagginmfaggin left review comments
@victor-gonzalezvictor-gonzalezvictor-gonzalez approved these changes
@vkuceravkuceravkucera approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner
@fgrosafgrosaAwaiting requested review from fgrosafgrosa is a code owner
@fcatalan92fcatalan92Awaiting requested review from fcatalan92fcatalan92 is a code owner
@mmazzillimmazzilliAwaiting requested review from mmazzillimmazzilli is a code owner
@deepathomsdeepathomsAwaiting requested review from deepathomsdeepathoms is a code owner
@nzardoshnzardoshAwaiting requested review from nzardosh
@NicoleBastidNicoleBastidAwaiting requested review from NicoleBastidNicoleBastid is a code owner
@hahassan7hahassan7Awaiting requested review from hahassan7hahassan7 is a code owner
@jpxrkjpxrkAwaiting requested review from jpxrkjpxrk is a code owner
@jgrosseojgrosseoAwaiting requested review from jgrosseojgrosseo is a code owner
@saganattsaganattAwaiting requested review from saganatt
@zchochulzchochulAwaiting requested review from zchochul

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@singhra1994@alibuild@victor-gonzalez@ariedel-cern@vkucera@mfaggin