Skip to content

PIDML: evaluate FSE + self-attention network - #7162

Merged
saganatt merged 6 commits into
AliceO2Group:masterfrom
mytkom:master
Aug 7, 2024
Merged

PIDML: evaluate FSE + self-attention network#7162
saganatt merged 6 commits into
AliceO2Group:masterfrom
mytkom:master

Conversation

@mytkom

@mytkommytkom commented Aug 5, 2024

Copy link
Copy Markdown
Contributor

  • remove detector count setting and reorder network arguments (with NaNs if detector not available)

  • update README.md

  • markdownlint changes

@mytkom
PIDML evaluate FSE + self-attention network (#5)
a317a17
* remove detector count setting and reorder network arguments (with NaNs if detector not available)
* update README.md
* markdownlint changes
@alibuildalibuild mentioned this pull request Aug 5, 2024
Merged
@alibuild

alibuild commented Aug 5, 2024

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 6bafb63 at 2024-08-05 16:28:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/7162-slc7_x86-64/0/Tools/PIDML/pidOnnxModel.h:29:10: fatal error: onnxruntime/core/session/experimental_onnxruntime_cxx_api.h: No such file or directory
/sw/SOURCES/O2Physics/7162-slc7_x86-64/0/Tools/PIDML/pidOnnxModel.h:29:10: fatal error: onnxruntime/core/session/experimental_onnxruntime_cxx_api.h: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

saganatt
saganatt requested changes Aug 6, 2024
View reviewed changes

@saganattsaganatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for upgrading the code.
Here is my batch of comments.

Comment threadTools/PIDML/pidOnnxModel.h
Comment threadTools/PIDML/pidOnnxInterface.h Outdated
Comment threadTools/PIDML/README.md Outdated
Comment threadTools/PIDML/pidOnnxModel.h Outdated
Comment threadTools/PIDML/pidOnnxModel.h Outdated
Comment threadTools/PIDML/qaPidML.cxx
@alibuildalibuild mentioned this pull request Aug 6, 2024
Merged
@saganatt
saganatt merged commit 8247afd into AliceO2Group:masterAug 7, 2024
Luca610 pushed a commit to Luca610/O2Physics that referenced this pull request Aug 13, 2024
@mytkom@alibuild@Luca610
PIDML: evaluate FSE + self-attention network (AliceO2Group#7162)
e512fe0
* PIDML evaluate FSE + self-attention network (#5)
* remove detector count setting and reorder network arguments (with NaNs if detector not available)
* update README.md
* markdownlint changes
* MegaLinter fixes (#6)
* fix include missing file, the same way it was before
* readd pLimits to ONNXinterface and pass it to ONNXmodel
* Please consider the following formatting changes (#9)
* improve qaPidML according to new approach
---------
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
joonsukbae pushed a commit to joonsukbae/O2Physics that referenced this pull request Aug 27, 2024
@mytkom@alibuild@joonsukbae
PIDML: evaluate FSE + self-attention network (AliceO2Group#7162)
998bebb
* PIDML evaluate FSE + self-attention network (#5)
* remove detector count setting and reorder network arguments (with NaNs if detector not available)
* update README.md
* markdownlint changes
* MegaLinter fixes (#6)
* fix include missing file, the same way it was before
* readd pLimits to ONNXinterface and pass it to ONNXmodel
* Please consider the following formatting changes (#9)
* improve qaPidML according to new approach
---------
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saganattsaganattsaganatt approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mytkom@alibuild@saganatt