PWGHF: taskFlow.cxx: Add process functions for data TPC-MFT HF-h case, and MC Rec/Gen for TPC-TPC h-h case by AlexianL · Pull Request #7802 · AliceO2Group/O2Physics

AlexianL · 2024-09-26T13:17:01Z

QA functions and histograms for the data TPC-MFT HF-h case were also added
In both TPC-MFT h-h and TPC-MFT HF-h case, histograms have been more clearly separated to investigate tracks/candidates from the TPC and tracks from the MFT
QA functions and histograms for the MC Rec/Gen TPC-TPC h-h case were also added
Also mixCollisions function had to be duplicated to be adapted for MC Gen

Please consider the following formatting changes to AliceO2Group#6715

… multiplicity bins (merged with Container_labels)

…_labels

… run, and most of post-processing macros works on it too

Please consider the following formatting changes to AliceO2Group#7802

alibuild · 2024-10-04T10:53:38Z

Error while checking build/O2Physics/o2 for edd7cf7 at 2024-10-04 23:17:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/PWGHF/HFC/Tasks/taskFlow.cxx:116:59: error: redeclaration of 'using HfTaskFlow::aodMcCollisions = class o2::soa::Filtered<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::mccollision::BCId, o2::aod::mccollision::GeneratorsID, o2::aod::mccollision::PosX, o2::aod::mccollision::PosY, o2::aod::mccollision::PosZ, o2::aod::mccollision::T, o2::aod::mccollision::Weight, o2::aod::mccollision::ImpactParameter, o2::aod::mccollision::EventPlaneAngle, o2::aod::mccollision::GetGeneratorId<o2::aod::mccollision::GeneratorsID>, o2::aod::mccollision::GetSubGeneratorId<o2::aod::mccollision::GeneratorsID>, o2::aod::mccollision::GetSourceId<o2::aod::mccollision::GeneratorsID> > >'
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/PWGHF/HFC/Tasks/taskFlow.cxx:118:57: error: redeclaration of 'using HfTaskFlow::aodMcParticles = class o2::soa::Filtered<o2::soa::Join<o2::aod::McParticles_001ExtensionFrom<o2::framework::OriginEnc{5134660}>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::mcparticle::McCollisionId, o2::aod::mcparticle::PdgCode, o2::aod::mcparticle::StatusCode, o2::aod::mcparticle::Flags, o2::aod::mcparticle::MothersIds, o2::aod::mcparticle::DaughtersIdSlice, o2::aod::mcparticle::Weight, o2::aod::mcparticle::Px, o2::aod::mcparticle::Py, o2::aod::mcparticle::Pz, o2::aod::mcparticle::E, o2::aod::mcparticle::Vx, o2::aod::mcparticle::Vy, o2::aod::mcparticle::Vz, o2::aod::mcparticle::Vt, o2::aod::mcparticle::PVector<o2::aod::mcparticle::Px, o2::aod::mcparticle::Py, o2::aod::mcparticle::Pz>, o2::aod::mcparticle::ProducedByGenerator<o2::aod::mcparticle::Flags>, o2::aod::mcparticle::FromBackgroundEvent<o2::aod::mcparticle::Flags>, o2::aod::mcparticle::GetGenStatusCode<o2::aod::mcparticle::Flags, o2::aod::mcparticle::StatusCode>, o2::aod::mcparticle::GetHepMCStatusCode<o2::aod::mcparticle::Flags, o2::aod::mcparticle::StatusCode>, o2::aod::mcparticle::GetProcess<o2::aod::mcparticle::Flags, o2::aod::mcparticle::StatusCode>, o2::aod::mcparticle::IsPhysicalPrimary<o2::aod::mcparticle::Flags> > > >'
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/PWGHF/HFC/Tasks/taskFlow.cxx:120:115: error: redeclaration of 'using HfTaskFlow::aodTracks = class o2::soa::Filtered<o2::soa::Join<o2::soa::Join<o2::aod::TracksExtensionFrom<o2::framework::OriginEnc{5134660}>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::track::CollisionId, o2::aod::track::TrackType, o2::aod::track::X, o2::aod::track::Alpha, o2::aod::track::Y, o2::aod::track::Z, o2::aod::track::Snp, o2::aod::track::Tgl, o2::aod::track::Signed1Pt, o2::aod::track::IsWithinBeamPipe<o2::aod::track::X>, o2::aod::track::Px<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Py<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Pz<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::PVector<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha, o2::aod::track::Tgl>, o2::aod::track::Energy<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Rapidity<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Sign<o2::aod::track::Signed1Pt>, o2::soa::Marker<1> > >, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::track::DcaXY, o2::aod::track::DcaZ>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::track::IsGlobalTrackSDD, o2::aod::track::TrackCutFlag, o2::aod::track::TrackCutFlagFb1, o2::aod::track::TrackCutFlagFb2, o2::aod::track::TrackCutFlagFb3, o2::aod::track::TrackCutFlagFb4, o2::aod::track::TrackCutFlagFb5, o2::aod::track::IsQualityTrack<o2::aod::track::TrackCutFlag>, o2::aod::track::IsQualityTrackITS<o2::aod::track::TrackCutFlag>, o2::aod::track::IsQualityTrackTPC<o2::aod::track::TrackCutFlag>, o2::aod::track::IsPrimaryTrack<o2::aod::track::TrackCutFlag>, o2::aod::track::IsInAcceptanceTrack<o2::aod::track::TrackCutFlag>, o2::aod::track::IsGlobalTrack<o2::aod::track::TrackCutFlag>, o2::aod::track::IsGlobalTrackWoTPCCluster<o2::aod::track::TrackCutFlag>, o2::aod::track::IsGlobalTrackWoPtEta<o2::aod::track::TrackCutFlag>, o2::aod::track::IsGlobalTrackWoDCA<o2::aod::track::TrackCutFlag>, o2::aod::track::IsGlobalTrackWoDCATPCCluster<o2::aod::track::TrackCutFlag> >, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::mctracklabel::McParticleId, o2::aod::mctracklabel::McMask> > >'
ninja: build stopped: subcommand failed.

Full log here.

AlexianL · 2024-10-04T11:42:03Z

Error while checking build/O2Physics/o2 for edd7cf7 at 2024-10-04 12:53:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/DPG/Tasks/AOTTrack/qaTrackSplitting.cxx:170:128: fatal error: error writing to /tmp/cc2FfA0n.s: No space left on device
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/DPG/Tasks/AOTTrack/MonitorFilterBit.cxx:585:1: fatal error: error writing to /tmp/ccoQz47A.s: No space left on device
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/DPG/Tasks/AOTTrack/PID/TOF/qaPIDTOFBeta.cxx:418:124: fatal error: error writing to /tmp/cc3MBysw.s: No space left on device
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/DPG/Tasks/AOTTrack/PID/HMPID/analysisHMPID.cxx:131:126: fatal error: error writing to /tmp/ccU5sbEt.s: No space left on device
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/DPG/Tasks/AOTTrack/PID/Combined/qaPIDWithV0s.cxx:265:1: fatal error: error writing to /tmp/ccHQuxS7.s: No space left on device
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/DPG/Tasks/AOTTrack/PID/TPC/qaPIDTPCSignal.cxx:299:126: fatal error: error writing to /tmp/ccKJlwRe.s: No space left on device
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/DPG/Tasks/AOTTrack/PID/HMPID/qaHMPID.cxx:305:120: fatal error: error writing to /tmp/ccfUF9QC.s: No space left on device
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/DPG/Tasks/AOTTrack/PID/TOF/qaPIDTOFEvTime.cxx:604:133: fatal error: error writing to /tmp/ccT7GX8n.s: No space left on device
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/DPG/Tasks/AOTTrack/qaEventTrackLiteProducer.cxx:432:1: fatal error: error writing to /tmp/cctEfcEn.s: No space left on device
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/DPG/Tasks/AOTTrack/PID/TOF/qaPIDTOFMC.cxx:752:122: fatal error: error writing to /tmp/ccP4dGA8.s: No space left on device
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/DPG/Tasks/AOTTrack/PID/TPC/qaPIDTPCMC.cxx:591:122: fatal error: error writing to /tmp/ccOgNL1E.s: No space left on device
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/DPG/Tasks/AOTTrack/qaMatchEff.cxx:3448:1: fatal error: error writing to /tmp/ccGD8w3s.s: No space left on device
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/DPG/Tasks/AOTTrack/qaImpPar.cxx:717:1: fatal error: error writing to /tmp/ccZolJZ3.s: No space left on device
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/DPG/Tasks/AOTTrack/qaEventTrack.cxx:1733:1: fatal error: error writing to /tmp/ccuYJH34.s: No space left on device
/sw/SOURCES/O2Physics/7802-slc7_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:2118:124: fatal error: error writing to /tmp/ccMbX10i.s: No space left on device
ninja: build stopped: subcommand failed.

Full log here.

It is not obvious to me what the problem is here

vkucera · 2024-10-04T11:50:02Z

@AlexianL , the machine that checks the compilation ran out of disk space. Unlikely your fault.

vkucera · 2024-10-04T16:12:15Z

@AlexianL , please always compile and test your code before making/updating a PR. Your code does not even compile, wasting resources for PR tests.

…way to remove MC particles with charge equal to 0 which caused segmentation faults in the MC GEN case

Please consider the following formatting changes to AliceO2Group#7802

…way to remove MC particles with charge equal to 0 which caused segmentation faults in the MC GEN case

Please consider the following formatting changes to AliceO2Group#7802

…way to remove MC particles with charge equal to 0 which caused segmentation faults in the MC GEN case

Please consider the following formatting changes to AliceO2Group#7802

vkucera

Thanks @AlexianL for implementing patiently my comments.
I leave the final approval and merging to the HFC coordinators.

…, and MC Rec/Gen for TPC-TPC h-h case (AliceO2Group#7802) * Uniformization of the name of the correlation containers * ONGOING WORK : adding TPC-TPC Monte-Carlo process functions * ONGOING WORK : Uniformize the name of Correlations containers * Please consider the following formatting changes * Solved typos in the declaration of 2 correlation containers * Solved the same typos as the container_labels branch * The newly added MC process functions for TPC-TPC h-h case compile and run, and most of post-processing macros works on it too * Corrected a typo * Typo correction * Typo correction : everything case can run successfully now * Implemented both rec MC and gen MC * Running MC process functions for TPC-TPC h-h * Added process functions for the TPC-MFT HF-h case * Please consider the following formatting changes * Update PWGHF/HFC/Tasks/taskFlow.cxx Co-authored-by: Vít Kučera <vit.kucera@cern.ch> * Addressing comments * Addressing comments * Please consider the following formatting changes * Changing the path of some plots, and adding new plot * Renaming plots and adding inv mass plot for D0 * Please consider the following formatting changes * Problems solved : error when merging + have to come back to previous way to remove MC particles with charge equal to 0 which caused segmentation faults in the MC GEN case * add space at the end * Please consider the following formatting changes * Problems solved : error when merging + have to come back to previous way to remove MC particles with charge equal to 0 which caused segmentation faults in the MC GEN case * Changes in isMcParticleSelected * Please consider the following formatting changes * Problems solved : error when merging + have to come back to previous way to remove MC particles with charge equal to 0 which caused segmentation faults in the MC GEN case * Changes in isMcParticleSelected * addressing comments * Please consider the following formatting changes --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>

AlexianLand others added 17 commits June 19, 2024 13:37

Uniformization of the name of the correlation containers
c11e472

ONGOING WORK : adding TPC-TPC Monte-Carlo process functions
c63bd5f

ONGOING WORK : Uniformize the name of Correlations containers
133d65f

Please consider the following formatting changes
393d11b

Merge pull request#1from alibuild/alibot-cleanup-6715
e8a0f73
Please consider the following formatting changes to AliceO2Group#6715

Added h-MFT mixed event process function, trying to artificially fill…
a91d176
… multiplicity bins (merged with Container_labels)

Solved typos in the declaration of 2 correlation containers
25b629e

Merge remote-tracking branch 'origin/Container_labels' into Container…
ccf8e9b
…_labels

Solved the same typos as the container_labels branch
773b95c

The newly added MC process functions for TPC-TPC h-h case compile and…
e136d0d
… run, and most of post-processing macros works on it too

Corrected a typo
f5825f2

Typo correction
1c646a0

Typo correction : everything case can run successfully now
835f4ce

Merged with Container_labels
2f71182

Implemented both rec MC and gen MC
f46b6d1

Running MC process functions for TPC-TPC h-h
2975e66

Added process functions for the TPC-MFT HF-h case
0de6f92

alibuild mentioned this pull request Sep 26, 2024
Please consider the following formatting changes to #7802 AlexianL/O2Physics#4
Merged

AlexianLand others added 3 commits September 26, 2024 15:18

Merge branch 'master' into add_data_TPCMFT_HF_h
0cff43a

Please consider the following formatting changes
97bfadd

Merge pull request#4from alibuild/alibot-cleanup-7802
a4dac16
Please consider the following formatting changes to AliceO2Group#7802

AlexianL changed the title ~~PWGHF: taskFlow.cxx: Add process functions for TPC-MFT HF-h case~~PWGHF: taskFlow.cxx: Add process functions for data TPC-MFT HF-h case, and MC Rec/Gen for TPC-TPC h-h caseSep 26, 2024

AlexianL marked this pull request as ready for review September 26, 2024 13:31

AlexianL requested review from alibuild, fcatalan92, fcolamar, fgrosa, mfaggin, mmazzilli and vkucera as code owners September 26, 2024 13:31

Please consider the following formatting changes
0e43de8

alibuild mentioned this pull request Oct 4, 2024
Please consider the following formatting changes to #7802 AlexianL/O2Physics#6
Merged

Merge pull request#6from alibuild/alibot-cleanup-7802
edd7cf7
Please consider the following formatting changes to AliceO2Group#7802

AlexianLand others added 3 commits October 7, 2024 15:16

Problems solved : error when merging + have to come back to previous …
a2eba57
…way to remove MC particles with charge equal to 0 which caused segmentation faults in the MC GEN case

add space at the end
7061aa9

Please consider the following formatting changes
b000230

alibuild mentioned this pull request Oct 7, 2024
Please consider the following formatting changes to #7802 AlexianL/O2Physics#7
Merged

AlexianLand others added 4 commits October 7, 2024 15:24

Merge pull request#7from alibuild/alibot-cleanup-7802
168876d
Please consider the following formatting changes to AliceO2Group#7802

Problems solved : error when merging + have to come back to previous …
3010e1f
…way to remove MC particles with charge equal to 0 which caused segmentation faults in the MC GEN case

Changes in isMcParticleSelected
fdb9800

Please consider the following formatting changes
06d456e

alibuild mentioned this pull request Oct 8, 2024
Please consider the following formatting changes to #7802 AlexianL/O2Physics#8
Merged

Merge pull request#8from alibuild/alibot-cleanup-7802
e715c61
Please consider the following formatting changes to AliceO2Group#7802

vkucera requested changes Oct 9, 2024
View reviewed changes

Comment threadPWGHF/HFC/Tasks/taskFlow.cxx Outdated
Comment threadPWGHF/HFC/Tasks/taskFlow.cxx Outdated
Comment threadPWGHF/HFC/Tasks/taskFlow.cxx Outdated
Comment threadPWGHF/HFC/Tasks/taskFlow.cxx Outdated
Comment threadPWGHF/HFC/Tasks/taskFlow.cxx

AlexianLand others added 4 commits October 9, 2024 18:04

Problems solved : error when merging + have to come back to previous …
2a2ecea
…way to remove MC particles with charge equal to 0 which caused segmentation faults in the MC GEN case

Changes in isMcParticleSelected
dbe5f27

addressing comments
556b88f

Please consider the following formatting changes
65425d8

alibuild mentioned this pull request Oct 9, 2024
Please consider the following formatting changes to #7802 AlexianL/O2Physics#9
Merged

Merge pull request#9from alibuild/alibot-cleanup-7802
90c9adf
Please consider the following formatting changes to AliceO2Group#7802

vkucera approved these changes Oct 9, 2024
View reviewed changes

deepathoms approved these changes Oct 11, 2024
View reviewed changes

fgrosa merged commit 0a15984 into AliceO2Group:masterOct 11, 2024

AlexianL deleted the add_data_TPCMFT_HF_h branch October 16, 2024 10:04

Navigation Menu

Uh oh!

PWGHF: taskFlow.cxx: Add process functions for data TPC-MFT HF-h case, and MC Rec/Gen for TPC-TPC h-h case - #7802

PWGHF: taskFlow.cxx: Add process functions for data TPC-MFT HF-h case, and MC Rec/Gen for TPC-TPC h-h case#7802
fgrosa merged 43 commits into
AliceO2Group:masterfrom
AlexianL:add_data_TPCMFT_HF_h

AlexianL commented Sep 26, 2024•
edited
Loading

Uh oh!

alibuild commented Oct 4, 2024•
edited
Loading

Uh oh!

AlexianL commented Oct 4, 2024

Uh oh!

vkucera commented Oct 4, 2024

Uh oh!

vkucera commented Oct 4, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vkucera left a comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

AlexianL commented Sep 26, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Oct 4, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlexianL commented Oct 4, 2024

Uh oh!

vkucera commented Oct 4, 2024

Uh oh!

vkucera commented Oct 4, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vkucera left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

AlexianL commented Sep 26, 2024•
edited
Loading

alibuild commented Oct 4, 2024•
edited
Loading