Uh oh!
There was an error while loading. Please reload this page.
[PWGHF] Adjust the structure of the Lc to pkpi task - #8210
Conversation
mfaggin
left a comment
There was a problem hiding this comment.
thanks @zhangbiao-phy , please consider my comments.
On top of them: have you compared the output with the new version of the code vs. the old one? Are they the same?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
zhangbiao-phy
commented
Oct 30, 2024
Hi @mfaggin, yes, I have tested the Mc data, the histogram of the rec is the same for new and old. Then there is an issue introduced by my last commit for the generated particle loop. It can be fixed by run it per collision with this PR. |
Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch>
Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch>
Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch>
Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch>
Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch>
mfaggin
left a comment
There was a problem hiding this comment.
thanks a lot @zhangbiao-phy , approved
alibuild
commented
Oct 30, 2024
Error while checking build/O2Physics/o2 for 772d2c7 at 2024-10-30 10:37: Full log here. |
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Please consider the following formatting changes to AliceO2Group#8210
Hi @vkucera, I have commited the changes from your last comment, Could you please have a look? Thanks a lot! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vkucera
commented
Nov 1, 2024
Fix the cpplint error |
updated based on Vit's suggestions Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
zhangbiao-phy
commented
Nov 1, 2024
@vkucera, I'm not sure why this error is occurring. I could add |
vkucera
commented
Nov 1, 2024
The error is occurring because the code uses |
Please consider the following formatting changes to AliceO2Group#8210
zhangbiao-phy
commented
Nov 1, 2024
hi @vkucera, Thanks a lot! Done! but another error for |
vkucera
commented
Nov 1, 2024
Indeed, that one is unrelated. |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
vkucera
commented
Nov 1, 2024
Thanks @zhangbiao-phy for addressing my comments. Can you please test the latest version and confirm that it gives results identical with the results of the upstream version? |
zhangbiao-phy
commented
Nov 2, 2024
Hi @vkucera, Thanks for your review! I have tested the task with both MC and data using the old and new versions, and I have confirmed that both versions produce the same results. |
vkucera
commented
Nov 3, 2024
Thanks @zhangbiao-phy |
fillHistosMcGen,fillHistosMcRec,fillHistosDatafor the histogram and THnSparse filling)