Uh oh!
There was an error while loading. Please reload this page.
[PWGCF] New task for TwoParticleCorrelation - #8509
Merged
Merged
Conversation
Thorkj
marked this pull request as ready for review
November 18, 2024 13:38
Thorkj
requested review from
alibuild, ariedel-cern, lauraser, lgraczykCern, otonvd, prchakra, saganatt, shouqiye, victor-gonzalez and zchochul
as code ownersNovember 18, 2024 13:38
Please consider the following formatting changes to AliceO2Group#8509
vkucera
reviewed
Nov 18, 2024
Comment on lines
+110
to
+115
| if (deltaPhi > 1.5f * PI) { | ||
| deltaPhi -= TwoPI; | ||
| } | ||
| if (deltaPhi < -PIHalf) { | ||
| deltaPhi += TwoPI; | ||
| } |
Collaborator
There was a problem hiding this comment.
Do not duplicate already available utilities. See RecoDecay::constrainAngle.
Collaborator
There was a problem hiding this comment.
vkucera
reviewed
Nov 18, 2024
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
vkucera
reviewed
Nov 18, 2024
Comment on lines
+48
to
+50
| int s = 1; // same event | ||
| int m = 2; // mixed event | ||
Collaborator
There was a problem hiding this comment.
Where do you use these? The names are very bad because they are meaningless and basically unsearchable in the code. If you really need those as constants, use enum.
ContributorAuthor
There was a problem hiding this comment.
Sorry for the late response, I have now removed them as I didn't use them.
vkucera
reviewed
Nov 18, 2024
Comment on lines
+25
to
+30
| #include "TMath.h" | ||
| #include "TList.h" | ||
| #include "TProfile.h" | ||
| #include "TRandom3.h" | ||
| #include <cmath> | ||
| #include <iostream> |
Collaborator
There was a problem hiding this comment.
Where do you need these headers?
ContributorAuthor
There was a problem hiding this comment.
I'll remove them and see if the code works
I removed some headers which were not needed
victor-gonzalez
requested changes
Nov 20, 2024
Comment on lines
+28
to
+35
| namespace hash | ||
| { | ||
| DECLARE_SOA_COLUMN(Bin, bin, int); | ||
| } // namespace hash | ||
| DECLARE_SOA_TABLE(Hashes, "AOD", "HASH", hash::Bin); | ||
| using Hash = Hashes::iterator; | ||
| } // namespace o2::aod |
Collaborator
There was a problem hiding this comment.
Please, remove it as it is not used
Comment on lines
+110
to
+115
| if (deltaPhi > 1.5f * PI) { | ||
| deltaPhi -= TwoPI; | ||
| } | ||
| if (deltaPhi < -PIHalf) { | ||
| deltaPhi += TwoPI; | ||
| } |
Collaborator
There was a problem hiding this comment.
removed namespase o2::aod
Please consider the following formatting changes to AliceO2Group#8509
victor-gonzalez
requested changes
Nov 22, 2024
victor-gonzalez
left a comment
Collaborator
There was a problem hiding this comment.
Please, implement the first suggestion from Vit which I expanded giving you where you can find what he suggested
I have changed to RicoDecay::constrainAngle()
Please consider the following formatting changes to AliceO2Group#8509
victor-gonzalez
approved these changes
Nov 26, 2024
victor-gonzalez
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for implementing our suggestions!
victor-gonzalez
enabled auto-merge (squash)
November 26, 2024 14:41
joachimckh pushed a commit
to joachimckh/O2Physics
that referenced
this pull request
Dec 2, 2024
Co-authored-by: Thor Jensen <thor@Thors-MacBook-Pro.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
joachimckh pushed a commit
to joachimckh/O2Physics
that referenced
this pull request
Dec 2, 2024
Co-authored-by: Thor Jensen <thor@Thors-MacBook-Pro.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
wefeng1110 pushed a commit
to wefeng1110/O2Physics
that referenced
this pull request
Dec 6, 2024
Co-authored-by: Thor Jensen <thor@Thors-MacBook-Pro.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Archita-Dash pushed a commit
to Archita-Dash/O2Physics
that referenced
this pull request
Dec 11, 2024
Co-authored-by: Thor Jensen <thor@Thors-MacBook-Pro.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
hernasab pushed a commit
to hernasab/O2Physics
that referenced
this pull request
Dec 20, 2024
Co-authored-by: Thor Jensen <thor@Thors-MacBook-Pro.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
feisenhu pushed a commit
to feisenhu/O2Physics
that referenced
this pull request
Jan 8, 2025
Co-authored-by: Thor Jensen <thor@Thors-MacBook-Pro.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a task adding the deltaPhi and deltaEta along with, Nch, pT, to a sparse for local processing.