Skip to content

[PWGCF] Generic Framework: PID v2 - #8651

Merged
victor-gonzalez merged 4 commits into
AliceO2Group:masterfrom
Preet-Bhanjan:master
Nov 27, 2024
Merged

[PWGCF] Generic Framework: PID v2#8651
victor-gonzalez merged 4 commits into
AliceO2Group:masterfrom
Preet-Bhanjan:master

Conversation

@Preet-Bhanjan

@Preet-BhanjanPreet-Bhanjan commented Nov 25, 2024

Copy link
Copy Markdown
Contributor

Using generic framework for computing the two-particle correlation v2 for pions, kaons, and protons.

@alibuildalibuild mentioned this pull request Nov 25, 2024
Closed
@alibuild

alibuild commented Nov 25, 2024

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 24db179 at 2024-11-25 21:18:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/8651-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/FlowGFPbPbpikp.cxx:113:5: error: 'sTObjArray' was not declared in this scope; did you mean 'TObjArray'?
/sw/SOURCES/O2Physics/8651-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/FlowGFPbPbpikp.cxx:113:17: error: 'oba' was not declared in this scope
/sw/SOURCES/O2Physics/8651-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/FlowGFPbPbpikp.cxx:130:5: error: type '<type error>' argument given to 'delete', expected pointer
ninja: build stopped: subcommand failed.

Full log here.

victor-gonzalez
victor-gonzalez requested changes Nov 25, 2024
View reviewed changes

@victor-gonzalezvictor-gonzalez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't use the GenericFramework directory. It is for the own GFW

This task was already created in the Flow directory which is where it should be placed

Why is not the one there updated?

@Preet-Bhanjan

Preet-Bhanjan commented Nov 26, 2024 via email

Copy link
Copy Markdown
ContributorAuthor

@alibuildalibuild mentioned this pull request Nov 26, 2024
Merged
Preet-Bhanjan added a commit to Preet-Bhanjan/O2Physics that referenced this pull request Nov 27, 2024
@Preet-Bhanjan
Merge pull request#3from alibuild/alibot-cleanup-8651
d7fcd07
[PWGCF] Please consider the following formatting changes to AliceO2Group#8651
victor-gonzalez
victor-gonzalez reviewed Nov 27, 2024
View reviewed changes
Comment threadPWGCF/Flow/Tasks/FlowPbPbpikp.cxx Outdated
victor-gonzalez
victor-gonzalez reviewed Nov 27, 2024
View reviewed changes
Comment threadPWGCF/Flow/Tasks/FlowPbPbpikp.cxx Outdated
victor-gonzalez
victor-gonzalez reviewed Nov 27, 2024
View reviewed changes
Comment threadPWGCF/Flow/Tasks/FlowPbPbpikp.cxx Outdated
victor-gonzalez
victor-gonzalez reviewed Nov 27, 2024
View reviewed changes
Comment threadPWGCF/Flow/Tasks/FlowPbPbpikp.cxx
Comment on lines +183 to +200
if (idprob.first == 0 || idprob.first == 1 || idprob.first == 2) { // 0 = pion, 1 = kaon, 2 = proton
pidID = idprob.first;
float nsigmaTPC[3] = {track.tpcNSigmaPi(), track.tpcNSigmaKa(), track.tpcNSigmaPr()};
if (idprob.second > maxProb[pidID]) {
if (abs(nsigmaTPC[pidID]) > 3)
return 0;
return pidID + 1; // shift the pid by 1, 1 = pion, 2 = kaon, 3 = proton

@victor-gonzalezvictor-gonzalezNov 27, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using an enum for particle named constants and using it consistently
The function can return -1 (kWRONGID = -1) in case the identification is not accepted

victor-gonzalez
victor-gonzalez requested changes Nov 27, 2024
View reviewed changes

@victor-gonzalezvictor-gonzalez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove from the PR the not affected file and also change the name of the task according to the functionality
The other comments are for your consideration in next iterations

Comment threadPWGCF/GenericFramework/Tasks/CMakeLists.txt
@alibuild

alibuild commented Nov 27, 2024

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 3e7fdc0 at 2024-11-27 14:21:

## sw/BUILD/O2Physics-latest/log
CMake Error at PWGCF/GenericFramework/CMakeLists.txt:13 (add_subdirectory):

Full log here.

@alibuildalibuild mentioned this pull request Nov 27, 2024
Merged
Preet-Bhanjan added a commit to Preet-Bhanjan/O2Physics that referenced this pull request Nov 27, 2024
@Preet-Bhanjan
Merge pull request#4from alibuild/alibot-cleanup-8651
3151ba3
[PWGCF] Please consider the following formatting changes to AliceO2Group#8651
@alibuildalibuild mentioned this pull request Nov 27, 2024
Closed
@alibuild

alibuild commented Nov 27, 2024

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for b70ef6a at 2024-11-27 14:48:

## sw/BUILD/O2Physics-latest/log
CMake Error at PWGCF/GenericFramework/CMakeLists.txt:13 (add_subdirectory):

Full log here.

victor-gonzalez
victor-gonzalez requested changes Nov 27, 2024
View reviewed changes

@victor-gonzalezvictor-gonzalez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file PWGCF/GenericFramework/Tasks/CMakeLists.txt should not be part of this PR which means that it should not be modified by the PR. As it is right now the PR modify it and that's why it is included in the PR. It should not be included in the PR

Comment threadPWGCF/GenericFramework/Tasks/CMakeLists.txt
@@ -12,4 +12,4 @@
o2physics_add_dpl_workflow(flow-generic-framework

@victor-gonzalezvictor-gonzalezNov 27, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be part of this PR

@victor-gonzalez

victor-gonzalez commented Nov 27, 2024

Copy link
Copy Markdown
Collaborator

@Preet-Bhanjan Please, don't close the PR, all the comments will be lost if you open a new one
Just modify your local repository restoring the original PWGCF/GenericFramework/Tasks/CMakeLists.txt before your changes and then push again towards your remote fork. That will update automatically the PR

@alibuildalibuild mentioned this pull request Nov 27, 2024
Merged
@Preet-Bhanjan
Merge pull request#6from alibuild/alibot-cleanup-8651
dd6f46c
[PWGCF] Please consider the following formatting changes to AliceO2Group#8651
@alibuildalibuild mentioned this pull request Nov 27, 2024
Closed
victor-gonzalez
victor-gonzalez approved these changes Nov 27, 2024
View reviewed changes

@victor-gonzalezvictor-gonzalez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@victor-gonzalez
victor-gonzalez merged commit d91eb8c into AliceO2Group:masterNov 27, 2024
joachimckh pushed a commit to joachimckh/O2Physics that referenced this pull request Dec 2, 2024
@Preet-BhanjanPreet Pati
@alibuild@joachimckh
[PWGCF] Generic Framework: PID v2 (AliceO2Group#8651)
35a7bd6
Co-authored-by: Preet Pati <preet@preet-2.local>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
joachimckh pushed a commit to joachimckh/O2Physics that referenced this pull request Dec 2, 2024
@Preet-BhanjanPreet Pati
@alibuild@joachimckh
[PWGCF] Generic Framework: PID v2 (AliceO2Group#8651)
4ea6d75
Co-authored-by: Preet Pati <preet@preet-2.local>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
wefeng1110 pushed a commit to wefeng1110/O2Physics that referenced this pull request Dec 6, 2024
@Preet-BhanjanPreet Pati
@alibuildWenhui Feng
[PWGCF] Generic Framework: PID v2 (AliceO2Group#8651)
afe9956
Co-authored-by: Preet Pati <preet@preet-2.local>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Archita-Dash pushed a commit to Archita-Dash/O2Physics that referenced this pull request Dec 11, 2024
@Preet-BhanjanPreet Pati
@alibuild@Archita-Dash
[PWGCF] Generic Framework: PID v2 (AliceO2Group#8651)
47fcb3c
Co-authored-by: Preet Pati <preet@preet-2.local>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Dec 20, 2024
@Preet-BhanjanPreet Pati
@alibuildSabrina Hernandez
[PWGCF] Generic Framework: PID v2 (AliceO2Group#8651)
bae4d3f
Co-authored-by: Preet Pati <preet@preet-2.local>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
feisenhu pushed a commit to feisenhu/O2Physics that referenced this pull request Jan 8, 2025
@Preet-BhanjanPreet Pati
@alibuild@feisenhu
[PWGCF] Generic Framework: PID v2 (AliceO2Group#8651)
f6116d1
Co-authored-by: Preet Pati <preet@preet-2.local>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-gonzalezvictor-gonzalezvictor-gonzalez approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@saganattsaganattAwaiting requested review from saganatt
@zchochulzchochulAwaiting requested review from zchochul
@lgraczykCernlgraczykCernAwaiting requested review from lgraczykCern
@prchakraprchakraAwaiting requested review from prchakra
@lauraserlauraserAwaiting requested review from lauraserlauraser is a code owner
@ariedel-cernariedel-cernAwaiting requested review from ariedel-cern
@otonvdotonvdAwaiting requested review from otonvd
@shouqiyeshouqiyeAwaiting requested review from shouqiye

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Preet-Bhanjan@alibuild@victor-gonzalez