Skip to content

[PWGCF] Update analysis structure and add centrality dependence - #9082

Merged
victor-gonzalez merged 5 commits into
AliceO2Group:masterfrom
omassen:NeutronSbranch
Jan 6, 2025
Merged

[PWGCF] Update analysis structure and add centrality dependence#9082
victor-gonzalez merged 5 commits into
AliceO2Group:masterfrom
omassen:NeutronSbranch

Conversation

@omassen

@omassenomassen commented Dec 20, 2024

Copy link
Copy Markdown
Contributor

Updated the structure of the analysis task to a more realistic one. Changed the output structure, using folders for the A- and C-side of the ZDC. In addition also implemented centrality dependence for more histograms.

See for a full history of recent changes this closed PR: #9045

@github-actionsgithub-actionsBot changed the title Update analysis structure and add centrality dependence[PWGCF] Update analysis structure and add centrality dependenceDec 20, 2024
@victor-gonzalez

victor-gonzalez commented Dec 20, 2024

Copy link
Copy Markdown
Collaborator

Please, rename your executable to neutron-proton-corr-zdc in CMakeLists.txt to adhere to linter rules

@omassen
omassen marked this pull request as ready for review December 20, 2024 15:37
@alibuild

alibuild commented Dec 20, 2024

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 2b28fd8 at 2024-12-20 17:38:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:113:34: error: 'std::__cxx11::basic_string<char>::<unnamed union> std::__cxx11::basic_string<char>::<anonymous>' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:113:34: error: 'char std::__cxx11::basic_string<char>::<unnamed union>::_M_local_buf [16]' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:113:34: error: 'std::__cxx11::basic_string<char>::<unnamed union> std::__cxx11::basic_string<char>::<anonymous>' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:113:34: error: 'char std::__cxx11::basic_string<char>::<unnamed union>::_M_local_buf [16]' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:113:34: error: 'std::__cxx11::basic_string<char>::<unnamed union> std::__cxx11::basic_string<char>::<anonymous>' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:113:34: error: 'char std::__cxx11::basic_string<char>::<unnamed union>::_M_local_buf [16]' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:113:34: error: 'std::__cxx11::basic_string<char>::<unnamed union> std::__cxx11::basic_string<char>::<anonymous>' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:113:34: error: 'char std::__cxx11::basic_string<char>::<unnamed union>::_M_local_buf [16]' is private within this context
ninja: build stopped: subcommand failed.

Full log here.

@victor-gonzalez

victor-gonzalez commented Dec 22, 2024

Copy link
Copy Markdown
Collaborator

Check O2Physics/Tutorials/src/histogramRegistry.cxx for guidance

@alibuild

alibuild commented Jan 6, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for f45b62e at 2025-01-06 12:15:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:114:34: error: 'std::__cxx11::basic_string<char>::<unnamed union> std::__cxx11::basic_string<char>::<anonymous>' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:114:34: error: 'char std::__cxx11::basic_string<char>::<unnamed union>::_M_local_buf [16]' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:114:34: error: 'std::__cxx11::basic_string<char>::<unnamed union> std::__cxx11::basic_string<char>::<anonymous>' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:114:34: error: 'char std::__cxx11::basic_string<char>::<unnamed union>::_M_local_buf [16]' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:114:34: error: 'std::__cxx11::basic_string<char>::<unnamed union> std::__cxx11::basic_string<char>::<anonymous>' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:114:34: error: 'char std::__cxx11::basic_string<char>::<unnamed union>::_M_local_buf [16]' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:114:34: error: 'std::__cxx11::basic_string<char>::<unnamed union> std::__cxx11::basic_string<char>::<anonymous>' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:114:34: error: 'char std::__cxx11::basic_string<char>::<unnamed union>::_M_local_buf [16]' is private within this context
ninja: build stopped: subcommand failed.

Full log here.

@omassen

omassen commented Jan 6, 2025

Copy link
Copy Markdown
ContributorAuthor

I fixed the build issues. It took a bit longer as I did not experience these problems locally, but it should be all good now!

victor-gonzalez
victor-gonzalez reviewed Jan 6, 2025
View reviewed changes
Comment threadPWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx
histos.fill(HIST(SubDir[side]) + HIST("CentvsZNSector1Signal"), centr, znEnergyResponse[side][1]);
histos.fill(HIST(SubDir[side]) + HIST("CentvsZNSector2Signal"), centr, znEnergyResponse[side][2]);
histos.fill(HIST(SubDir[side]) + HIST("CentvsZNSector3Signal"), centr, znEnergyResponse[side][3]);

@victor-gonzalezvictor-gonzalezJan 6, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point you can consider using a static constexpr array of std::string_view for encoding the names of the four sectors histograms and simplify this code

@victor-gonzalez
victor-gonzalez merged commit bc31718 into AliceO2Group:masterJan 6, 2025
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Jan 11, 2025
@omassenSabrina Hernandez
[PWGCF] Update analysis structure and add centrality dependence (Alic…
ba32ab8
…eO2Group#9082)
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Feb 17, 2025
@omassen@smaff92
[PWGCF] Update analysis structure and add centrality dependence (Alic…
030446a
…eO2Group#9082)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-gonzalezvictor-gonzalezvictor-gonzalez approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@saganattsaganattAwaiting requested review from saganatt
@zchochulzchochulAwaiting requested review from zchochul
@lgraczykCernlgraczykCernAwaiting requested review from lgraczykCern
@prchakraprchakraAwaiting requested review from prchakra
@lauraserlauraserAwaiting requested review from lauraserlauraser is a code owner
@ariedel-cernariedel-cernAwaiting requested review from ariedel-cern
@otonvdotonvdAwaiting requested review from otonvd
@shouqiyeshouqiyeAwaiting requested review from shouqiye

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@omassen@victor-gonzalez@alibuild