[PWGHF] Add centrality information to Xic0 by Tao-Fang · Pull Request #9128 · AliceO2Group/O2Physics

Tao-Fang · 2024-12-25T12:31:01Z

The FT0M, FT0A, FT0C and numContrib has been added to Xic0 event lever

Please consider the following formatting changes to #9128

fgrosa

Hi @Tao-Fang! I have a couple of comments, please take a look at them (especially regarding the unbound indices, I believe that you need to find another strategy)

fgrosa

@Tao-Fang ok for me if removed from the "lite" table, even though I am still convinced that this will give you the error about unbound indices if you select the "full" table. I think that for the Lc nobody uses the "full" version, but I believe that it also produces the error about unbound indices.
In any case we can merge it as soon as you implement the two remaining comments (if you consume the table with the centrality in the process functions without centrality, they anyway require the centrality task as dependency)

Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>

alibuild · 2025-01-21T19:02:05Z

Error while checking build/O2Physics/o2 for 0fe7dbc at 2025-01-21 20:02:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9128-slc9_x86-64/0/PWGHF/TableProducer/treeCreatorToXiPi.cxx:275:28: error: 'const struct o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >' has no member named 'centFT0A'
/sw/SOURCES/O2Physics/9128-slc9_x86-64/0/PWGHF/TableProducer/treeCreatorToXiPi.cxx:276:28: error: 'const struct o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >' has no member named 'centFT0C'
/sw/SOURCES/O2Physics/9128-slc9_x86-64/0/PWGHF/TableProducer/treeCreatorToXiPi.cxx:277:28: error: 'const struct o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >' has no member named 'centFT0M'
/sw/SOURCES/O2Physics/9128-slc9_x86-64/0/PWGHF/TableProducer/treeCreatorToXiPi.cxx:278:28: error: 'const struct o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >' has no member named 'centFV0A'
/sw/SOURCES/O2Physics/9128-slc9_x86-64/0/PWGHF/TableProducer/treeCreatorToXiPi.cxx:279:28: error: 'const struct o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >' has no member named 'centFDDM'
/sw/SOURCES/O2Physics/9128-slc9_x86-64/0/PWGHF/TableProducer/treeCreatorToXiPi.cxx:296:17: error: 'const struct o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >' has no member named 'multZeqNTracksPV'
ninja: build stopped: subcommand failed.

Full log here.

ktf · 2025-01-21T19:22:41Z

Looks like a genuine error. Please check.

ktf · 2025-01-22T21:31:10Z

Please check the build.

Tao-Fang · 2025-01-23T12:04:59Z

Please check the build.
The bug is fix and local build is passed

Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>

Add centrality information to Xic0
fcf5cbf
The FT0M, FT0A, FT0C and numContrib has been added to Xic0 event lever

Tao-Fang requested review from NicoleBastid, alibuild, apalasciano, deepathoms, fcatalan92, fcolamar, fgrosa, hahassan7, jpxrk, mfaggin, mmazzilli and vkucera as code owners December 25, 2024 12:31

github-actionsBot added the pwghf PWG-HF label Dec 25, 2024

github-actionsBot changed the title ~~Add centrality information to Xic0~~[PWGHF] Add centrality information to Xic0Dec 25, 2024

Tao-Fangand others added 7 commits December 25, 2024 20:48

Update treeCreatorToXiPi.cxx
bcb88d4

Update treeCreatorToXiPi.cxx
24b83de

Please consider the following formatting changes
c4b4a37

Merge pull request#1from alibuild/alibot-cleanup-9128
0421db5
Please consider the following formatting changes to #9128

Update whether to use centrality
127c897

Update treeCreatorToXiPi.cxx
dfd1f60

Update treeCreatorToXiPi.cxx
1fa7c23

fgrosa requested changes Jan 6, 2025
View reviewed changes

Comment threadPWGHF/TableProducer/treeCreatorToXiPi.cxx Outdated
Comment threadPWGHF/TableProducer/treeCreatorToXiPi.cxx Outdated
Comment threadPWGHF/TableProducer/treeCreatorToXiPi.cxx Outdated

Tao-Fang added 3 commits January 17, 2025 14:46

Update treeCreatorToXiPi.cxx
6e6b37d

Update treeCreatorToXiPi.cxx
79ba9eb

Update treeCreatorToXiPi.cxx
c7606b6

fgrosa requested changes Jan 19, 2025
View reviewed changes

Comment threadPWGHF/TableProducer/treeCreatorToXiPi.cxx Outdated
Comment threadPWGHF/TableProducer/treeCreatorToXiPi.cxx Outdated
Comment threadPWGHF/TableProducer/treeCreatorToXiPi.cxx Outdated

Update PWGHF/TableProducer/treeCreatorToXiPi.cxx
63830e4
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>

Tao-Fang requested a review from zhangbiao-phy as a code owner January 21, 2025 13:57

Update PWGHF/TableProducer/treeCreatorToXiPi.cxx
3c3d46a
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>

Tao-Fangand others added 2 commits January 21, 2025 21:58

Update PWGHF/TableProducer/treeCreatorToXiPi.cxx
6c19fef
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>

Update treeCreatorToXiPi.cxx
0fe7dbc

fgrosa previously approved these changes Jan 21, 2025
View reviewed changes

fgrosa enabled auto-merge (squash) January 21, 2025 18:32

ktf requested a review from fgrosa January 21, 2025 19:22

Update treeCreatorToXiPi.cxx of bulid
01951ed

auto-merge was automatically disabled January 23, 2025 11:58
Head branch was pushed to by a user without write access

Tao-Fang dismissed fgrosa’s stale review via 01951edJanuary 23, 2025 11:58

fgrosa approved these changes Jan 23, 2025
View reviewed changes

fgrosa enabled auto-merge (squash) January 23, 2025 14:41

fgrosa merged commit c674eb0 into AliceO2Group:masterJan 23, 2025

smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Feb 17, 2025
[PWGHF] Add centrality information to Xic0 (AliceO2Group#9128)
d6d7a1e
Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>

Navigation Menu

Uh oh!

[PWGHF] Add centrality information to Xic0 - #9128

[PWGHF] Add centrality information to Xic0#9128
fgrosa merged 16 commits into
AliceO2Group:masterfrom
Tao-Fang:master

Tao-Fang commented Dec 25, 2024

Uh oh!

fgrosa left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fgrosa left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alibuild commented Jan 21, 2025

Uh oh!

ktf commented Jan 21, 2025

Uh oh!

ktf commented Jan 22, 2025

Uh oh!

Tao-Fang commented Jan 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Tao-Fang commented Dec 25, 2024

Uh oh!

fgrosa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fgrosa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alibuild commented Jan 21, 2025

Uh oh!

ktf commented Jan 21, 2025

Uh oh!

ktf commented Jan 22, 2025

Uh oh!

Tao-Fang commented Jan 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants