Skip to content

[PWGHF] Added info for efficiency computation in PbPb for D+ - #9142

Merged
fgrosa merged 12 commits into
AliceO2Group:masterfrom
Marcellocosti:dpMLcentocc
Jan 6, 2025
Merged

[PWGHF] Added info for efficiency computation in PbPb for D+#9142
fgrosa merged 12 commits into
AliceO2Group:masterfrom
Marcellocosti:dpMLcentocc

Conversation

@Marcellocosti

@MarcellocostiMarcellocosti commented Dec 27, 2024

Copy link
Copy Markdown
Contributor

The following axes have been added to the existing THnSparses present in taskDplus.cxx:

  • collision centrality
  • occupancy
  • B mother pt (for nonprompt candidates)
  • B mother pdg (for nonprompt candidates)

Plus, a dedicated sparse histogram for the information on the generated D+ candidates is added.

@github-actionsgithub-actionsBot added the pwghf PWG-HF label Dec 27, 2024
@alibuildalibuild mentioned this pull request Dec 27, 2024
Merged
@alibuildalibuild mentioned this pull request Dec 27, 2024
Merged
@Marcellocosti
Merge pull request#4from alibuild/alibot-cleanup-9142
b8ccd33
Please consider the following formatting changes to AliceO2Group#9142
vkucera
vkucera reviewed Dec 27, 2024
View reviewed changes
Comment threadPWGHF/D2H/Tasks/taskDplus.cxx Outdated
vkucera
vkucera reviewed Dec 27, 2024
View reviewed changes
Comment threadPWGHF/D2H/Tasks/taskDplus.cxx
Comment threadPWGHF/D2H/Tasks/taskDplus.cxx
vkucera
vkucera reviewed Dec 30, 2024
View reviewed changes
Comment threadPWGHF/D2H/Tasks/taskDplus.cxx Outdated
vkucera
vkucera reviewed Dec 30, 2024
View reviewed changes
Comment threadPWGHF/D2H/Tasks/taskDplus.cxx Outdated
vkucera
vkucera reviewed Dec 30, 2024
View reviewed changes
Comment threadPWGHF/D2H/Tasks/taskDplus.cxx Outdated
vkucera
vkucera reviewed Dec 30, 2024
View reviewed changes
Comment threadPWGHF/D2H/Tasks/taskDplus.cxx Outdated
vkucera
vkucera reviewed Dec 30, 2024
View reviewed changes
Comment threadPWGHF/D2H/Tasks/taskDplus.cxx Outdated
vkucera
vkucera reviewed Dec 30, 2024
View reviewed changes
Comment threadPWGHF/D2H/Tasks/taskDplus.cxx Outdated
vkucera
vkucera reviewed Dec 30, 2024
View reviewed changes
Comment threadPWGHF/D2H/Tasks/taskDplus.cxx Outdated
@Marcellocosti

Marcellocosti commented Dec 30, 2024

Copy link
Copy Markdown
ContributorAuthor

Thank you @vkucera for the suggestions, I have however some curiosities for the future. Thank you in advance!

@alibuild

alibuild commented Dec 30, 2024

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for e9bddd3 at 2024-12-30 16:04:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9142-slc9_x86-64/0/PWGHF/D2H/Tasks/taskDplus.cxx:700:41: error: unused parameter 'mcRecoParticles' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/9142-slc9_x86-64/0/PWGHF/D2H/Tasks/taskDplus.cxx:710:53: error: unused parameter 'mcRecoParticles' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera reviewed Jan 2, 2025
View reviewed changes
Comment threadPWGHF/D2H/Tasks/taskDplus.cxx
@vkuceravkucera mentioned this pull request Jan 6, 2025
Merged
fgrosa
fgrosa approved these changes Jan 6, 2025
View reviewed changes

@fgrosafgrosa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, thanks a lot for the development @Marcellocosti!

@fgrosa
fgrosa merged commit bd446ab into AliceO2Group:masterJan 6, 2025
@Marcellocosti
Marcellocosti deleted the dpMLcentocc branch January 7, 2025 08:13
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Jan 11, 2025
@Marcellocosti@alibuildSabrina Hernandez
[PWGHF] Added info for efficiency computation in PbPb for D+ (AliceO2…
ae14a52
…Group#9142)
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Feb 17, 2025
@Marcellocosti@alibuild@smaff92
[PWGHF] Added info for efficiency computation in PbPb for D+ (AliceO2…
97ec838
…Group#9142)
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuceravkuceravkucera left review comments
@fgrosafgrosafgrosa approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner
@fcatalan92fcatalan92Awaiting requested review from fcatalan92fcatalan92 is a code owner
@mfagginmfagginAwaiting requested review from mfagginmfaggin is a code owner
@mmazzillimmazzilliAwaiting requested review from mmazzillimmazzilli is a code owner
@deepathomsdeepathomsAwaiting requested review from deepathomsdeepathoms is a code owner
@NicoleBastidNicoleBastidAwaiting requested review from NicoleBastidNicoleBastid is a code owner
@hahassan7hahassan7Awaiting requested review from hahassan7hahassan7 is a code owner
@jpxrkjpxrkAwaiting requested review from jpxrkjpxrk is a code owner
@apalascianoapalascianoAwaiting requested review from apalascianoapalasciano is a code owner

Assignees

No one assigned

Labels

pwghfPWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Marcellocosti@alibuild@fgrosa@vkucera