Skip to content

[PWGHF] KFParticle reconstruction of 3-prong decay - #9211

Merged
ddobrigk merged 31 commits into
AliceO2Group:masterfrom
lubynets:KF
Jan 21, 2025
Merged

[PWGHF] KFParticle reconstruction of 3-prong decay#9211
ddobrigk merged 31 commits into
AliceO2Group:masterfrom
lubynets:KF

Conversation

@lubynets

@lubynetslubynets commented Jan 7, 2025

Copy link
Copy Markdown
Contributor
  1. In this PR the usage of Kalman Filter Particle algorithm is implemented for 3-body decay reconstruction (by way of analogy with 2-body decay).
  2. A table with KF-specific variables (mainly topological) is added.
  3. Changes related to item 1 are introduced into selection and treeCreator tasks.

Oleksii Lubynetsand others added 19 commits January 7, 2025 21:53
Oleksii Lubynets@lubynets
reproduce KF functionality in 3 prong candidate creator
3a23570
Oleksii Lubynets@lubynets
KF for Lc selector; fix bugs of previous commit
ce3ad2e
Oleksii Lubynets@lubynets
add KF topological variables into a tree
8a39f66
Oleksii Lubynets@lubynets
cosmetics treeCreatorLcToPKPi.cxx
602b7f5
Oleksii Lubynets@lubynets
modify HFCAND3PKF table
48bbf70
Oleksii Lubynets@lubynets
adapt treeCreatorLcToPKPi to KF use
3ebd381
Oleksii Lubynets@lubynets
simplify fillTable[]() in treeCreatorLcToPKPi.cxx
60899af
Oleksii Lubynets@lubynets
add LdL field to treeCreatorLcToPKPi.cxx
5754d4f
Oleksii Lubynets@lubynets
add mc-match table to treeCreatorLcToPKPi.cxx
cc5939b
Oleksii Lubynets@lubynets
exclude swapped prongs candidates from mc-signal definition
92f2ac0
Oleksii Lubynets@lubynets
add MC info for residuals and pulls of p, pt, x, y, z
96cd16a
Oleksii Lubynets@lubynets
add MC L to treeCreatorLcToPKPi.cxx, use correct units for T
140703b
Oleksii Lubynets@lubynets
add processData for KF in treeCreatorLcToPKPi.cxx
6b6b6b0
Oleksii Lubynets@lubynets
add PV info (candidate-wise)
14e8b7b
Oleksii Lubynets@lubynets
save usual tree in case of KF as well
c4b6660
Oleksii Lubynets@lubynets
save usual tree in case of KF as well in case of data; bugfix: calcul…
7bcb893
…ate PV's uncertainty properly
@lubynets
add bitmapProngsContributorsPV in KF-related parts of code
e000ea6
@lubynets
rename variables according to conventions
a1b0d1c
@lubynets
apply clang format
784ecbc
vkucera
vkucera reviewed Jan 16, 2025
View reviewed changes
Comment threadPWGHF/TableProducer/treeCreatorLcToPKPi.cxx Outdated
vkucera
vkucera reviewed Jan 16, 2025
View reviewed changes
Comment threadPWGHF/TableProducer/treeCreatorLcToPKPi.cxx Outdated
vkucera
vkucera reviewed Jan 16, 2025
View reviewed changes
Comment threadPWGHF/TableProducer/treeCreatorLcToPKPi.cxx Outdated
vkucera
vkucera reviewed Jan 16, 2025
View reviewed changes
Comment threadPWGHF/DataModel/CandidateReconstructionTables.h Outdated
vkucera
vkucera reviewed Jan 16, 2025
View reviewed changes
Comment threadPWGHF/DataModel/CandidateReconstructionTables.h Outdated
@lubynets

lubynets commented Jan 16, 2025

Copy link
Copy Markdown
ContributorAuthor

@lubynets Please fix the MegaLinter errors.

Done

vkucera
vkucera reviewed Jan 17, 2025
View reviewed changes
Comment threadPWGHF/TableProducer/candidateSelectorLc.cxx Outdated
vkucera
vkucera reviewed Jan 17, 2025
View reviewed changes
Comment threadPWGHF/TableProducer/candidateSelectorLc.cxx Outdated
vkucera
vkucera reviewed Jan 17, 2025
View reviewed changes
Comment threadPWGHF/TableProducer/treeCreatorLcToPKPi.cxx Outdated
vkucera
vkucera reviewed Jan 17, 2025
View reviewed changes
Comment threadPWGHF/TableProducer/treeCreatorLcToPKPi.cxx Outdated
vkucera
vkucera reviewed Jan 17, 2025
View reviewed changes
Comment threadPWGHF/TableProducer/treeCreatorLcToPKPi.cxx Outdated
vkucera
vkucera reviewed Jan 17, 2025
View reviewed changes
Comment threadPWGHF/TableProducer/treeCreatorLcToPKPi.cxx Outdated
vkucera
vkucera reviewed Jan 17, 2025
View reviewed changes
Comment threadPWGHF/TableProducer/treeCreatorLcToPKPi.cxx Outdated
@alibuildalibuild mentioned this pull request Jan 17, 2025
Merged
@lubynets
Merge pull request#4from alibuild/alibot-cleanup-9211
ce1a182
Please consider the following formatting changes to AliceO2Group#9211
@vkucera

vkucera commented Jan 17, 2025

Copy link
Copy Markdown
Collaborator

@lubynets Thanks for addressing my comments.
Not strictly required for this PR, but there is a lot of duplication between fillTablesData and fillTablesMc. It would be worth exploring the possibility to reduce it with refactoring that code.

@fgrosa

fgrosa commented Jan 19, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

@lubynets Thanks for addressing my comments. Not strictly required for this PR, but there is a lot of duplication between fillTablesData and fillTablesMc. It would be worth exploring the possibility to reduce it with refactoring that code.

I agree on this, but I also agree that it can be done in a second PR (@lubynets please consider it) in order to move on with this one. I cannot merge however because the utils header was included in Tools, for which I have no approval rights (maybe @ktf can merge? Thanks!)

@fgrosa
fgrosa enabled auto-merge (squash) January 19, 2025 15:14
@fgrosa
fgrosa disabled auto-merge January 19, 2025 17:28
@ddobrigk
ddobrigk merged commit 3a0382b into AliceO2Group:masterJan 21, 2025
@lubynets
lubynets deleted the KF branch January 28, 2025 09:52
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Feb 17, 2025
@lubynetsOleksii Lubynets
Oleksii LubynetsOleksii LubynetsOleksii Lubynets@fgrosa@alibuild@smaff92
[PWGHF] KFParticle reconstruction of 3-prong decay (AliceO2Group#9211)
8f8f5c8
Co-authored-by: Oleksii Lubynets <lubynets@lxbk0552.gsi.de>
Co-authored-by: Oleksii Lubynets <lubynets@lxbk1130.gsi.de>
Co-authored-by: Oleksii Lubynets <lubynets@lxbuild07.gsi.de>
Co-authored-by: Oleksii Lubynets <lubynets@lxbk1131.gsi.de>
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
@lubynetslubynets mentioned this pull request Dec 28, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuceravkuceravkucera left review comments
@fgrosafgrosafgrosa approved these changes
@ddobrigkddobrigkddobrigk approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner
@fcatalan92fcatalan92Awaiting requested review from fcatalan92fcatalan92 is a code owner
@mfagginmfagginAwaiting requested review from mfagginmfaggin is a code owner
@mmazzillimmazzilliAwaiting requested review from mmazzillimmazzilli is a code owner
@deepathomsdeepathomsAwaiting requested review from deepathomsdeepathoms is a code owner
@NicoleBastidNicoleBastidAwaiting requested review from NicoleBastidNicoleBastid is a code owner
@hahassan7hahassan7Awaiting requested review from hahassan7hahassan7 is a code owner
@jpxrkjpxrkAwaiting requested review from jpxrkjpxrk is a code owner
@apalascianoapalascianoAwaiting requested review from apalascianoapalasciano is a code owner
@jgrosseojgrosseoAwaiting requested review from jgrosseojgrosseo is a code owner
@iarseneiarseneAwaiting requested review from iarseneiarsene is a code owner
@ktfktfAwaiting requested review from ktfktf is a code owner

Assignees

No one assigned

Labels

datamodelpwghfPWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lubynets@vkucera@fgrosa@ddobrigk@alibuild