Uh oh!
There was an error while loading. Please reload this page.
[pull] master from bitcoin:master - #1829
Merged
Merged
Conversation
Noted in the last iwyu PR: #35900 (review)
It is base58, so shouldn't be qualified with STR_HEX. Similarly, signmessagewithprivkey also declares the argument as a STR. This fix is motivated by the OpenRPC dump, where fields tagged with STR_HEX are described with a restricting regex that would make its correct usage a violation against the unpatched schema.
This seems to be the only place where a STR_AMOUNT is used for a sats denominated fee amount. Many other places use the raw NUM type for a fee amount, for example getblockstats and getblocktemplate. This doesn't change the actual result of the RPC call. The change is motivated by OpenRPC, where the field was previously given a 'x-bitcoin-unit' tag. This usually describes a decimal amount, and may be confusing for consumers applying this tag.
78e691e rpc: Change listunspent's ancestorfees type to NUM (sedited) 73fb9ce rpc: Fix private key type in signrawtransactionwithkey (sedited) Pull request description: This corrects the types for two fields in the OpenRPC dump. Both changes have no effect on the rpc help output. The changes to the schema's format are: ```diff diff dump.json dump_new.json 11452d11451 < "x-bitcoin-unit": "amount", 13844,13845c13843 < "type": "string", < "pattern": "^[0-9a-fA-F]+$" --- > "type": "string" ``` I asked Claude to flag any inconsistencies in the dump and these were the two, out of many others, that I thought were worthwhile to fix. ACKs for top commit: maflcko: lgtm ACK 78e691e stickies-v: ACK 78e691e musaHaruna: Tested ACK [78e691e](78e691e) Tree-SHA512: 121d80520a39738c1c7375a50bb552203fe2db403cb3414195e6a79142677ac3c3509ba5f18d4b1982a8e2872c73e47cf6e54b6acd66b1a71ddcbe335ea33f34
…ing clocks 55390d1 doc: Correct comment about which subsystem detects lagging clocks (Hodlinator) Pull request description: Turns out a completely fresh datadir means there is no chain state to load and hence no detection of a lagging clock occurs in that subsystem. Instead we do proceed into attempting to start a headers sync. <details><summary>Diff to repro with fresh -datadir</summary> ```diff --- a/src/init.cpp +++ b/src/init.cpp @@ -1499,6 +1499,8 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info) const ArgsManager& args = *Assert(node.args); const CChainParams& chainparams = Params(); + SetMockTime(chainparams.GenesisBlock().Time() - 3h); + auto opt_max_upload = ParseByteUnits(args.GetArg("-maxuploadtarget", DEFAULT_MAX_UPLOAD_TARGET), ByteUnit::M); if (!opt_max_upload) { return InitError(strprintf(_("Unable to parse -maxuploadtarget: '%s'"), args.GetArg("-maxuploadtarget", ""))); ``` </details> Follow-up to #35351 ACKs for top commit: sedited: ACK 55390d1 jonatack: ACK 55390d1 Tree-SHA512: 244a0cb634a0ba67fa88fe83f73111e475f6fff258cd1783b9b0a39669eefdd3b2e739a0b761616972bc938216336e18b0c0322e1201c2e805767cb813ca616c
fa7be0a test: refactor: Remove confusing ignore_errors=True (MarcoFalke) Pull request description: There is an unexplained `ignore_errors=True` in the internal `_initialize_chain` helper: ```py shutil.rmtree(cache_path('fees'), ignore_errors=True) ``` This is fine, because no error should happen. But it is a bit confusing, because an ignored error may lead to a later error anyway. Fix that by failing early instead. Also, re-write the simple block to `pathlib`. ACKs for top commit: willcl-ark: ACK fa7be0a Tree-SHA512: c533a8aebd92f3f1054563f20af438165632c98f7a2f189f3306420780468b143c24001f794a79ddfc0527c9605a4cfe59949648a9a7f41bbe138128b09f0a6e
fa39710 ci: Exclude subtrees from iwyu (MarcoFalke) fa85661 refactor: Bump old copyright header in univalue (MarcoFalke) Pull request description: The iwyu CI may modify subtrees when iwyu thinks a header inside a subtree is "associated" (due to the naming). This happens to not be a problem on current master, but can become a problem if an iwyu-enforced file is renamed or a file is iwyu-enforced in the future. Fix this by excluding subtrees. Can be tested by running the iwyu CI on `src/test/fuzz/minisketch.cpp` and seeing a change in `minisketch.h` before this CI fix. ACKs for top commit: hebasto: re-ACK fa39710. Tree-SHA512: 9a555ab020f0f1a2bc4d70ea72011f8d42ba4bfe4a463947d31b0d208b4671b76b466f92a18b6295bc7a8c5bb67c6f697844f673fc02e18983b062d25bc0dc8c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )