Uh oh!
There was an error while loading. Please reload this page.
[pull] master from bitcoin:master - #1830
Merged
Merged
Conversation
Clear ConnmanTestMsg state at the start of each input in cmpctblock and p2p_handshake so sticky CConnman state does not leak between fuzz inputs.
d29b22d fuzz: reset connman state in p2p targets (Hao Xu) Pull request description: Resets `ConnmanTestMsg` at the start of each input in `cmpctblock` and `p2p_handshake`, matching the other reused-connman fuzz targets and preventing sticky `CConnman` state from leaking between corpus inputs. Before this, deterministic-fuzz-coverage showed single inputs were stable, but all-input directory runs were not: ```diff cmpctblock, src/net.cpp:4172 - Branch (4172:9): [True: 1.21k, False: 33.0k] + Branch (4172:9): [True: 613, False: 33.6k] - Branch (4172:72): [True: 901, False: 311] + Branch (4172:72): [True: 497, False: 116] ``` ```diff p2p_handshake, src/net.cpp:4172 - Branch (4172:9): [True: 98, False: 1.67k] + Branch (4172:9): [True: 743, False: 1.03k] - Branch (4172:72): [True: 90, False: 8] + Branch (4172:72): [True: 612, False: 131] ``` With the resets, `deterministic-fuzz-coverage` passed for both `cmpctblock` and `p2p_handshake`. ACKs for top commit: nervana21: re-tACK d29b22d maflcko: lgtm ACK d29b22d Tree-SHA512: bd445ae33ab7f9850046e3de4e318bee9ae7b38ee77ee282d0f5c3a88a4b67610dd00faef2af913a4d7d42bfc42b957855b2d85f1849f77823149baa089afce2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )