Uh oh!
There was an error while loading. Please reload this page.
fix: [AI-211] normalize Installation.VERSION and fix branding leaks - #213
Merged
Conversation
…des and fix branding leaks - Strip "v" prefix from `OPENCODE_VERSION` at the source so `Installation.VERSION` always matches `latest()` output (e.g. "0.4.1", never "v0.4.1") - Add `.trim()` for defensive hardening against stray whitespace from CI - Fix user-facing "opencode" references → "altimate" in upgrade toast, auth errors, provider messages, terminal-auth capability, and CLI descriptions - Remove redundant `.replace(/^v/, "")` in `welcome.ts` (VERSION is now pre-normalized) - Add 25 new tests for version normalization, upgrade comparison, and branding regression Closes#211 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Claude Code ReviewThis repository is configured for manual code reviews. Comment |
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
…tions Wraps all changes in altimate_change start/end markers so the upstream merge script preserves them when pulling from anomalyco/opencode. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes version display and upgrade issues reported in #211:
Version normalization: CI sets
OPENCODE_VERSIONfrom the git tag (e.g.v0.4.1), butInstallation.latest()returns clean semver (0.4.1). The string comparisonVERSION === targetalways failed, causing the upgrade command to "upgrade" to the same version. Fix: strip "v" prefix and trim whitespace at theVERSIONdefinition site.Branding fixes: User-facing strings in upgrade toast, auth errors, provider messages, terminal-auth capability, and CLI descriptions still referenced "opencode" instead of "altimate".
Cleanup: Removed redundant
.replace(/^v/, "")inwelcome.tssince VERSION is now pre-normalized.Type of change
Issue for this PR
Closes#211
How did you verify your code works?
Checklist
🤖 Generated with Claude Code