Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 134
feat: simplify to 3 modes (builder/analyst/plan) + SQL write access control#282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -17,11 +17,6 @@ import PROMPT_TITLE from "./prompt/title.txt" | ||
| // altimate_change start - import custom agent mode prompts | ||
| import PROMPT_BUILDER from "../altimate/prompts/builder.txt" | ||
| import PROMPT_ANALYST from "../altimate/prompts/analyst.txt" | ||
| import PROMPT_VALIDATOR from "../altimate/prompts/validator.txt" | ||
| import PROMPT_MIGRATOR from "../altimate/prompts/migrator.txt" | ||
| import PROMPT_EXECUTIVE from "../altimate/prompts/executive.txt" | ||
| import PROMPT_RESEARCHER from "../altimate/prompts/researcher.txt" | ||
| import PROMPT_TRAINER from "../altimate/prompts/trainer.txt" | ||
| // altimate_change end | ||
| import { PermissionNext } from "@/permission/next" | ||
| import { mergeDeep, pipe, sortBy, values } from "remeda" | ||
| @@ -126,13 +121,26 @@ export namespace Agent { | ||
| "Drop Schema *": "deny", | ||
| "Truncate *": "deny", | ||
| }, | ||
| // altimate_change start - SQL write safety denials | ||
| sql_execute_write: { | ||
| "DROP DATABASE *": "deny", | ||
| "DROP SCHEMA *": "deny", | ||
| "TRUNCATE *": "deny", | ||
| "drop database *": "deny", | ||
| "drop schema *": "deny", | ||
| "truncate *": "deny", | ||
| "Drop Database *": "deny", | ||
| "Drop Schema *": "deny", | ||
| "Truncate *": "deny", | ||
| }, | ||
| // altimate_change end | ||
| }) | ||
| // Combine user config with safety denials so every agent inherits them | ||
| const userWithSafety = PermissionNext.merge(user, safetyDenials) | ||
| const result: Record<string, Info> = { | ||
| // altimate_change start - replace default build agent with builder and add custom modes | ||
| // altimate_change start - 3 modes: builder, analyst, plan | ||
| builder: { | ||
| name: "builder", | ||
| description: "Create and modify dbt models, SQL, and data pipelines. Full read/write access.", | ||
| @@ -143,6 +151,7 @@ export namespace Agent { | ||
| PermissionNext.fromConfig({ | ||
| question: "allow", | ||
| plan_enter: "allow", | ||
| sql_execute_write: "ask", | ||
| }), | ||
| userWithSafety, | ||
| ), | ||
| @@ -151,178 +160,45 @@ export namespace Agent { | ||
| }, | ||
| analyst: { | ||
| name: "analyst", | ||
| description: "Read-only data exploration. Cannot modify files or run destructive SQL.", | ||
| description: "Read-only data exploration and analysis. Cannot modify files or run destructive SQL.", | ||
| prompt: PROMPT_ANALYST, | ||
| options: {}, | ||
| permission: PermissionNext.merge( | ||
| defaults, | ||
| PermissionNext.fromConfig({ | ||
| "*": "deny", | ||
| // SQL read tools | ||
| sql_execute: "allow", sql_validate: "allow", sql_analyze: "allow", | ||
| sql_translate: "allow", sql_optimize: "allow", lineage_check: "allow", | ||
| sql_explain: "allow", sql_format: "allow", sql_fix: "allow", | ||
| sql_autocomplete: "allow", sql_diff: "allow", | ||
| // SQL writes denied | ||
| sql_execute_write: "deny", | ||
| // Warehouse/schema/finops | ||
| warehouse_list: "allow", warehouse_test: "allow", warehouse_discover: "allow", | ||
| schema_inspect: "allow", schema_index: "allow", schema_search: "allow", | ||
| schema_cache_status: "allow", sql_explain: "allow", sql_format: "allow", | ||
| sql_fix: "allow", sql_autocomplete: "allow", sql_diff: "allow", | ||
| schema_cache_status: "allow", schema_detect_pii: "allow", | ||
| schema_tags: "allow", schema_tags_list: "allow", | ||
| finops_query_history: "allow", finops_analyze_credits: "allow", | ||
| finops_expensive_queries: "allow", finops_warehouse_advice: "allow", | ||
| finops_unused_resources: "allow", finops_role_grants: "allow", | ||
| finops_role_hierarchy: "allow", finops_user_roles: "allow", | ||
| schema_detect_pii: "allow", schema_tags: "allow", schema_tags_list: "allow", | ||
| // Core tools | ||
| altimate_core_validate: "allow", altimate_core_check: "allow", | ||
| altimate_core_rewrite: "allow", | ||
| tool_lookup: "allow", | ||
| // Read-only file access | ||
| read: "allow", grep: "allow", glob: "allow", | ||
| question: "allow", webfetch: "allow", websearch: "allow", | ||
| training_save: "allow", training_list: "allow", training_remove: "allow", | ||
| }), | ||
| userWithSafety, | ||
| ), | ||
| mode: "primary", | ||
| native: true, | ||
| }, | ||
| executive: { | ||
| name: "executive", | ||
| description: "Read-only data exploration with output calibrated for non-technical executives. No SQL or jargon — findings expressed as business impact.", | ||
| prompt: PROMPT_EXECUTIVE, | ||
| options: { audience: "executive" }, | ||
| permission: PermissionNext.merge( | ||
| defaults, | ||
| PermissionNext.fromConfig({ | ||
| "*": "deny", | ||
| sql_execute: "allow", sql_validate: "allow", sql_analyze: "allow", | ||
| sql_translate: "allow", sql_optimize: "allow", lineage_check: "allow", | ||
| warehouse_list: "allow", warehouse_test: "allow", warehouse_discover: "allow", | ||
| schema_inspect: "allow", schema_index: "allow", schema_search: "allow", | ||
| schema_cache_status: "allow", sql_explain: "allow", sql_format: "allow", | ||
| sql_fix: "allow", sql_autocomplete: "allow", sql_diff: "allow", | ||
| finops_query_history: "allow", finops_analyze_credits: "allow", | ||
| finops_expensive_queries: "allow", finops_warehouse_advice: "allow", | ||
| finops_unused_resources: "allow", finops_role_grants: "allow", | ||
| finops_role_hierarchy: "allow", finops_user_roles: "allow", | ||
| schema_detect_pii: "allow", schema_tags: "allow", schema_tags_list: "allow", | ||
| altimate_core_validate: "allow", altimate_core_check: "allow", | ||
| altimate_core_rewrite: "allow", | ||
| tool_lookup: "allow", | ||
| read: "allow", grep: "allow", glob: "allow", | ||
| question: "allow", webfetch: "allow", websearch: "allow", | ||
| training_save: "allow", training_list: "allow", training_remove: "allow", | ||
| }), | ||
| userWithSafety, | ||
| ), | ||
| mode: "primary", | ||
| native: true, | ||
| }, | ||
| validator: { | ||
| name: "validator", | ||
| description: "Test, lint, and verify data integrity. Cannot modify files.", | ||
| prompt: PROMPT_VALIDATOR, | ||
| options: {}, | ||
| permission: PermissionNext.merge( | ||
| defaults, | ||
| PermissionNext.fromConfig({ | ||
| "*": "deny", | ||
| sql_validate: "allow", sql_execute: "allow", sql_analyze: "allow", | ||
| sql_translate: "allow", sql_optimize: "allow", lineage_check: "allow", | ||
| warehouse_list: "allow", warehouse_test: "allow", warehouse_discover: "allow", | ||
| schema_inspect: "allow", schema_index: "allow", schema_search: "allow", | ||
| schema_cache_status: "allow", sql_explain: "allow", sql_format: "allow", | ||
| sql_fix: "allow", sql_autocomplete: "allow", sql_diff: "allow", | ||
| finops_query_history: "allow", finops_analyze_credits: "allow", | ||
| finops_expensive_queries: "allow", finops_warehouse_advice: "allow", | ||
| finops_unused_resources: "allow", finops_role_grants: "allow", | ||
| finops_role_hierarchy: "allow", finops_user_roles: "allow", | ||
| schema_detect_pii: "allow", schema_tags: "allow", schema_tags_list: "allow", | ||
| altimate_core_validate: "allow", altimate_core_check: "allow", | ||
| altimate_core_rewrite: "allow", | ||
| tool_lookup: "allow", | ||
| read: "allow", grep: "allow", glob: "allow", bash: "allow", | ||
| question: "allow", | ||
| training_save: "allow", training_list: "allow", training_remove: "allow", | ||
| }), | ||
| userWithSafety, | ||
| ), | ||
| mode: "primary", | ||
| native: true, | ||
| }, | ||
| migrator: { | ||
| name: "migrator", | ||
| description: "Cross-warehouse SQL migration and dialect conversion.", | ||
| prompt: PROMPT_MIGRATOR, | ||
| options: {}, | ||
| permission: PermissionNext.merge( | ||
| defaults, | ||
| PermissionNext.fromConfig({ | ||
| sql_execute: "allow", sql_validate: "allow", sql_translate: "allow", | ||
| sql_optimize: "allow", lineage_check: "allow", | ||
| warehouse_list: "allow", warehouse_test: "allow", | ||
| schema_inspect: "allow", schema_index: "allow", schema_search: "allow", | ||
| schema_cache_status: "allow", sql_explain: "allow", sql_format: "allow", | ||
| sql_fix: "allow", sql_autocomplete: "allow", sql_diff: "allow", | ||
| finops_query_history: "allow", finops_analyze_credits: "allow", | ||
| finops_expensive_queries: "allow", finops_warehouse_advice: "allow", | ||
| finops_unused_resources: "allow", finops_role_grants: "allow", | ||
| finops_role_hierarchy: "allow", finops_user_roles: "allow", | ||
| schema_detect_pii: "allow", schema_tags: "allow", schema_tags_list: "allow", | ||
| altimate_core_validate: "allow", altimate_core_check: "allow", | ||
| altimate_core_rewrite: "allow", | ||
| tool_lookup: "allow", | ||
| read: "allow", write: "allow", edit: "allow", | ||
| grep: "allow", glob: "allow", question: "allow", | ||
| training_save: "allow", training_list: "allow", training_remove: "allow", | ||
| }), | ||
| userWithSafety, | ||
| ), | ||
| mode: "primary", | ||
| native: true, | ||
| }, | ||
| researcher: { | ||
| name: "researcher", | ||
| description: "Deep research mode. Thorough multi-step investigation with structured reports. Use for complex analytical questions.", | ||
| prompt: PROMPT_RESEARCHER, | ||
| options: {}, | ||
| permission: PermissionNext.merge( | ||
| defaults, | ||
| PermissionNext.fromConfig({ | ||
| "*": "deny", | ||
| sql_execute: "allow", sql_validate: "allow", sql_analyze: "allow", | ||
| sql_translate: "allow", sql_optimize: "allow", lineage_check: "allow", | ||
| warehouse_list: "allow", warehouse_test: "allow", warehouse_discover: "allow", | ||
| schema_inspect: "allow", schema_index: "allow", schema_search: "allow", | ||
| schema_cache_status: "allow", sql_explain: "allow", sql_format: "allow", | ||
| sql_fix: "allow", sql_autocomplete: "allow", sql_diff: "allow", | ||
| finops_query_history: "allow", finops_analyze_credits: "allow", | ||
| finops_expensive_queries: "allow", finops_warehouse_advice: "allow", | ||
| finops_unused_resources: "allow", finops_role_grants: "allow", | ||
| finops_role_hierarchy: "allow", finops_user_roles: "allow", | ||
| schema_detect_pii: "allow", schema_tags: "allow", schema_tags_list: "allow", | ||
| altimate_core_validate: "allow", altimate_core_check: "allow", | ||
| altimate_core_rewrite: "allow", | ||
| tool_lookup: "allow", | ||
| read: "allow", grep: "allow", glob: "allow", bash: "allow", | ||
| question: "allow", webfetch: "allow", websearch: "allow", | ||
| task: "allow", training_save: "allow", training_list: "allow", training_remove: "allow", | ||
| }), | ||
| userWithSafety, | ||
| ), | ||
| mode: "primary", | ||
| native: true, | ||
| }, | ||
| trainer: { | ||
| name: "trainer", | ||
| description: "Teach your AI teammate. Scan for patterns, validate training against code, curate knowledge. Read-only.", | ||
| prompt: PROMPT_TRAINER, | ||
| options: {}, | ||
| permission: PermissionNext.merge( | ||
| defaults, | ||
| PermissionNext.fromConfig({ | ||
| "*": "deny", | ||
| read: "allow", grep: "allow", glob: "allow", bash: "allow", | ||
| question: "allow", | ||
| webfetch: "allow", websearch: "allow", | ||
| question: "allow", tool_lookup: "allow", | ||
| // Bash: last-match-wins — "*": "deny" MUST come first, then specific allows override | ||
| bash: { | ||
| "*": "deny", | ||
| "ls *": "allow", "grep *": "allow", "cat *": "allow", | ||
| "head *": "allow", "tail *": "allow", "find *": "allow", "wc *": "allow", | ||
| "dbt list *": "allow", "dbt ls *": "allow", "dbt debug *": "allow", | ||
| }, | ||
coderabbitai[bot] marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| // Training | ||
| training_save: "allow", training_list: "allow", training_remove: "allow", | ||
| schema_inspect: "allow", schema_index: "allow", schema_search: "allow", | ||
| schema_cache_status: "allow", | ||
| warehouse_list: "allow", warehouse_discover: "allow", | ||
| }), | ||
| userWithSafety, | ||
| ), | ||
| @@ -469,7 +345,8 @@ export namespace Agent { | ||
| item.name = value.name ?? item.name | ||
| item.steps = value.steps ?? item.steps | ||
| item.options = mergeDeep(item.options, value.options ?? {}) | ||
| item.permission = PermissionNext.merge(item.permission, PermissionNext.fromConfig(value.permission ?? {})) | ||
| // Re-apply safety denials AFTER user config so they cannot be overridden | ||
| item.permission = PermissionNext.merge(item.permission, PermissionNext.fromConfig(value.permission ?? {}), safetyDenials) | ||
| } | ||
| // Ensure Truncate.GLOB is allowed unless explicitly configured | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.