Send chat prompt message to lsp by angjordn · Pull Request #26 · Amazon-Q-Developer/amazon-q-eclipse

angjordn · 2024-09-18T21:39:53Z

Description:

Add handler for aws/chat/sendChatPrompt message
Intentionally does not handle the Response (currently just logging)

Demo of UI to Logged response

Log_response.mov

breedloj · 2024-09-18T22:40:18Z

+ e.printStackTrace();
+ }
+ return null;


Instead of swallowing the exception let's wrap the original with an AmazonQPluginException and throw it back to the caller. In that case it should probably be the top level webview command execution logic that catches any error occurring during the processing of one of the commands. That could then log + potentially display an error to the user in the view (this part can come later).

Good idea! Didn't realize there was an AmazonQPluginException. Added to the other LSP send functions also.

breedloj · 2024-09-18T22:47:25Z

+ void tabAdd(GenericTabParams params);
+
+ @JsonNotification("aws/chat/ready")
+ void chatReady();


Did it not work when annotated as a JsonRequest with a void response type (CompletableFuture<Void>)? Maybe this makes more sense as an explicit fire & forget non blocking type though.

Yeah the LSP server did not recognize the request when it was annotated as a JsonRequest. The server is explicitly expecting a Notification. Surprisingly, most of the LSP features are Notifications rather than requests as specified in their doc (https://github.com/aws/language-server-runtimes/tree/main/runtimes#feature-specification-4)

Cool, thanks for the info. That makes sense.

…sp communication errors

angjordn

Made the requested updates

breedloj · 2024-09-19T20:10:49Z

 PluginLogger.error("Unhandled chat command: " + command.toString());
 }
+ return null;


Avoid the null return by explicitly raising a PluginException here. This is a specific internal failure that should not be squelched.

angjordn

Throw AmazonQPlugiinException for missing commands and fix checkstyle errors

angjordn · 2024-09-19T21:17:37Z

+return null;
 default:
-PluginLogger.error("Unhandled chat command: " + command.toString());
+throw new AmazonQPluginException("Unhandled command in ChatCommunicationManager: " + command.toString());


@breedloj Throwing the PluginException as you mentioned. You also mentioned throwing the exception to avoid returning null - I moved the return null statements to the associated cases to be more explicit about which cases null is being returned on.

angjordn · 2024-09-19T21:20:33Z

 default:
- PluginLogger.info("Unhandled command: " + parsedCommand.getCommand());
- break;
+ throw new AmazonQPluginException("Unhandled command in AmazonQChatViewActionHandler: " + command.toString());


@breedloj Also updated the ActionHandler to a PluginException to match the unhandled command case in ChatCommunicationManager

angjordn · 2024-09-18T21:39:53Z

Description:

Add handler for aws/chat/sendChatPrompt message
Intentionally does not handle the Response (currently just logging)

Demo of UI to Logged response

Log_response.mov

breedloj · 2024-09-18T22:40:18Z

+ e.printStackTrace();
+ }
+ return null;


Instead of swallowing the exception let's wrap the original with an AmazonQPluginException and throw it back to the caller. In that case it should probably be the top level webview command execution logic that catches any error occurring during the processing of one of the commands. That could then log + potentially display an error to the user in the view (this part can come later).

Good idea! Didn't realize there was an AmazonQPluginException. Added to the other LSP send functions also.

breedloj · 2024-09-18T22:47:25Z

+ void tabAdd(GenericTabParams params);
+
+ @JsonNotification("aws/chat/ready")
+ void chatReady();


Did it not work when annotated as a JsonRequest with a void response type (CompletableFuture<Void>)? Maybe this makes more sense as an explicit fire & forget non blocking type though.

Yeah the LSP server did not recognize the request when it was annotated as a JsonRequest. The server is explicitly expecting a Notification. Surprisingly, most of the LSP features are Notifications rather than requests as specified in their doc (https://github.com/aws/language-server-runtimes/tree/main/runtimes#feature-specification-4)

Cool, thanks for the info. That makes sense.

…sp communication errors

angjordn

Made the requested updates

breedloj · 2024-09-19T20:10:49Z

 PluginLogger.error("Unhandled chat command: " + command.toString());
 }
+ return null;


Avoid the null return by explicitly raising a PluginException here. This is a specific internal failure that should not be squelched.

angjordn

Throw AmazonQPlugiinException for missing commands and fix checkstyle errors

angjordn · 2024-09-19T21:17:37Z

+return null;
 default:
-PluginLogger.error("Unhandled chat command: " + command.toString());
+throw new AmazonQPluginException("Unhandled command in ChatCommunicationManager: " + command.toString());


@breedloj Throwing the PluginException as you mentioned. You also mentioned throwing the exception to avoid returning null - I moved the return null statements to the associated cases to be more explicit about which cases null is being returned on.

angjordn · 2024-09-19T21:20:33Z

 default:
- PluginLogger.info("Unhandled command: " + parsedCommand.getCommand());
- break;
+ throw new AmazonQPluginException("Unhandled command in AmazonQChatViewActionHandler: " + command.toString());


@breedloj Also updated the ActionHandler to a PluginException to match the unhandled command case in ChatCommunicationManager

angjordn · 2024-09-18T21:39:53Z

Description:

Add handler for aws/chat/sendChatPrompt message
Intentionally does not handle the Response (currently just logging)

Demo of UI to Logged response

Log_response.mov

breedloj · 2024-09-18T22:40:18Z

+ e.printStackTrace();
+ }
+ return null;


Instead of swallowing the exception let's wrap the original with an AmazonQPluginException and throw it back to the caller. In that case it should probably be the top level webview command execution logic that catches any error occurring during the processing of one of the commands. That could then log + potentially display an error to the user in the view (this part can come later).

Good idea! Didn't realize there was an AmazonQPluginException. Added to the other LSP send functions also.

breedloj · 2024-09-18T22:47:25Z

+ void tabAdd(GenericTabParams params);
+
+ @JsonNotification("aws/chat/ready")
+ void chatReady();


Did it not work when annotated as a JsonRequest with a void response type (CompletableFuture<Void>)? Maybe this makes more sense as an explicit fire & forget non blocking type though.

Yeah the LSP server did not recognize the request when it was annotated as a JsonRequest. The server is explicitly expecting a Notification. Surprisingly, most of the LSP features are Notifications rather than requests as specified in their doc (https://github.com/aws/language-server-runtimes/tree/main/runtimes#feature-specification-4)

Cool, thanks for the info. That makes sense.

…sp communication errors

angjordn

Made the requested updates

breedloj · 2024-09-19T20:10:49Z

 PluginLogger.error("Unhandled chat command: " + command.toString());
 }
+ return null;


Avoid the null return by explicitly raising a PluginException here. This is a specific internal failure that should not be squelched.

angjordn

Throw AmazonQPlugiinException for missing commands and fix checkstyle errors

angjordn · 2024-09-19T21:17:37Z

+return null;
 default:
-PluginLogger.error("Unhandled chat command: " + command.toString());
+throw new AmazonQPluginException("Unhandled command in ChatCommunicationManager: " + command.toString());


@breedloj Throwing the PluginException as you mentioned. You also mentioned throwing the exception to avoid returning null - I moved the return null statements to the associated cases to be more explicit about which cases null is being returned on.

angjordn · 2024-09-19T21:20:33Z

 default:
- PluginLogger.info("Unhandled command: " + parsedCommand.getCommand());
- break;
+ throw new AmazonQPluginException("Unhandled command in AmazonQChatViewActionHandler: " + command.toString());


@breedloj Also updated the ActionHandler to a PluginException to match the unhandled command case in ChatCommunicationManager

angjordn · 2024-09-18T21:39:53Z

Description:

Add handler for aws/chat/sendChatPrompt message
Intentionally does not handle the Response (currently just logging)

Demo of UI to Logged response

Log_response.mov

breedloj · 2024-09-18T22:40:18Z

+ e.printStackTrace();
+ }
+ return null;


Instead of swallowing the exception let's wrap the original with an AmazonQPluginException and throw it back to the caller. In that case it should probably be the top level webview command execution logic that catches any error occurring during the processing of one of the commands. That could then log + potentially display an error to the user in the view (this part can come later).

Good idea! Didn't realize there was an AmazonQPluginException. Added to the other LSP send functions also.

breedloj · 2024-09-18T22:47:25Z

+ void tabAdd(GenericTabParams params);
+
+ @JsonNotification("aws/chat/ready")
+ void chatReady();


Did it not work when annotated as a JsonRequest with a void response type (CompletableFuture<Void>)? Maybe this makes more sense as an explicit fire & forget non blocking type though.

Yeah the LSP server did not recognize the request when it was annotated as a JsonRequest. The server is explicitly expecting a Notification. Surprisingly, most of the LSP features are Notifications rather than requests as specified in their doc (https://github.com/aws/language-server-runtimes/tree/main/runtimes#feature-specification-4)

Cool, thanks for the info. That makes sense.

…sp communication errors

angjordn

Made the requested updates

breedloj · 2024-09-19T20:10:49Z

 PluginLogger.error("Unhandled chat command: " + command.toString());
 }
+ return null;


Avoid the null return by explicitly raising a PluginException here. This is a specific internal failure that should not be squelched.

angjordn

Throw AmazonQPlugiinException for missing commands and fix checkstyle errors

angjordn · 2024-09-19T21:17:37Z

+return null;
 default:
-PluginLogger.error("Unhandled chat command: " + command.toString());
+throw new AmazonQPluginException("Unhandled command in ChatCommunicationManager: " + command.toString());


@breedloj Throwing the PluginException as you mentioned. You also mentioned throwing the exception to avoid returning null - I moved the return null statements to the associated cases to be more explicit about which cases null is being returned on.

angjordn · 2024-09-19T21:20:33Z

 default:
- PluginLogger.info("Unhandled command: " + parsedCommand.getCommand());
- break;
+ throw new AmazonQPluginException("Unhandled command in AmazonQChatViewActionHandler: " + command.toString());


@breedloj Also updated the ActionHandler to a PluginException to match the unhandled command case in ChatCommunicationManager

angjordn · 2024-09-18T21:39:53Z

Description:

Add handler for aws/chat/sendChatPrompt message
Intentionally does not handle the Response (currently just logging)

Demo of UI to Logged response

Log_response.mov

breedloj · 2024-09-18T22:40:18Z

+ e.printStackTrace();
+ }
+ return null;


Instead of swallowing the exception let's wrap the original with an AmazonQPluginException and throw it back to the caller. In that case it should probably be the top level webview command execution logic that catches any error occurring during the processing of one of the commands. That could then log + potentially display an error to the user in the view (this part can come later).

Good idea! Didn't realize there was an AmazonQPluginException. Added to the other LSP send functions also.

breedloj · 2024-09-18T22:47:25Z

+ void tabAdd(GenericTabParams params);
+
+ @JsonNotification("aws/chat/ready")
+ void chatReady();


Did it not work when annotated as a JsonRequest with a void response type (CompletableFuture<Void>)? Maybe this makes more sense as an explicit fire & forget non blocking type though.

Yeah the LSP server did not recognize the request when it was annotated as a JsonRequest. The server is explicitly expecting a Notification. Surprisingly, most of the LSP features are Notifications rather than requests as specified in their doc (https://github.com/aws/language-server-runtimes/tree/main/runtimes#feature-specification-4)

Cool, thanks for the info. That makes sense.

…sp communication errors

angjordn

Made the requested updates

breedloj · 2024-09-19T20:10:49Z

 PluginLogger.error("Unhandled chat command: " + command.toString());
 }
+ return null;


Avoid the null return by explicitly raising a PluginException here. This is a specific internal failure that should not be squelched.

angjordn

Throw AmazonQPlugiinException for missing commands and fix checkstyle errors

angjordn · 2024-09-19T21:17:37Z

+return null;
 default:
-PluginLogger.error("Unhandled chat command: " + command.toString());
+throw new AmazonQPluginException("Unhandled command in ChatCommunicationManager: " + command.toString());


@breedloj Throwing the PluginException as you mentioned. You also mentioned throwing the exception to avoid returning null - I moved the return null statements to the associated cases to be more explicit about which cases null is being returned on.

angjordn · 2024-09-19T21:20:33Z

 default:
- PluginLogger.info("Unhandled command: " + parsedCommand.getCommand());
- break;
+ throw new AmazonQPluginException("Unhandled command in AmazonQChatViewActionHandler: " + command.toString());


@breedloj Also updated the ActionHandler to a PluginException to match the unhandled command case in ChatCommunicationManager

angjordn · 2024-09-18T21:39:53Z

Description:

Add handler for aws/chat/sendChatPrompt message
Intentionally does not handle the Response (currently just logging)

Demo of UI to Logged response

Log_response.mov

breedloj · 2024-09-18T22:40:18Z

+ e.printStackTrace();
+ }
+ return null;


Instead of swallowing the exception let's wrap the original with an AmazonQPluginException and throw it back to the caller. In that case it should probably be the top level webview command execution logic that catches any error occurring during the processing of one of the commands. That could then log + potentially display an error to the user in the view (this part can come later).

Good idea! Didn't realize there was an AmazonQPluginException. Added to the other LSP send functions also.

breedloj · 2024-09-18T22:47:25Z

+ void tabAdd(GenericTabParams params);
+
+ @JsonNotification("aws/chat/ready")
+ void chatReady();


Did it not work when annotated as a JsonRequest with a void response type (CompletableFuture<Void>)? Maybe this makes more sense as an explicit fire & forget non blocking type though.

Yeah the LSP server did not recognize the request when it was annotated as a JsonRequest. The server is explicitly expecting a Notification. Surprisingly, most of the LSP features are Notifications rather than requests as specified in their doc (https://github.com/aws/language-server-runtimes/tree/main/runtimes#feature-specification-4)

Cool, thanks for the info. That makes sense.

…sp communication errors

angjordn

Made the requested updates

breedloj · 2024-09-19T20:10:49Z

 PluginLogger.error("Unhandled chat command: " + command.toString());
 }
+ return null;


Avoid the null return by explicitly raising a PluginException here. This is a specific internal failure that should not be squelched.

angjordn

Throw AmazonQPlugiinException for missing commands and fix checkstyle errors

angjordn · 2024-09-19T21:17:37Z

+return null;
 default:
-PluginLogger.error("Unhandled chat command: " + command.toString());
+throw new AmazonQPluginException("Unhandled command in ChatCommunicationManager: " + command.toString());


@breedloj Throwing the PluginException as you mentioned. You also mentioned throwing the exception to avoid returning null - I moved the return null statements to the associated cases to be more explicit about which cases null is being returned on.

angjordn · 2024-09-19T21:20:33Z

 default:
- PluginLogger.info("Unhandled command: " + parsedCommand.getCommand());
- break;
+ throw new AmazonQPluginException("Unhandled command in AmazonQChatViewActionHandler: " + command.toString());


@breedloj Also updated the ActionHandler to a PluginException to match the unhandled command case in ChatCommunicationManager

angjordn · 2024-09-18T21:39:53Z

Description:

Add handler for aws/chat/sendChatPrompt message
Intentionally does not handle the Response (currently just logging)

Demo of UI to Logged response

Log_response.mov

breedloj · 2024-09-18T22:40:18Z

+ e.printStackTrace();
+ }
+ return null;


Instead of swallowing the exception let's wrap the original with an AmazonQPluginException and throw it back to the caller. In that case it should probably be the top level webview command execution logic that catches any error occurring during the processing of one of the commands. That could then log + potentially display an error to the user in the view (this part can come later).

Good idea! Didn't realize there was an AmazonQPluginException. Added to the other LSP send functions also.

breedloj · 2024-09-18T22:47:25Z

+ void tabAdd(GenericTabParams params);
+
+ @JsonNotification("aws/chat/ready")
+ void chatReady();


Did it not work when annotated as a JsonRequest with a void response type (CompletableFuture<Void>)? Maybe this makes more sense as an explicit fire & forget non blocking type though.

Yeah the LSP server did not recognize the request when it was annotated as a JsonRequest. The server is explicitly expecting a Notification. Surprisingly, most of the LSP features are Notifications rather than requests as specified in their doc (https://github.com/aws/language-server-runtimes/tree/main/runtimes#feature-specification-4)

Cool, thanks for the info. That makes sense.

…sp communication errors

angjordn

Made the requested updates

breedloj · 2024-09-19T20:10:49Z

 PluginLogger.error("Unhandled chat command: " + command.toString());
 }
+ return null;


Avoid the null return by explicitly raising a PluginException here. This is a specific internal failure that should not be squelched.

angjordn

Throw AmazonQPlugiinException for missing commands and fix checkstyle errors

angjordn · 2024-09-19T21:17:37Z

+return null;
 default:
-PluginLogger.error("Unhandled chat command: " + command.toString());
+throw new AmazonQPluginException("Unhandled command in ChatCommunicationManager: " + command.toString());


@breedloj Throwing the PluginException as you mentioned. You also mentioned throwing the exception to avoid returning null - I moved the return null statements to the associated cases to be more explicit about which cases null is being returned on.

angjordn · 2024-09-19T21:20:33Z

 default:
- PluginLogger.info("Unhandled command: " + parsedCommand.getCommand());
- break;
+ throw new AmazonQPluginException("Unhandled command in AmazonQChatViewActionHandler: " + command.toString());


@breedloj Also updated the ActionHandler to a PluginException to match the unhandled command case in ChatCommunicationManager

angjordn · 2024-09-18T21:39:53Z

Description:

Add handler for aws/chat/sendChatPrompt message
Intentionally does not handle the Response (currently just logging)

Demo of UI to Logged response

Log_response.mov

breedloj · 2024-09-18T22:40:18Z

+ e.printStackTrace();
+ }
+ return null;


Instead of swallowing the exception let's wrap the original with an AmazonQPluginException and throw it back to the caller. In that case it should probably be the top level webview command execution logic that catches any error occurring during the processing of one of the commands. That could then log + potentially display an error to the user in the view (this part can come later).

Good idea! Didn't realize there was an AmazonQPluginException. Added to the other LSP send functions also.

breedloj · 2024-09-18T22:47:25Z

+ void tabAdd(GenericTabParams params);
+
+ @JsonNotification("aws/chat/ready")
+ void chatReady();


Did it not work when annotated as a JsonRequest with a void response type (CompletableFuture<Void>)? Maybe this makes more sense as an explicit fire & forget non blocking type though.

Yeah the LSP server did not recognize the request when it was annotated as a JsonRequest. The server is explicitly expecting a Notification. Surprisingly, most of the LSP features are Notifications rather than requests as specified in their doc (https://github.com/aws/language-server-runtimes/tree/main/runtimes#feature-specification-4)

Cool, thanks for the info. That makes sense.

…sp communication errors

angjordn

Made the requested updates

breedloj · 2024-09-19T20:10:49Z

 PluginLogger.error("Unhandled chat command: " + command.toString());
 }
+ return null;


Avoid the null return by explicitly raising a PluginException here. This is a specific internal failure that should not be squelched.

angjordn

Throw AmazonQPlugiinException for missing commands and fix checkstyle errors

angjordn · 2024-09-19T21:17:37Z

+return null;
 default:
-PluginLogger.error("Unhandled chat command: " + command.toString());
+throw new AmazonQPluginException("Unhandled command in ChatCommunicationManager: " + command.toString());


@breedloj Throwing the PluginException as you mentioned. You also mentioned throwing the exception to avoid returning null - I moved the return null statements to the associated cases to be more explicit about which cases null is being returned on.

angjordn · 2024-09-19T21:20:33Z

 default:
- PluginLogger.info("Unhandled command: " + parsedCommand.getCommand());
- break;
+ throw new AmazonQPluginException("Unhandled command in AmazonQChatViewActionHandler: " + command.toString());


@breedloj Also updated the ActionHandler to a PluginException to match the unhandled command case in ChatCommunicationManager

angjordn requested a review from breedloj September 18, 2024 22:01

Base automatically changed from send-chat-ready-to-lsp to mainSeptember 18, 2024 22:30

breedloj reviewed Sep 18, 2024
View reviewed changes

angjordn added 5 commits September 19, 2024 11:36

Send chat/ready message to lsp and fix addTab issue
61281d3

Fix checkstyle errors
c927579

Send chat/prompt message to lsp
566cbcf

Fix checkstyle errors
f247cf6

Add threading for the commands and throw AmazonQPluginException for l…
4ff9d04
…sp communication errors

angjordn force-pushed the send-chat-prompt-to-lsp branch from a5ca0d4 to 4ff9d04Compare September 19, 2024 19:09

angjordn commented Sep 19, 2024
View reviewed changes

breedloj reviewed Sep 19, 2024
View reviewed changes

angjordn added 2 commits September 19, 2024 14:14

Throw exception for missing commands
adb6fb5

fix checkstyle errors
249d088

angjordn commented Sep 19, 2024
View reviewed changes

Merge branch 'main' into send-chat-prompt-to-lsp
a6aec4d

breedloj approved these changes Sep 20, 2024
View reviewed changes

breedloj merged commit 3b09977 into mainSep 20, 2024

breedloj deleted the send-chat-prompt-to-lsp branch September 20, 2024 18:16

laileni-aws mentioned this pull request Jul 16, 2026
fix(security): bump vulnerable dependencies to patched versions #568
Open

angjordn requested a review from breedloj September 18, 2024 22:01

Base automatically changed from send-chat-ready-to-lsp to mainSeptember 18, 2024 22:30

breedloj reviewed Sep 18, 2024
View reviewed changes

angjordn added 5 commits September 19, 2024 11:36

Send chat/ready message to lsp and fix addTab issue
61281d3

Fix checkstyle errors
c927579

Send chat/prompt message to lsp
566cbcf

Fix checkstyle errors
f247cf6

Add threading for the commands and throw AmazonQPluginException for l…
4ff9d04
…sp communication errors

angjordn force-pushed the send-chat-prompt-to-lsp branch from a5ca0d4 to 4ff9d04Compare September 19, 2024 19:09

angjordn commented Sep 19, 2024
View reviewed changes

breedloj reviewed Sep 19, 2024
View reviewed changes

angjordn added 2 commits September 19, 2024 14:14

Throw exception for missing commands
adb6fb5

fix checkstyle errors
249d088

angjordn commented Sep 19, 2024
View reviewed changes

Merge branch 'main' into send-chat-prompt-to-lsp
a6aec4d

breedloj approved these changes Sep 20, 2024
View reviewed changes

breedloj merged commit 3b09977 into mainSep 20, 2024

breedloj deleted the send-chat-prompt-to-lsp branch September 20, 2024 18:16

laileni-aws mentioned this pull request Jul 16, 2026
fix(security): bump vulnerable dependencies to patched versions #568
Open

angjordn requested a review from breedloj September 18, 2024 22:01

Base automatically changed from send-chat-ready-to-lsp to mainSeptember 18, 2024 22:30

breedloj reviewed Sep 18, 2024
View reviewed changes

angjordn added 5 commits September 19, 2024 11:36

Send chat/ready message to lsp and fix addTab issue
61281d3

Fix checkstyle errors
c927579

Send chat/prompt message to lsp
566cbcf

Fix checkstyle errors
f247cf6

Add threading for the commands and throw AmazonQPluginException for l…
4ff9d04
…sp communication errors

angjordn force-pushed the send-chat-prompt-to-lsp branch from a5ca0d4 to 4ff9d04Compare September 19, 2024 19:09

angjordn commented Sep 19, 2024
View reviewed changes

breedloj reviewed Sep 19, 2024
View reviewed changes

angjordn added 2 commits September 19, 2024 14:14

Throw exception for missing commands
adb6fb5

fix checkstyle errors
249d088

angjordn commented Sep 19, 2024
View reviewed changes

Merge branch 'main' into send-chat-prompt-to-lsp
a6aec4d

breedloj approved these changes Sep 20, 2024
View reviewed changes

breedloj merged commit 3b09977 into mainSep 20, 2024

breedloj deleted the send-chat-prompt-to-lsp branch September 20, 2024 18:16

laileni-aws mentioned this pull request Jul 16, 2026
fix(security): bump vulnerable dependencies to patched versions #568
Open

angjordn requested a review from breedloj September 18, 2024 22:01

Base automatically changed from send-chat-ready-to-lsp to mainSeptember 18, 2024 22:30

breedloj reviewed Sep 18, 2024
View reviewed changes

angjordn added 5 commits September 19, 2024 11:36

Send chat/ready message to lsp and fix addTab issue
61281d3

Fix checkstyle errors
c927579

Send chat/prompt message to lsp
566cbcf

Fix checkstyle errors
f247cf6

Add threading for the commands and throw AmazonQPluginException for l…
4ff9d04
…sp communication errors

angjordn force-pushed the send-chat-prompt-to-lsp branch from a5ca0d4 to 4ff9d04Compare September 19, 2024 19:09

angjordn commented Sep 19, 2024
View reviewed changes

breedloj reviewed Sep 19, 2024
View reviewed changes

angjordn added 2 commits September 19, 2024 14:14

Throw exception for missing commands
adb6fb5

fix checkstyle errors
249d088

angjordn commented Sep 19, 2024
View reviewed changes

Merge branch 'main' into send-chat-prompt-to-lsp
a6aec4d

breedloj approved these changes Sep 20, 2024
View reviewed changes

breedloj merged commit 3b09977 into mainSep 20, 2024

breedloj deleted the send-chat-prompt-to-lsp branch September 20, 2024 18:16

laileni-aws mentioned this pull request Jul 16, 2026
fix(security): bump vulnerable dependencies to patched versions #568
Open

angjordn requested a review from breedloj September 18, 2024 22:01

Base automatically changed from send-chat-ready-to-lsp to mainSeptember 18, 2024 22:30

breedloj reviewed Sep 18, 2024
View reviewed changes

angjordn added 5 commits September 19, 2024 11:36

Send chat/ready message to lsp and fix addTab issue
61281d3

Fix checkstyle errors
c927579

Send chat/prompt message to lsp
566cbcf

Fix checkstyle errors
f247cf6

Add threading for the commands and throw AmazonQPluginException for l…
4ff9d04
…sp communication errors

angjordn force-pushed the send-chat-prompt-to-lsp branch from a5ca0d4 to 4ff9d04Compare September 19, 2024 19:09

angjordn commented Sep 19, 2024
View reviewed changes

breedloj reviewed Sep 19, 2024
View reviewed changes

angjordn added 2 commits September 19, 2024 14:14

Throw exception for missing commands
adb6fb5

fix checkstyle errors
249d088

angjordn commented Sep 19, 2024
View reviewed changes

Merge branch 'main' into send-chat-prompt-to-lsp
a6aec4d

breedloj approved these changes Sep 20, 2024
View reviewed changes

breedloj merged commit 3b09977 into mainSep 20, 2024

breedloj deleted the send-chat-prompt-to-lsp branch September 20, 2024 18:16

laileni-aws mentioned this pull request Jul 16, 2026
fix(security): bump vulnerable dependencies to patched versions #568
Open

angjordn requested a review from breedloj September 18, 2024 22:01

Base automatically changed from send-chat-ready-to-lsp to mainSeptember 18, 2024 22:30

breedloj reviewed Sep 18, 2024
View reviewed changes

angjordn added 5 commits September 19, 2024 11:36

Send chat/ready message to lsp and fix addTab issue
61281d3

Fix checkstyle errors
c927579

Send chat/prompt message to lsp
566cbcf

Fix checkstyle errors
f247cf6

Add threading for the commands and throw AmazonQPluginException for l…
4ff9d04
…sp communication errors

angjordn force-pushed the send-chat-prompt-to-lsp branch from a5ca0d4 to 4ff9d04Compare September 19, 2024 19:09

angjordn commented Sep 19, 2024
View reviewed changes

breedloj reviewed Sep 19, 2024
View reviewed changes

angjordn added 2 commits September 19, 2024 14:14

Throw exception for missing commands
adb6fb5

fix checkstyle errors
249d088

angjordn commented Sep 19, 2024
View reviewed changes

Merge branch 'main' into send-chat-prompt-to-lsp
a6aec4d

breedloj approved these changes Sep 20, 2024
View reviewed changes

breedloj merged commit 3b09977 into mainSep 20, 2024

breedloj deleted the send-chat-prompt-to-lsp branch September 20, 2024 18:16

laileni-aws mentioned this pull request Jul 16, 2026
fix(security): bump vulnerable dependencies to patched versions #568
Open

angjordn requested a review from breedloj September 18, 2024 22:01

Base automatically changed from send-chat-ready-to-lsp to mainSeptember 18, 2024 22:30

breedloj reviewed Sep 18, 2024
View reviewed changes

angjordn added 5 commits September 19, 2024 11:36

Send chat/ready message to lsp and fix addTab issue
61281d3

Fix checkstyle errors
c927579

Send chat/prompt message to lsp
566cbcf

Fix checkstyle errors
f247cf6

Add threading for the commands and throw AmazonQPluginException for l…
4ff9d04
…sp communication errors

angjordn force-pushed the send-chat-prompt-to-lsp branch from a5ca0d4 to 4ff9d04Compare September 19, 2024 19:09

angjordn commented Sep 19, 2024
View reviewed changes

breedloj reviewed Sep 19, 2024
View reviewed changes

angjordn added 2 commits September 19, 2024 14:14

Throw exception for missing commands
adb6fb5

fix checkstyle errors
249d088

angjordn commented Sep 19, 2024
View reviewed changes

Merge branch 'main' into send-chat-prompt-to-lsp
a6aec4d

breedloj approved these changes Sep 20, 2024
View reviewed changes

breedloj merged commit 3b09977 into mainSep 20, 2024

breedloj deleted the send-chat-prompt-to-lsp branch September 20, 2024 18:16

laileni-aws mentioned this pull request Jul 16, 2026
fix(security): bump vulnerable dependencies to patched versions #568
Open

angjordn requested a review from breedloj September 18, 2024 22:01

Base automatically changed from send-chat-ready-to-lsp to mainSeptember 18, 2024 22:30

breedloj reviewed Sep 18, 2024
View reviewed changes

angjordn added 5 commits September 19, 2024 11:36

Send chat/ready message to lsp and fix addTab issue
61281d3

Fix checkstyle errors
c927579

Send chat/prompt message to lsp
566cbcf

Fix checkstyle errors
f247cf6

Add threading for the commands and throw AmazonQPluginException for l…
4ff9d04
…sp communication errors

angjordn force-pushed the send-chat-prompt-to-lsp branch from a5ca0d4 to 4ff9d04Compare September 19, 2024 19:09

angjordn commented Sep 19, 2024
View reviewed changes

breedloj reviewed Sep 19, 2024
View reviewed changes

angjordn added 2 commits September 19, 2024 14:14

Throw exception for missing commands
adb6fb5

fix checkstyle errors
249d088

angjordn commented Sep 19, 2024
View reviewed changes

Merge branch 'main' into send-chat-prompt-to-lsp
a6aec4d

breedloj approved these changes Sep 20, 2024
View reviewed changes

breedloj merged commit 3b09977 into mainSep 20, 2024

breedloj deleted the send-chat-prompt-to-lsp branch September 20, 2024 18:16

laileni-aws mentioned this pull request Jul 16, 2026
fix(security): bump vulnerable dependencies to patched versions #568
Open

Uh oh!

Conversation

angjordn commented Sep 18, 2024

Description:

Demo of UI to Logged response

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angjordn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angjordn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

angjordn commented Sep 18, 2024

Description:

Demo of UI to Logged response

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angjordn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angjordn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

angjordn commented Sep 18, 2024

Description:

Demo of UI to Logged response

Uh oh!