Trigger customization notifications on ide, stacking multiple notifications vertically and refactor/add support for more methods in PluginStore by pras0131 · Pull Request #48 · Amazon-Q-Developer/amazon-q-eclipse

pras0131 · 2024-10-02T13:44:13Z

Reference ticket: https://issues.amazon.com/issues/ECLIPSE-297

Trigger IDE notifications on customization updates or selection of default foundation.
The PR also includes changes to stack multiple notifications vertically and the logic to reposition notifications once any of the notification is closed. The CRUX of the implementation is AbstractNotificationPopup initializeBounds() method, which has been overriden according to our requirements and repositioning of notifications once the older ones starts to flash out.
Support for two new methods - putObject and getObject in the PluginStore to ease set/get for more complex objects other than just plain strings.
Refactored the customizations preference storage code to let it store the entire customization object, rather than storing each of the individual fields.

… selected

…ustomization preference storage

breedloj · 2024-10-03T23:37:03Z

- PluginStore.put(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.selectedCustomisationArn);
+ Display.getCurrent().asyncExec(() -> showNotification(Constants.DEFAULT_Q_FOUNDATION_DISPLAY_NAME));
+ } else if (Objects.nonNull(this.getSelectedCustomization()) && StringUtils.isNotBlank(this.getSelectedCustomization().getName())) {
+ PluginStore.putObject(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.getSelectedCustomization());


Can we not just store the ARN?

Earlier I was just storing ARN only but I need to have name (or maybe description as well later) for showing notifications. So instead of creating 3 different getter/setter for all of these, I changed the implementation to just have a single setter/getter.

breedloj · 2024-10-03T23:50:51Z

+ synchronized (lock) {
+ activeNotifications.add(this);
+ }


Having a synchronized block here adds no value since the underlying call to add is thread safe since you're using a CopyOnWriteArrayList. It would make sense if you are trying to perform several operations together in an atomic unit of work.

makes sense, I can actually remove the synchronized block. Thanks for this.

breedloj · 2024-10-03T23:54:13Z

+ String jsonValue = GSON.toJson(value);
+ byte[] byteValue = jsonValue.getBytes(StandardCharsets.UTF_8);
+ PREFERENCES.putByteArray(key, byteValue);


While this technically can be done serializing entire objects does present additional risks. In general I would like to be convinced that use cases require it, vs. binding relational configuration under a common key namespace, e.g.:
notifications.foo: 123
notifications.bar: 456

For the same reason which I described here https://github.com/aws/amazon-q-eclipse/pull/48/files#r1787324480
Also, currently when LSP server requests for aws.q, we only return customization object but maybe in near future - we might be returning more than just one single row item. Then in those kindof cases, it would be better to just do a single lookup and return it.

…clipse into paras/fetchCustomizations

…paras/triggerCustomizationNotificationsOnIDE

Add missing import missed during merge conflict

pras0131 · 2024-10-02T13:44:13Z

Reference ticket: https://issues.amazon.com/issues/ECLIPSE-297

Trigger IDE notifications on customization updates or selection of default foundation.
The PR also includes changes to stack multiple notifications vertically and the logic to reposition notifications once any of the notification is closed. The CRUX of the implementation is AbstractNotificationPopup initializeBounds() method, which has been overriden according to our requirements and repositioning of notifications once the older ones starts to flash out.
Support for two new methods - putObject and getObject in the PluginStore to ease set/get for more complex objects other than just plain strings.
Refactored the customizations preference storage code to let it store the entire customization object, rather than storing each of the individual fields.

… selected

…ustomization preference storage

breedloj · 2024-10-03T23:37:03Z

- PluginStore.put(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.selectedCustomisationArn);
+ Display.getCurrent().asyncExec(() -> showNotification(Constants.DEFAULT_Q_FOUNDATION_DISPLAY_NAME));
+ } else if (Objects.nonNull(this.getSelectedCustomization()) && StringUtils.isNotBlank(this.getSelectedCustomization().getName())) {
+ PluginStore.putObject(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.getSelectedCustomization());


Can we not just store the ARN?

Earlier I was just storing ARN only but I need to have name (or maybe description as well later) for showing notifications. So instead of creating 3 different getter/setter for all of these, I changed the implementation to just have a single setter/getter.

breedloj · 2024-10-03T23:50:51Z

+ synchronized (lock) {
+ activeNotifications.add(this);
+ }


Having a synchronized block here adds no value since the underlying call to add is thread safe since you're using a CopyOnWriteArrayList. It would make sense if you are trying to perform several operations together in an atomic unit of work.

makes sense, I can actually remove the synchronized block. Thanks for this.

breedloj · 2024-10-03T23:54:13Z

+ String jsonValue = GSON.toJson(value);
+ byte[] byteValue = jsonValue.getBytes(StandardCharsets.UTF_8);
+ PREFERENCES.putByteArray(key, byteValue);


While this technically can be done serializing entire objects does present additional risks. In general I would like to be convinced that use cases require it, vs. binding relational configuration under a common key namespace, e.g.:
notifications.foo: 123
notifications.bar: 456

For the same reason which I described here https://github.com/aws/amazon-q-eclipse/pull/48/files#r1787324480
Also, currently when LSP server requests for aws.q, we only return customization object but maybe in near future - we might be returning more than just one single row item. Then in those kindof cases, it would be better to just do a single lookup and return it.

…clipse into paras/fetchCustomizations

…paras/triggerCustomizationNotificationsOnIDE

Add missing import missed during merge conflict

pras0131 · 2024-10-02T13:44:13Z

Reference ticket: https://issues.amazon.com/issues/ECLIPSE-297

Trigger IDE notifications on customization updates or selection of default foundation.
The PR also includes changes to stack multiple notifications vertically and the logic to reposition notifications once any of the notification is closed. The CRUX of the implementation is AbstractNotificationPopup initializeBounds() method, which has been overriden according to our requirements and repositioning of notifications once the older ones starts to flash out.
Support for two new methods - putObject and getObject in the PluginStore to ease set/get for more complex objects other than just plain strings.
Refactored the customizations preference storage code to let it store the entire customization object, rather than storing each of the individual fields.

… selected

…ustomization preference storage

breedloj · 2024-10-03T23:37:03Z

- PluginStore.put(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.selectedCustomisationArn);
+ Display.getCurrent().asyncExec(() -> showNotification(Constants.DEFAULT_Q_FOUNDATION_DISPLAY_NAME));
+ } else if (Objects.nonNull(this.getSelectedCustomization()) && StringUtils.isNotBlank(this.getSelectedCustomization().getName())) {
+ PluginStore.putObject(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.getSelectedCustomization());


Can we not just store the ARN?

Earlier I was just storing ARN only but I need to have name (or maybe description as well later) for showing notifications. So instead of creating 3 different getter/setter for all of these, I changed the implementation to just have a single setter/getter.

breedloj · 2024-10-03T23:50:51Z

+ synchronized (lock) {
+ activeNotifications.add(this);
+ }


Having a synchronized block here adds no value since the underlying call to add is thread safe since you're using a CopyOnWriteArrayList. It would make sense if you are trying to perform several operations together in an atomic unit of work.

makes sense, I can actually remove the synchronized block. Thanks for this.

breedloj · 2024-10-03T23:54:13Z

+ String jsonValue = GSON.toJson(value);
+ byte[] byteValue = jsonValue.getBytes(StandardCharsets.UTF_8);
+ PREFERENCES.putByteArray(key, byteValue);


While this technically can be done serializing entire objects does present additional risks. In general I would like to be convinced that use cases require it, vs. binding relational configuration under a common key namespace, e.g.:
notifications.foo: 123
notifications.bar: 456

For the same reason which I described here https://github.com/aws/amazon-q-eclipse/pull/48/files#r1787324480
Also, currently when LSP server requests for aws.q, we only return customization object but maybe in near future - we might be returning more than just one single row item. Then in those kindof cases, it would be better to just do a single lookup and return it.

…clipse into paras/fetchCustomizations

…paras/triggerCustomizationNotificationsOnIDE

Add missing import missed during merge conflict

pras0131 · 2024-10-02T13:44:13Z

Reference ticket: https://issues.amazon.com/issues/ECLIPSE-297

Trigger IDE notifications on customization updates or selection of default foundation.
The PR also includes changes to stack multiple notifications vertically and the logic to reposition notifications once any of the notification is closed. The CRUX of the implementation is AbstractNotificationPopup initializeBounds() method, which has been overriden according to our requirements and repositioning of notifications once the older ones starts to flash out.
Support for two new methods - putObject and getObject in the PluginStore to ease set/get for more complex objects other than just plain strings.
Refactored the customizations preference storage code to let it store the entire customization object, rather than storing each of the individual fields.

… selected

…ustomization preference storage

breedloj · 2024-10-03T23:37:03Z

- PluginStore.put(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.selectedCustomisationArn);
+ Display.getCurrent().asyncExec(() -> showNotification(Constants.DEFAULT_Q_FOUNDATION_DISPLAY_NAME));
+ } else if (Objects.nonNull(this.getSelectedCustomization()) && StringUtils.isNotBlank(this.getSelectedCustomization().getName())) {
+ PluginStore.putObject(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.getSelectedCustomization());


Can we not just store the ARN?

Earlier I was just storing ARN only but I need to have name (or maybe description as well later) for showing notifications. So instead of creating 3 different getter/setter for all of these, I changed the implementation to just have a single setter/getter.

breedloj · 2024-10-03T23:50:51Z

+ synchronized (lock) {
+ activeNotifications.add(this);
+ }


Having a synchronized block here adds no value since the underlying call to add is thread safe since you're using a CopyOnWriteArrayList. It would make sense if you are trying to perform several operations together in an atomic unit of work.

makes sense, I can actually remove the synchronized block. Thanks for this.

breedloj · 2024-10-03T23:54:13Z

+ String jsonValue = GSON.toJson(value);
+ byte[] byteValue = jsonValue.getBytes(StandardCharsets.UTF_8);
+ PREFERENCES.putByteArray(key, byteValue);


While this technically can be done serializing entire objects does present additional risks. In general I would like to be convinced that use cases require it, vs. binding relational configuration under a common key namespace, e.g.:
notifications.foo: 123
notifications.bar: 456

For the same reason which I described here https://github.com/aws/amazon-q-eclipse/pull/48/files#r1787324480
Also, currently when LSP server requests for aws.q, we only return customization object but maybe in near future - we might be returning more than just one single row item. Then in those kindof cases, it would be better to just do a single lookup and return it.

…clipse into paras/fetchCustomizations

…paras/triggerCustomizationNotificationsOnIDE

Add missing import missed during merge conflict

pras0131 · 2024-10-02T13:44:13Z

Reference ticket: https://issues.amazon.com/issues/ECLIPSE-297

Trigger IDE notifications on customization updates or selection of default foundation.
The PR also includes changes to stack multiple notifications vertically and the logic to reposition notifications once any of the notification is closed. The CRUX of the implementation is AbstractNotificationPopup initializeBounds() method, which has been overriden according to our requirements and repositioning of notifications once the older ones starts to flash out.
Support for two new methods - putObject and getObject in the PluginStore to ease set/get for more complex objects other than just plain strings.
Refactored the customizations preference storage code to let it store the entire customization object, rather than storing each of the individual fields.

… selected

…ustomization preference storage

breedloj · 2024-10-03T23:37:03Z

- PluginStore.put(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.selectedCustomisationArn);
+ Display.getCurrent().asyncExec(() -> showNotification(Constants.DEFAULT_Q_FOUNDATION_DISPLAY_NAME));
+ } else if (Objects.nonNull(this.getSelectedCustomization()) && StringUtils.isNotBlank(this.getSelectedCustomization().getName())) {
+ PluginStore.putObject(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.getSelectedCustomization());


Can we not just store the ARN?

Earlier I was just storing ARN only but I need to have name (or maybe description as well later) for showing notifications. So instead of creating 3 different getter/setter for all of these, I changed the implementation to just have a single setter/getter.

breedloj · 2024-10-03T23:50:51Z

+ synchronized (lock) {
+ activeNotifications.add(this);
+ }


Having a synchronized block here adds no value since the underlying call to add is thread safe since you're using a CopyOnWriteArrayList. It would make sense if you are trying to perform several operations together in an atomic unit of work.

makes sense, I can actually remove the synchronized block. Thanks for this.

breedloj · 2024-10-03T23:54:13Z

+ String jsonValue = GSON.toJson(value);
+ byte[] byteValue = jsonValue.getBytes(StandardCharsets.UTF_8);
+ PREFERENCES.putByteArray(key, byteValue);


While this technically can be done serializing entire objects does present additional risks. In general I would like to be convinced that use cases require it, vs. binding relational configuration under a common key namespace, e.g.:
notifications.foo: 123
notifications.bar: 456

For the same reason which I described here https://github.com/aws/amazon-q-eclipse/pull/48/files#r1787324480
Also, currently when LSP server requests for aws.q, we only return customization object but maybe in near future - we might be returning more than just one single row item. Then in those kindof cases, it would be better to just do a single lookup and return it.

…clipse into paras/fetchCustomizations

…paras/triggerCustomizationNotificationsOnIDE

Add missing import missed during merge conflict

pras0131 · 2024-10-02T13:44:13Z

Reference ticket: https://issues.amazon.com/issues/ECLIPSE-297

Trigger IDE notifications on customization updates or selection of default foundation.
The PR also includes changes to stack multiple notifications vertically and the logic to reposition notifications once any of the notification is closed. The CRUX of the implementation is AbstractNotificationPopup initializeBounds() method, which has been overriden according to our requirements and repositioning of notifications once the older ones starts to flash out.
Support for two new methods - putObject and getObject in the PluginStore to ease set/get for more complex objects other than just plain strings.
Refactored the customizations preference storage code to let it store the entire customization object, rather than storing each of the individual fields.

… selected

…ustomization preference storage

breedloj · 2024-10-03T23:37:03Z

- PluginStore.put(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.selectedCustomisationArn);
+ Display.getCurrent().asyncExec(() -> showNotification(Constants.DEFAULT_Q_FOUNDATION_DISPLAY_NAME));
+ } else if (Objects.nonNull(this.getSelectedCustomization()) && StringUtils.isNotBlank(this.getSelectedCustomization().getName())) {
+ PluginStore.putObject(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.getSelectedCustomization());


Can we not just store the ARN?

Earlier I was just storing ARN only but I need to have name (or maybe description as well later) for showing notifications. So instead of creating 3 different getter/setter for all of these, I changed the implementation to just have a single setter/getter.

breedloj · 2024-10-03T23:50:51Z

+ synchronized (lock) {
+ activeNotifications.add(this);
+ }


Having a synchronized block here adds no value since the underlying call to add is thread safe since you're using a CopyOnWriteArrayList. It would make sense if you are trying to perform several operations together in an atomic unit of work.

makes sense, I can actually remove the synchronized block. Thanks for this.

breedloj · 2024-10-03T23:54:13Z

+ String jsonValue = GSON.toJson(value);
+ byte[] byteValue = jsonValue.getBytes(StandardCharsets.UTF_8);
+ PREFERENCES.putByteArray(key, byteValue);


While this technically can be done serializing entire objects does present additional risks. In general I would like to be convinced that use cases require it, vs. binding relational configuration under a common key namespace, e.g.:
notifications.foo: 123
notifications.bar: 456

For the same reason which I described here https://github.com/aws/amazon-q-eclipse/pull/48/files#r1787324480
Also, currently when LSP server requests for aws.q, we only return customization object but maybe in near future - we might be returning more than just one single row item. Then in those kindof cases, it would be better to just do a single lookup and return it.

…clipse into paras/fetchCustomizations

…paras/triggerCustomizationNotificationsOnIDE

Add missing import missed during merge conflict

pras0131 · 2024-10-02T13:44:13Z

Reference ticket: https://issues.amazon.com/issues/ECLIPSE-297

Trigger IDE notifications on customization updates or selection of default foundation.
The PR also includes changes to stack multiple notifications vertically and the logic to reposition notifications once any of the notification is closed. The CRUX of the implementation is AbstractNotificationPopup initializeBounds() method, which has been overriden according to our requirements and repositioning of notifications once the older ones starts to flash out.
Support for two new methods - putObject and getObject in the PluginStore to ease set/get for more complex objects other than just plain strings.
Refactored the customizations preference storage code to let it store the entire customization object, rather than storing each of the individual fields.

… selected

…ustomization preference storage

breedloj · 2024-10-03T23:37:03Z

- PluginStore.put(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.selectedCustomisationArn);
+ Display.getCurrent().asyncExec(() -> showNotification(Constants.DEFAULT_Q_FOUNDATION_DISPLAY_NAME));
+ } else if (Objects.nonNull(this.getSelectedCustomization()) && StringUtils.isNotBlank(this.getSelectedCustomization().getName())) {
+ PluginStore.putObject(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.getSelectedCustomization());


Can we not just store the ARN?

Earlier I was just storing ARN only but I need to have name (or maybe description as well later) for showing notifications. So instead of creating 3 different getter/setter for all of these, I changed the implementation to just have a single setter/getter.

breedloj · 2024-10-03T23:50:51Z

+ synchronized (lock) {
+ activeNotifications.add(this);
+ }


Having a synchronized block here adds no value since the underlying call to add is thread safe since you're using a CopyOnWriteArrayList. It would make sense if you are trying to perform several operations together in an atomic unit of work.

makes sense, I can actually remove the synchronized block. Thanks for this.

breedloj · 2024-10-03T23:54:13Z

+ String jsonValue = GSON.toJson(value);
+ byte[] byteValue = jsonValue.getBytes(StandardCharsets.UTF_8);
+ PREFERENCES.putByteArray(key, byteValue);


While this technically can be done serializing entire objects does present additional risks. In general I would like to be convinced that use cases require it, vs. binding relational configuration under a common key namespace, e.g.:
notifications.foo: 123
notifications.bar: 456

For the same reason which I described here https://github.com/aws/amazon-q-eclipse/pull/48/files#r1787324480
Also, currently when LSP server requests for aws.q, we only return customization object but maybe in near future - we might be returning more than just one single row item. Then in those kindof cases, it would be better to just do a single lookup and return it.

…clipse into paras/fetchCustomizations

…paras/triggerCustomizationNotificationsOnIDE

Add missing import missed during merge conflict

pras0131 · 2024-10-02T13:44:13Z

Reference ticket: https://issues.amazon.com/issues/ECLIPSE-297

Trigger IDE notifications on customization updates or selection of default foundation.
The PR also includes changes to stack multiple notifications vertically and the logic to reposition notifications once any of the notification is closed. The CRUX of the implementation is AbstractNotificationPopup initializeBounds() method, which has been overriden according to our requirements and repositioning of notifications once the older ones starts to flash out.
Support for two new methods - putObject and getObject in the PluginStore to ease set/get for more complex objects other than just plain strings.
Refactored the customizations preference storage code to let it store the entire customization object, rather than storing each of the individual fields.

… selected

…ustomization preference storage

breedloj · 2024-10-03T23:37:03Z

- PluginStore.put(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.selectedCustomisationArn);
+ Display.getCurrent().asyncExec(() -> showNotification(Constants.DEFAULT_Q_FOUNDATION_DISPLAY_NAME));
+ } else if (Objects.nonNull(this.getSelectedCustomization()) && StringUtils.isNotBlank(this.getSelectedCustomization().getName())) {
+ PluginStore.putObject(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.getSelectedCustomization());


Can we not just store the ARN?

Earlier I was just storing ARN only but I need to have name (or maybe description as well later) for showing notifications. So instead of creating 3 different getter/setter for all of these, I changed the implementation to just have a single setter/getter.

breedloj · 2024-10-03T23:50:51Z

+ synchronized (lock) {
+ activeNotifications.add(this);
+ }


Having a synchronized block here adds no value since the underlying call to add is thread safe since you're using a CopyOnWriteArrayList. It would make sense if you are trying to perform several operations together in an atomic unit of work.

makes sense, I can actually remove the synchronized block. Thanks for this.

breedloj · 2024-10-03T23:54:13Z

+ String jsonValue = GSON.toJson(value);
+ byte[] byteValue = jsonValue.getBytes(StandardCharsets.UTF_8);
+ PREFERENCES.putByteArray(key, byteValue);


While this technically can be done serializing entire objects does present additional risks. In general I would like to be convinced that use cases require it, vs. binding relational configuration under a common key namespace, e.g.:
notifications.foo: 123
notifications.bar: 456

For the same reason which I described here https://github.com/aws/amazon-q-eclipse/pull/48/files#r1787324480
Also, currently when LSP server requests for aws.q, we only return customization object but maybe in near future - we might be returning more than just one single row item. Then in those kindof cases, it would be better to just do a single lookup and return it.

…clipse into paras/fetchCustomizations

…paras/triggerCustomizationNotificationsOnIDE

Add missing import missed during merge conflict

Parasand others added 3 commits October 1, 2024 14:36

Fetch customizations from LSP server
ec98e04

Merge branch 'main' into paras/fetchCustomizations
5e49228

Display IDE notification on customization change
3ba6cc7

pras0131 changed the base branch from main to paras/fetchCustomizationsOctober 2, 2024 13:45

Paras added 2 commits October 2, 2024 15:59

Only show notification & save preference if customization dropdown is…
6de13f6
… selected

Stacking multiple notifications vertically
617e53e

pras0131 changed the title ~~Trigger customization notifications on ide~~Trigger customization notifications on ide and stacking multiple notifications verticallyOct 3, 2024

Support for getObject,putObject in preference store and refactoring c…
5f2b1d1
…ustomization preference storage

pras0131 changed the title ~~Trigger customization notifications on ide and stacking multiple notifications vertically~~Trigger customization notifications on ide, stacking multiple notifications vertically and refactor/add support for more methods in PluginStoreOct 3, 2024

pras0131 requested a review from breedloj October 3, 2024 12:45

breedloj reviewed Oct 3, 2024
View reviewed changes

Paras added 3 commits October 4, 2024 12:18

Make combo dropdown to populate asynchronously
37bc88f

Merge branch 'paras/fetchCustomizations' of github.com:aws/amazon-q-e…
4d793b7
…clipse into paras/fetchCustomizations

Remove the synchronized block
013f639

pras0131 force-pushed the paras/triggerCustomizationNotificationsOnIDE branch from 6b587c6 to 013f639Compare October 4, 2024 13:41

Paras added 2 commits October 4, 2024 16:39

Merge remote-tracking branch 'origin/paras/fetchCustomizations' into …
d3b81da
…paras/triggerCustomizationNotificationsOnIDE

Allow primary label to select radio button
da58a94

Base automatically changed from paras/fetchCustomizations to mainOctober 4, 2024 22:25

breedloj approved these changes Oct 4, 2024
View reviewed changes

pras0131 added 2 commits October 5, 2024 00:33

Merge branch 'main' into paras/triggerCustomizationNotificationsOnIDE
2cc45d4

Update CustomizationDialogContributionItem.java
5fc9c59
Add missing import missed during merge conflict

pras0131 merged commit 7e8933a into mainOct 4, 2024

pras0131 deleted the paras/triggerCustomizationNotificationsOnIDE branch October 4, 2024 22:42

laileni-aws mentioned this pull request Jul 16, 2026
fix(security): bump vulnerable dependencies to patched versions #568
Open

Parasand others added 3 commits October 1, 2024 14:36

Fetch customizations from LSP server
ec98e04

Merge branch 'main' into paras/fetchCustomizations
5e49228

Display IDE notification on customization change
3ba6cc7

pras0131 changed the base branch from main to paras/fetchCustomizationsOctober 2, 2024 13:45

Paras added 2 commits October 2, 2024 15:59

Only show notification & save preference if customization dropdown is…
6de13f6
… selected

Stacking multiple notifications vertically
617e53e

pras0131 changed the title ~~Trigger customization notifications on ide~~Trigger customization notifications on ide and stacking multiple notifications verticallyOct 3, 2024

Support for getObject,putObject in preference store and refactoring c…
5f2b1d1
…ustomization preference storage

pras0131 changed the title ~~Trigger customization notifications on ide and stacking multiple notifications vertically~~Trigger customization notifications on ide, stacking multiple notifications vertically and refactor/add support for more methods in PluginStoreOct 3, 2024

pras0131 requested a review from breedloj October 3, 2024 12:45

breedloj reviewed Oct 3, 2024
View reviewed changes

Paras added 3 commits October 4, 2024 12:18

Make combo dropdown to populate asynchronously
37bc88f

Merge branch 'paras/fetchCustomizations' of github.com:aws/amazon-q-e…
4d793b7
…clipse into paras/fetchCustomizations

Remove the synchronized block
013f639

pras0131 force-pushed the paras/triggerCustomizationNotificationsOnIDE branch from 6b587c6 to 013f639Compare October 4, 2024 13:41

Paras added 2 commits October 4, 2024 16:39

Merge remote-tracking branch 'origin/paras/fetchCustomizations' into …
d3b81da
…paras/triggerCustomizationNotificationsOnIDE

Allow primary label to select radio button
da58a94

Base automatically changed from paras/fetchCustomizations to mainOctober 4, 2024 22:25

breedloj approved these changes Oct 4, 2024
View reviewed changes

pras0131 added 2 commits October 5, 2024 00:33

Merge branch 'main' into paras/triggerCustomizationNotificationsOnIDE
2cc45d4

Update CustomizationDialogContributionItem.java
5fc9c59
Add missing import missed during merge conflict

pras0131 merged commit 7e8933a into mainOct 4, 2024

pras0131 deleted the paras/triggerCustomizationNotificationsOnIDE branch October 4, 2024 22:42

laileni-aws mentioned this pull request Jul 16, 2026
fix(security): bump vulnerable dependencies to patched versions #568
Open

Parasand others added 3 commits October 1, 2024 14:36

Fetch customizations from LSP server
ec98e04

Merge branch 'main' into paras/fetchCustomizations
5e49228

Display IDE notification on customization change
3ba6cc7

pras0131 changed the base branch from main to paras/fetchCustomizationsOctober 2, 2024 13:45

Paras added 2 commits October 2, 2024 15:59

Only show notification & save preference if customization dropdown is…
6de13f6
… selected

Stacking multiple notifications vertically
617e53e

pras0131 changed the title ~~Trigger customization notifications on ide~~Trigger customization notifications on ide and stacking multiple notifications verticallyOct 3, 2024

Support for getObject,putObject in preference store and refactoring c…
5f2b1d1
…ustomization preference storage

pras0131 changed the title ~~Trigger customization notifications on ide and stacking multiple notifications vertically~~Trigger customization notifications on ide, stacking multiple notifications vertically and refactor/add support for more methods in PluginStoreOct 3, 2024

pras0131 requested a review from breedloj October 3, 2024 12:45

breedloj reviewed Oct 3, 2024
View reviewed changes

Paras added 3 commits October 4, 2024 12:18

Make combo dropdown to populate asynchronously
37bc88f

Merge branch 'paras/fetchCustomizations' of github.com:aws/amazon-q-e…
4d793b7
…clipse into paras/fetchCustomizations

Remove the synchronized block
013f639

pras0131 force-pushed the paras/triggerCustomizationNotificationsOnIDE branch from 6b587c6 to 013f639Compare October 4, 2024 13:41

Paras added 2 commits October 4, 2024 16:39

Merge remote-tracking branch 'origin/paras/fetchCustomizations' into …
d3b81da
…paras/triggerCustomizationNotificationsOnIDE

Allow primary label to select radio button
da58a94

Base automatically changed from paras/fetchCustomizations to mainOctober 4, 2024 22:25

breedloj approved these changes Oct 4, 2024
View reviewed changes

pras0131 added 2 commits October 5, 2024 00:33

Merge branch 'main' into paras/triggerCustomizationNotificationsOnIDE
2cc45d4

Update CustomizationDialogContributionItem.java
5fc9c59
Add missing import missed during merge conflict

pras0131 merged commit 7e8933a into mainOct 4, 2024

pras0131 deleted the paras/triggerCustomizationNotificationsOnIDE branch October 4, 2024 22:42

laileni-aws mentioned this pull request Jul 16, 2026
fix(security): bump vulnerable dependencies to patched versions #568
Open

Parasand others added 3 commits October 1, 2024 14:36

Fetch customizations from LSP server
ec98e04

Merge branch 'main' into paras/fetchCustomizations
5e49228

Display IDE notification on customization change
3ba6cc7

pras0131 changed the base branch from main to paras/fetchCustomizationsOctober 2, 2024 13:45

Paras added 2 commits October 2, 2024 15:59

Only show notification & save preference if customization dropdown is…
6de13f6
… selected

Stacking multiple notifications vertically
617e53e

pras0131 changed the title ~~Trigger customization notifications on ide~~Trigger customization notifications on ide and stacking multiple notifications verticallyOct 3, 2024

Support for getObject,putObject in preference store and refactoring c…
5f2b1d1
…ustomization preference storage

pras0131 changed the title ~~Trigger customization notifications on ide and stacking multiple notifications vertically~~Trigger customization notifications on ide, stacking multiple notifications vertically and refactor/add support for more methods in PluginStoreOct 3, 2024

pras0131 requested a review from breedloj October 3, 2024 12:45

breedloj reviewed Oct 3, 2024
View reviewed changes

Paras added 3 commits October 4, 2024 12:18

Make combo dropdown to populate asynchronously
37bc88f

Merge branch 'paras/fetchCustomizations' of github.com:aws/amazon-q-e…
4d793b7
…clipse into paras/fetchCustomizations

Remove the synchronized block
013f639

pras0131 force-pushed the paras/triggerCustomizationNotificationsOnIDE branch from 6b587c6 to 013f639Compare October 4, 2024 13:41

Paras added 2 commits October 4, 2024 16:39

Merge remote-tracking branch 'origin/paras/fetchCustomizations' into …
d3b81da
…paras/triggerCustomizationNotificationsOnIDE

Allow primary label to select radio button
da58a94

Base automatically changed from paras/fetchCustomizations to mainOctober 4, 2024 22:25

breedloj approved these changes Oct 4, 2024
View reviewed changes

pras0131 added 2 commits October 5, 2024 00:33

Merge branch 'main' into paras/triggerCustomizationNotificationsOnIDE
2cc45d4

Update CustomizationDialogContributionItem.java
5fc9c59
Add missing import missed during merge conflict

pras0131 merged commit 7e8933a into mainOct 4, 2024

pras0131 deleted the paras/triggerCustomizationNotificationsOnIDE branch October 4, 2024 22:42

laileni-aws mentioned this pull request Jul 16, 2026
fix(security): bump vulnerable dependencies to patched versions #568
Open

Parasand others added 3 commits October 1, 2024 14:36

Fetch customizations from LSP server
ec98e04

Merge branch 'main' into paras/fetchCustomizations
5e49228

Display IDE notification on customization change
3ba6cc7

pras0131 changed the base branch from main to paras/fetchCustomizationsOctober 2, 2024 13:45

Paras added 2 commits October 2, 2024 15:59

Only show notification & save preference if customization dropdown is…
6de13f6
… selected

Stacking multiple notifications vertically
617e53e

pras0131 changed the title ~~Trigger customization notifications on ide~~Trigger customization notifications on ide and stacking multiple notifications verticallyOct 3, 2024

Support for getObject,putObject in preference store and refactoring c…
5f2b1d1
…ustomization preference storage

pras0131 changed the title ~~Trigger customization notifications on ide and stacking multiple notifications vertically~~Trigger customization notifications on ide, stacking multiple notifications vertically and refactor/add support for more methods in PluginStoreOct 3, 2024

pras0131 requested a review from breedloj October 3, 2024 12:45

breedloj reviewed Oct 3, 2024
View reviewed changes

Paras added 3 commits October 4, 2024 12:18

Make combo dropdown to populate asynchronously
37bc88f

Merge branch 'paras/fetchCustomizations' of github.com:aws/amazon-q-e…
4d793b7
…clipse into paras/fetchCustomizations

Remove the synchronized block
013f639

pras0131 force-pushed the paras/triggerCustomizationNotificationsOnIDE branch from 6b587c6 to 013f639Compare October 4, 2024 13:41

Paras added 2 commits October 4, 2024 16:39

Merge remote-tracking branch 'origin/paras/fetchCustomizations' into …
d3b81da
…paras/triggerCustomizationNotificationsOnIDE

Allow primary label to select radio button
da58a94

Base automatically changed from paras/fetchCustomizations to mainOctober 4, 2024 22:25

breedloj approved these changes Oct 4, 2024
View reviewed changes

pras0131 added 2 commits October 5, 2024 00:33

Merge branch 'main' into paras/triggerCustomizationNotificationsOnIDE
2cc45d4

Update CustomizationDialogContributionItem.java
5fc9c59
Add missing import missed during merge conflict

pras0131 merged commit 7e8933a into mainOct 4, 2024

pras0131 deleted the paras/triggerCustomizationNotificationsOnIDE branch October 4, 2024 22:42

laileni-aws mentioned this pull request Jul 16, 2026
fix(security): bump vulnerable dependencies to patched versions #568
Open

Parasand others added 3 commits October 1, 2024 14:36

Fetch customizations from LSP server
ec98e04

Merge branch 'main' into paras/fetchCustomizations
5e49228

Display IDE notification on customization change
3ba6cc7

pras0131 changed the base branch from main to paras/fetchCustomizationsOctober 2, 2024 13:45

Paras added 2 commits October 2, 2024 15:59

Only show notification & save preference if customization dropdown is…
6de13f6
… selected

Stacking multiple notifications vertically
617e53e

pras0131 changed the title ~~Trigger customization notifications on ide~~Trigger customization notifications on ide and stacking multiple notifications verticallyOct 3, 2024

Support for getObject,putObject in preference store and refactoring c…
5f2b1d1
…ustomization preference storage

pras0131 changed the title ~~Trigger customization notifications on ide and stacking multiple notifications vertically~~Trigger customization notifications on ide, stacking multiple notifications vertically and refactor/add support for more methods in PluginStoreOct 3, 2024

pras0131 requested a review from breedloj October 3, 2024 12:45

breedloj reviewed Oct 3, 2024
View reviewed changes

Paras added 3 commits October 4, 2024 12:18

Make combo dropdown to populate asynchronously
37bc88f

Merge branch 'paras/fetchCustomizations' of github.com:aws/amazon-q-e…
4d793b7
…clipse into paras/fetchCustomizations

Remove the synchronized block
013f639

pras0131 force-pushed the paras/triggerCustomizationNotificationsOnIDE branch from 6b587c6 to 013f639Compare October 4, 2024 13:41

Paras added 2 commits October 4, 2024 16:39

Merge remote-tracking branch 'origin/paras/fetchCustomizations' into …
d3b81da
…paras/triggerCustomizationNotificationsOnIDE

Allow primary label to select radio button
da58a94

Base automatically changed from paras/fetchCustomizations to mainOctober 4, 2024 22:25

breedloj approved these changes Oct 4, 2024
View reviewed changes

pras0131 added 2 commits October 5, 2024 00:33

Merge branch 'main' into paras/triggerCustomizationNotificationsOnIDE
2cc45d4

Update CustomizationDialogContributionItem.java
5fc9c59
Add missing import missed during merge conflict

pras0131 merged commit 7e8933a into mainOct 4, 2024

pras0131 deleted the paras/triggerCustomizationNotificationsOnIDE branch October 4, 2024 22:42

laileni-aws mentioned this pull request Jul 16, 2026
fix(security): bump vulnerable dependencies to patched versions #568
Open

Parasand others added 3 commits October 1, 2024 14:36

Fetch customizations from LSP server
ec98e04

Merge branch 'main' into paras/fetchCustomizations
5e49228

Display IDE notification on customization change
3ba6cc7

pras0131 changed the base branch from main to paras/fetchCustomizationsOctober 2, 2024 13:45

Paras added 2 commits October 2, 2024 15:59

Only show notification & save preference if customization dropdown is…
6de13f6
… selected

Stacking multiple notifications vertically
617e53e

pras0131 changed the title ~~Trigger customization notifications on ide~~Trigger customization notifications on ide and stacking multiple notifications verticallyOct 3, 2024

Support for getObject,putObject in preference store and refactoring c…
5f2b1d1
…ustomization preference storage

pras0131 changed the title ~~Trigger customization notifications on ide and stacking multiple notifications vertically~~Trigger customization notifications on ide, stacking multiple notifications vertically and refactor/add support for more methods in PluginStoreOct 3, 2024

pras0131 requested a review from breedloj October 3, 2024 12:45

breedloj reviewed Oct 3, 2024
View reviewed changes

Paras added 3 commits October 4, 2024 12:18

Make combo dropdown to populate asynchronously
37bc88f

Merge branch 'paras/fetchCustomizations' of github.com:aws/amazon-q-e…
4d793b7
…clipse into paras/fetchCustomizations

Remove the synchronized block
013f639

pras0131 force-pushed the paras/triggerCustomizationNotificationsOnIDE branch from 6b587c6 to 013f639Compare October 4, 2024 13:41

Paras added 2 commits October 4, 2024 16:39

Merge remote-tracking branch 'origin/paras/fetchCustomizations' into …
d3b81da
…paras/triggerCustomizationNotificationsOnIDE

Allow primary label to select radio button
da58a94

Base automatically changed from paras/fetchCustomizations to mainOctober 4, 2024 22:25

breedloj approved these changes Oct 4, 2024
View reviewed changes

pras0131 added 2 commits October 5, 2024 00:33

Merge branch 'main' into paras/triggerCustomizationNotificationsOnIDE
2cc45d4

Update CustomizationDialogContributionItem.java
5fc9c59
Add missing import missed during merge conflict

pras0131 merged commit 7e8933a into mainOct 4, 2024

pras0131 deleted the paras/triggerCustomizationNotificationsOnIDE branch October 4, 2024 22:42

laileni-aws mentioned this pull request Jul 16, 2026
fix(security): bump vulnerable dependencies to patched versions #568
Open

Parasand others added 3 commits October 1, 2024 14:36

Fetch customizations from LSP server
ec98e04

Merge branch 'main' into paras/fetchCustomizations
5e49228

Display IDE notification on customization change
3ba6cc7

pras0131 changed the base branch from main to paras/fetchCustomizationsOctober 2, 2024 13:45

Paras added 2 commits October 2, 2024 15:59

Only show notification & save preference if customization dropdown is…
6de13f6
… selected

Stacking multiple notifications vertically
617e53e

pras0131 changed the title ~~Trigger customization notifications on ide~~Trigger customization notifications on ide and stacking multiple notifications verticallyOct 3, 2024

Support for getObject,putObject in preference store and refactoring c…
5f2b1d1
…ustomization preference storage

pras0131 changed the title ~~Trigger customization notifications on ide and stacking multiple notifications vertically~~Trigger customization notifications on ide, stacking multiple notifications vertically and refactor/add support for more methods in PluginStoreOct 3, 2024

pras0131 requested a review from breedloj October 3, 2024 12:45

breedloj reviewed Oct 3, 2024
View reviewed changes

Paras added 3 commits October 4, 2024 12:18

Make combo dropdown to populate asynchronously
37bc88f

Merge branch 'paras/fetchCustomizations' of github.com:aws/amazon-q-e…
4d793b7
…clipse into paras/fetchCustomizations

Remove the synchronized block
013f639

pras0131 force-pushed the paras/triggerCustomizationNotificationsOnIDE branch from 6b587c6 to 013f639Compare October 4, 2024 13:41

Paras added 2 commits October 4, 2024 16:39

Merge remote-tracking branch 'origin/paras/fetchCustomizations' into …
d3b81da
…paras/triggerCustomizationNotificationsOnIDE

Allow primary label to select radio button
da58a94

Base automatically changed from paras/fetchCustomizations to mainOctober 4, 2024 22:25

breedloj approved these changes Oct 4, 2024
View reviewed changes

pras0131 added 2 commits October 5, 2024 00:33

Merge branch 'main' into paras/triggerCustomizationNotificationsOnIDE
2cc45d4

Update CustomizationDialogContributionItem.java
5fc9c59
Add missing import missed during merge conflict

pras0131 merged commit 7e8933a into mainOct 4, 2024

pras0131 deleted the paras/triggerCustomizationNotificationsOnIDE branch October 4, 2024 22:42

laileni-aws mentioned this pull request Jul 16, 2026
fix(security): bump vulnerable dependencies to patched versions #568
Open

Uh oh!

Conversation

pras0131 commented Oct 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

pras0131 commented Oct 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

pras0131 commented Oct 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

pras0131 commented Oct 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pras0131 commented Oct 2, 2024•
edited
Loading

pras0131 commented Oct 2, 2024•
edited
Loading

pras0131 commented Oct 2, 2024•
edited
Loading

pras0131 commented Oct 2, 2024•
edited
Loading

pras0131 commented Oct 2, 2024•
edited
Loading