adt support by XiaoxuanLu · Pull Request #487 · Amazon-Q-Developer/amazon-q-eclipse

XiaoxuanLu · 2025-07-24T23:01:11Z

Problems

The Amazon Q Eclipse plugin lacked proper support for ABAP files when used with the ADT (ABAP Development Tools) plugin. ABAP developers could not access inline completion suggestions or benefit from active file functionality that was available for other programming languages. The plugin was unable to recognize ABAP workspace structure and files, preventing Amazon Q features from working in ABAP development environments.

Solutions

This PR enables ABAP support by registering a new editor to handle ABAP files in the active file system and utilizing temporary folder management to make ABAP files accessible to Q chat functionality. The solution registers common ABAP files into the workspace so clients can utilize inline suggestions for ABAP development. This allows ABAP files to display the Q button for inline suggestions and be properly recognized by the Amazon Q system.

Further work

Future improvements should include

Eclipse needs to send didWorkspaceFolderChangeEvent to language server
refactoring the editor listener architecture to support broader editor types beyond text editors, which would reduce code complexity and provide more comprehensive editor support across different file types and plugins.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…p files in adt plugin:

shruti0085 · 2025-07-31T23:38:38Z

+ Object part = partRef.getPart(false);
+ if (part instanceof ITextEditor) {
+ handleEditorChange((ITextEditor) part);
+ } else if (part instanceof IEditorPart) {


isnt ItextEditor as IEditorPart as well?

shruti0085 · 2025-08-05T18:39:30Z

 } else if (editorInput instanceof IFileEditorInput fileEditorInput) {
- return fileEditorInput.getFile().getRawLocation().toOSString();
+ var file = fileEditorInput.getFile();
+ if (file.getRawLocation() == null && AbapUtil.isAbapFile(file)) {


Also add a comment indicating that special handling is needed for abap files because we are referencing the cached location it is stored with ADT plugins.
Please add this.

shruti0085 · 2025-08-05T18:40:35Z

+ }
+
+ @Test
+ void isAdtEditorWithSapPackagePrefixReturnsTrue() {


this test can be removed

shruti0085 · 2025-08-07T18:39:23Z

 private void setupPlatformMock() {
+ setupPlatformMockWithPaths(
+ "file:///workspace/.metadata/.plugins/org.eclipse.core.resources.semantic/.cache/test/path",
+ "/workspace/.metadata/.plugins/org.eclipse.core.resources.semantic",


shouldnt this be c:/users instead?

will go back to tests later

Merges feature branch containing improvements for ADT ABAP support into main. Relevant PRs * adt support #487 * Support updating remote when ABAP files are edited #495 * handle the null case for contentType in adt plugin environment #496 * Fix: Handle removing paint listeners with ADT viewer and allow multiline text in inline chat #500

XiaoxuanLu · 2025-07-24T23:01:11Z

Problems

The Amazon Q Eclipse plugin lacked proper support for ABAP files when used with the ADT (ABAP Development Tools) plugin. ABAP developers could not access inline completion suggestions or benefit from active file functionality that was available for other programming languages. The plugin was unable to recognize ABAP workspace structure and files, preventing Amazon Q features from working in ABAP development environments.

Solutions

This PR enables ABAP support by registering a new editor to handle ABAP files in the active file system and utilizing temporary folder management to make ABAP files accessible to Q chat functionality. The solution registers common ABAP files into the workspace so clients can utilize inline suggestions for ABAP development. This allows ABAP files to display the Q button for inline suggestions and be properly recognized by the Amazon Q system.

Further work

Future improvements should include

Eclipse needs to send didWorkspaceFolderChangeEvent to language server
refactoring the editor listener architecture to support broader editor types beyond text editors, which would reduce code complexity and provide more comprehensive editor support across different file types and plugins.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…p files in adt plugin:

shruti0085 · 2025-07-31T23:38:38Z

+ Object part = partRef.getPart(false);
+ if (part instanceof ITextEditor) {
+ handleEditorChange((ITextEditor) part);
+ } else if (part instanceof IEditorPart) {


isnt ItextEditor as IEditorPart as well?

shruti0085 · 2025-08-05T18:39:30Z

 } else if (editorInput instanceof IFileEditorInput fileEditorInput) {
- return fileEditorInput.getFile().getRawLocation().toOSString();
+ var file = fileEditorInput.getFile();
+ if (file.getRawLocation() == null && AbapUtil.isAbapFile(file)) {


Also add a comment indicating that special handling is needed for abap files because we are referencing the cached location it is stored with ADT plugins.
Please add this.

shruti0085 · 2025-08-05T18:40:35Z

+ }
+
+ @Test
+ void isAdtEditorWithSapPackagePrefixReturnsTrue() {


this test can be removed

shruti0085 · 2025-08-07T18:39:23Z

 private void setupPlatformMock() {
+ setupPlatformMockWithPaths(
+ "file:///workspace/.metadata/.plugins/org.eclipse.core.resources.semantic/.cache/test/path",
+ "/workspace/.metadata/.plugins/org.eclipse.core.resources.semantic",


shouldnt this be c:/users instead?

will go back to tests later

Merges feature branch containing improvements for ADT ABAP support into main. Relevant PRs * adt support #487 * Support updating remote when ABAP files are edited #495 * handle the null case for contentType in adt plugin environment #496 * Fix: Handle removing paint listeners with ADT viewer and allow multiline text in inline chat #500

XiaoxuanLu · 2025-07-24T23:01:11Z

Problems

The Amazon Q Eclipse plugin lacked proper support for ABAP files when used with the ADT (ABAP Development Tools) plugin. ABAP developers could not access inline completion suggestions or benefit from active file functionality that was available for other programming languages. The plugin was unable to recognize ABAP workspace structure and files, preventing Amazon Q features from working in ABAP development environments.

Solutions

This PR enables ABAP support by registering a new editor to handle ABAP files in the active file system and utilizing temporary folder management to make ABAP files accessible to Q chat functionality. The solution registers common ABAP files into the workspace so clients can utilize inline suggestions for ABAP development. This allows ABAP files to display the Q button for inline suggestions and be properly recognized by the Amazon Q system.

Further work

Future improvements should include

Eclipse needs to send didWorkspaceFolderChangeEvent to language server
refactoring the editor listener architecture to support broader editor types beyond text editors, which would reduce code complexity and provide more comprehensive editor support across different file types and plugins.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…p files in adt plugin:

shruti0085 · 2025-07-31T23:38:38Z

+ Object part = partRef.getPart(false);
+ if (part instanceof ITextEditor) {
+ handleEditorChange((ITextEditor) part);
+ } else if (part instanceof IEditorPart) {


isnt ItextEditor as IEditorPart as well?

shruti0085 · 2025-08-05T18:39:30Z

 } else if (editorInput instanceof IFileEditorInput fileEditorInput) {
- return fileEditorInput.getFile().getRawLocation().toOSString();
+ var file = fileEditorInput.getFile();
+ if (file.getRawLocation() == null && AbapUtil.isAbapFile(file)) {


Also add a comment indicating that special handling is needed for abap files because we are referencing the cached location it is stored with ADT plugins.
Please add this.

shruti0085 · 2025-08-05T18:40:35Z

+ }
+
+ @Test
+ void isAdtEditorWithSapPackagePrefixReturnsTrue() {


this test can be removed

shruti0085 · 2025-08-07T18:39:23Z

 private void setupPlatformMock() {
+ setupPlatformMockWithPaths(
+ "file:///workspace/.metadata/.plugins/org.eclipse.core.resources.semantic/.cache/test/path",
+ "/workspace/.metadata/.plugins/org.eclipse.core.resources.semantic",


shouldnt this be c:/users instead?

will go back to tests later

Merges feature branch containing improvements for ADT ABAP support into main. Relevant PRs * adt support #487 * Support updating remote when ABAP files are edited #495 * handle the null case for contentType in adt plugin environment #496 * Fix: Handle removing paint listeners with ADT viewer and allow multiline text in inline chat #500

XiaoxuanLu · 2025-07-24T23:01:11Z

Problems

The Amazon Q Eclipse plugin lacked proper support for ABAP files when used with the ADT (ABAP Development Tools) plugin. ABAP developers could not access inline completion suggestions or benefit from active file functionality that was available for other programming languages. The plugin was unable to recognize ABAP workspace structure and files, preventing Amazon Q features from working in ABAP development environments.

Solutions

This PR enables ABAP support by registering a new editor to handle ABAP files in the active file system and utilizing temporary folder management to make ABAP files accessible to Q chat functionality. The solution registers common ABAP files into the workspace so clients can utilize inline suggestions for ABAP development. This allows ABAP files to display the Q button for inline suggestions and be properly recognized by the Amazon Q system.

Further work

Future improvements should include

Eclipse needs to send didWorkspaceFolderChangeEvent to language server
refactoring the editor listener architecture to support broader editor types beyond text editors, which would reduce code complexity and provide more comprehensive editor support across different file types and plugins.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…p files in adt plugin:

shruti0085 · 2025-07-31T23:38:38Z

+ Object part = partRef.getPart(false);
+ if (part instanceof ITextEditor) {
+ handleEditorChange((ITextEditor) part);
+ } else if (part instanceof IEditorPart) {


isnt ItextEditor as IEditorPart as well?

shruti0085 · 2025-08-05T18:39:30Z

 } else if (editorInput instanceof IFileEditorInput fileEditorInput) {
- return fileEditorInput.getFile().getRawLocation().toOSString();
+ var file = fileEditorInput.getFile();
+ if (file.getRawLocation() == null && AbapUtil.isAbapFile(file)) {


Also add a comment indicating that special handling is needed for abap files because we are referencing the cached location it is stored with ADT plugins.
Please add this.

shruti0085 · 2025-08-05T18:40:35Z

+ }
+
+ @Test
+ void isAdtEditorWithSapPackagePrefixReturnsTrue() {


this test can be removed

shruti0085 · 2025-08-07T18:39:23Z

 private void setupPlatformMock() {
+ setupPlatformMockWithPaths(
+ "file:///workspace/.metadata/.plugins/org.eclipse.core.resources.semantic/.cache/test/path",
+ "/workspace/.metadata/.plugins/org.eclipse.core.resources.semantic",


shouldnt this be c:/users instead?

will go back to tests later

Merges feature branch containing improvements for ADT ABAP support into main. Relevant PRs * adt support #487 * Support updating remote when ABAP files are edited #495 * handle the null case for contentType in adt plugin environment #496 * Fix: Handle removing paint listeners with ADT viewer and allow multiline text in inline chat #500

XiaoxuanLu · 2025-07-24T23:01:11Z

Problems

The Amazon Q Eclipse plugin lacked proper support for ABAP files when used with the ADT (ABAP Development Tools) plugin. ABAP developers could not access inline completion suggestions or benefit from active file functionality that was available for other programming languages. The plugin was unable to recognize ABAP workspace structure and files, preventing Amazon Q features from working in ABAP development environments.

Solutions

This PR enables ABAP support by registering a new editor to handle ABAP files in the active file system and utilizing temporary folder management to make ABAP files accessible to Q chat functionality. The solution registers common ABAP files into the workspace so clients can utilize inline suggestions for ABAP development. This allows ABAP files to display the Q button for inline suggestions and be properly recognized by the Amazon Q system.

Further work

Future improvements should include

Eclipse needs to send didWorkspaceFolderChangeEvent to language server
refactoring the editor listener architecture to support broader editor types beyond text editors, which would reduce code complexity and provide more comprehensive editor support across different file types and plugins.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…p files in adt plugin:

shruti0085 · 2025-07-31T23:38:38Z

+ Object part = partRef.getPart(false);
+ if (part instanceof ITextEditor) {
+ handleEditorChange((ITextEditor) part);
+ } else if (part instanceof IEditorPart) {


isnt ItextEditor as IEditorPart as well?

shruti0085 · 2025-08-05T18:39:30Z

 } else if (editorInput instanceof IFileEditorInput fileEditorInput) {
- return fileEditorInput.getFile().getRawLocation().toOSString();
+ var file = fileEditorInput.getFile();
+ if (file.getRawLocation() == null && AbapUtil.isAbapFile(file)) {


Also add a comment indicating that special handling is needed for abap files because we are referencing the cached location it is stored with ADT plugins.
Please add this.

shruti0085 · 2025-08-05T18:40:35Z

+ }
+
+ @Test
+ void isAdtEditorWithSapPackagePrefixReturnsTrue() {


this test can be removed

shruti0085 · 2025-08-07T18:39:23Z

 private void setupPlatformMock() {
+ setupPlatformMockWithPaths(
+ "file:///workspace/.metadata/.plugins/org.eclipse.core.resources.semantic/.cache/test/path",
+ "/workspace/.metadata/.plugins/org.eclipse.core.resources.semantic",


shouldnt this be c:/users instead?

will go back to tests later

Merges feature branch containing improvements for ADT ABAP support into main. Relevant PRs * adt support #487 * Support updating remote when ABAP files are edited #495 * handle the null case for contentType in adt plugin environment #496 * Fix: Handle removing paint listeners with ADT viewer and allow multiline text in inline chat #500

XiaoxuanLu · 2025-07-24T23:01:11Z

Problems

The Amazon Q Eclipse plugin lacked proper support for ABAP files when used with the ADT (ABAP Development Tools) plugin. ABAP developers could not access inline completion suggestions or benefit from active file functionality that was available for other programming languages. The plugin was unable to recognize ABAP workspace structure and files, preventing Amazon Q features from working in ABAP development environments.

Solutions

This PR enables ABAP support by registering a new editor to handle ABAP files in the active file system and utilizing temporary folder management to make ABAP files accessible to Q chat functionality. The solution registers common ABAP files into the workspace so clients can utilize inline suggestions for ABAP development. This allows ABAP files to display the Q button for inline suggestions and be properly recognized by the Amazon Q system.

Further work

Future improvements should include

Eclipse needs to send didWorkspaceFolderChangeEvent to language server
refactoring the editor listener architecture to support broader editor types beyond text editors, which would reduce code complexity and provide more comprehensive editor support across different file types and plugins.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…p files in adt plugin:

shruti0085 · 2025-07-31T23:38:38Z

+ Object part = partRef.getPart(false);
+ if (part instanceof ITextEditor) {
+ handleEditorChange((ITextEditor) part);
+ } else if (part instanceof IEditorPart) {


isnt ItextEditor as IEditorPart as well?

shruti0085 · 2025-08-05T18:39:30Z

 } else if (editorInput instanceof IFileEditorInput fileEditorInput) {
- return fileEditorInput.getFile().getRawLocation().toOSString();
+ var file = fileEditorInput.getFile();
+ if (file.getRawLocation() == null && AbapUtil.isAbapFile(file)) {


Also add a comment indicating that special handling is needed for abap files because we are referencing the cached location it is stored with ADT plugins.
Please add this.

shruti0085 · 2025-08-05T18:40:35Z

+ }
+
+ @Test
+ void isAdtEditorWithSapPackagePrefixReturnsTrue() {


this test can be removed

shruti0085 · 2025-08-07T18:39:23Z

 private void setupPlatformMock() {
+ setupPlatformMockWithPaths(
+ "file:///workspace/.metadata/.plugins/org.eclipse.core.resources.semantic/.cache/test/path",
+ "/workspace/.metadata/.plugins/org.eclipse.core.resources.semantic",


shouldnt this be c:/users instead?

will go back to tests later

Merges feature branch containing improvements for ADT ABAP support into main. Relevant PRs * adt support #487 * Support updating remote when ABAP files are edited #495 * handle the null case for contentType in adt plugin environment #496 * Fix: Handle removing paint listeners with ADT viewer and allow multiline text in inline chat #500

XiaoxuanLu · 2025-07-24T23:01:11Z

Problems

The Amazon Q Eclipse plugin lacked proper support for ABAP files when used with the ADT (ABAP Development Tools) plugin. ABAP developers could not access inline completion suggestions or benefit from active file functionality that was available for other programming languages. The plugin was unable to recognize ABAP workspace structure and files, preventing Amazon Q features from working in ABAP development environments.

Solutions

This PR enables ABAP support by registering a new editor to handle ABAP files in the active file system and utilizing temporary folder management to make ABAP files accessible to Q chat functionality. The solution registers common ABAP files into the workspace so clients can utilize inline suggestions for ABAP development. This allows ABAP files to display the Q button for inline suggestions and be properly recognized by the Amazon Q system.

Further work

Future improvements should include

Eclipse needs to send didWorkspaceFolderChangeEvent to language server
refactoring the editor listener architecture to support broader editor types beyond text editors, which would reduce code complexity and provide more comprehensive editor support across different file types and plugins.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…p files in adt plugin:

shruti0085 · 2025-07-31T23:38:38Z

+ Object part = partRef.getPart(false);
+ if (part instanceof ITextEditor) {
+ handleEditorChange((ITextEditor) part);
+ } else if (part instanceof IEditorPart) {


isnt ItextEditor as IEditorPart as well?

shruti0085 · 2025-08-05T18:39:30Z

 } else if (editorInput instanceof IFileEditorInput fileEditorInput) {
- return fileEditorInput.getFile().getRawLocation().toOSString();
+ var file = fileEditorInput.getFile();
+ if (file.getRawLocation() == null && AbapUtil.isAbapFile(file)) {


Also add a comment indicating that special handling is needed for abap files because we are referencing the cached location it is stored with ADT plugins.
Please add this.

shruti0085 · 2025-08-05T18:40:35Z

+ }
+
+ @Test
+ void isAdtEditorWithSapPackagePrefixReturnsTrue() {


this test can be removed

shruti0085 · 2025-08-07T18:39:23Z

 private void setupPlatformMock() {
+ setupPlatformMockWithPaths(
+ "file:///workspace/.metadata/.plugins/org.eclipse.core.resources.semantic/.cache/test/path",
+ "/workspace/.metadata/.plugins/org.eclipse.core.resources.semantic",


shouldnt this be c:/users instead?

will go back to tests later

Merges feature branch containing improvements for ADT ABAP support into main. Relevant PRs * adt support #487 * Support updating remote when ABAP files are edited #495 * handle the null case for contentType in adt plugin environment #496 * Fix: Handle removing paint listeners with ADT viewer and allow multiline text in inline chat #500

XiaoxuanLu · 2025-07-24T23:01:11Z

Problems

The Amazon Q Eclipse plugin lacked proper support for ABAP files when used with the ADT (ABAP Development Tools) plugin. ABAP developers could not access inline completion suggestions or benefit from active file functionality that was available for other programming languages. The plugin was unable to recognize ABAP workspace structure and files, preventing Amazon Q features from working in ABAP development environments.

Solutions

This PR enables ABAP support by registering a new editor to handle ABAP files in the active file system and utilizing temporary folder management to make ABAP files accessible to Q chat functionality. The solution registers common ABAP files into the workspace so clients can utilize inline suggestions for ABAP development. This allows ABAP files to display the Q button for inline suggestions and be properly recognized by the Amazon Q system.

Further work

Future improvements should include

Eclipse needs to send didWorkspaceFolderChangeEvent to language server
refactoring the editor listener architecture to support broader editor types beyond text editors, which would reduce code complexity and provide more comprehensive editor support across different file types and plugins.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…p files in adt plugin:

shruti0085 · 2025-07-31T23:38:38Z

+ Object part = partRef.getPart(false);
+ if (part instanceof ITextEditor) {
+ handleEditorChange((ITextEditor) part);
+ } else if (part instanceof IEditorPart) {


isnt ItextEditor as IEditorPart as well?

shruti0085 · 2025-08-05T18:39:30Z

 } else if (editorInput instanceof IFileEditorInput fileEditorInput) {
- return fileEditorInput.getFile().getRawLocation().toOSString();
+ var file = fileEditorInput.getFile();
+ if (file.getRawLocation() == null && AbapUtil.isAbapFile(file)) {


Also add a comment indicating that special handling is needed for abap files because we are referencing the cached location it is stored with ADT plugins.
Please add this.

shruti0085 · 2025-08-05T18:40:35Z

+ }
+
+ @Test
+ void isAdtEditorWithSapPackagePrefixReturnsTrue() {


this test can be removed

shruti0085 · 2025-08-07T18:39:23Z

 private void setupPlatformMock() {
+ setupPlatformMockWithPaths(
+ "file:///workspace/.metadata/.plugins/org.eclipse.core.resources.semantic/.cache/test/path",
+ "/workspace/.metadata/.plugins/org.eclipse.core.resources.semantic",


shouldnt this be c:/users instead?

will go back to tests later

Merges feature branch containing improvements for ADT ABAP support into main. Relevant PRs * adt support #487 * Support updating remote when ABAP files are edited #495 * handle the null case for contentType in adt plugin environment #496 * Fix: Handle removing paint listeners with ADT viewer and allow multiline text in inline chat #500

XiaoxuanLuand others added 4 commits July 24, 2025 13:19

register all known abap types in plugin.xml to let clients see Q button
ce415e9

Update plugin.xml to match the format
d6ab17b

send abap workspace and let inline completion/avtivefile work for aba…
2d85a68
…p files in adt plugin:

change the checkstyle
634fabb

XiaoxuanLu requested a review from shruti0085 July 25, 2025 21:47

add test for abapUtil
a7f5e54

XiaoxuanLu changed the base branch from main to feature/adt-supportJuly 28, 2025 18:17

fix the checkstyle
d572a8b

shruti0085 reviewed Jul 31, 2025
View reviewed changes

XiaoxuanLu added 9 commits August 1, 2025 11:54

register function module files
02141bd

refactor code based on comments and add function module support
e39c53f

fix the abapUtil test
8ee19cc

local test for flare
78b7e2c

remove dependency on abap extension
623db43

fix the test
a00852c

Merge branch 'main' into xiaoluk/adt-support
a19a8f3

fix the semanticCachePath that do not work for mac
2d62710

fix unused import
39d65af

shruti0085 reviewed Aug 5, 2025
View reviewed changes

XiaoxuanLu added 2 commits August 5, 2025 11:57

Merge branch 'feature/adt-support' into xiaoluk/adt-support
d471cef

add null handling and reduce code duplication
b1fa5e7

shruti0085 reviewed Aug 7, 2025
View reviewed changes

shruti0085 approved these changes Aug 7, 2025
View reviewed changes

XiaoxuanLu merged commit 3a0767a into feature/adt-supportAug 7, 2025
1 check passed

XiaoxuanLu deleted the xiaoluk/adt-support branch August 7, 2025 19:46

shruti0085 mentioned this pull request Aug 13, 2025
Merge ADT support into main #501
Merged

XiaoxuanLuand others added 4 commits July 24, 2025 13:19

register all known abap types in plugin.xml to let clients see Q button
ce415e9

Update plugin.xml to match the format
d6ab17b

send abap workspace and let inline completion/avtivefile work for aba…
2d85a68
…p files in adt plugin:

change the checkstyle
634fabb

XiaoxuanLu requested a review from shruti0085 July 25, 2025 21:47

add test for abapUtil
a7f5e54

XiaoxuanLu changed the base branch from main to feature/adt-supportJuly 28, 2025 18:17

fix the checkstyle
d572a8b

shruti0085 reviewed Jul 31, 2025
View reviewed changes

XiaoxuanLu added 9 commits August 1, 2025 11:54

register function module files
02141bd

refactor code based on comments and add function module support
e39c53f

fix the abapUtil test
8ee19cc

local test for flare
78b7e2c

remove dependency on abap extension
623db43

fix the test
a00852c

Merge branch 'main' into xiaoluk/adt-support
a19a8f3

fix the semanticCachePath that do not work for mac
2d62710

fix unused import
39d65af

shruti0085 reviewed Aug 5, 2025
View reviewed changes

XiaoxuanLu added 2 commits August 5, 2025 11:57

Merge branch 'feature/adt-support' into xiaoluk/adt-support
d471cef

add null handling and reduce code duplication
b1fa5e7

shruti0085 reviewed Aug 7, 2025
View reviewed changes

shruti0085 approved these changes Aug 7, 2025
View reviewed changes

XiaoxuanLu merged commit 3a0767a into feature/adt-supportAug 7, 2025
1 check passed

XiaoxuanLu deleted the xiaoluk/adt-support branch August 7, 2025 19:46

shruti0085 mentioned this pull request Aug 13, 2025
Merge ADT support into main #501
Merged

XiaoxuanLuand others added 4 commits July 24, 2025 13:19

register all known abap types in plugin.xml to let clients see Q button
ce415e9

Update plugin.xml to match the format
d6ab17b

send abap workspace and let inline completion/avtivefile work for aba…
2d85a68
…p files in adt plugin:

change the checkstyle
634fabb

XiaoxuanLu requested a review from shruti0085 July 25, 2025 21:47

add test for abapUtil
a7f5e54

XiaoxuanLu changed the base branch from main to feature/adt-supportJuly 28, 2025 18:17

fix the checkstyle
d572a8b

shruti0085 reviewed Jul 31, 2025
View reviewed changes

XiaoxuanLu added 9 commits August 1, 2025 11:54

register function module files
02141bd

refactor code based on comments and add function module support
e39c53f

fix the abapUtil test
8ee19cc

local test for flare
78b7e2c

remove dependency on abap extension
623db43

fix the test
a00852c

Merge branch 'main' into xiaoluk/adt-support
a19a8f3

fix the semanticCachePath that do not work for mac
2d62710

fix unused import
39d65af

shruti0085 reviewed Aug 5, 2025
View reviewed changes

XiaoxuanLu added 2 commits August 5, 2025 11:57

Merge branch 'feature/adt-support' into xiaoluk/adt-support
d471cef

add null handling and reduce code duplication
b1fa5e7

shruti0085 reviewed Aug 7, 2025
View reviewed changes

shruti0085 approved these changes Aug 7, 2025
View reviewed changes

XiaoxuanLu merged commit 3a0767a into feature/adt-supportAug 7, 2025
1 check passed

XiaoxuanLu deleted the xiaoluk/adt-support branch August 7, 2025 19:46

shruti0085 mentioned this pull request Aug 13, 2025
Merge ADT support into main #501
Merged

XiaoxuanLuand others added 4 commits July 24, 2025 13:19

register all known abap types in plugin.xml to let clients see Q button
ce415e9

Update plugin.xml to match the format
d6ab17b

send abap workspace and let inline completion/avtivefile work for aba…
2d85a68
…p files in adt plugin:

change the checkstyle
634fabb

XiaoxuanLu requested a review from shruti0085 July 25, 2025 21:47

add test for abapUtil
a7f5e54

XiaoxuanLu changed the base branch from main to feature/adt-supportJuly 28, 2025 18:17

fix the checkstyle
d572a8b

shruti0085 reviewed Jul 31, 2025
View reviewed changes

XiaoxuanLu added 9 commits August 1, 2025 11:54

register function module files
02141bd

refactor code based on comments and add function module support
e39c53f

fix the abapUtil test
8ee19cc

local test for flare
78b7e2c

remove dependency on abap extension
623db43

fix the test
a00852c

Merge branch 'main' into xiaoluk/adt-support
a19a8f3

fix the semanticCachePath that do not work for mac
2d62710

fix unused import
39d65af

shruti0085 reviewed Aug 5, 2025
View reviewed changes

XiaoxuanLu added 2 commits August 5, 2025 11:57

Merge branch 'feature/adt-support' into xiaoluk/adt-support
d471cef

add null handling and reduce code duplication
b1fa5e7

shruti0085 reviewed Aug 7, 2025
View reviewed changes

shruti0085 approved these changes Aug 7, 2025
View reviewed changes

XiaoxuanLu merged commit 3a0767a into feature/adt-supportAug 7, 2025
1 check passed

XiaoxuanLu deleted the xiaoluk/adt-support branch August 7, 2025 19:46

shruti0085 mentioned this pull request Aug 13, 2025
Merge ADT support into main #501
Merged

XiaoxuanLuand others added 4 commits July 24, 2025 13:19

register all known abap types in plugin.xml to let clients see Q button
ce415e9

Update plugin.xml to match the format
d6ab17b

send abap workspace and let inline completion/avtivefile work for aba…
2d85a68
…p files in adt plugin:

change the checkstyle
634fabb

XiaoxuanLu requested a review from shruti0085 July 25, 2025 21:47

add test for abapUtil
a7f5e54

XiaoxuanLu changed the base branch from main to feature/adt-supportJuly 28, 2025 18:17

fix the checkstyle
d572a8b

shruti0085 reviewed Jul 31, 2025
View reviewed changes

XiaoxuanLu added 9 commits August 1, 2025 11:54

register function module files
02141bd

refactor code based on comments and add function module support
e39c53f

fix the abapUtil test
8ee19cc

local test for flare
78b7e2c

remove dependency on abap extension
623db43

fix the test
a00852c

Merge branch 'main' into xiaoluk/adt-support
a19a8f3

fix the semanticCachePath that do not work for mac
2d62710

fix unused import
39d65af

shruti0085 reviewed Aug 5, 2025
View reviewed changes

XiaoxuanLu added 2 commits August 5, 2025 11:57

Merge branch 'feature/adt-support' into xiaoluk/adt-support
d471cef

add null handling and reduce code duplication
b1fa5e7

shruti0085 reviewed Aug 7, 2025
View reviewed changes

shruti0085 approved these changes Aug 7, 2025
View reviewed changes

XiaoxuanLu merged commit 3a0767a into feature/adt-supportAug 7, 2025
1 check passed

XiaoxuanLu deleted the xiaoluk/adt-support branch August 7, 2025 19:46

shruti0085 mentioned this pull request Aug 13, 2025
Merge ADT support into main #501
Merged

XiaoxuanLuand others added 4 commits July 24, 2025 13:19

register all known abap types in plugin.xml to let clients see Q button
ce415e9

Update plugin.xml to match the format
d6ab17b

send abap workspace and let inline completion/avtivefile work for aba…
2d85a68
…p files in adt plugin:

change the checkstyle
634fabb

XiaoxuanLu requested a review from shruti0085 July 25, 2025 21:47

add test for abapUtil
a7f5e54

XiaoxuanLu changed the base branch from main to feature/adt-supportJuly 28, 2025 18:17

fix the checkstyle
d572a8b

shruti0085 reviewed Jul 31, 2025
View reviewed changes

XiaoxuanLu added 9 commits August 1, 2025 11:54

register function module files
02141bd

refactor code based on comments and add function module support
e39c53f

fix the abapUtil test
8ee19cc

local test for flare
78b7e2c

remove dependency on abap extension
623db43

fix the test
a00852c

Merge branch 'main' into xiaoluk/adt-support
a19a8f3

fix the semanticCachePath that do not work for mac
2d62710

fix unused import
39d65af

shruti0085 reviewed Aug 5, 2025
View reviewed changes

XiaoxuanLu added 2 commits August 5, 2025 11:57

Merge branch 'feature/adt-support' into xiaoluk/adt-support
d471cef

add null handling and reduce code duplication
b1fa5e7

shruti0085 reviewed Aug 7, 2025
View reviewed changes

shruti0085 approved these changes Aug 7, 2025
View reviewed changes

XiaoxuanLu merged commit 3a0767a into feature/adt-supportAug 7, 2025
1 check passed

XiaoxuanLu deleted the xiaoluk/adt-support branch August 7, 2025 19:46

shruti0085 mentioned this pull request Aug 13, 2025
Merge ADT support into main #501
Merged

XiaoxuanLuand others added 4 commits July 24, 2025 13:19

register all known abap types in plugin.xml to let clients see Q button
ce415e9

Update plugin.xml to match the format
d6ab17b

send abap workspace and let inline completion/avtivefile work for aba…
2d85a68
…p files in adt plugin:

change the checkstyle
634fabb

XiaoxuanLu requested a review from shruti0085 July 25, 2025 21:47

add test for abapUtil
a7f5e54

XiaoxuanLu changed the base branch from main to feature/adt-supportJuly 28, 2025 18:17

fix the checkstyle
d572a8b

shruti0085 reviewed Jul 31, 2025
View reviewed changes

XiaoxuanLu added 9 commits August 1, 2025 11:54

register function module files
02141bd

refactor code based on comments and add function module support
e39c53f

fix the abapUtil test
8ee19cc

local test for flare
78b7e2c

remove dependency on abap extension
623db43

fix the test
a00852c

Merge branch 'main' into xiaoluk/adt-support
a19a8f3

fix the semanticCachePath that do not work for mac
2d62710

fix unused import
39d65af

shruti0085 reviewed Aug 5, 2025
View reviewed changes

XiaoxuanLu added 2 commits August 5, 2025 11:57

Merge branch 'feature/adt-support' into xiaoluk/adt-support
d471cef

add null handling and reduce code duplication
b1fa5e7

shruti0085 reviewed Aug 7, 2025
View reviewed changes

shruti0085 approved these changes Aug 7, 2025
View reviewed changes

XiaoxuanLu merged commit 3a0767a into feature/adt-supportAug 7, 2025
1 check passed

XiaoxuanLu deleted the xiaoluk/adt-support branch August 7, 2025 19:46

shruti0085 mentioned this pull request Aug 13, 2025
Merge ADT support into main #501
Merged

XiaoxuanLuand others added 4 commits July 24, 2025 13:19

register all known abap types in plugin.xml to let clients see Q button
ce415e9

Update plugin.xml to match the format
d6ab17b

send abap workspace and let inline completion/avtivefile work for aba…
2d85a68
…p files in adt plugin:

change the checkstyle
634fabb

XiaoxuanLu requested a review from shruti0085 July 25, 2025 21:47

add test for abapUtil
a7f5e54

XiaoxuanLu changed the base branch from main to feature/adt-supportJuly 28, 2025 18:17

fix the checkstyle
d572a8b

shruti0085 reviewed Jul 31, 2025
View reviewed changes

XiaoxuanLu added 9 commits August 1, 2025 11:54

register function module files
02141bd

refactor code based on comments and add function module support
e39c53f

fix the abapUtil test
8ee19cc

local test for flare
78b7e2c

remove dependency on abap extension
623db43

fix the test
a00852c

Merge branch 'main' into xiaoluk/adt-support
a19a8f3

fix the semanticCachePath that do not work for mac
2d62710

fix unused import
39d65af

shruti0085 reviewed Aug 5, 2025
View reviewed changes

XiaoxuanLu added 2 commits August 5, 2025 11:57

Merge branch 'feature/adt-support' into xiaoluk/adt-support
d471cef

add null handling and reduce code duplication
b1fa5e7

shruti0085 reviewed Aug 7, 2025
View reviewed changes

shruti0085 approved these changes Aug 7, 2025
View reviewed changes

XiaoxuanLu merged commit 3a0767a into feature/adt-supportAug 7, 2025
1 check passed

XiaoxuanLu deleted the xiaoluk/adt-support branch August 7, 2025 19:46

shruti0085 mentioned this pull request Aug 13, 2025
Merge ADT support into main #501
Merged

Uh oh!

Conversation

XiaoxuanLu commented Jul 24, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problems

Solutions

Further work

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

XiaoxuanLu commented Jul 24, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problems

Solutions

Further work

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

XiaoxuanLu commented Jul 24, 2025•
edited
Loading

XiaoxuanLu commented Jul 24, 2025•
edited
Loading

XiaoxuanLu commented Jul 24, 2025•
edited
Loading