Uh oh!
There was an error while loading. Please reload this page.
fix: scope and forward stepId for the planning-branch LBV HITL - #2835
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #2835 +/- ##
==========================================
- Coverage 62.26% 59.48% -2.79%
==========================================
Files 282 282 Lines 72369 72367 -2 Branches 5264 4550 -714 ==========================================
- Hits 45060 43045 -2015 - Misses 27217 29232 +2015 + Partials 92 90 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pranav-firake
approved these changes
Aug 13, 2026
The AWAITING_HUMAN_INPUT path already scopes the local-build-verification HITL to the loaded beamed repo and forwards its plan-step id, but the PLANNING branch did neither: it picked the first LBV HITL in the list and returned it without StepInformation. On a multi-repo beam where the job sits in PLANNING at build time, that surfaces a sibling's (or untagged) HITL, so the IDE scope guard cannot confirm ownership and defers the build indefinitely. Bring the PLANNING branch to parity with AWAITING_HUMAN_INPUT: - prefer the in-scope LBV via selectScopedLbvHitl (no-op when scope is empty, so non-beam behavior is unchanged) - forward StepInformation.StepId when present Verified live on a 3-repo beam: each loaded repo now builds and siblings are correctly deferred.
Brings the PLANNING branch of getTransformInfo to full parity with the EXECUTING / getHitlAgentArtifact paths for multi-repo beam. It already preferred the loaded repo's in-scope LBV and forwarded its stepId, but it did not suppress out-of-scope sibling LBVs: when scope was set with no in-scope LBV it could still surface a sibling's LBV HITL to the IDE. Mirror the sibling branches: - when scope is set and every pending HITL is a sibling's LBV, return plan-only (surface nothing) - otherwise drop out-of-scope LBVs from the fallback pool so a sibling's LBV can't be picked in a mixed pending set Not a live false-green (the IDE scope guard already rejects a HITL whose stepId is out of the loaded subtree) — this restores the LSP-side layer so all three branches behave identically. Non-beam is byte-identical: the new logic is gated on a non-empty beam scope.
- getStepId uses || so an empty-string id falls through to the next spelling (was ?? which let an empty id defeat coalescing and scope matching) - move the normalizeBeamRepo JSDoc onto normalizeBeamRepo (was stranded above getStepId)
Rajanna-Karthikforce-pushed
the
karsraja-beam-lsp-planning-branch-scope
branch
from
August 17, 2026 21:36
d585833 to
584e2e0Comparelaileni-aws
approved these changes
Aug 17, 2026
- PLANNING branch: a sibling repo's out-of-scope LBV is not surfaced - getStepId: empty stepId falls through to planStepId/parentStepId (|| not ??)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a multi-repo "Transfer to IDE" (beam) job that sits in PLANNING at local-build-verification (LBV) time, the IDE could never trigger the build for a loaded repo — it deferred every poll with
hitlStepId=<none>/ "cannot confirm it belongs to this loaded beamed repo".Root cause: the
getTransformInfoPLANNING branch handled the LBV HITL differently from theAWAITING_HUMAN_INPUTbranch. It:local-build-verificationHITL in the list (no scope filter) — on a multi-repo job that can be a sibling's HITL, andStepInformation— so the IDE's multi-repo scope guard had no stepId to confirm ownership and deferred the build indefinitely.The
AWAITING_HUMAN_INPUTpath already did both correctly; the PLANNING branch was missing them.Fix
Bring the PLANNING branch to parity with
AWAITING_HUMAN_INPUT:selectScopedLbvHitl(...)StepInformation.StepIdwhen presentBoth are additive and beam-scoped:
selectScopedLbvHitlreturns{scopedLbv: null, allOutOfScopeLbv: false}when the scope list is empty (every non-beam job, and beam before Load), so the fallback selection is unchanged and non-beam behavior is byte-identical.StepInformationisundefinedwhen no stepId exists — same wire shape as today.Testing
tsc --noEmit: cleanBuild result: SUCCESS; siblings are correctly deferred (no false-green).