Skip to content
This repository was archived by the owner on Sep 18, 2024. It is now read-only.

feat: d.js v14 - #165

Open
WilsontheWolf wants to merge 9 commits into
AnIdiotsGuide:masterfrom
WilsontheWolf:master
Open

feat: d.js v14#165
WilsontheWolf wants to merge 9 commits into
AnIdiotsGuide:masterfrom
WilsontheWolf:master

Conversation

@WilsontheWolf

@WilsontheWolfWilsontheWolf commented Jul 26, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Everything should work, but I haven't tested too much.

BREAKING CHANGES:
Suprisingly not much.

  • Config file format changed to add support for new intents and partials
  • Bot no longer has the message content intent, which means it needs to be whitelisted and then enabled in the config.
    NOTE: the client still will receive message commands in dm's or when pinged.

Semantic versioning classification:

  • This PR changes the framework's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to README, etc.

@WilsontheWolf
feat: d.js v14
1a28f06
Everything *should* work, but I haven't tested too much.
**BREAKING CHANGES:**
Suprisingly not much.
- Config file format changed to add support for new intents and partials
- Bot no longer has the message content intent, which means it needs to be whitelisted and then enabled in the config.
NOTE: the client still will receive message commands in dm's or when pinged.
@WilsontheWolf
chore: update config note
53a8d28
@WilsontheWolf
chore: don't content by default
750b48f
RealShadowNova
RealShadowNova suggested changes Jul 26, 2022
View reviewed changes
Comment threadslash/leave.js
Comment threadpackage.json Outdated
RealShadowNova
RealShadowNova approved these changes Jul 26, 2022
View reviewed changes

@RealShadowNovaRealShadowNova left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but why is there a lockfile for NPM and Yarn?

@WilsontheWolf

WilsontheWolf commented Jul 26, 2022

Copy link
Copy Markdown
ContributorAuthor

Idk but it was like that when I got to it

GoldenAngel2
GoldenAngel2 suggested changes Jul 26, 2022
View reviewed changes

@GoldenAngel2GoldenAngel2 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than these, it looks good.

Comment threadcommands/stats.js Outdated
Comment threadslash/stats.js Outdated
kyranet
kyranet suggested changes Jul 26, 2022
View reviewed changes

@kyranetkyranet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaultPermission can be updated to use dmPermission

Comment threadconfig.js.example Outdated
WilsontheWolfand others added 2 commits July 26, 2022 06:33
@WilsontheWolf@kyranet
Remove trailing space
d1b6c04
Co-authored-by: A. Román <kyradiscord@gmail.com>
@WilsontheWolf
chore: update defaultPermission
1654431
kyranet
kyranet reviewed Jul 30, 2022
View reviewed changes

@kyranetkyranet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing that was introduced with 14.1.0:

Comment threadevents/interactionCreate.js Outdated
@WhyAydan

WhyAydan commented Oct 20, 2022

Copy link
Copy Markdown

Hey,

Any update when this will be pushed live?

Aydan

@WilsontheWolf
chore: misc fixes
8bee297
- Update deps
- Update readme
- Revert isCommand
@WilsontheWolf
WilsontheWolf requested review from RealShadowNova and kyranet and removed request for kyranetNovember 12, 2022 20:14
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kyranetkyranetAwaiting requested review from kyranet
2 more reviewers
@GoldenAngel2GoldenAngel2GoldenAngel2 requested changes
@RealShadowNovaRealShadowNovaRealShadowNova approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@WilsontheWolf@WhyAydan@kyranet@RealShadowNova@GoldenAngel2