Fix install path, make release safe, and implement real launch-check

[AndroidPoet]

Summary

Reviewed the repo against its own concept ("one coherent, deterministic, auditable release surface"). The code built and tested clean, so this focuses on real defects plus production-readiness gaps for a tool that publishes to app stores.

Bug fixes

• install.sh was broken — GoReleaser's {{ .Version }} strips the leading v (shipkit_0.1.0_…), but the script built the filename from the raw tag v0.1.0. The documented curl … | sh install would 404 on the first release. Fixed by stripping v for the archive name while keeping it in the download path.
• Generated CI workflow could never succeed — the readiness job ran shipkit doctor, which exits non-zero when gpc/rc/asc are missing, and nothing installed them, so the gated release job was always skipped. Added a shipkit install step to both jobs.
• agent.go drift — hardcoded .shipkit.yaml now routes through config.FileName.

Safety + features

• release --dry-run — prints the exact provider commands instead of executing them (no more unguarded push to production stores). Command mapping refactored into a testable table.
• doctor --json — structured output, consistent with agent --json.
• Real launch-check — was just doctor + file-exists. Now evaluates tools installed, config present/readable, and store identifiers set and not the generated com.company.* placeholder. Text and --json, non-zero exit when not ready. Store/network checks remain honestly in the roadmap.

Quality

• CI now enforces gofmt and go vet.
• New tests: release dry-run + bad target, config Load round-trip, launch-check (ready / placeholder / missing tools), workflow generation.

Verification

gofmt clean · go vet clean · go test -race ./... all pass · smoke-tested the compiled binary on the green path, the placeholder-caught path, and JSON output.

Note: the install.sh fix is correct by inspection but unverifiable until a real tag is cut and GoReleaser produces artifacts.

[AndroidPoet]

Summary

Reviewed the repo against its own concept ("one coherent, deterministic, auditable release surface"). The code built and tested clean, so this focuses on real defects plus production-readiness gaps for a tool that publishes to app stores.

Bug fixes

• install.sh was broken — GoReleaser's {{ .Version }} strips the leading v (shipkit_0.1.0_…), but the script built the filename from the raw tag v0.1.0. The documented curl … | sh install would 404 on the first release. Fixed by stripping v for the archive name while keeping it in the download path.
• Generated CI workflow could never succeed — the readiness job ran shipkit doctor, which exits non-zero when gpc/rc/asc are missing, and nothing installed them, so the gated release job was always skipped. Added a shipkit install step to both jobs.
• agent.go drift — hardcoded .shipkit.yaml now routes through config.FileName.

Safety + features

• release --dry-run — prints the exact provider commands instead of executing them (no more unguarded push to production stores). Command mapping refactored into a testable table.
• doctor --json — structured output, consistent with agent --json.
• Real launch-check — was just doctor + file-exists. Now evaluates tools installed, config present/readable, and store identifiers set and not the generated com.company.* placeholder. Text and --json, non-zero exit when not ready. Store/network checks remain honestly in the roadmap.

Quality

• CI now enforces gofmt and go vet.
• New tests: release dry-run + bad target, config Load round-trip, launch-check (ready / placeholder / missing tools), workflow generation.

Verification

gofmt clean · go vet clean · go test -race ./... all pass · smoke-tested the compiled binary on the green path, the placeholder-caught path, and JSON output.

Note: the install.sh fix is correct by inspection but unverifiable until a real tag is cut and GoReleaser produces artifacts.

[AndroidPoet]

Summary

Reviewed the repo against its own concept ("one coherent, deterministic, auditable release surface"). The code built and tested clean, so this focuses on real defects plus production-readiness gaps for a tool that publishes to app stores.

Bug fixes

• install.sh was broken — GoReleaser's {{ .Version }} strips the leading v (shipkit_0.1.0_…), but the script built the filename from the raw tag v0.1.0. The documented curl … | sh install would 404 on the first release. Fixed by stripping v for the archive name while keeping it in the download path.
• Generated CI workflow could never succeed — the readiness job ran shipkit doctor, which exits non-zero when gpc/rc/asc are missing, and nothing installed them, so the gated release job was always skipped. Added a shipkit install step to both jobs.
• agent.go drift — hardcoded .shipkit.yaml now routes through config.FileName.

Safety + features

• release --dry-run — prints the exact provider commands instead of executing them (no more unguarded push to production stores). Command mapping refactored into a testable table.
• doctor --json — structured output, consistent with agent --json.
• Real launch-check — was just doctor + file-exists. Now evaluates tools installed, config present/readable, and store identifiers set and not the generated com.company.* placeholder. Text and --json, non-zero exit when not ready. Store/network checks remain honestly in the roadmap.

Quality

• CI now enforces gofmt and go vet.
• New tests: release dry-run + bad target, config Load round-trip, launch-check (ready / placeholder / missing tools), workflow generation.

Verification

gofmt clean · go vet clean · go test -race ./... all pass · smoke-tested the compiled binary on the green path, the placeholder-caught path, and JSON output.

Note: the install.sh fix is correct by inspection but unverifiable until a real tag is cut and GoReleaser produces artifacts.

[AndroidPoet]

Summary

Reviewed the repo against its own concept ("one coherent, deterministic, auditable release surface"). The code built and tested clean, so this focuses on real defects plus production-readiness gaps for a tool that publishes to app stores.

Bug fixes

• install.sh was broken — GoReleaser's {{ .Version }} strips the leading v (shipkit_0.1.0_…), but the script built the filename from the raw tag v0.1.0. The documented curl … | sh install would 404 on the first release. Fixed by stripping v for the archive name while keeping it in the download path.
• Generated CI workflow could never succeed — the readiness job ran shipkit doctor, which exits non-zero when gpc/rc/asc are missing, and nothing installed them, so the gated release job was always skipped. Added a shipkit install step to both jobs.
• agent.go drift — hardcoded .shipkit.yaml now routes through config.FileName.

Safety + features

• release --dry-run — prints the exact provider commands instead of executing them (no more unguarded push to production stores). Command mapping refactored into a testable table.
• doctor --json — structured output, consistent with agent --json.
• Real launch-check — was just doctor + file-exists. Now evaluates tools installed, config present/readable, and store identifiers set and not the generated com.company.* placeholder. Text and --json, non-zero exit when not ready. Store/network checks remain honestly in the roadmap.

Quality

• CI now enforces gofmt and go vet.
• New tests: release dry-run + bad target, config Load round-trip, launch-check (ready / placeholder / missing tools), workflow generation.

Verification

gofmt clean · go vet clean · go test -race ./... all pass · smoke-tested the compiled binary on the green path, the placeholder-caught path, and JSON output.

Note: the install.sh fix is correct by inspection but unverifiable until a real tag is cut and GoReleaser produces artifacts.

[AndroidPoet]

Summary

Reviewed the repo against its own concept ("one coherent, deterministic, auditable release surface"). The code built and tested clean, so this focuses on real defects plus production-readiness gaps for a tool that publishes to app stores.

Bug fixes

• install.sh was broken — GoReleaser's {{ .Version }} strips the leading v (shipkit_0.1.0_…), but the script built the filename from the raw tag v0.1.0. The documented curl … | sh install would 404 on the first release. Fixed by stripping v for the archive name while keeping it in the download path.
• Generated CI workflow could never succeed — the readiness job ran shipkit doctor, which exits non-zero when gpc/rc/asc are missing, and nothing installed them, so the gated release job was always skipped. Added a shipkit install step to both jobs.
• agent.go drift — hardcoded .shipkit.yaml now routes through config.FileName.

Safety + features

• release --dry-run — prints the exact provider commands instead of executing them (no more unguarded push to production stores). Command mapping refactored into a testable table.
• doctor --json — structured output, consistent with agent --json.
• Real launch-check — was just doctor + file-exists. Now evaluates tools installed, config present/readable, and store identifiers set and not the generated com.company.* placeholder. Text and --json, non-zero exit when not ready. Store/network checks remain honestly in the roadmap.

Quality

• CI now enforces gofmt and go vet.
• New tests: release dry-run + bad target, config Load round-trip, launch-check (ready / placeholder / missing tools), workflow generation.

Verification

gofmt clean · go vet clean · go test -race ./... all pass · smoke-tested the compiled binary on the green path, the placeholder-caught path, and JSON output.

Note: the install.sh fix is correct by inspection but unverifiable until a real tag is cut and GoReleaser produces artifacts.

[AndroidPoet]

Summary

Reviewed the repo against its own concept ("one coherent, deterministic, auditable release surface"). The code built and tested clean, so this focuses on real defects plus production-readiness gaps for a tool that publishes to app stores.

Bug fixes

• install.sh was broken — GoReleaser's {{ .Version }} strips the leading v (shipkit_0.1.0_…), but the script built the filename from the raw tag v0.1.0. The documented curl … | sh install would 404 on the first release. Fixed by stripping v for the archive name while keeping it in the download path.
• Generated CI workflow could never succeed — the readiness job ran shipkit doctor, which exits non-zero when gpc/rc/asc are missing, and nothing installed them, so the gated release job was always skipped. Added a shipkit install step to both jobs.
• agent.go drift — hardcoded .shipkit.yaml now routes through config.FileName.

Safety + features

• release --dry-run — prints the exact provider commands instead of executing them (no more unguarded push to production stores). Command mapping refactored into a testable table.
• doctor --json — structured output, consistent with agent --json.
• Real launch-check — was just doctor + file-exists. Now evaluates tools installed, config present/readable, and store identifiers set and not the generated com.company.* placeholder. Text and --json, non-zero exit when not ready. Store/network checks remain honestly in the roadmap.

Quality

• CI now enforces gofmt and go vet.
• New tests: release dry-run + bad target, config Load round-trip, launch-check (ready / placeholder / missing tools), workflow generation.

Verification

gofmt clean · go vet clean · go test -race ./... all pass · smoke-tested the compiled binary on the green path, the placeholder-caught path, and JSON output.

Note: the install.sh fix is correct by inspection but unverifiable until a real tag is cut and GoReleaser produces artifacts.

[AndroidPoet]

Summary

Reviewed the repo against its own concept ("one coherent, deterministic, auditable release surface"). The code built and tested clean, so this focuses on real defects plus production-readiness gaps for a tool that publishes to app stores.

Bug fixes

• install.sh was broken — GoReleaser's {{ .Version }} strips the leading v (shipkit_0.1.0_…), but the script built the filename from the raw tag v0.1.0. The documented curl … | sh install would 404 on the first release. Fixed by stripping v for the archive name while keeping it in the download path.
• Generated CI workflow could never succeed — the readiness job ran shipkit doctor, which exits non-zero when gpc/rc/asc are missing, and nothing installed them, so the gated release job was always skipped. Added a shipkit install step to both jobs.
• agent.go drift — hardcoded .shipkit.yaml now routes through config.FileName.

Safety + features

• release --dry-run — prints the exact provider commands instead of executing them (no more unguarded push to production stores). Command mapping refactored into a testable table.
• doctor --json — structured output, consistent with agent --json.
• Real launch-check — was just doctor + file-exists. Now evaluates tools installed, config present/readable, and store identifiers set and not the generated com.company.* placeholder. Text and --json, non-zero exit when not ready. Store/network checks remain honestly in the roadmap.

Quality

• CI now enforces gofmt and go vet.
• New tests: release dry-run + bad target, config Load round-trip, launch-check (ready / placeholder / missing tools), workflow generation.

Verification

gofmt clean · go vet clean · go test -race ./... all pass · smoke-tested the compiled binary on the green path, the placeholder-caught path, and JSON output.

Note: the install.sh fix is correct by inspection but unverifiable until a real tag is cut and GoReleaser produces artifacts.

[AndroidPoet]

Summary

Reviewed the repo against its own concept ("one coherent, deterministic, auditable release surface"). The code built and tested clean, so this focuses on real defects plus production-readiness gaps for a tool that publishes to app stores.

Bug fixes

• install.sh was broken — GoReleaser's {{ .Version }} strips the leading v (shipkit_0.1.0_…), but the script built the filename from the raw tag v0.1.0. The documented curl … | sh install would 404 on the first release. Fixed by stripping v for the archive name while keeping it in the download path.
• Generated CI workflow could never succeed — the readiness job ran shipkit doctor, which exits non-zero when gpc/rc/asc are missing, and nothing installed them, so the gated release job was always skipped. Added a shipkit install step to both jobs.
• agent.go drift — hardcoded .shipkit.yaml now routes through config.FileName.

Safety + features

• release --dry-run — prints the exact provider commands instead of executing them (no more unguarded push to production stores). Command mapping refactored into a testable table.
• doctor --json — structured output, consistent with agent --json.
• Real launch-check — was just doctor + file-exists. Now evaluates tools installed, config present/readable, and store identifiers set and not the generated com.company.* placeholder. Text and --json, non-zero exit when not ready. Store/network checks remain honestly in the roadmap.

Quality

• CI now enforces gofmt and go vet.
• New tests: release dry-run + bad target, config Load round-trip, launch-check (ready / placeholder / missing tools), workflow generation.

Verification

gofmt clean · go vet clean · go test -race ./... all pass · smoke-tested the compiled binary on the green path, the placeholder-caught path, and JSON output.

Note: the install.sh fix is correct by inspection but unverifiable until a real tag is cut and GoReleaser produces artifacts.