aipc, an async ipc library for aero - #60
Conversation
48cf
commented
Mar 19, 2022
I'm not a fan of all these |
pitust
commented
Mar 19, 2022
I could possibly move them to The unwraps are there because I explicitly wanted to prevent injecting |
| fn main() { | ||
| let mut rt = aipc::async_runtime::AsyncRuntime::new(); |
There was a problem hiding this comment.
Instead of constructing a runtime manually at the start of the main function, it would be a much cleaner idea to initialize it lazily in the spawn function instead. So it will look like apic::spawn(async {}). In future we; after we get the rust userland port sorted out we can switch to using tokio as our async runtime.
b2b7b40 to
711c1ecComparef320b00 to
e98c22dCompare5b4b6dd to
6defcdeCompareebad1c8 to
f1ba94dCompare90094ea to
5222520Compare1de1b56 to
f7cd1a0Compare51c9079 to
9105725Compare936f430 to
f275662Compare
'nuff said.