Minor fixes - #6

Merged
AndyAyersMS merged 2 commits into
AndyAyersMS:StackAllocateUnescapedBoxesfrom
jakobbotsch:stack-allocate-unescaped-boxes-lclmorph
Jun 12, 2024
Merged

Minor fixes#6
AndyAyersMS merged 2 commits into
AndyAyersMS:StackAllocateUnescapedBoxesfrom
jakobbotsch:stack-allocate-unescaped-boxes-lclmorph

Conversation

@jakobbotsch

@jakobbotschjakobbotsch commented Jun 12, 2024

Copy link
Copy Markdown

Switch local morph to use its semantic reasoning about addresses in the GT_EQ/GT_NE cases. Add a missing return false.

@jakobbotsch

jakobbotsch commented Jun 12, 2024

Copy link
Copy Markdown
Author

With this we manage to reduce the case in dotnet#9118 to

; Assembly listing for method C:Main():int (FullOpts); Emitting BLENDED_CODE for X64 with AVX - Windows; FullOpts code; optimized code; rsp based frame; partially interruptible; No PGO data; 1 inlinees with PGO data; 3 single block inlinees; 1 inlinees without PGO data; Final local variable assignments;; V00 OutArgs [V00 ] ( 1, 1 ) struct (32) [rsp+0x00] do-not-enreg[XS] addr-exposed "OutgoingArgSpace";* V01 tmp1 [V01,T00] ( 0, 0 ) ref -> zero-ref class-hnd exact single-def "NewObj constructor temp" <ObjectEqualityComparer`1[int]>;* V02 tmp2 [V02 ] ( 0, 0 ) ubyte -> zero-ref "Inline return value spill temp";* V03 tmp3 [V03 ] ( 0, 0 ) int -> zero-ref ld-addr-op "Inlining Arg";* V04 tmp4 [V04 ] ( 0, 0 ) long -> zero-ref class-hnd exact "Single-def Box Helper" <System.Int32>;* V05 tmp5 [V05 ] ( 0, 0 ) ubyte -> zero-ref "Inline return value spill temp";* V06 tmp6 [V06 ] ( 0, 0 ) long -> zero-ref class-hnd exact "Inlining Arg" <System.Int32>;* V07 tmp7 [V07 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] "stack allocated boxed value class temp" <System.Collections.Generic.KeyValuePair`2[long,int]>;* V08 tmp8 [V08 ] ( 0, 0 ) long -> zero-ref "V07.[000..008)";* V09 tmp9 [V09 ] ( 0, 0 ) int -> zero-ref "V07.[008..012)";; Lcl frame size = 40G_M46144_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=1 PerfScore 0.25G_M46144_IG02: ;; offset=0x0004moveax,100 ;; size=5 bbWeight=1 PerfScore 0.25G_M46144_IG03: ;; offset=0x0009addrsp,40ret ;; size=5 bbWeight=1 PerfScore 1.25; Total bytes of code 14, prolog size 4, PerfScore 1.75, instruction count 4, allocated bytes for code 14 (MethodHash=cd934bbf) for method C:Main():int (FullOpts); ============================================================

Looks like we don't manage to remove the frame entirely since we don't get rid of the heap allocation until post-lower DCE, so there is still a helper call during lowering when we're figuring out how much outgoing arg space we need.

jakobbotsch
jakobbotsch commented Jun 12, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp Outdated
@AndyAyersMS
AndyAyersMS merged commit 5a08c84 into AndyAyersMS:StackAllocateUnescapedBoxesJun 12, 2024
@jakobbotsch
jakobbotsch deleted the stack-allocate-unescaped-boxes-lclmorph branch June 12, 2024 18:15
AndyAyersMS pushed a commit that referenced this pull request Sep 7, 2024
@adamsitnik
[NRBF] Fix bugs discovered by the fuzzer (dotnet#107368)
e79426e
* bug #1: don't allow for values out of the SerializationRecordType enum range
* bug #2: throw SerializationException rather than KeyNotFoundException when the referenced record is missing or it points to a record of different type
* bug #3: throw SerializationException rather than FormatException when it's being thrown by BinaryReader (or sth else that we use)
* bug #4: document the fact that IOException can be thrown
* bug #5: throw SerializationException rather than OverflowException when parsing the decimal fails
* bug #6: 0 and 17 are illegal values for PrimitiveType enum
* bug #7: throw SerializationException when a surrogate character is read (so far an ArgumentException was thrown)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch@AndyAyersMS
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Minor fixes - #6
Merged
AndyAyersMS merged 2 commits into
AndyAyersMS:StackAllocateUnescapedBoxesfrom 
jakobbotsch:stack-allocate-unescaped-boxes-lclmorph
Jun 12, 2024
Merged
Minor fixes#6
AndyAyersMS merged 2 commits into
AndyAyersMS:StackAllocateUnescapedBoxesfrom 
jakobbotsch:stack-allocate-unescaped-boxes-lclmorph
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Jun 12, 2024

Copy link


Copy Markdown

Switch local morph to use its semantic reasoning about addresses in the GT_EQ/GT_NE cases. Add a missing return false.
@jakobbotsch
jakobbotsch
commented
Jun 12, 2024

Copy link


Copy Markdown

Author
With this we manage to reduce the case in dotnet#9118 to
; Assembly listing for method C:Main():int (FullOpts); Emitting BLENDED_CODE for X64 with AVX - Windows; FullOpts code; optimized code; rsp based frame; partially interruptible; No PGO data; 1 inlinees with PGO data; 3 single block inlinees; 1 inlinees without PGO data; Final local variable assignments;; V00 OutArgs [V00 ] ( 1, 1 ) struct (32) [rsp+0x00] do-not-enreg[XS] addr-exposed "OutgoingArgSpace";* V01 tmp1 [V01,T00] ( 0, 0 ) ref -> zero-ref class-hnd exact single-def "NewObj constructor temp" <ObjectEqualityComparer`1[int]>;* V02 tmp2 [V02 ] ( 0, 0 ) ubyte -> zero-ref "Inline return value spill temp";* V03 tmp3 [V03 ] ( 0, 0 ) int -> zero-ref ld-addr-op "Inlining Arg";* V04 tmp4 [V04 ] ( 0, 0 ) long -> zero-ref class-hnd exact "Single-def Box Helper" <System.Int32>;* V05 tmp5 [V05 ] ( 0, 0 ) ubyte -> zero-ref "Inline return value spill temp";* V06 tmp6 [V06 ] ( 0, 0 ) long -> zero-ref class-hnd exact "Inlining Arg" <System.Int32>;* V07 tmp7 [V07 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] "stack allocated boxed value class temp" <System.Collections.Generic.KeyValuePair`2[long,int]>;* V08 tmp8 [V08 ] ( 0, 0 ) long -> zero-ref "V07.[000..008)";* V09 tmp9 [V09 ] ( 0, 0 ) int -> zero-ref "V07.[008..012)";; Lcl frame size = 40G_M46144_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=1 PerfScore 0.25G_M46144_IG02: ;; offset=0x0004moveax,100 ;; size=5 bbWeight=1 PerfScore 0.25G_M46144_IG03: ;; offset=0x0009addrsp,40ret ;; size=5 bbWeight=1 PerfScore 1.25; Total bytes of code 14, prolog size 4, PerfScore 1.75, instruction count 4, allocated bytes for code 14 (MethodHash=cd934bbf) for method C:Main():int (FullOpts); ============================================================
Looks like we don't manage to remove the frame entirely since we don't get rid of the heap allocation until post-lower DCE, so there is still a helper call during lowering when we're figuring out how much outgoing arg space we need.
jakobbotsch
jakobbotsch
commented
Jun 12, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@AndyAyersMS
AndyAyersMS
merged commit 5a08c84
into
AndyAyersMS:StackAllocateUnescapedBoxesJun 12, 2024
@jakobbotsch
jakobbotsch
deleted the

stack-allocate-unescaped-boxes-lclmorph

branch
June 12, 2024 18:15
AndyAyersMS pushed a commit
that referenced
this pull request
Sep 7, 2024
@adamsitnik
[NRBF] Fix bugs discovered by the fuzzer (dotnet#107368)
e79426e
* bug #1: don't allow for values out of the SerializationRecordType enum range
* bug #2: throw SerializationException rather than KeyNotFoundException when the referenced record is missing or it points to a record of different type
* bug #3: throw SerializationException rather than FormatException when it's being thrown by BinaryReader (or sth else that we use)
* bug #4: document the fact that IOException can be thrown
* bug #5: throw SerializationException rather than OverflowException when parsing the decimal fails
* bug #6: 0 and 17 are illegal values for PrimitiveType enum
* bug #7: throw SerializationException when a surrogate character is read (so far an ArgumentException was thrown)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch@AndyAyersMS

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Minor fixes - #6
Merged
AndyAyersMS merged 2 commits into
AndyAyersMS:StackAllocateUnescapedBoxesfrom 
jakobbotsch:stack-allocate-unescaped-boxes-lclmorph
Jun 12, 2024
Merged
Minor fixes#6
AndyAyersMS merged 2 commits into
AndyAyersMS:StackAllocateUnescapedBoxesfrom 
jakobbotsch:stack-allocate-unescaped-boxes-lclmorph
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Jun 12, 2024

Copy link


Copy Markdown

Switch local morph to use its semantic reasoning about addresses in the GT_EQ/GT_NE cases. Add a missing return false.
@jakobbotsch
jakobbotsch
commented
Jun 12, 2024

Copy link


Copy Markdown

Author
With this we manage to reduce the case in dotnet#9118 to
; Assembly listing for method C:Main():int (FullOpts); Emitting BLENDED_CODE for X64 with AVX - Windows; FullOpts code; optimized code; rsp based frame; partially interruptible; No PGO data; 1 inlinees with PGO data; 3 single block inlinees; 1 inlinees without PGO data; Final local variable assignments;; V00 OutArgs [V00 ] ( 1, 1 ) struct (32) [rsp+0x00] do-not-enreg[XS] addr-exposed "OutgoingArgSpace";* V01 tmp1 [V01,T00] ( 0, 0 ) ref -> zero-ref class-hnd exact single-def "NewObj constructor temp" <ObjectEqualityComparer`1[int]>;* V02 tmp2 [V02 ] ( 0, 0 ) ubyte -> zero-ref "Inline return value spill temp";* V03 tmp3 [V03 ] ( 0, 0 ) int -> zero-ref ld-addr-op "Inlining Arg";* V04 tmp4 [V04 ] ( 0, 0 ) long -> zero-ref class-hnd exact "Single-def Box Helper" <System.Int32>;* V05 tmp5 [V05 ] ( 0, 0 ) ubyte -> zero-ref "Inline return value spill temp";* V06 tmp6 [V06 ] ( 0, 0 ) long -> zero-ref class-hnd exact "Inlining Arg" <System.Int32>;* V07 tmp7 [V07 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] "stack allocated boxed value class temp" <System.Collections.Generic.KeyValuePair`2[long,int]>;* V08 tmp8 [V08 ] ( 0, 0 ) long -> zero-ref "V07.[000..008)";* V09 tmp9 [V09 ] ( 0, 0 ) int -> zero-ref "V07.[008..012)";; Lcl frame size = 40G_M46144_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=1 PerfScore 0.25G_M46144_IG02: ;; offset=0x0004moveax,100 ;; size=5 bbWeight=1 PerfScore 0.25G_M46144_IG03: ;; offset=0x0009addrsp,40ret ;; size=5 bbWeight=1 PerfScore 1.25; Total bytes of code 14, prolog size 4, PerfScore 1.75, instruction count 4, allocated bytes for code 14 (MethodHash=cd934bbf) for method C:Main():int (FullOpts); ============================================================
Looks like we don't manage to remove the frame entirely since we don't get rid of the heap allocation until post-lower DCE, so there is still a helper call during lowering when we're figuring out how much outgoing arg space we need.
jakobbotsch
jakobbotsch
commented
Jun 12, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@AndyAyersMS
AndyAyersMS
merged commit 5a08c84
into
AndyAyersMS:StackAllocateUnescapedBoxesJun 12, 2024
@jakobbotsch
jakobbotsch
deleted the

stack-allocate-unescaped-boxes-lclmorph

branch
June 12, 2024 18:15
AndyAyersMS pushed a commit
that referenced
this pull request
Sep 7, 2024
@adamsitnik
[NRBF] Fix bugs discovered by the fuzzer (dotnet#107368)
e79426e
* bug #1: don't allow for values out of the SerializationRecordType enum range
* bug #2: throw SerializationException rather than KeyNotFoundException when the referenced record is missing or it points to a record of different type
* bug #3: throw SerializationException rather than FormatException when it's being thrown by BinaryReader (or sth else that we use)
* bug #4: document the fact that IOException can be thrown
* bug #5: throw SerializationException rather than OverflowException when parsing the decimal fails
* bug #6: 0 and 17 are illegal values for PrimitiveType enum
* bug #7: throw SerializationException when a surrogate character is read (so far an ArgumentException was thrown)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch@AndyAyersMS

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Minor fixes - #6
Merged
AndyAyersMS merged 2 commits into
AndyAyersMS:StackAllocateUnescapedBoxesfrom 
jakobbotsch:stack-allocate-unescaped-boxes-lclmorph
Jun 12, 2024
Merged
Minor fixes#6
AndyAyersMS merged 2 commits into
AndyAyersMS:StackAllocateUnescapedBoxesfrom 
jakobbotsch:stack-allocate-unescaped-boxes-lclmorph
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Jun 12, 2024

Copy link


Copy Markdown

Switch local morph to use its semantic reasoning about addresses in the GT_EQ/GT_NE cases. Add a missing return false.
@jakobbotsch
jakobbotsch
commented
Jun 12, 2024

Copy link


Copy Markdown

Author
With this we manage to reduce the case in dotnet#9118 to
; Assembly listing for method C:Main():int (FullOpts); Emitting BLENDED_CODE for X64 with AVX - Windows; FullOpts code; optimized code; rsp based frame; partially interruptible; No PGO data; 1 inlinees with PGO data; 3 single block inlinees; 1 inlinees without PGO data; Final local variable assignments;; V00 OutArgs [V00 ] ( 1, 1 ) struct (32) [rsp+0x00] do-not-enreg[XS] addr-exposed "OutgoingArgSpace";* V01 tmp1 [V01,T00] ( 0, 0 ) ref -> zero-ref class-hnd exact single-def "NewObj constructor temp" <ObjectEqualityComparer`1[int]>;* V02 tmp2 [V02 ] ( 0, 0 ) ubyte -> zero-ref "Inline return value spill temp";* V03 tmp3 [V03 ] ( 0, 0 ) int -> zero-ref ld-addr-op "Inlining Arg";* V04 tmp4 [V04 ] ( 0, 0 ) long -> zero-ref class-hnd exact "Single-def Box Helper" <System.Int32>;* V05 tmp5 [V05 ] ( 0, 0 ) ubyte -> zero-ref "Inline return value spill temp";* V06 tmp6 [V06 ] ( 0, 0 ) long -> zero-ref class-hnd exact "Inlining Arg" <System.Int32>;* V07 tmp7 [V07 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] "stack allocated boxed value class temp" <System.Collections.Generic.KeyValuePair`2[long,int]>;* V08 tmp8 [V08 ] ( 0, 0 ) long -> zero-ref "V07.[000..008)";* V09 tmp9 [V09 ] ( 0, 0 ) int -> zero-ref "V07.[008..012)";; Lcl frame size = 40G_M46144_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=1 PerfScore 0.25G_M46144_IG02: ;; offset=0x0004moveax,100 ;; size=5 bbWeight=1 PerfScore 0.25G_M46144_IG03: ;; offset=0x0009addrsp,40ret ;; size=5 bbWeight=1 PerfScore 1.25; Total bytes of code 14, prolog size 4, PerfScore 1.75, instruction count 4, allocated bytes for code 14 (MethodHash=cd934bbf) for method C:Main():int (FullOpts); ============================================================
Looks like we don't manage to remove the frame entirely since we don't get rid of the heap allocation until post-lower DCE, so there is still a helper call during lowering when we're figuring out how much outgoing arg space we need.
jakobbotsch
jakobbotsch
commented
Jun 12, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@AndyAyersMS
AndyAyersMS
merged commit 5a08c84
into
AndyAyersMS:StackAllocateUnescapedBoxesJun 12, 2024
@jakobbotsch
jakobbotsch
deleted the

stack-allocate-unescaped-boxes-lclmorph

branch
June 12, 2024 18:15
AndyAyersMS pushed a commit
that referenced
this pull request
Sep 7, 2024
@adamsitnik
[NRBF] Fix bugs discovered by the fuzzer (dotnet#107368)
e79426e
* bug #1: don't allow for values out of the SerializationRecordType enum range
* bug #2: throw SerializationException rather than KeyNotFoundException when the referenced record is missing or it points to a record of different type
* bug #3: throw SerializationException rather than FormatException when it's being thrown by BinaryReader (or sth else that we use)
* bug #4: document the fact that IOException can be thrown
* bug #5: throw SerializationException rather than OverflowException when parsing the decimal fails
* bug #6: 0 and 17 are illegal values for PrimitiveType enum
* bug #7: throw SerializationException when a surrogate character is read (so far an ArgumentException was thrown)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch@AndyAyersMS

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Minor fixes - #6
Merged
AndyAyersMS merged 2 commits into
AndyAyersMS:StackAllocateUnescapedBoxesfrom 
jakobbotsch:stack-allocate-unescaped-boxes-lclmorph
Jun 12, 2024
Merged
Minor fixes#6
AndyAyersMS merged 2 commits into
AndyAyersMS:StackAllocateUnescapedBoxesfrom 
jakobbotsch:stack-allocate-unescaped-boxes-lclmorph
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Jun 12, 2024

Copy link


Copy Markdown

Switch local morph to use its semantic reasoning about addresses in the GT_EQ/GT_NE cases. Add a missing return false.
@jakobbotsch
jakobbotsch
commented
Jun 12, 2024

Copy link


Copy Markdown

Author
With this we manage to reduce the case in dotnet#9118 to
; Assembly listing for method C:Main():int (FullOpts); Emitting BLENDED_CODE for X64 with AVX - Windows; FullOpts code; optimized code; rsp based frame; partially interruptible; No PGO data; 1 inlinees with PGO data; 3 single block inlinees; 1 inlinees without PGO data; Final local variable assignments;; V00 OutArgs [V00 ] ( 1, 1 ) struct (32) [rsp+0x00] do-not-enreg[XS] addr-exposed "OutgoingArgSpace";* V01 tmp1 [V01,T00] ( 0, 0 ) ref -> zero-ref class-hnd exact single-def "NewObj constructor temp" <ObjectEqualityComparer`1[int]>;* V02 tmp2 [V02 ] ( 0, 0 ) ubyte -> zero-ref "Inline return value spill temp";* V03 tmp3 [V03 ] ( 0, 0 ) int -> zero-ref ld-addr-op "Inlining Arg";* V04 tmp4 [V04 ] ( 0, 0 ) long -> zero-ref class-hnd exact "Single-def Box Helper" <System.Int32>;* V05 tmp5 [V05 ] ( 0, 0 ) ubyte -> zero-ref "Inline return value spill temp";* V06 tmp6 [V06 ] ( 0, 0 ) long -> zero-ref class-hnd exact "Inlining Arg" <System.Int32>;* V07 tmp7 [V07 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] "stack allocated boxed value class temp" <System.Collections.Generic.KeyValuePair`2[long,int]>;* V08 tmp8 [V08 ] ( 0, 0 ) long -> zero-ref "V07.[000..008)";* V09 tmp9 [V09 ] ( 0, 0 ) int -> zero-ref "V07.[008..012)";; Lcl frame size = 40G_M46144_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=1 PerfScore 0.25G_M46144_IG02: ;; offset=0x0004moveax,100 ;; size=5 bbWeight=1 PerfScore 0.25G_M46144_IG03: ;; offset=0x0009addrsp,40ret ;; size=5 bbWeight=1 PerfScore 1.25; Total bytes of code 14, prolog size 4, PerfScore 1.75, instruction count 4, allocated bytes for code 14 (MethodHash=cd934bbf) for method C:Main():int (FullOpts); ============================================================
Looks like we don't manage to remove the frame entirely since we don't get rid of the heap allocation until post-lower DCE, so there is still a helper call during lowering when we're figuring out how much outgoing arg space we need.
jakobbotsch
jakobbotsch
commented
Jun 12, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@AndyAyersMS
AndyAyersMS
merged commit 5a08c84
into
AndyAyersMS:StackAllocateUnescapedBoxesJun 12, 2024
@jakobbotsch
jakobbotsch
deleted the

stack-allocate-unescaped-boxes-lclmorph

branch
June 12, 2024 18:15
AndyAyersMS pushed a commit
that referenced
this pull request
Sep 7, 2024
@adamsitnik
[NRBF] Fix bugs discovered by the fuzzer (dotnet#107368)
e79426e
* bug #1: don't allow for values out of the SerializationRecordType enum range
* bug #2: throw SerializationException rather than KeyNotFoundException when the referenced record is missing or it points to a record of different type
* bug #3: throw SerializationException rather than FormatException when it's being thrown by BinaryReader (or sth else that we use)
* bug #4: document the fact that IOException can be thrown
* bug #5: throw SerializationException rather than OverflowException when parsing the decimal fails
* bug #6: 0 and 17 are illegal values for PrimitiveType enum
* bug #7: throw SerializationException when a surrogate character is read (so far an ArgumentException was thrown)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch@AndyAyersMS

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Minor fixes - #6
Merged
AndyAyersMS merged 2 commits into
AndyAyersMS:StackAllocateUnescapedBoxesfrom 
jakobbotsch:stack-allocate-unescaped-boxes-lclmorph
Jun 12, 2024
Merged
Minor fixes#6
AndyAyersMS merged 2 commits into
AndyAyersMS:StackAllocateUnescapedBoxesfrom 
jakobbotsch:stack-allocate-unescaped-boxes-lclmorph
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Jun 12, 2024

Copy link


Copy Markdown

Switch local morph to use its semantic reasoning about addresses in the GT_EQ/GT_NE cases. Add a missing return false.
@jakobbotsch
jakobbotsch
commented
Jun 12, 2024

Copy link


Copy Markdown

Author
With this we manage to reduce the case in dotnet#9118 to
; Assembly listing for method C:Main():int (FullOpts); Emitting BLENDED_CODE for X64 with AVX - Windows; FullOpts code; optimized code; rsp based frame; partially interruptible; No PGO data; 1 inlinees with PGO data; 3 single block inlinees; 1 inlinees without PGO data; Final local variable assignments;; V00 OutArgs [V00 ] ( 1, 1 ) struct (32) [rsp+0x00] do-not-enreg[XS] addr-exposed "OutgoingArgSpace";* V01 tmp1 [V01,T00] ( 0, 0 ) ref -> zero-ref class-hnd exact single-def "NewObj constructor temp" <ObjectEqualityComparer`1[int]>;* V02 tmp2 [V02 ] ( 0, 0 ) ubyte -> zero-ref "Inline return value spill temp";* V03 tmp3 [V03 ] ( 0, 0 ) int -> zero-ref ld-addr-op "Inlining Arg";* V04 tmp4 [V04 ] ( 0, 0 ) long -> zero-ref class-hnd exact "Single-def Box Helper" <System.Int32>;* V05 tmp5 [V05 ] ( 0, 0 ) ubyte -> zero-ref "Inline return value spill temp";* V06 tmp6 [V06 ] ( 0, 0 ) long -> zero-ref class-hnd exact "Inlining Arg" <System.Int32>;* V07 tmp7 [V07 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] "stack allocated boxed value class temp" <System.Collections.Generic.KeyValuePair`2[long,int]>;* V08 tmp8 [V08 ] ( 0, 0 ) long -> zero-ref "V07.[000..008)";* V09 tmp9 [V09 ] ( 0, 0 ) int -> zero-ref "V07.[008..012)";; Lcl frame size = 40G_M46144_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=1 PerfScore 0.25G_M46144_IG02: ;; offset=0x0004moveax,100 ;; size=5 bbWeight=1 PerfScore 0.25G_M46144_IG03: ;; offset=0x0009addrsp,40ret ;; size=5 bbWeight=1 PerfScore 1.25; Total bytes of code 14, prolog size 4, PerfScore 1.75, instruction count 4, allocated bytes for code 14 (MethodHash=cd934bbf) for method C:Main():int (FullOpts); ============================================================
Looks like we don't manage to remove the frame entirely since we don't get rid of the heap allocation until post-lower DCE, so there is still a helper call during lowering when we're figuring out how much outgoing arg space we need.
jakobbotsch
jakobbotsch
commented
Jun 12, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@AndyAyersMS
AndyAyersMS
merged commit 5a08c84
into
AndyAyersMS:StackAllocateUnescapedBoxesJun 12, 2024
@jakobbotsch
jakobbotsch
deleted the

stack-allocate-unescaped-boxes-lclmorph

branch
June 12, 2024 18:15
AndyAyersMS pushed a commit
that referenced
this pull request
Sep 7, 2024
@adamsitnik
[NRBF] Fix bugs discovered by the fuzzer (dotnet#107368)
e79426e
* bug #1: don't allow for values out of the SerializationRecordType enum range
* bug #2: throw SerializationException rather than KeyNotFoundException when the referenced record is missing or it points to a record of different type
* bug #3: throw SerializationException rather than FormatException when it's being thrown by BinaryReader (or sth else that we use)
* bug #4: document the fact that IOException can be thrown
* bug #5: throw SerializationException rather than OverflowException when parsing the decimal fails
* bug #6: 0 and 17 are illegal values for PrimitiveType enum
* bug #7: throw SerializationException when a surrogate character is read (so far an ArgumentException was thrown)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch@AndyAyersMS

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Minor fixes - #6
Merged
AndyAyersMS merged 2 commits into
AndyAyersMS:StackAllocateUnescapedBoxesfrom 
jakobbotsch:stack-allocate-unescaped-boxes-lclmorph
Jun 12, 2024
Merged
Minor fixes#6
AndyAyersMS merged 2 commits into
AndyAyersMS:StackAllocateUnescapedBoxesfrom 
jakobbotsch:stack-allocate-unescaped-boxes-lclmorph
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Jun 12, 2024

Copy link


Copy Markdown

Switch local morph to use its semantic reasoning about addresses in the GT_EQ/GT_NE cases. Add a missing return false.
@jakobbotsch
jakobbotsch
commented
Jun 12, 2024

Copy link


Copy Markdown

Author
With this we manage to reduce the case in dotnet#9118 to
; Assembly listing for method C:Main():int (FullOpts); Emitting BLENDED_CODE for X64 with AVX - Windows; FullOpts code; optimized code; rsp based frame; partially interruptible; No PGO data; 1 inlinees with PGO data; 3 single block inlinees; 1 inlinees without PGO data; Final local variable assignments;; V00 OutArgs [V00 ] ( 1, 1 ) struct (32) [rsp+0x00] do-not-enreg[XS] addr-exposed "OutgoingArgSpace";* V01 tmp1 [V01,T00] ( 0, 0 ) ref -> zero-ref class-hnd exact single-def "NewObj constructor temp" <ObjectEqualityComparer`1[int]>;* V02 tmp2 [V02 ] ( 0, 0 ) ubyte -> zero-ref "Inline return value spill temp";* V03 tmp3 [V03 ] ( 0, 0 ) int -> zero-ref ld-addr-op "Inlining Arg";* V04 tmp4 [V04 ] ( 0, 0 ) long -> zero-ref class-hnd exact "Single-def Box Helper" <System.Int32>;* V05 tmp5 [V05 ] ( 0, 0 ) ubyte -> zero-ref "Inline return value spill temp";* V06 tmp6 [V06 ] ( 0, 0 ) long -> zero-ref class-hnd exact "Inlining Arg" <System.Int32>;* V07 tmp7 [V07 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] "stack allocated boxed value class temp" <System.Collections.Generic.KeyValuePair`2[long,int]>;* V08 tmp8 [V08 ] ( 0, 0 ) long -> zero-ref "V07.[000..008)";* V09 tmp9 [V09 ] ( 0, 0 ) int -> zero-ref "V07.[008..012)";; Lcl frame size = 40G_M46144_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=1 PerfScore 0.25G_M46144_IG02: ;; offset=0x0004moveax,100 ;; size=5 bbWeight=1 PerfScore 0.25G_M46144_IG03: ;; offset=0x0009addrsp,40ret ;; size=5 bbWeight=1 PerfScore 1.25; Total bytes of code 14, prolog size 4, PerfScore 1.75, instruction count 4, allocated bytes for code 14 (MethodHash=cd934bbf) for method C:Main():int (FullOpts); ============================================================
Looks like we don't manage to remove the frame entirely since we don't get rid of the heap allocation until post-lower DCE, so there is still a helper call during lowering when we're figuring out how much outgoing arg space we need.
jakobbotsch
jakobbotsch
commented
Jun 12, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@AndyAyersMS
AndyAyersMS
merged commit 5a08c84
into
AndyAyersMS:StackAllocateUnescapedBoxesJun 12, 2024
@jakobbotsch
jakobbotsch
deleted the

stack-allocate-unescaped-boxes-lclmorph

branch
June 12, 2024 18:15
AndyAyersMS pushed a commit
that referenced
this pull request
Sep 7, 2024
@adamsitnik
[NRBF] Fix bugs discovered by the fuzzer (dotnet#107368)
e79426e
* bug #1: don't allow for values out of the SerializationRecordType enum range
* bug #2: throw SerializationException rather than KeyNotFoundException when the referenced record is missing or it points to a record of different type
* bug #3: throw SerializationException rather than FormatException when it's being thrown by BinaryReader (or sth else that we use)
* bug #4: document the fact that IOException can be thrown
* bug #5: throw SerializationException rather than OverflowException when parsing the decimal fails
* bug #6: 0 and 17 are illegal values for PrimitiveType enum
* bug #7: throw SerializationException when a surrogate character is read (so far an ArgumentException was thrown)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch@AndyAyersMS

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Minor fixes - #6
Merged
AndyAyersMS merged 2 commits into
AndyAyersMS:StackAllocateUnescapedBoxesfrom 
jakobbotsch:stack-allocate-unescaped-boxes-lclmorph
Jun 12, 2024
Merged
Minor fixes#6
AndyAyersMS merged 2 commits into
AndyAyersMS:StackAllocateUnescapedBoxesfrom 
jakobbotsch:stack-allocate-unescaped-boxes-lclmorph
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Jun 12, 2024

Copy link


Copy Markdown

Switch local morph to use its semantic reasoning about addresses in the GT_EQ/GT_NE cases. Add a missing return false.
@jakobbotsch
jakobbotsch
commented
Jun 12, 2024

Copy link


Copy Markdown

Author
With this we manage to reduce the case in dotnet#9118 to
; Assembly listing for method C:Main():int (FullOpts); Emitting BLENDED_CODE for X64 with AVX - Windows; FullOpts code; optimized code; rsp based frame; partially interruptible; No PGO data; 1 inlinees with PGO data; 3 single block inlinees; 1 inlinees without PGO data; Final local variable assignments;; V00 OutArgs [V00 ] ( 1, 1 ) struct (32) [rsp+0x00] do-not-enreg[XS] addr-exposed "OutgoingArgSpace";* V01 tmp1 [V01,T00] ( 0, 0 ) ref -> zero-ref class-hnd exact single-def "NewObj constructor temp" <ObjectEqualityComparer`1[int]>;* V02 tmp2 [V02 ] ( 0, 0 ) ubyte -> zero-ref "Inline return value spill temp";* V03 tmp3 [V03 ] ( 0, 0 ) int -> zero-ref ld-addr-op "Inlining Arg";* V04 tmp4 [V04 ] ( 0, 0 ) long -> zero-ref class-hnd exact "Single-def Box Helper" <System.Int32>;* V05 tmp5 [V05 ] ( 0, 0 ) ubyte -> zero-ref "Inline return value spill temp";* V06 tmp6 [V06 ] ( 0, 0 ) long -> zero-ref class-hnd exact "Inlining Arg" <System.Int32>;* V07 tmp7 [V07 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] "stack allocated boxed value class temp" <System.Collections.Generic.KeyValuePair`2[long,int]>;* V08 tmp8 [V08 ] ( 0, 0 ) long -> zero-ref "V07.[000..008)";* V09 tmp9 [V09 ] ( 0, 0 ) int -> zero-ref "V07.[008..012)";; Lcl frame size = 40G_M46144_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=1 PerfScore 0.25G_M46144_IG02: ;; offset=0x0004moveax,100 ;; size=5 bbWeight=1 PerfScore 0.25G_M46144_IG03: ;; offset=0x0009addrsp,40ret ;; size=5 bbWeight=1 PerfScore 1.25; Total bytes of code 14, prolog size 4, PerfScore 1.75, instruction count 4, allocated bytes for code 14 (MethodHash=cd934bbf) for method C:Main():int (FullOpts); ============================================================
Looks like we don't manage to remove the frame entirely since we don't get rid of the heap allocation until post-lower DCE, so there is still a helper call during lowering when we're figuring out how much outgoing arg space we need.
jakobbotsch
jakobbotsch
commented
Jun 12, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@AndyAyersMS
AndyAyersMS
merged commit 5a08c84
into
AndyAyersMS:StackAllocateUnescapedBoxesJun 12, 2024
@jakobbotsch
jakobbotsch
deleted the

stack-allocate-unescaped-boxes-lclmorph

branch
June 12, 2024 18:15
AndyAyersMS pushed a commit
that referenced
this pull request
Sep 7, 2024
@adamsitnik
[NRBF] Fix bugs discovered by the fuzzer (dotnet#107368)
e79426e
* bug #1: don't allow for values out of the SerializationRecordType enum range
* bug #2: throw SerializationException rather than KeyNotFoundException when the referenced record is missing or it points to a record of different type
* bug #3: throw SerializationException rather than FormatException when it's being thrown by BinaryReader (or sth else that we use)
* bug #4: document the fact that IOException can be thrown
* bug #5: throw SerializationException rather than OverflowException when parsing the decimal fails
* bug #6: 0 and 17 are illegal values for PrimitiveType enum
* bug #7: throw SerializationException when a surrogate character is read (so far an ArgumentException was thrown)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch@AndyAyersMS