feat: add loong64 support by msojocs · Pull Request #33 · AppImage/type2-runtime

msojocs · 2024-05-19T14:45:15Z

chroot_build.sh works fine. And I add loong64 support in it, the script works fine on Arch.
~~But ubuntu-latest of github action does not support loongarch64.~~
~~So I use docker to complete it.~~

Now I use the latest version of qemu-user-static to complete it.

Local Arch Linux

[msojocs@DESKTOP-1TV4OAG type2-runtime-loongarch]$ which qemu-arm-static
/usr/sbin/qemu-arm-static
[msojocs@DESKTOP-1TV4OAG type2-runtime-loongarch]$ which qemu-loongarch64-static
/usr/sbin/qemu-loongarch64-static

Github Actions

sudo apt-get -y install qemu-user-static
which qemu-arm-static
which qemu-loongarch64-static

Run sudo apt-get -y install qemu-user-static
sudo apt-get -y install qemu-user-static
which qemu-arm-static
which qemu-loongarch64-static
docker run --rm --privileged loongcr.lcpu.dev/multiarch/archlinux --reset -p yes
./build_loong64.sh
shell: /usr/bin/sh -e {0}
env:
GITHUB_TOKEN: ***
ARCHITECTURE: loong64
Reading package lists...
Building dependency tree...
Reading state information...
The following NEW packages will be installed:
qemu-user-static
0 upgraded, 1 newly installed, 0 to remove and 15 not upgraded.
Need to get 13.0 MB of archives.
After this operation, 130 MB of additional disk space will be used.
Get:1 file:/etc/apt/apt-mirrors.txt Mirrorlist [14[2](https://github.com/msojocs/type2-runtime-loongarch/actions/runs/9148408548/job/25150909441#step:5:2) B]
Get:2 http://azure.archive.ubuntu.com/ubuntu jammy-updates/universe amd64 qemu-user-static amd64 1:6.2+dfsg-2ubuntu6.19 [1[3](https://github.com/msojocs/type2-runtime-loongarch/actions/runs/9148408548/job/25150909441#step:5:3).0 MB]
Fetched 13.0 MB in 1s (21.5 MB/s)
Selecting previously unselected package qemu-user-static.
(Reading database ... (Reading database ... 5%
(Reading database ... 10%
(Reading database ... 15%
(Reading database ... 20%
(Reading database ... 25%
(Reading database ... 30%
(Reading database ... 35%
(Reading database ... [4](https://github.com/msojocs/type2-runtime-loongarch/actions/runs/9148408548/job/25150909441#step:5:4)0%
(Reading database ... 45%
(Reading database ... [5](https://github.com/msojocs/type2-runtime-loongarch/actions/runs/9148408548/job/25150909441#step:5:5)0%
(Reading database ... 55%
(Reading database ... 60%
(Reading database ... [6](https://github.com/msojocs/type2-runtime-loongarch/actions/runs/9148408548/job/25150909441#step:5:6)5%
(Reading database ... [7](https://github.com/msojocs/type2-runtime-loongarch/actions/runs/9148408548/job/25150909441#step:5:7)0%
(Reading database ... 75%
(Reading database ... [8](https://github.com/msojocs/type2-runtime-loongarch/actions/runs/9148408548/job/25150909441#step:5:8)0%
(Reading database ... 85%
(Reading database ... [9](https://github.com/msojocs/type2-runtime-loongarch/actions/runs/9148408548/job/25150909441#step:5:9)0%
(Reading database ... 95%
(Reading database ... [10](https://github.com/msojocs/type2-runtime-loongarch/actions/runs/9148408548/job/25150909441#step:5:10)0%
(Reading database ... 269108 files and directories currently installed.)
Preparing to unpack .../qemu-user-static_1%3a6.2+dfsg-2ubuntu6.19_amd64.deb ...
Unpacking qemu-user-static (1:6.2+dfsg-2ubuntu6.19) ...
Setting up qemu-user-static (1:6.2+dfsg-2ubuntu6.19) ...
Processing triggers for man-db (2.10.2-1) ...
NEEDRESTART-VER: 3.5
NEEDRESTART-KCUR: 6.5.0-1021-azure
NEEDRESTART-KEXP: 6.5.0-1021-azure
NEEDRESTART-KSTA: 1
/usr/bin/qemu-arm-static
Error: Process completed with exit code 1.

probonopd · 2024-05-19T18:26:35Z

Hi @msojocs. Thanks for the pull request.

It uses quay.io/msojocs and loongcr.lcpu.dev. How can we know that we can trust them? It would be better to use only official Alpine containers.

msojocs · 2024-05-20T01:13:50Z

Thanks for your reply.

loongcr.lcpu.dev is matained by Linux Club of Peking University.

Because the offiaial docker image not support loong64 yet, so I use this temporarily. Maybe it is not safe.

quay.io/msojocs/alpine-loong64 is the backup of lcr.loongnix.cn/library/alpine, beacuse It went down a few days ago.(now I have modified the code to use lcr.loongnix.cn)

lcr.loongnix.cn is the official site of loongson which designs loongarch architecture, it is safe.

Maybe this pr should keep in draft until the official qemu image to support loongarch?

msojocs · 2024-05-20T01:24:42Z

~~Maybe I can apply patches for loong64, but I think it is not a good idea. (https://github.com/multiarch/qemu-user-static/pull/189/files)~~

I think I can use Arch docker image and chroot_build.sh to complete it.

I will try it later.

msojocs · 2024-05-20T12:53:56Z

I did not find the stable release of alpine minirootfs for loongarch, so I am using the edge version.

probonopd · 2024-05-25T08:49:52Z

Thanks @msojocs.

It is good to use only official Alpine files. We would like to use the same Alpine release for all builds, so we should wait until loong64 support is in a Alpine release (not edge). https://wiki.alpinelinux.org/wiki/Loongarch64 says it is "planned". Hopefully it will be ready soon.

Question: Should the file extension be loong64 or loongarch64? What does env say on a loongarch64 machine?

We will also need to add it around

https://github.com/AppImage/appimagetool/blob/b9b26c34e8340d0c2f03bdf09b01cbba55d8470c/src/appimagetool.c#L369-L373

probonopd

Need to decide on loongarch64 vs loong64
Need to wait until it is in Alpine release
NOTE: Need to also patch appimagetool

msojocs · 2024-05-25T11:44:13Z

reference: loong-or-loongarch(chinese)

Linux	Architecture
AOSC OS	`loongarch64`
Debian	old world：`loongarch64` new world：`loong64`
Gentoo	`loong`
Loong Arch Linux	`loong64`
RPM 系	`loongarch64`
Slackware	`loong64`

Many Linux distributions use loong64, so I think loong64 is better than loongarch64.

Of course, I also think Loongarch is a bit of a mess right now.

Program Language	Architecture
C#	`LoongArch64`
Go	`GOARCH=loong64`
Rust	`loongarch64-unknown-linux-gnu`

probonopd · 2024-07-27T10:15:10Z

http://dl-cdn.alpinelinux.org/alpine/v3.20/releases/ still doesn't have this architecture. Will it arrive soon?

msojocs · 2024-07-27T10:19:50Z

https://wiki.alpinelinux.org/wiki/Loongarch64

Official support is planned for Alpine 3.21.

TheAssassin · 2024-12-08T15:08:04Z

Tempted to reject since we don't even have the hardware and nobody is committed to maintaining this specific architecture.

Edit: please create an issue beforehand next time. I have just peeked at your changes, it would take at least 10 minutes to explain all the necessary changes. But we have not even decided whether we would want to support this at all.

probonopd · 2024-12-08T15:12:19Z

loong64 might become popular, particular in China. So supporting it would be welcome in principle, even though I currently have no hardware to test it with.

loong64 is only supported in Alpine starting from 3.21.

Currently our Dockerfile uses FROM alpine:3.20. For this to work, we would need FROM alpine:3.21 but either that build fails or the build product doesn't work properly (to be retested).

Bump alpine from 3.20 to 3.21 in /scripts/docker #109

Hence, independently from this PR, we would need to get things going on 3.21 first before we can even consider supporting loong64.

probonopd · 2024-12-09T12:41:19Z

Alpine 3.21 works now, so we may consider this. Let's continue discussion in

Consider to add loong64 support #108

xen0n · 2024-12-11T04:19:37Z

-
-wget "http://dl-cdn.alpinelinux.org/alpine/v3.17/releases/${ARCHITECTURE}/alpine-minirootfs-3.17.2-${ARCHITECTURE}.tar.gz"
+if [ "$ARCHITECTURE" = "loong64" ];then
+ wget -c "https://dev.alpinelinux.org/~loongarch/edge/releases/loongarch64/alpine-minirootfs-edge-240514-loongarch64.tar.gz" -O alpine-minirootfs-edge-240514-loong64.tar.gz


You can switch to 3.21 and in fact unify the download logic here by parameterizing the version number. See #111 for an approach.

xen0n · 2024-12-11T04:20:51Z

 	exit 1
 fi
-
+if [ "$ARCHITECTURE" == "" ] && [ "$1" != "" ];then


IIRC, POSIX sh seems to only support [ xxx = yy ] i.e. single equal sign.

xen0n · 2024-12-11T04:23:50Z

+uname -m
 apk update
+if [ "$ARCHITECTURE" == "loong64" ];then
+	# only loong64 can install this package, other arch can not install it.


This is not because LoongArch is special, only that its Alpine baseline is different than others -- the package is also needed for other architectures if they're switched to Alpine 3.21.
For now though, the comment can be removed as having no additional info is better than inaccurate info, and the intent behind the code is at least kinda clear. Also, moving the installation of extra packages after the common ones should be more intuitive.

xen0n · 2024-12-11T04:26:06Z

+ if [ -d "./miniroot" ];then
+ sudo umount miniroot/proc miniroot/sys miniroot/dev
+ fi
+ # sudo rm -rf ./miniroot


Is this remnant of debugging code? It could be better to remove it before submitting for review.

feat: add loong64 support
98db66a

perf: use official image
c31e586

msojocs marked this pull request as draft May 20, 2024 05:48

msojocs force-pushed the loong64 branch 2 times, most recently from cdbfe43 to c31e586Compare May 20, 2024 06:54

perf: use official file
86afe22

msojocs marked this pull request as ready for review May 20, 2024 12:27

msojocs mentioned this pull request May 21, 2024
feat: add loong64 support AppImage/appimagetool#53
Closed

probonopd reviewed May 25, 2024
View reviewed changes

probonopd mentioned this pull request Dec 8, 2024
Consider to add loong64 support #108
Open

TheAssassin marked this pull request as draft December 8, 2024 15:27

msojocs closed this Dec 9, 2024

xen0n mentioned this pull request Dec 11, 2024
[WIP] Add support for LoongArch64 #111
Closed

xen0n reviewed Dec 11, 2024
View reviewed changes

Uh oh!

Conversation

msojocs commented May 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Local Arch Linux

Github Actions

Uh oh!

probonopd commented May 19, 2024

Uh oh!

msojocs commented May 20, 2024

Uh oh!

msojocs commented May 20, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msojocs commented May 20, 2024

Uh oh!

probonopd commented May 25, 2024

Uh oh!

probonopd left a comment

Choose a reason for hiding this comment

Uh oh!

msojocs commented May 25, 2024

Uh oh!

probonopd commented Jul 27, 2024

Uh oh!

msojocs commented Jul 27, 2024

Uh oh!

TheAssassin commented Dec 8, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

probonopd commented Dec 8, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

probonopd commented Dec 9, 2024

Uh oh!

xen0nDec 11, 2024

Choose a reason for hiding this comment

Uh oh!

xen0nDec 11, 2024

Choose a reason for hiding this comment

Uh oh!

xen0nDec 11, 2024

Choose a reason for hiding this comment

Uh oh!

xen0nDec 11, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

msojocs commented May 19, 2024•
edited
Loading

msojocs commented May 20, 2024•
edited
Loading

TheAssassin commented Dec 8, 2024•
edited
Loading

probonopd commented Dec 8, 2024•
edited
Loading