Develop by intmain · Pull Request #1 · ArchitectureStudy/githubIssue

intmain · 2017-09-26T16:35:39Z

reqeust

reload 해결 이전.

yoonhg84 · 2017-09-26T16:39:28Z

+ return json.arrayValue.map{
+ Model.Issue(json: $0)
+ }
+ })


뭔가 좀더 간단히 할 수 있을 것 같은데..
letresult= dataResponse.map{ $0.arrayValue }.map{Model.Issue(json: $0)}

yoonhg84 · 2017-09-26T16:40:02Z

+ }
+
+ typealias IssueResponsesHandler = (DataResponse<[Model.Issue]>) -> Void
+ static func repoIssues(owner: String, repo: String) -> (Int, @escaping IssueResponsesHandler) -> Void {


typealias는 class 밖에 있는게 더 읽기 편할듯?

API. IssueResponsesHandler 보다 IssueResponsesHandler가 나아보이나요?

yoonhg84 · 2017-09-26T16:41:54Z

+ if !GlobalState.instance.isLoggedIn {
+ let loginViewController = LoginViewController.viewController
+ DispatchQueue.main.asyncAfter(deadline: .now() + 0.0, execute: { [weak self] in
+ self?.window?.rootViewController?.present(loginViewController, animated: false, completion: nil)


여기야 말로 unowned로 써도 되겠네요?
아니면... 이렇게 회피? ㅋㅋㅋ
UIApplication.shared.delegate?.window?.rootViewController?.present(loginViewController, animated:false, completion:nil)

yoonhg84 · 2017-09-26T16:42:56Z

+ print(issue)
+ self.createdIssue = issue
+ self.performSegue(withIdentifier: "UnwindToIssues", sender: self)
+ case .failure(_):


이거도 case .failure:

yoonhg84 · 2017-09-26T16:43:43Z

+ static let tokenKey = "token"
+ static let ownerKey = "owner"
+ static let repoKey = "repo"
+ static let reposKey = "repos"


전 이런 공백 극혐함 ㅋㅋ

yoonhg84 · 2017-09-26T16:44:00Z

+ var token: String? {
+ get {
+ let token = UserDefaults.standard.string(forKey: constants.tokenKey)
+ return token


token 변수가 불필요?

yoonhg84 · 2017-09-26T16:46:12Z

+ "body": body,
+ "state": state.display,
+ "user": ["id": user.id, "login": user.login, "acatar_url": (user.avatarURL?.absoluteString ?? "")]
+ ] as [String : Any]


윽 이부분 읽기 어렵네요.
탭 좀..

그리고 결국 타입이 [String:Any] 라면 변수에 적어주는게 더 좋겠네요.
vardict:[String:Any]=["id": id,"number": number,"title": title,"comments": comments,"body": body,"state": state.display,"user":["id": user.id,"login": user.login,"acatar_url":(user.avatarURL?.absoluteString ??"")]]

yoonhg84 · 2017-09-26T16:49:01Z

+ enum State: String {
+ case open = "open"
+ case closed = "closed"
+ case none = "none"


String 을 상속받고 case 와 rawValue 가 같으면 rawValue 따로 안 써도 됩니다.
enumState:String{case open case closed case none }

yoonhg84 · 2017-09-26T16:49:20Z

+ switch self {
+ case .open: return "opened"
+ case .closed: return "closed"
+ default: return "-"


case none:

yoonhg84 · 2017-09-26T16:51:07Z

+
+ static var cellFromNib: IssueCell {
+ get {
+ return Bundle.main.loadNibNamed("IssueCell", owner: nil, options: nil)?.first as! IssueCell


오류날 일은 없겠지만... 그래도 as!는 위험하니
guardlet cell =Bundle.main.loadNibNamed("IssueCell", owner:nil, options:nil)?.first as?IssueCellelse{assertionFailure()returnIssueCell()} return cell

yoonhg84 · 2017-09-26T16:51:35Z

+ }
+ }
+
+ func update(data issue: Model.Issue) {


func update(issue:Model.Issue){

오 이거는 프로토콜때매 data

yoonhg84 · 2017-09-26T16:52:19Z

+final class IssueCommentCell: UICollectionViewCell, CellProtocol {
+
+
+ @IBOutlet var bodyLabel: UILabel!


빈줄은 한줄

yoonhg84 · 2017-09-26T16:55:53Z

+
+ @IBOutlet var commentTextField: UITextField!
+ var owner: String = ""
+ var repo: String = ""


빈줄이 IBOutlet 두개 사이가 아니라 owner 와 commentTextField 사이에 들어가는게 더 보기 좋을 것 같네요

yoonhg84 · 2017-09-26T16:56:43Z

+ var owner: String = ""
+ var repo: String = ""
+ var issue: Model.Issue!
+ var headerSize: CGSize = CGSize.zero


줄임 가능
varheaderSize:CGSize=.zero

yoonhg84 · 2017-09-26T16:57:47Z

+ @IBAction func sendButtonTapped(_ sender: Any) {
+ let comment = commentTextField.text ?? ""
+ API.createComment(owner: owner, repo: repo, number: issue.number, comment: comment) { [weak self] (dataResponse: DataResponse<Model.Comment>) in
+ guard let `self` = self else { return }


이거에 대한 의견도 많죠.
전 self는 안 쓰자는 주의 ㅋ
[weak self] 를 놓쳤을때 찾기가 쉽지 않아서..

yoonhg84 · 2017-09-26T16:58:22Z

+
+ default:
+
+ assert(false, "Unexpected element kind")


assertionFailure("Unexpected element kind")

yoonhg84 · 2017-09-26T17:00:43Z

+
+ }
+ override func prepare(for segue: UIStoryboardSegue, sender: Any?) {
+ if let detailViewController = segue.destination as? IssueDetailViewController,let issue = sender as? Model.Issue {


여기서는 segue.identifier 인가로 비교하는게 좋지 않나요?

분기의 목적보다는 까려는 목적? 어케 생각하시나요?

yoonhg84 · 2017-09-26T17:01:22Z

+
+ case UICollectionElementKindSectionHeader:
+ assert(false, "Unexpected element kind")
+


이렇게 사용하시면 release 빌드에서 오류납니다.
assert외에 다른 문장이 없으면 항상 break를 같이 넣어주세요

yoonhg84 · 2017-09-26T17:02:38Z

+ estimatedLayout[key] = nil
+ } else {
+ estimatedLayout = [:]
+ }


개인 취향
guardlet key = indexPath else{ estimatedLayout =[:]return}estimatedLayout[key]=nil

yoonhg84 · 2017-09-26T17:03:07Z

+ func estimateLayoutAttributes(_ layoutAttributes: UICollectionViewLayoutAttributes) -> UICollectionViewLayoutAttributes {
+ if layoutAttributes.isHidden {
+ return layoutAttributes
+ }


guard layoutAttributes.isHidden ==falseelse{return layoutAttributes }

yoonhg84 · 2017-09-26T17:04:09Z

+ if needRefreshDatasource {
+ datasource = []
+ needRefreshDatasource = false
+ }


이거야 말로 guard를 써야 할때
guard needRefreshDatasource ==trueelse{return} datasource =[] needRefreshDatasource =false

yoonhg84 · 2017-09-26T17:04:49Z

+ var page: Int = 1
+ var canLoadMore: Bool = true
+ fileprivate var estimatedSizes: [IndexPath: CGSize] = [:]
+ fileprivate let estimateCell: CellType = CellType.cellFromNib


멤버변수 선언이 정신이 없네요.
accessor 별로 분류 하거나 기능별로 분류하거나 뭔가 기준이 있으면 좋을 것 같아요

yoonhg84 · 2017-09-26T17:05:05Z

+ var api: ((Int, @escaping IssueResponsesHandler) -> Void)?
+
+ func loadMore(indexPath: IndexPath) {
+ guard indexPath.item == datasource.count - 1 && !isLoading && canLoadMore else { return }


guard 뒤에 공백이 2개!

yoonhg84 · 2017-09-26T17:05:26Z

+ }
+
+ func load() {
+ guard isLoading == false else {return }


return 앞에 공백 필요

yoonhg84 · 2017-09-26T17:05:56Z

+ func load() {
+ guard isLoading == false else {return }
+ isLoading = true
+ api?(page, {[weak self] (response: DataResponse<[Item]>) -> Void in


api?(page){[weak self](response:DataResponse<[Item]>)->Void in

yoonhg84 · 2017-09-26T17:06:36Z

+ canLoadMore = false
+ loadMoreCell?.loadDone()
+
+ }


의미없는 빈줄인것 같네요

yoonhg84 · 2017-09-26T17:07:08Z

+ 가져온 사이즈를 인덱싱.
+ 그 사이즈를 리턴.
+
+ */


불필요한 주석?

yoonhg84 · 2017-09-26T17:08:41Z

+
+
+ @IBAction func unwindFromRepos(_ segue: UIStoryboardSegue) {
+ if let reposViewController = segue.source as? ReposViewController, let (owner, repo) = reposViewController.selectedRepo {


이것도 guard가 더 깔끔?

yoonhg84 · 2017-09-26T17:09:17Z

+ GlobalState.instance.token = ""
+ let loginViewController = LoginViewController.viewController
+ DispatchQueue.main.asyncAfter(deadline: .now() + 0.0, execute: { [weak self] in
+ self?.present(loginViewController, animated: true, completion: nil)


DispatchQueue.main.asyncAfter(deadline:.now()+0.0){[weak self] in

yoonhg84 · 2017-09-26T17:09:50Z

+ return .put
+ case .repoIssues,
+ .issueDetail
+ :


콜론을 왜 내리셨나요?

API는 한개씩 추가되니까 아래줄에 하나씩만 추가하려고요

yoonhg84 · 2017-09-26T17:10:58Z

+ let rect = CGRect(x: 0, y: 0, width: size.width, height: size.height)
+ UIGraphicsBeginImageContext(rect.size)
+
+ if let context = UIGraphicsGetCurrentContext() {


이것도 guard가 깔끔

intmain

캬

intmain · 2017-09-26T16:41:46Z

+ }
+
+ typealias IssueResponsesHandler = (DataResponse<[Model.Issue]>) -> Void
+ static func repoIssues(owner: String, repo: String) -> (Int, @escaping IssueResponsesHandler) -> Void {


API. IssueResponsesHandler 보다 IssueResponsesHandler가 나아보이나요?

intmain · 2017-09-26T16:53:54Z

+ }
+ }
+
+ func update(data issue: Model.Issue) {


오 이거는 프로토콜때매 data

intmain · 2017-09-26T17:03:05Z

+
+ }
+ override func prepare(for segue: UIStoryboardSegue, sender: Any?) {
+ if let detailViewController = segue.destination as? IssueDetailViewController,let issue = sender as? Model.Issue {


분기의 목적보다는 까려는 목적? 어케 생각하시나요?

intmain · 2017-09-26T17:11:50Z

+ return .put
+ case .repoIssues,
+ .issueDetail
+ :


API는 한개씩 추가되니까 아래줄에 하나씩만 추가하려고요

Leonard-happy added 7 commits September 10, 2017 11:09

인증 API, Issues API, Model (Issue, User) 추가.
b2cd611

IssuesViewController 완
91e816e

모든 기능 구션
da76a5f
reload 해결 이전.

loadmore 뷰 추가.
fe7e016

1차 추상
d7dc081

리스트뷰 추상
29bcc8e

헤더 셀 사이즈 계산 캐시.
bd491c1

yoonhg84 reviewed Sep 26, 2017
View reviewed changes

intmain commented Sep 26, 2017
View reviewed changes

Leonard-happy added 2 commits October 1, 2017 22:11

bitbucket 지원 완료
61c3bbe

swiftlint 적용.
67fcdec

		final class IssueCommentCell: UICollectionViewCell, CellProtocol {


		@IBOutlet var bodyLabel: UILabel!


		case UICollectionElementKindSectionHeader:
		assert(false, "Unexpected element kind")



		@IBAction func unwindFromRepos(_ segue: UIStoryboardSegue) {
		if let reposViewController = segue.source as? ReposViewController, let (owner, repo) = reposViewController.selectedRepo {

Uh oh!

Conversation

intmain commented Sep 26, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yoonhg84Sep 26, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

intmain left a comment

Choose a reason for hiding this comment

yoonhg84Sep 26, 2017•
edited
Loading