fix(sessions): preserve active terminal during launches - #180
Merged
Conversation
Lint111
marked this pull request as ready for review
July 29, 2026 17:24
runAntigravity() landed on master after this branch was cut, so it kept the exact pattern the rest of this PR removes: terminal.clear() plus direct writeln into whatever session happened to be active. Merging master in surfaced it, leaving one of six run modes still wiping the active session's xterm on launch. Also adds regression coverage that can actually see the bug. The existing test drives the three helpers directly, so it stays green even when a run*() function is reverted to writing at the terminal itself: reverting runClaude()'s call site keeps all 16 tests passing. The new static guard scans session-ui.js and fails if any run*() body touches this.terminal.clear/writeln, which catches a regressed call site and would have caught runAntigravity on its own. A second unit test covers the home-screen path that nothing exercised: with no active session, launch progress must still clear and render in the terminal. Verified in a browser against a live instance. With a session active, runShell() and runAntigravity() leave its terminal untouched (clear() calls: 0, writes: 0) and emit one info toast; on master the same run wipes the session's marker text. The session-less home screen still clears and writes exactly as before. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
Ark0N
commented
Aug 4, 2026
Owner
Thank you for this contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Starting a new session always cleared and wrote launch status into the shared terminal. If another session was active, the later session switch could serialize that launch chrome into the active session's cached terminal frame, producing a mixed or stale view.
Scope
This is the active-session launch-preservation slice extracted from #173. It changes only frontend launch-status routing and its focused regression test. Session creation APIs and launch sequencing are unchanged.
Behavior
Validation
npx vitest run --config config/vitest.config.ts test/run-mode-ui.test.ts: 14 passednpm run check:frontend-syntax: 26 files passednpm run build: passedgit diff --check: passed