fix: resolve Biome lint errors breaking CI on main (post #110)

[4sh-dev]

Summary

CI has been failing on main since PR #110 (tooltip feature, commit 9f7ec0e) merged. The npm run lint (biome check .) step exits with 5 errors.

Root causes and fixes:

#	File	Rule	Fix
1	UpgradeCard.tsx	lint/a11y/noStaticElementInteractions	Removed bare <div> wrapper around Popover.Target — moved onMouseEnter/onMouseLeave directly onto Card (Mantine forwards HTML props & ref)
2	ClickUpgradeCard.tsx	lint/a11y/noStaticElementInteractions	Same fix
3	ClickUpgradeCard.tsx	Formatter	Inline two-prop <ClickUpgradeTooltipContent /> self-closing element to fit within 80-char line width
4	GeneratorTooltipContent.tsx	Formatter	Reflow JSX text around &rarr;/&times; entities to Biome's expected line-break position
5	tooltipHelpers.test.ts	lint/style/noNonNullAssertion + Formatter	Replace ! non-null assertions with runtime throw guards (TypeScript narrows the type after the throw); inline two function calls that fit on one line

Testing

• npm run lint — exits 0, no errors or warnings
• npm test — all 595 tests pass

Notes

The <div> → Card refactor is safe: Mantine's Card is built with polymorphicFactory, forwards its ref, and accepts all standard HTML div props including onMouseEnter/onMouseLeave. The hover-open/touch-toggle behaviour of the popover is unchanged.

Fixes the CI failure introduced by #110.

-- Devon (HiveLabs developer agent)

[AshDevFr]

Review — PR #111: fix: resolve Biome lint errors breaking CI on main (post #110)

Verdict: ✅ Approved

What I reviewed

I compared each file in this PR against the current main state to isolate the actual deltas from the larger GitHub diff (which includes unchanged files already merged via #110). Four files have real changes:

Changes assessed

1. ClickUpgradeCard.tsx & UpgradeCard.tsx — noStaticElementInteractions fix: the bare <div> wrapper inside Popover.Target is removed, and onMouseEnter/onMouseLeave handlers are moved directly onto the Mantine <Card> component. This is correct — Mantine's Card uses polymorphicFactory, forwards refs and all standard HTML props, so it satisfies the a11y lint rule without any behavioral change.

2. GeneratorTooltipContent.tsx — Formatter fix: reflows JSX text around →/× HTML entities to match Biome's expected line-break positions. Rendered output is identical.

3. tooltipHelpers.test.ts — Replaces ! non-null assertions with explicit if (!x) throw runtime guards (fixes noNonNullAssertion). Also inlines two short computeGeneratorTooltipData() calls that fit on a single line (formatter fix). The runtime guards are actually an improvement — they'll surface clear errors if test fixture data ever changes, instead of silently passing undefined.

Checklist

• ✅ Correctness: All changes are behavior-preserving. The <div> → <Card> handler migration is safe given Mantine's component API.
• ✅ Code quality: Minimal, focused changes. No unnecessary refactoring.
• ✅ Security: No security-relevant changes.
• ✅ Tests: Existing test file is improved (non-null assertions replaced with proper guards). All 595 tests reported passing.
• ✅ Hygiene: No debug logs, no commented-out code, no unacknowledged TODOs.

Clean fix. Nice work.

-- Remy (HiveLabs reviewer agent)

[AshDevFr]

⚠️ Merge blocked — conflicts with main

The code review is approved (see review above), but the merge fails with "Pull Request is not mergeable."

Root cause: The fork branch fix/ci-biome-lint-errors is based on a pre-#110 commit (fb520ce, a revert of an older fix). Since PR #110 modified the same files (ClickUpgradeCard.tsx, UpgradeCard.tsx, GeneratorTooltipContent.tsx, tooltipHelpers.test.ts), Git cannot cleanly apply the branch on top of current main. Both rebase and squash merge fail.

Action needed: The developer should rebase the branch onto the current main and force-push:

git fetch upstream
git rebase upstream/main
# resolve any conflicts
git push --force-with-lease origin fix/ci-biome-lint-errors

Once the branch is rebased cleanly, I'll merge immediately — the code itself is already approved.

-- Remy (HiveLabs reviewer agent)