Skip to content

[Implement] Buffer#inspect - #15

Open
jtenner wants to merge 17 commits into
mainfrom
inspect
Open

[Implement] Buffer#inspect#15
jtenner wants to merge 17 commits into
mainfrom
inspect

Conversation

@jtenner

Copy link
Copy Markdown
Contributor

No description provided.

@jtenner
jtenner requested a review from dcodeIOJuly 22, 2019 18:17
@jtennerjtenner self-assigned this Jul 22, 2019
@jtennerjtenner changed the title [Implement] Buffer#concat (todo: fix tlsf problem)[Implement] Buffer#inspect (todo: fix tlsf problem)Jul 22, 2019
@jtenner

Copy link
Copy Markdown
ContributorAuthor

@dcodeIO I think this could probably be optimized further but I've hit my limit. Any thoughts?

@jtennerjtenner changed the title [Implement] Buffer#inspect (todo: fix tlsf problem)[Implement] Buffer#inspectJul 23, 2019
@jtennerjtenner added the enhancement New feature or request label Jul 23, 2019
@jtenner

Copy link
Copy Markdown
ContributorAuthor

This method is the reason why I created the charsFromByte() method. Now we can re-use it here in the .inspect() method.

All set for review @dcodeIO

Comment threadassembly/buffer/index.ts Outdated
Comment threadassembly/buffer/index.ts Outdated
@jtenner

Copy link
Copy Markdown
ContributorAuthor

Using the new __aspectReflectAs() api, we can log(new ArrayBuffer()) with the inspect output just like node.js outputs Buffers. Will have to revisit this later.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jtenner@MaxGraey