Uh oh!
There was an error while loading. Please reload this page.
Conversation
dcodeIO
reviewed
Jul 19, 2019
Uh oh!
There was an error while loading. Please reload this page.
dcodeIO
reviewed
Jul 19, 2019
Uh oh!
There was an error while loading. Please reload this page.
dcodeIO
reviewed
Jul 19, 2019
Uh oh!
There was an error while loading. Please reload this page.
ContributorAuthor
I think I'm going to implement a test function for utility purposes. functionbufferFrom(values: i32[]): Buffer{letlength=values.lengrh;letbuffer=Buffer.allocUnsafe(length);for(leti=0;i<length;i++)buffer[i]=u8(unchecked(values[i]));returnbuffer;}This should be relatively safe for testing. |
jtenner
commented
Jul 31, 2019
ContributorAuthor
Do you think this can be merged? It looks good to me. |
jtenner
commented
Mar 12, 2020
ContributorAuthor
Six months in the making! Time to revive this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current problems:No good logging for that extendArrayBufferView(opened issue with as-pect https://github.com/jtenner/as-pect/issues/132 )No good way of comparing things that extendArrayBufferView(opened issue with as-pect https://github.com/jtenner/as-pect/issues/133 )No good way to create a buffer from scratch without a naiveBuffer.from<T>()functionCould create a helper function, but that's a todoThis pull request is not blocked by anything. Current questions:
i32.MAX_VALUE?nullcheck on the array? (in case of uninitialized field problems?)