Uh oh!
There was an error while loading. Please reload this page.
escape quote and crlf in multipart content-disposition values - #2203
Merged
hyperxpro merged 1 commit intoJun 19, 2026
Merged
Conversation
hyperxpro
approved these changes
Jun 19, 2026
Uh oh!
There was an error while loading. Please reload this page.
hyperxpro added a commit
that referenced
this pull request
Jul 18, 2026
Motivation `MultipartPart` writes several part-header fields (`dispositionType`, `contentType`, `contentTransferEncoding`, `contentId`, and custom header names/values) directly into the multipart header without validating CR/LF characters. This allows header injection or multipart body splitting. While `name` and `filename` were hardened in #2203, these fields remained unprotected. Modification Add `asciiHeaderBytes(String)` to reject CR/LF characters before encoding to US-ASCII, and use it for all raw part-header fields. `name` and `filename` continue using their existing quoted-string escaping. Result Raw part-header fields now fail fast on CR/LF input, preventing header injection while leaving valid values unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unescaped values in the multipart Content-Disposition header:
Percent-escape ", CR and LF in both before the bytes are written, per RFC 7578 section 5.1.