Uh oh!
There was an error while loading. Please reload this page.
Bind origin Kerberos/SPNEGO token to the origin service, not the proxy - #2245
Merged
Conversation
perConnectionAuthorizationHeader built the origin realm's Negotiate token against proxyServer.getHost() whenever a proxy was configured, producing a service ticket for the proxy's SPN. That is a confused deputy: the origin credential is delivered to, and only usable by, the proxy, while origin authentication fails. Always target the origin host (virtualHost or the request host); the proxy realm keeps its own per-connection path.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a proxy is configured,
perConnectionAuthorizationHeaderincorrectly builds the origin Kerberos/SPNEGO token using the proxy host instead of the origin host. This generates a service ticket for the proxy's SPN, causing origin authentication to fail and misdirecting the credential.Modification
Always build the origin token using the origin host (
request.getVirtualHost()when set, otherwiserequest.getUri().getHost()). Proxy authentication remains unchanged and continues to useperConnectionProxyAuthorizationHeader.Result
Origin Kerberos/SPNEGO authentication now targets the correct SPN even when requests are sent through a proxy. Proxy authentication and direct (non-proxy) behavior remain unchanged.