Skip to content

Mirror Netty option-failure semantics in applyChannelOptions#2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperxpro merged 1 commit into from
Jul 18, 2026
Merged

Mirror Netty option-failure semantics in applyChannelOptions #2247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion client/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -300,12 +300,24 @@ private static Map.Entry<ChannelOption<?>, Object>[] buildChannelOptions(AsyncHt
* Applies the pre-resolved channel options to a freshly created channel. Invoked from the channel initializer
* (once per connection, on the channel's event loop, before the channel is connected), mirroring what
* {@link Bootstrap#option} would otherwise do but without the shared, synchronized options map.
* <p>
* The per-option handling mirrors Netty's {@code AbstractBootstrap#setChannelOption}: an unknown option is
* warned about and skipped, and a failure to set an option is warned about and rethrown so the channel is
* closed rather than connecting with a half-applied configuration.
*/
@SuppressWarnings("unchecked")
private void applyChannelOptions(Channel channel) {
ChannelConfig channelConfig = channel.config();
for (Map.Entry<ChannelOption<?>, Object> option : channelOptions) {
channelConfig.setOption((ChannelOption<Object>) option.getKey(), option.getValue());
ChannelOption<Object> key = (ChannelOption<Object>) option.getKey();
try {
if (!channelConfig.setOption(key, option.getValue())) {
LOGGER.warn("Unknown channel option '{}' for channel '{}'", key, channel);
}
} catch (Throwable t) {
LOGGER.warn("Failed to set channel option '{}' with value '{}' for channel '{}'", key, option.getValue(), channel, t);
throw t;
}
}
}

Expand Down
Loading