Uh oh!
There was an error while loading. Please reload this page.
refuse secure cookies planted over a plaintext connection - #2315
Closed
jmestwa-coder wants to merge 1 commit into
Closed
refuse secure cookies planted over a plaintext connection#2315jmestwa-coder wants to merge 1 commit into
jmestwa-coder wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThreadSafeCookieStore.add ignores the scheme a Set-Cookie arrived on, so anyone on the plaintext path of http://example.com can plant or replace the cookie the site only ever sets inside TLS and the next https request carries it back (RFC 6265bis section 5.7, steps 14 and 22, the Strict Secure Cookies rules browsers and curl apply):
Both checks now live in add(), keyed on the request URI scheme and placed before the expiry branch; the path test is one-way as the spec asks, so a non-Secure cookie for /foo is still fine next to a Secure one for /login. SecureCookieSchemeTest covers the three rejections and the unchanged https and plain-http cases.