Skip to content

Enhance provider to add resync() method - #359

Open
earthman1 wants to merge 10 commits into
masterfrom
walktweak
Open

Enhance provider to add resync() method#359
earthman1 wants to merge 10 commits into
masterfrom
walktweak

Conversation

@earthman1

@earthman1earthman1 commented Jul 8, 2021

Copy link
Copy Markdown
Contributor

resync method is same as walk, but will take a path to a file or folder. Walk only accepts folders.

@codecov

codecovBot commented Jul 8, 2021

Copy link
Copy Markdown

Codecov Report

Merging #359 (7f97121) into master (44d787e) will decrease coverage by 3.78%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #359 +/- ##
==========================================
- Coverage 89.33% 85.54% -3.79% 
==========================================
Files 29 33 +4 Lines 4502 6408 +1906 Branches 854 1191 +337 ==========================================
+ Hits 4022 5482 +1460 - Misses 294 616 +322 - Partials 186 310 +124 
Impacted FilesCoverage Δ
cloudsync/provider.py91.05% <100.00%> (-2.23%)⬇️
cloudsync/sync/sqlite_storage.py83.11% <0.00%> (-2.22%)⬇️
cloudsync/event.py92.97% <0.00%> (-1.92%)⬇️
cloudsync/runnable.py92.10% <0.00%> (-0.82%)⬇️
cloudsync/command/utils.py92.24% <0.00%> (-0.73%)⬇️
cloudsync/oauth/apiserver.py81.58% <0.00%> (-0.69%)⬇️
cloudsync/smartsync.py90.37% <0.00%> (-0.54%)⬇️
cloudsync/sync/manager.py86.21% <0.00%> (-0.01%)⬇️
cloudsync/__main__.py0.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d787e...7f97121. Read the comment docs.

@earthman1earthman1 changed the title Enhance walk() to take a file to resyncEnhance provider to add resync() methodJul 14, 2021
@earonesty

Copy link
Copy Markdown
Contributor

can we add the @deprecated decorator to walk?

Comment threadcloudsync/provider.py
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed! Quality Gate passed

BugA0 Bugs
VulnerabilityA0 Vulnerabilities
Security HotspotA0 Security Hotspots
Code SmellA4 Code Smells

No Coverage information No Coverage information
0.0%0.0% Duplication

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@earthman1@earonesty