Remove membersChange24hrPercent - #346

Merged
rickyrombo merged 3 commits into
mainfrom
mjp-insights-faster
Aug 28, 2025
Merged

Remove membersChange24hrPercent#346
rickyrombo merged 3 commits into
mainfrom
mjp-insights-faster

Conversation

@rickyrombo

Copy link
Copy Markdown
Contributor

Removes the membersChange24hrPercent from the /v1/coins/:mint/insights endpoint.

It's not included in the design anymore and is slowing down the endpoint greatly.

@DejayJDDejayJD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪

type MembersStatsRow struct {
Members int `json:"members"`
Members24hChangePercent float64 `json:"membersChange24hPercent"`
Members int `json:"members"`

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we remove this too @faridsalau / @DejayJD ? Or are we using it somewhere? Might be nice to just have this be a birdeye proxy

@rickyrombo
rickyrombo merged commit fdcdfca into mainAug 28, 2025
5 checks passed
@rickyrombo
rickyrombo deleted the mjp-insights-faster branch August 28, 2025 20:13
schottra added a commit that referenced this pull request Aug 29, 2025
* origin/main:
[API-321] Migrate tests for blast writes (#342)
Update query for best selling (#347)
Remove membersChange24hrPercent (#346)
[QA-2301] Fix blockees req (#345)
raymondjacobson added a commit that referenced this pull request Jun 9, 2026
## Summary
Bumps `github.com/OpenAudio/go-openaudio` and `.../pkg/etl` from
`c5fcacf` (#924) to **`e8586ac`**.
**Primary:** go-openaudio **#348** — fixes `playlists.last_added_to`
never being written (perpetually NULL), which silently broke the
"recently added to" sort and the playlist-update notification. Now set
to the block time of the most recent track add (code-only in #348).
**Also carried** (main advanced past the baseline): #345/#346 — the
**TrackCollaborator** entity. This adds ETL migration **0033**, which
`CREATE TABLE IF NOT EXISTS track_collaborators` (a new, empty table)
plus one index on it.
`core-indexer` runs this vendored image, so the bump is required to ship
the fix.
## Changes
- `go.mod` / `go.sum`: both go-openaudio modules →
`v1.3.1-0.20260609013415-e8586ac9ce16`
## Deploy note — migration 0033 is low risk
0033 creates a brand-new empty table + index with `IF NOT EXISTS`.
There's no existing data to scan and no `ACCESS EXCLUSIVE` lock on a
populated table (unlike the 0031 slug index), so it applies instantly —
no pre-build/CONCURRENT step needed. The `last_added_to` fix itself is
code-only (no migration).
## Test plan
- [x] `go mod tidy` — only go.mod/go.sum changed
- [x] `go build ./...` passes
- [x] resolved module contains the `last_added_to` writes (`LastAddedTo`
in playlist_row.go) and migration `0033`
- [ ] Post-deploy: migration version 33 applied clean; creating/editing
a playlist populates `last_added_to`, and a rename preserves it
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
raymondjacobson added a commit that referenced this pull request Jun 9, 2026
…hboard merge (#932)
Phase 2 of collaborative tracks (the api slice). Consumes the ETL
`TrackCollaborator` entity (go-openaudio #345 / #346) and surfaces it
through the API. **Ships inert** — nothing emits the on-chain
invites/accepts until the client work lands, so this is safe to deploy
dark.
### Recap
A track owner tags collaborator artists (in track metadata); each must
**accept** (pending → accepted). Accepted collaborators get the track on
their profile and merged into their dashboard analytics. Scope is
**display + analytics only** — no revenue split, no edit rights.
### What's here
**Table + notifications**
- `ddl/migrations/0220_track_collaborators.sql` mirrors the ETL table
with `CREATE TABLE IF NOT EXISTS` (byte-compatible with go-openaudio
migration 0033). It runs in the `migrations/` pass, *before*
`functions/`, so the trigger always has its table regardless of
ETL-indexer timing.
- `ddl/functions/handle_track_collaborator.sql` — a trigger modeled on
`handle_manager_request.sql`: a new pending invite notifies the
**collaborator** (`track_collaborator_invite`); a transition to accepted
notifies the **inviter/owner** (`track_collaborator_accept`).
- Both types added to the notifications request whitelist.
**Read path**
- Track responses now carry a `collaborators` array (accepted only),
bulk-resolved in a single indexed query folded into the existing user
fetch — no N+1.
- `GET /users/:id/tracks` UNIONs the user's owned tracks with tracks
they've accepted a credit on, preserving sort/pagination. The
artist-pick pin now references the **profile** user, so a collaborator's
track is never spuriously pinned by the *owner's* pick.
**Dashboard**
- `GET /users/:id/listen_counts_monthly` widens to include co-owned
tracks (engagement analytics).
- The dashboard track table is powered by `GET /users/:id/tracks`, so it
merges automatically.
- **Sales/revenue intentionally left scoped to the seller** —
collaborators don't share revenue (per the no-split scope). Easy to
widen later if desired; flagging for a decision.
**New endpoint**
- `GET
/users/:id/collaboration_invites?status=pending|accepted|rejected` lists
a user's invites/credits with the inviter embedded as a user object
(mirrors `/managers`). Powers the client's accept/decline UX.
### Performance
- The collaborators embed is one extra indexed query per track-list
response (returns 0 rows for the common no-collaborator case; backed by
the `track_collaborators` PK). The profile UNION uses the covering
`(collaborator_user_id, status, track_id)` index.
- Every track response now includes a `collaborators` field (empty array
when none) — a small, constant payload addition.
### Tests
`api/v1_track_collaborators_test.go`: collaborators embedded on track
responses, accepted credit appears on the collaborator's profile,
pending invite stays hidden, the invites endpoint (status filter +
validation), and the notification trigger firing for both invite and
accept. Full `./api/` package suite passes.
> Note: `sql/01_schema.sql` carries the table + trigger inline so
fresh/test DBs have them; `make test-schema` (which needs an exclusive
local pg) will canonicalize the placement on the next regen.
### Next
Phase 3 (apps): SDK methods, upload tagging UI, push + in-app
notifications, comma-separated artist line, dashboard — web + mobile,
behind a flag.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rickyrombo@DejayJD@faridsalau
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Remove membersChange24hrPercent - #346

Merged
rickyrombo merged 3 commits into
mainfrom
mjp-insights-faster
Aug 28, 2025
Merged

Remove membersChange24hrPercent#346
rickyrombo merged 3 commits into
mainfrom
mjp-insights-faster

Conversation

@rickyrombo

Copy link
Copy Markdown
Contributor

Removes the membersChange24hrPercent from the /v1/coins/:mint/insights endpoint.

It's not included in the design anymore and is slowing down the endpoint greatly.

@DejayJDDejayJD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪

type MembersStatsRow struct {
Members int `json:"members"`
Members24hChangePercent float64 `json:"membersChange24hPercent"`
Members int `json:"members"`

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we remove this too @faridsalau / @DejayJD ? Or are we using it somewhere? Might be nice to just have this be a birdeye proxy

@rickyrombo
rickyrombo merged commit fdcdfca into mainAug 28, 2025
5 checks passed
@rickyrombo
rickyrombo deleted the mjp-insights-faster branch August 28, 2025 20:13
schottra added a commit that referenced this pull request Aug 29, 2025
* origin/main:
[API-321] Migrate tests for blast writes (#342)
Update query for best selling (#347)
Remove membersChange24hrPercent (#346)
[QA-2301] Fix blockees req (#345)
raymondjacobson added a commit that referenced this pull request Jun 9, 2026
## Summary
Bumps `github.com/OpenAudio/go-openaudio` and `.../pkg/etl` from
`c5fcacf` (#924) to **`e8586ac`**.
**Primary:** go-openaudio **#348** — fixes `playlists.last_added_to`
never being written (perpetually NULL), which silently broke the
"recently added to" sort and the playlist-update notification. Now set
to the block time of the most recent track add (code-only in #348).
**Also carried** (main advanced past the baseline): #345/#346 — the
**TrackCollaborator** entity. This adds ETL migration **0033**, which
`CREATE TABLE IF NOT EXISTS track_collaborators` (a new, empty table)
plus one index on it.
`core-indexer` runs this vendored image, so the bump is required to ship
the fix.
## Changes
- `go.mod` / `go.sum`: both go-openaudio modules →
`v1.3.1-0.20260609013415-e8586ac9ce16`
## Deploy note — migration 0033 is low risk
0033 creates a brand-new empty table + index with `IF NOT EXISTS`.
There's no existing data to scan and no `ACCESS EXCLUSIVE` lock on a
populated table (unlike the 0031 slug index), so it applies instantly —
no pre-build/CONCURRENT step needed. The `last_added_to` fix itself is
code-only (no migration).
## Test plan
- [x] `go mod tidy` — only go.mod/go.sum changed
- [x] `go build ./...` passes
- [x] resolved module contains the `last_added_to` writes (`LastAddedTo`
in playlist_row.go) and migration `0033`
- [ ] Post-deploy: migration version 33 applied clean; creating/editing
a playlist populates `last_added_to`, and a rename preserves it
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
raymondjacobson added a commit that referenced this pull request Jun 9, 2026
…hboard merge (#932)
Phase 2 of collaborative tracks (the api slice). Consumes the ETL
`TrackCollaborator` entity (go-openaudio #345 / #346) and surfaces it
through the API. **Ships inert** — nothing emits the on-chain
invites/accepts until the client work lands, so this is safe to deploy
dark.
### Recap
A track owner tags collaborator artists (in track metadata); each must
**accept** (pending → accepted). Accepted collaborators get the track on
their profile and merged into their dashboard analytics. Scope is
**display + analytics only** — no revenue split, no edit rights.
### What's here
**Table + notifications**
- `ddl/migrations/0220_track_collaborators.sql` mirrors the ETL table
with `CREATE TABLE IF NOT EXISTS` (byte-compatible with go-openaudio
migration 0033). It runs in the `migrations/` pass, *before*
`functions/`, so the trigger always has its table regardless of
ETL-indexer timing.
- `ddl/functions/handle_track_collaborator.sql` — a trigger modeled on
`handle_manager_request.sql`: a new pending invite notifies the
**collaborator** (`track_collaborator_invite`); a transition to accepted
notifies the **inviter/owner** (`track_collaborator_accept`).
- Both types added to the notifications request whitelist.
**Read path**
- Track responses now carry a `collaborators` array (accepted only),
bulk-resolved in a single indexed query folded into the existing user
fetch — no N+1.
- `GET /users/:id/tracks` UNIONs the user's owned tracks with tracks
they've accepted a credit on, preserving sort/pagination. The
artist-pick pin now references the **profile** user, so a collaborator's
track is never spuriously pinned by the *owner's* pick.
**Dashboard**
- `GET /users/:id/listen_counts_monthly` widens to include co-owned
tracks (engagement analytics).
- The dashboard track table is powered by `GET /users/:id/tracks`, so it
merges automatically.
- **Sales/revenue intentionally left scoped to the seller** —
collaborators don't share revenue (per the no-split scope). Easy to
widen later if desired; flagging for a decision.
**New endpoint**
- `GET
/users/:id/collaboration_invites?status=pending|accepted|rejected` lists
a user's invites/credits with the inviter embedded as a user object
(mirrors `/managers`). Powers the client's accept/decline UX.
### Performance
- The collaborators embed is one extra indexed query per track-list
response (returns 0 rows for the common no-collaborator case; backed by
the `track_collaborators` PK). The profile UNION uses the covering
`(collaborator_user_id, status, track_id)` index.
- Every track response now includes a `collaborators` field (empty array
when none) — a small, constant payload addition.
### Tests
`api/v1_track_collaborators_test.go`: collaborators embedded on track
responses, accepted credit appears on the collaborator's profile,
pending invite stays hidden, the invites endpoint (status filter +
validation), and the notification trigger firing for both invite and
accept. Full `./api/` package suite passes.
> Note: `sql/01_schema.sql` carries the table + trigger inline so
fresh/test DBs have them; `make test-schema` (which needs an exclusive
local pg) will canonicalize the placement on the next regen.
### Next
Phase 3 (apps): SDK methods, upload tagging UI, push + in-app
notifications, comma-separated artist line, dashboard — web + mobile,
behind a flag.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rickyrombo@DejayJD@faridsalau
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Remove membersChange24hrPercent - #346

Merged
rickyrombo merged 3 commits into
mainfrom
mjp-insights-faster
Aug 28, 2025
Merged

Remove membersChange24hrPercent#346
rickyrombo merged 3 commits into
mainfrom
mjp-insights-faster

Conversation

@rickyrombo

Copy link
Copy Markdown
Contributor

Removes the membersChange24hrPercent from the /v1/coins/:mint/insights endpoint.

It's not included in the design anymore and is slowing down the endpoint greatly.

@DejayJDDejayJD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪

type MembersStatsRow struct {
Members int `json:"members"`
Members24hChangePercent float64 `json:"membersChange24hPercent"`
Members int `json:"members"`

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we remove this too @faridsalau / @DejayJD ? Or are we using it somewhere? Might be nice to just have this be a birdeye proxy

@rickyrombo
rickyrombo merged commit fdcdfca into mainAug 28, 2025
5 checks passed
@rickyrombo
rickyrombo deleted the mjp-insights-faster branch August 28, 2025 20:13
schottra added a commit that referenced this pull request Aug 29, 2025
* origin/main:
[API-321] Migrate tests for blast writes (#342)
Update query for best selling (#347)
Remove membersChange24hrPercent (#346)
[QA-2301] Fix blockees req (#345)
raymondjacobson added a commit that referenced this pull request Jun 9, 2026
## Summary
Bumps `github.com/OpenAudio/go-openaudio` and `.../pkg/etl` from
`c5fcacf` (#924) to **`e8586ac`**.
**Primary:** go-openaudio **#348** — fixes `playlists.last_added_to`
never being written (perpetually NULL), which silently broke the
"recently added to" sort and the playlist-update notification. Now set
to the block time of the most recent track add (code-only in #348).
**Also carried** (main advanced past the baseline): #345/#346 — the
**TrackCollaborator** entity. This adds ETL migration **0033**, which
`CREATE TABLE IF NOT EXISTS track_collaborators` (a new, empty table)
plus one index on it.
`core-indexer` runs this vendored image, so the bump is required to ship
the fix.
## Changes
- `go.mod` / `go.sum`: both go-openaudio modules →
`v1.3.1-0.20260609013415-e8586ac9ce16`
## Deploy note — migration 0033 is low risk
0033 creates a brand-new empty table + index with `IF NOT EXISTS`.
There's no existing data to scan and no `ACCESS EXCLUSIVE` lock on a
populated table (unlike the 0031 slug index), so it applies instantly —
no pre-build/CONCURRENT step needed. The `last_added_to` fix itself is
code-only (no migration).
## Test plan
- [x] `go mod tidy` — only go.mod/go.sum changed
- [x] `go build ./...` passes
- [x] resolved module contains the `last_added_to` writes (`LastAddedTo`
in playlist_row.go) and migration `0033`
- [ ] Post-deploy: migration version 33 applied clean; creating/editing
a playlist populates `last_added_to`, and a rename preserves it
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
raymondjacobson added a commit that referenced this pull request Jun 9, 2026
…hboard merge (#932)
Phase 2 of collaborative tracks (the api slice). Consumes the ETL
`TrackCollaborator` entity (go-openaudio #345 / #346) and surfaces it
through the API. **Ships inert** — nothing emits the on-chain
invites/accepts until the client work lands, so this is safe to deploy
dark.
### Recap
A track owner tags collaborator artists (in track metadata); each must
**accept** (pending → accepted). Accepted collaborators get the track on
their profile and merged into their dashboard analytics. Scope is
**display + analytics only** — no revenue split, no edit rights.
### What's here
**Table + notifications**
- `ddl/migrations/0220_track_collaborators.sql` mirrors the ETL table
with `CREATE TABLE IF NOT EXISTS` (byte-compatible with go-openaudio
migration 0033). It runs in the `migrations/` pass, *before*
`functions/`, so the trigger always has its table regardless of
ETL-indexer timing.
- `ddl/functions/handle_track_collaborator.sql` — a trigger modeled on
`handle_manager_request.sql`: a new pending invite notifies the
**collaborator** (`track_collaborator_invite`); a transition to accepted
notifies the **inviter/owner** (`track_collaborator_accept`).
- Both types added to the notifications request whitelist.
**Read path**
- Track responses now carry a `collaborators` array (accepted only),
bulk-resolved in a single indexed query folded into the existing user
fetch — no N+1.
- `GET /users/:id/tracks` UNIONs the user's owned tracks with tracks
they've accepted a credit on, preserving sort/pagination. The
artist-pick pin now references the **profile** user, so a collaborator's
track is never spuriously pinned by the *owner's* pick.
**Dashboard**
- `GET /users/:id/listen_counts_monthly` widens to include co-owned
tracks (engagement analytics).
- The dashboard track table is powered by `GET /users/:id/tracks`, so it
merges automatically.
- **Sales/revenue intentionally left scoped to the seller** —
collaborators don't share revenue (per the no-split scope). Easy to
widen later if desired; flagging for a decision.
**New endpoint**
- `GET
/users/:id/collaboration_invites?status=pending|accepted|rejected` lists
a user's invites/credits with the inviter embedded as a user object
(mirrors `/managers`). Powers the client's accept/decline UX.
### Performance
- The collaborators embed is one extra indexed query per track-list
response (returns 0 rows for the common no-collaborator case; backed by
the `track_collaborators` PK). The profile UNION uses the covering
`(collaborator_user_id, status, track_id)` index.
- Every track response now includes a `collaborators` field (empty array
when none) — a small, constant payload addition.
### Tests
`api/v1_track_collaborators_test.go`: collaborators embedded on track
responses, accepted credit appears on the collaborator's profile,
pending invite stays hidden, the invites endpoint (status filter +
validation), and the notification trigger firing for both invite and
accept. Full `./api/` package suite passes.
> Note: `sql/01_schema.sql` carries the table + trigger inline so
fresh/test DBs have them; `make test-schema` (which needs an exclusive
local pg) will canonicalize the placement on the next regen.
### Next
Phase 3 (apps): SDK methods, upload tagging UI, push + in-app
notifications, comma-separated artist line, dashboard — web + mobile,
behind a flag.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rickyrombo@DejayJD@faridsalau
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Remove membersChange24hrPercent - #346

Merged
rickyrombo merged 3 commits into
mainfrom
mjp-insights-faster
Aug 28, 2025
Merged

Remove membersChange24hrPercent#346
rickyrombo merged 3 commits into
mainfrom
mjp-insights-faster

Conversation

@rickyrombo

Copy link
Copy Markdown
Contributor

Removes the membersChange24hrPercent from the /v1/coins/:mint/insights endpoint.

It's not included in the design anymore and is slowing down the endpoint greatly.

@DejayJDDejayJD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪

type MembersStatsRow struct {
Members int `json:"members"`
Members24hChangePercent float64 `json:"membersChange24hPercent"`
Members int `json:"members"`

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we remove this too @faridsalau / @DejayJD ? Or are we using it somewhere? Might be nice to just have this be a birdeye proxy

@rickyrombo
rickyrombo merged commit fdcdfca into mainAug 28, 2025
5 checks passed
@rickyrombo
rickyrombo deleted the mjp-insights-faster branch August 28, 2025 20:13
schottra added a commit that referenced this pull request Aug 29, 2025
* origin/main:
[API-321] Migrate tests for blast writes (#342)
Update query for best selling (#347)
Remove membersChange24hrPercent (#346)
[QA-2301] Fix blockees req (#345)
raymondjacobson added a commit that referenced this pull request Jun 9, 2026
## Summary
Bumps `github.com/OpenAudio/go-openaudio` and `.../pkg/etl` from
`c5fcacf` (#924) to **`e8586ac`**.
**Primary:** go-openaudio **#348** — fixes `playlists.last_added_to`
never being written (perpetually NULL), which silently broke the
"recently added to" sort and the playlist-update notification. Now set
to the block time of the most recent track add (code-only in #348).
**Also carried** (main advanced past the baseline): #345/#346 — the
**TrackCollaborator** entity. This adds ETL migration **0033**, which
`CREATE TABLE IF NOT EXISTS track_collaborators` (a new, empty table)
plus one index on it.
`core-indexer` runs this vendored image, so the bump is required to ship
the fix.
## Changes
- `go.mod` / `go.sum`: both go-openaudio modules →
`v1.3.1-0.20260609013415-e8586ac9ce16`
## Deploy note — migration 0033 is low risk
0033 creates a brand-new empty table + index with `IF NOT EXISTS`.
There's no existing data to scan and no `ACCESS EXCLUSIVE` lock on a
populated table (unlike the 0031 slug index), so it applies instantly —
no pre-build/CONCURRENT step needed. The `last_added_to` fix itself is
code-only (no migration).
## Test plan
- [x] `go mod tidy` — only go.mod/go.sum changed
- [x] `go build ./...` passes
- [x] resolved module contains the `last_added_to` writes (`LastAddedTo`
in playlist_row.go) and migration `0033`
- [ ] Post-deploy: migration version 33 applied clean; creating/editing
a playlist populates `last_added_to`, and a rename preserves it
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
raymondjacobson added a commit that referenced this pull request Jun 9, 2026
…hboard merge (#932)
Phase 2 of collaborative tracks (the api slice). Consumes the ETL
`TrackCollaborator` entity (go-openaudio #345 / #346) and surfaces it
through the API. **Ships inert** — nothing emits the on-chain
invites/accepts until the client work lands, so this is safe to deploy
dark.
### Recap
A track owner tags collaborator artists (in track metadata); each must
**accept** (pending → accepted). Accepted collaborators get the track on
their profile and merged into their dashboard analytics. Scope is
**display + analytics only** — no revenue split, no edit rights.
### What's here
**Table + notifications**
- `ddl/migrations/0220_track_collaborators.sql` mirrors the ETL table
with `CREATE TABLE IF NOT EXISTS` (byte-compatible with go-openaudio
migration 0033). It runs in the `migrations/` pass, *before*
`functions/`, so the trigger always has its table regardless of
ETL-indexer timing.
- `ddl/functions/handle_track_collaborator.sql` — a trigger modeled on
`handle_manager_request.sql`: a new pending invite notifies the
**collaborator** (`track_collaborator_invite`); a transition to accepted
notifies the **inviter/owner** (`track_collaborator_accept`).
- Both types added to the notifications request whitelist.
**Read path**
- Track responses now carry a `collaborators` array (accepted only),
bulk-resolved in a single indexed query folded into the existing user
fetch — no N+1.
- `GET /users/:id/tracks` UNIONs the user's owned tracks with tracks
they've accepted a credit on, preserving sort/pagination. The
artist-pick pin now references the **profile** user, so a collaborator's
track is never spuriously pinned by the *owner's* pick.
**Dashboard**
- `GET /users/:id/listen_counts_monthly` widens to include co-owned
tracks (engagement analytics).
- The dashboard track table is powered by `GET /users/:id/tracks`, so it
merges automatically.
- **Sales/revenue intentionally left scoped to the seller** —
collaborators don't share revenue (per the no-split scope). Easy to
widen later if desired; flagging for a decision.
**New endpoint**
- `GET
/users/:id/collaboration_invites?status=pending|accepted|rejected` lists
a user's invites/credits with the inviter embedded as a user object
(mirrors `/managers`). Powers the client's accept/decline UX.
### Performance
- The collaborators embed is one extra indexed query per track-list
response (returns 0 rows for the common no-collaborator case; backed by
the `track_collaborators` PK). The profile UNION uses the covering
`(collaborator_user_id, status, track_id)` index.
- Every track response now includes a `collaborators` field (empty array
when none) — a small, constant payload addition.
### Tests
`api/v1_track_collaborators_test.go`: collaborators embedded on track
responses, accepted credit appears on the collaborator's profile,
pending invite stays hidden, the invites endpoint (status filter +
validation), and the notification trigger firing for both invite and
accept. Full `./api/` package suite passes.
> Note: `sql/01_schema.sql` carries the table + trigger inline so
fresh/test DBs have them; `make test-schema` (which needs an exclusive
local pg) will canonicalize the placement on the next regen.
### Next
Phase 3 (apps): SDK methods, upload tagging UI, push + in-app
notifications, comma-separated artist line, dashboard — web + mobile,
behind a flag.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rickyrombo@DejayJD@faridsalau
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Remove membersChange24hrPercent - #346

Merged
rickyrombo merged 3 commits into
mainfrom
mjp-insights-faster
Aug 28, 2025
Merged

Remove membersChange24hrPercent#346
rickyrombo merged 3 commits into
mainfrom
mjp-insights-faster

Conversation

@rickyrombo

Copy link
Copy Markdown
Contributor

Removes the membersChange24hrPercent from the /v1/coins/:mint/insights endpoint.

It's not included in the design anymore and is slowing down the endpoint greatly.

@DejayJDDejayJD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪

type MembersStatsRow struct {
Members int `json:"members"`
Members24hChangePercent float64 `json:"membersChange24hPercent"`
Members int `json:"members"`

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we remove this too @faridsalau / @DejayJD ? Or are we using it somewhere? Might be nice to just have this be a birdeye proxy

@rickyrombo
rickyrombo merged commit fdcdfca into mainAug 28, 2025
5 checks passed
@rickyrombo
rickyrombo deleted the mjp-insights-faster branch August 28, 2025 20:13
schottra added a commit that referenced this pull request Aug 29, 2025
* origin/main:
[API-321] Migrate tests for blast writes (#342)
Update query for best selling (#347)
Remove membersChange24hrPercent (#346)
[QA-2301] Fix blockees req (#345)
raymondjacobson added a commit that referenced this pull request Jun 9, 2026
## Summary
Bumps `github.com/OpenAudio/go-openaudio` and `.../pkg/etl` from
`c5fcacf` (#924) to **`e8586ac`**.
**Primary:** go-openaudio **#348** — fixes `playlists.last_added_to`
never being written (perpetually NULL), which silently broke the
"recently added to" sort and the playlist-update notification. Now set
to the block time of the most recent track add (code-only in #348).
**Also carried** (main advanced past the baseline): #345/#346 — the
**TrackCollaborator** entity. This adds ETL migration **0033**, which
`CREATE TABLE IF NOT EXISTS track_collaborators` (a new, empty table)
plus one index on it.
`core-indexer` runs this vendored image, so the bump is required to ship
the fix.
## Changes
- `go.mod` / `go.sum`: both go-openaudio modules →
`v1.3.1-0.20260609013415-e8586ac9ce16`
## Deploy note — migration 0033 is low risk
0033 creates a brand-new empty table + index with `IF NOT EXISTS`.
There's no existing data to scan and no `ACCESS EXCLUSIVE` lock on a
populated table (unlike the 0031 slug index), so it applies instantly —
no pre-build/CONCURRENT step needed. The `last_added_to` fix itself is
code-only (no migration).
## Test plan
- [x] `go mod tidy` — only go.mod/go.sum changed
- [x] `go build ./...` passes
- [x] resolved module contains the `last_added_to` writes (`LastAddedTo`
in playlist_row.go) and migration `0033`
- [ ] Post-deploy: migration version 33 applied clean; creating/editing
a playlist populates `last_added_to`, and a rename preserves it
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
raymondjacobson added a commit that referenced this pull request Jun 9, 2026
…hboard merge (#932)
Phase 2 of collaborative tracks (the api slice). Consumes the ETL
`TrackCollaborator` entity (go-openaudio #345 / #346) and surfaces it
through the API. **Ships inert** — nothing emits the on-chain
invites/accepts until the client work lands, so this is safe to deploy
dark.
### Recap
A track owner tags collaborator artists (in track metadata); each must
**accept** (pending → accepted). Accepted collaborators get the track on
their profile and merged into their dashboard analytics. Scope is
**display + analytics only** — no revenue split, no edit rights.
### What's here
**Table + notifications**
- `ddl/migrations/0220_track_collaborators.sql` mirrors the ETL table
with `CREATE TABLE IF NOT EXISTS` (byte-compatible with go-openaudio
migration 0033). It runs in the `migrations/` pass, *before*
`functions/`, so the trigger always has its table regardless of
ETL-indexer timing.
- `ddl/functions/handle_track_collaborator.sql` — a trigger modeled on
`handle_manager_request.sql`: a new pending invite notifies the
**collaborator** (`track_collaborator_invite`); a transition to accepted
notifies the **inviter/owner** (`track_collaborator_accept`).
- Both types added to the notifications request whitelist.
**Read path**
- Track responses now carry a `collaborators` array (accepted only),
bulk-resolved in a single indexed query folded into the existing user
fetch — no N+1.
- `GET /users/:id/tracks` UNIONs the user's owned tracks with tracks
they've accepted a credit on, preserving sort/pagination. The
artist-pick pin now references the **profile** user, so a collaborator's
track is never spuriously pinned by the *owner's* pick.
**Dashboard**
- `GET /users/:id/listen_counts_monthly` widens to include co-owned
tracks (engagement analytics).
- The dashboard track table is powered by `GET /users/:id/tracks`, so it
merges automatically.
- **Sales/revenue intentionally left scoped to the seller** —
collaborators don't share revenue (per the no-split scope). Easy to
widen later if desired; flagging for a decision.
**New endpoint**
- `GET
/users/:id/collaboration_invites?status=pending|accepted|rejected` lists
a user's invites/credits with the inviter embedded as a user object
(mirrors `/managers`). Powers the client's accept/decline UX.
### Performance
- The collaborators embed is one extra indexed query per track-list
response (returns 0 rows for the common no-collaborator case; backed by
the `track_collaborators` PK). The profile UNION uses the covering
`(collaborator_user_id, status, track_id)` index.
- Every track response now includes a `collaborators` field (empty array
when none) — a small, constant payload addition.
### Tests
`api/v1_track_collaborators_test.go`: collaborators embedded on track
responses, accepted credit appears on the collaborator's profile,
pending invite stays hidden, the invites endpoint (status filter +
validation), and the notification trigger firing for both invite and
accept. Full `./api/` package suite passes.
> Note: `sql/01_schema.sql` carries the table + trigger inline so
fresh/test DBs have them; `make test-schema` (which needs an exclusive
local pg) will canonicalize the placement on the next regen.
### Next
Phase 3 (apps): SDK methods, upload tagging UI, push + in-app
notifications, comma-separated artist line, dashboard — web + mobile,
behind a flag.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rickyrombo@DejayJD@faridsalau
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Remove membersChange24hrPercent - #346

Merged
rickyrombo merged 3 commits into
mainfrom
mjp-insights-faster
Aug 28, 2025
Merged

Remove membersChange24hrPercent#346
rickyrombo merged 3 commits into
mainfrom
mjp-insights-faster

Conversation

@rickyrombo

Copy link
Copy Markdown
Contributor

Removes the membersChange24hrPercent from the /v1/coins/:mint/insights endpoint.

It's not included in the design anymore and is slowing down the endpoint greatly.

@DejayJDDejayJD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪

type MembersStatsRow struct {
Members int `json:"members"`
Members24hChangePercent float64 `json:"membersChange24hPercent"`
Members int `json:"members"`

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we remove this too @faridsalau / @DejayJD ? Or are we using it somewhere? Might be nice to just have this be a birdeye proxy

@rickyrombo
rickyrombo merged commit fdcdfca into mainAug 28, 2025
5 checks passed
@rickyrombo
rickyrombo deleted the mjp-insights-faster branch August 28, 2025 20:13
schottra added a commit that referenced this pull request Aug 29, 2025
* origin/main:
[API-321] Migrate tests for blast writes (#342)
Update query for best selling (#347)
Remove membersChange24hrPercent (#346)
[QA-2301] Fix blockees req (#345)
raymondjacobson added a commit that referenced this pull request Jun 9, 2026
## Summary
Bumps `github.com/OpenAudio/go-openaudio` and `.../pkg/etl` from
`c5fcacf` (#924) to **`e8586ac`**.
**Primary:** go-openaudio **#348** — fixes `playlists.last_added_to`
never being written (perpetually NULL), which silently broke the
"recently added to" sort and the playlist-update notification. Now set
to the block time of the most recent track add (code-only in #348).
**Also carried** (main advanced past the baseline): #345/#346 — the
**TrackCollaborator** entity. This adds ETL migration **0033**, which
`CREATE TABLE IF NOT EXISTS track_collaborators` (a new, empty table)
plus one index on it.
`core-indexer` runs this vendored image, so the bump is required to ship
the fix.
## Changes
- `go.mod` / `go.sum`: both go-openaudio modules →
`v1.3.1-0.20260609013415-e8586ac9ce16`
## Deploy note — migration 0033 is low risk
0033 creates a brand-new empty table + index with `IF NOT EXISTS`.
There's no existing data to scan and no `ACCESS EXCLUSIVE` lock on a
populated table (unlike the 0031 slug index), so it applies instantly —
no pre-build/CONCURRENT step needed. The `last_added_to` fix itself is
code-only (no migration).
## Test plan
- [x] `go mod tidy` — only go.mod/go.sum changed
- [x] `go build ./...` passes
- [x] resolved module contains the `last_added_to` writes (`LastAddedTo`
in playlist_row.go) and migration `0033`
- [ ] Post-deploy: migration version 33 applied clean; creating/editing
a playlist populates `last_added_to`, and a rename preserves it
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
raymondjacobson added a commit that referenced this pull request Jun 9, 2026
…hboard merge (#932)
Phase 2 of collaborative tracks (the api slice). Consumes the ETL
`TrackCollaborator` entity (go-openaudio #345 / #346) and surfaces it
through the API. **Ships inert** — nothing emits the on-chain
invites/accepts until the client work lands, so this is safe to deploy
dark.
### Recap
A track owner tags collaborator artists (in track metadata); each must
**accept** (pending → accepted). Accepted collaborators get the track on
their profile and merged into their dashboard analytics. Scope is
**display + analytics only** — no revenue split, no edit rights.
### What's here
**Table + notifications**
- `ddl/migrations/0220_track_collaborators.sql` mirrors the ETL table
with `CREATE TABLE IF NOT EXISTS` (byte-compatible with go-openaudio
migration 0033). It runs in the `migrations/` pass, *before*
`functions/`, so the trigger always has its table regardless of
ETL-indexer timing.
- `ddl/functions/handle_track_collaborator.sql` — a trigger modeled on
`handle_manager_request.sql`: a new pending invite notifies the
**collaborator** (`track_collaborator_invite`); a transition to accepted
notifies the **inviter/owner** (`track_collaborator_accept`).
- Both types added to the notifications request whitelist.
**Read path**
- Track responses now carry a `collaborators` array (accepted only),
bulk-resolved in a single indexed query folded into the existing user
fetch — no N+1.
- `GET /users/:id/tracks` UNIONs the user's owned tracks with tracks
they've accepted a credit on, preserving sort/pagination. The
artist-pick pin now references the **profile** user, so a collaborator's
track is never spuriously pinned by the *owner's* pick.
**Dashboard**
- `GET /users/:id/listen_counts_monthly` widens to include co-owned
tracks (engagement analytics).
- The dashboard track table is powered by `GET /users/:id/tracks`, so it
merges automatically.
- **Sales/revenue intentionally left scoped to the seller** —
collaborators don't share revenue (per the no-split scope). Easy to
widen later if desired; flagging for a decision.
**New endpoint**
- `GET
/users/:id/collaboration_invites?status=pending|accepted|rejected` lists
a user's invites/credits with the inviter embedded as a user object
(mirrors `/managers`). Powers the client's accept/decline UX.
### Performance
- The collaborators embed is one extra indexed query per track-list
response (returns 0 rows for the common no-collaborator case; backed by
the `track_collaborators` PK). The profile UNION uses the covering
`(collaborator_user_id, status, track_id)` index.
- Every track response now includes a `collaborators` field (empty array
when none) — a small, constant payload addition.
### Tests
`api/v1_track_collaborators_test.go`: collaborators embedded on track
responses, accepted credit appears on the collaborator's profile,
pending invite stays hidden, the invites endpoint (status filter +
validation), and the notification trigger firing for both invite and
accept. Full `./api/` package suite passes.
> Note: `sql/01_schema.sql` carries the table + trigger inline so
fresh/test DBs have them; `make test-schema` (which needs an exclusive
local pg) will canonicalize the placement on the next regen.
### Next
Phase 3 (apps): SDK methods, upload tagging UI, push + in-app
notifications, comma-separated artist line, dashboard — web + mobile,
behind a flag.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rickyrombo@DejayJD@faridsalau
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Remove membersChange24hrPercent - #346

Merged
rickyrombo merged 3 commits into
mainfrom
mjp-insights-faster
Aug 28, 2025
Merged

Remove membersChange24hrPercent#346
rickyrombo merged 3 commits into
mainfrom
mjp-insights-faster

Conversation

@rickyrombo

Copy link
Copy Markdown
Contributor

Removes the membersChange24hrPercent from the /v1/coins/:mint/insights endpoint.

It's not included in the design anymore and is slowing down the endpoint greatly.

@DejayJDDejayJD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪

type MembersStatsRow struct {
Members int `json:"members"`
Members24hChangePercent float64 `json:"membersChange24hPercent"`
Members int `json:"members"`

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we remove this too @faridsalau / @DejayJD ? Or are we using it somewhere? Might be nice to just have this be a birdeye proxy

@rickyrombo
rickyrombo merged commit fdcdfca into mainAug 28, 2025
5 checks passed
@rickyrombo
rickyrombo deleted the mjp-insights-faster branch August 28, 2025 20:13
schottra added a commit that referenced this pull request Aug 29, 2025
* origin/main:
[API-321] Migrate tests for blast writes (#342)
Update query for best selling (#347)
Remove membersChange24hrPercent (#346)
[QA-2301] Fix blockees req (#345)
raymondjacobson added a commit that referenced this pull request Jun 9, 2026
## Summary
Bumps `github.com/OpenAudio/go-openaudio` and `.../pkg/etl` from
`c5fcacf` (#924) to **`e8586ac`**.
**Primary:** go-openaudio **#348** — fixes `playlists.last_added_to`
never being written (perpetually NULL), which silently broke the
"recently added to" sort and the playlist-update notification. Now set
to the block time of the most recent track add (code-only in #348).
**Also carried** (main advanced past the baseline): #345/#346 — the
**TrackCollaborator** entity. This adds ETL migration **0033**, which
`CREATE TABLE IF NOT EXISTS track_collaborators` (a new, empty table)
plus one index on it.
`core-indexer` runs this vendored image, so the bump is required to ship
the fix.
## Changes
- `go.mod` / `go.sum`: both go-openaudio modules →
`v1.3.1-0.20260609013415-e8586ac9ce16`
## Deploy note — migration 0033 is low risk
0033 creates a brand-new empty table + index with `IF NOT EXISTS`.
There's no existing data to scan and no `ACCESS EXCLUSIVE` lock on a
populated table (unlike the 0031 slug index), so it applies instantly —
no pre-build/CONCURRENT step needed. The `last_added_to` fix itself is
code-only (no migration).
## Test plan
- [x] `go mod tidy` — only go.mod/go.sum changed
- [x] `go build ./...` passes
- [x] resolved module contains the `last_added_to` writes (`LastAddedTo`
in playlist_row.go) and migration `0033`
- [ ] Post-deploy: migration version 33 applied clean; creating/editing
a playlist populates `last_added_to`, and a rename preserves it
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
raymondjacobson added a commit that referenced this pull request Jun 9, 2026
…hboard merge (#932)
Phase 2 of collaborative tracks (the api slice). Consumes the ETL
`TrackCollaborator` entity (go-openaudio #345 / #346) and surfaces it
through the API. **Ships inert** — nothing emits the on-chain
invites/accepts until the client work lands, so this is safe to deploy
dark.
### Recap
A track owner tags collaborator artists (in track metadata); each must
**accept** (pending → accepted). Accepted collaborators get the track on
their profile and merged into their dashboard analytics. Scope is
**display + analytics only** — no revenue split, no edit rights.
### What's here
**Table + notifications**
- `ddl/migrations/0220_track_collaborators.sql` mirrors the ETL table
with `CREATE TABLE IF NOT EXISTS` (byte-compatible with go-openaudio
migration 0033). It runs in the `migrations/` pass, *before*
`functions/`, so the trigger always has its table regardless of
ETL-indexer timing.
- `ddl/functions/handle_track_collaborator.sql` — a trigger modeled on
`handle_manager_request.sql`: a new pending invite notifies the
**collaborator** (`track_collaborator_invite`); a transition to accepted
notifies the **inviter/owner** (`track_collaborator_accept`).
- Both types added to the notifications request whitelist.
**Read path**
- Track responses now carry a `collaborators` array (accepted only),
bulk-resolved in a single indexed query folded into the existing user
fetch — no N+1.
- `GET /users/:id/tracks` UNIONs the user's owned tracks with tracks
they've accepted a credit on, preserving sort/pagination. The
artist-pick pin now references the **profile** user, so a collaborator's
track is never spuriously pinned by the *owner's* pick.
**Dashboard**
- `GET /users/:id/listen_counts_monthly` widens to include co-owned
tracks (engagement analytics).
- The dashboard track table is powered by `GET /users/:id/tracks`, so it
merges automatically.
- **Sales/revenue intentionally left scoped to the seller** —
collaborators don't share revenue (per the no-split scope). Easy to
widen later if desired; flagging for a decision.
**New endpoint**
- `GET
/users/:id/collaboration_invites?status=pending|accepted|rejected` lists
a user's invites/credits with the inviter embedded as a user object
(mirrors `/managers`). Powers the client's accept/decline UX.
### Performance
- The collaborators embed is one extra indexed query per track-list
response (returns 0 rows for the common no-collaborator case; backed by
the `track_collaborators` PK). The profile UNION uses the covering
`(collaborator_user_id, status, track_id)` index.
- Every track response now includes a `collaborators` field (empty array
when none) — a small, constant payload addition.
### Tests
`api/v1_track_collaborators_test.go`: collaborators embedded on track
responses, accepted credit appears on the collaborator's profile,
pending invite stays hidden, the invites endpoint (status filter +
validation), and the notification trigger firing for both invite and
accept. Full `./api/` package suite passes.
> Note: `sql/01_schema.sql` carries the table + trigger inline so
fresh/test DBs have them; `make test-schema` (which needs an exclusive
local pg) will canonicalize the placement on the next regen.
### Next
Phase 3 (apps): SDK methods, upload tagging UI, push + in-app
notifications, comma-separated artist line, dashboard — web + mobile,
behind a flag.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rickyrombo@DejayJD@faridsalau
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Remove membersChange24hrPercent - #346

Merged
rickyrombo merged 3 commits into
mainfrom
mjp-insights-faster
Aug 28, 2025
Merged

Remove membersChange24hrPercent#346
rickyrombo merged 3 commits into
mainfrom
mjp-insights-faster

Conversation

@rickyrombo

Copy link
Copy Markdown
Contributor

Removes the membersChange24hrPercent from the /v1/coins/:mint/insights endpoint.

It's not included in the design anymore and is slowing down the endpoint greatly.

@DejayJDDejayJD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪

type MembersStatsRow struct {
Members int `json:"members"`
Members24hChangePercent float64 `json:"membersChange24hPercent"`
Members int `json:"members"`

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we remove this too @faridsalau / @DejayJD ? Or are we using it somewhere? Might be nice to just have this be a birdeye proxy

@rickyrombo
rickyrombo merged commit fdcdfca into mainAug 28, 2025
5 checks passed
@rickyrombo
rickyrombo deleted the mjp-insights-faster branch August 28, 2025 20:13
schottra added a commit that referenced this pull request Aug 29, 2025
* origin/main:
[API-321] Migrate tests for blast writes (#342)
Update query for best selling (#347)
Remove membersChange24hrPercent (#346)
[QA-2301] Fix blockees req (#345)
raymondjacobson added a commit that referenced this pull request Jun 9, 2026
## Summary
Bumps `github.com/OpenAudio/go-openaudio` and `.../pkg/etl` from
`c5fcacf` (#924) to **`e8586ac`**.
**Primary:** go-openaudio **#348** — fixes `playlists.last_added_to`
never being written (perpetually NULL), which silently broke the
"recently added to" sort and the playlist-update notification. Now set
to the block time of the most recent track add (code-only in #348).
**Also carried** (main advanced past the baseline): #345/#346 — the
**TrackCollaborator** entity. This adds ETL migration **0033**, which
`CREATE TABLE IF NOT EXISTS track_collaborators` (a new, empty table)
plus one index on it.
`core-indexer` runs this vendored image, so the bump is required to ship
the fix.
## Changes
- `go.mod` / `go.sum`: both go-openaudio modules →
`v1.3.1-0.20260609013415-e8586ac9ce16`
## Deploy note — migration 0033 is low risk
0033 creates a brand-new empty table + index with `IF NOT EXISTS`.
There's no existing data to scan and no `ACCESS EXCLUSIVE` lock on a
populated table (unlike the 0031 slug index), so it applies instantly —
no pre-build/CONCURRENT step needed. The `last_added_to` fix itself is
code-only (no migration).
## Test plan
- [x] `go mod tidy` — only go.mod/go.sum changed
- [x] `go build ./...` passes
- [x] resolved module contains the `last_added_to` writes (`LastAddedTo`
in playlist_row.go) and migration `0033`
- [ ] Post-deploy: migration version 33 applied clean; creating/editing
a playlist populates `last_added_to`, and a rename preserves it
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
raymondjacobson added a commit that referenced this pull request Jun 9, 2026
…hboard merge (#932)
Phase 2 of collaborative tracks (the api slice). Consumes the ETL
`TrackCollaborator` entity (go-openaudio #345 / #346) and surfaces it
through the API. **Ships inert** — nothing emits the on-chain
invites/accepts until the client work lands, so this is safe to deploy
dark.
### Recap
A track owner tags collaborator artists (in track metadata); each must
**accept** (pending → accepted). Accepted collaborators get the track on
their profile and merged into their dashboard analytics. Scope is
**display + analytics only** — no revenue split, no edit rights.
### What's here
**Table + notifications**
- `ddl/migrations/0220_track_collaborators.sql` mirrors the ETL table
with `CREATE TABLE IF NOT EXISTS` (byte-compatible with go-openaudio
migration 0033). It runs in the `migrations/` pass, *before*
`functions/`, so the trigger always has its table regardless of
ETL-indexer timing.
- `ddl/functions/handle_track_collaborator.sql` — a trigger modeled on
`handle_manager_request.sql`: a new pending invite notifies the
**collaborator** (`track_collaborator_invite`); a transition to accepted
notifies the **inviter/owner** (`track_collaborator_accept`).
- Both types added to the notifications request whitelist.
**Read path**
- Track responses now carry a `collaborators` array (accepted only),
bulk-resolved in a single indexed query folded into the existing user
fetch — no N+1.
- `GET /users/:id/tracks` UNIONs the user's owned tracks with tracks
they've accepted a credit on, preserving sort/pagination. The
artist-pick pin now references the **profile** user, so a collaborator's
track is never spuriously pinned by the *owner's* pick.
**Dashboard**
- `GET /users/:id/listen_counts_monthly` widens to include co-owned
tracks (engagement analytics).
- The dashboard track table is powered by `GET /users/:id/tracks`, so it
merges automatically.
- **Sales/revenue intentionally left scoped to the seller** —
collaborators don't share revenue (per the no-split scope). Easy to
widen later if desired; flagging for a decision.
**New endpoint**
- `GET
/users/:id/collaboration_invites?status=pending|accepted|rejected` lists
a user's invites/credits with the inviter embedded as a user object
(mirrors `/managers`). Powers the client's accept/decline UX.
### Performance
- The collaborators embed is one extra indexed query per track-list
response (returns 0 rows for the common no-collaborator case; backed by
the `track_collaborators` PK). The profile UNION uses the covering
`(collaborator_user_id, status, track_id)` index.
- Every track response now includes a `collaborators` field (empty array
when none) — a small, constant payload addition.
### Tests
`api/v1_track_collaborators_test.go`: collaborators embedded on track
responses, accepted credit appears on the collaborator's profile,
pending invite stays hidden, the invites endpoint (status filter +
validation), and the notification trigger firing for both invite and
accept. Full `./api/` package suite passes.
> Note: `sql/01_schema.sql` carries the table + trigger inline so
fresh/test DBs have them; `make test-schema` (which needs an exclusive
local pg) will canonicalize the placement on the next regen.
### Next
Phase 3 (apps): SDK methods, upload tagging UI, push + in-app
notifications, comma-separated artist line, dashboard — web + mobile,
behind a flag.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rickyrombo@DejayJD@faridsalau