Skip to content

[PE-6856] Add hasDiscord param to coins - #402

Merged
raymondjacobson merged 1 commit into
mainfrom
rj-pe-6856
Sep 20, 2025
Merged

[PE-6856] Add hasDiscord param to coins#402
raymondjacobson merged 1 commit into
mainfrom
rj-pe-6856

Conversation

@raymondjacobson

Copy link
Copy Markdown
Member

No description provided.

@DejayJDDejayJD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. With this change I'm assuming we're going forward with just manually updating these fields when we add a discord server config?

@raymondjacobson

Copy link
Copy Markdown
MemberAuthor

Looks good to me. With this change I'm assuming we're going forward with just manually updating these fields when we add a discord server config?

don't have a better idea atm! thoughts?

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to make sure we're trying to add chat blast changes as well

Comment threadsql/01_schema.sql
ON sol_user_balances.mint = artist_coins.mint
AND sol_user_balances.balance > 0
WHERE chat_blast.blast_id = blast_id_param
-- Case 1: userbank ie. sol_claimable_accounts

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes related?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is result from other ppl not updating schema but its from the db should be fine

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh gotcha sg

raymondjacobson added a commit to AudiusProject/apps that referenced this pull request Sep 20, 2025
…#12910)
### Description
See AudiusProject/api#402
Also, if website is missing, direct Learn More to the artist profile.
Better than nothing.
### How Has This Been Tested?
_Please describe the tests that you ran to verify your changes. Provide
repro instructions & any configuration._
<img width="932" height="471" alt="image"
src="https://github.com/user-attachments/assets/6a9fc2bb-36c9-46fe-bd21-d0e7995ec0ee"
/>
@raymondjacobson
raymondjacobson merged commit 70c4a60 into mainSep 20, 2025
4 of 8 checks passed
@raymondjacobson
raymondjacobson deleted the rj-pe-6856 branch September 20, 2025 01:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@raymondjacobson@DejayJD@dylanjeffers