Notifications endpoint

[stereosteve]

TODO:

• Do we need all the timestamp_offset, group_id_offset query logic? Does the client use some, all or none of those query params?
• playlist_id is weirdly a list, as discussed here: Fix marshalling for playlist notifs apps#11562
• Ordering of items inside of actions array may diverge. Will need a subquery there.
• The seen_at is never null in the golang version.. not sure why that's different.
• Need the unread count field

Questions:

• Difference in seen_at null behavior?
• limit=0 returns results from python server?
• playlist_id as array... is that for the client or for the python?

Changes:

• Added valid_types support, buttimestamp_offset and group_id_offset query logic is problematic and I don't understand what it's supposed to do.

[stereosteve]

Existing prod:

vs golang:

[raymondjacobson]

generally lgtm

[raymondjacobson]

I didn't know about LAG... that's super cool, though isn't this backwards? shouldn't the lag be prev_seen_at?

[stereosteve]

Yeah this does look backwards... it was mostly taken verbatim from get_notifications.py

I think it would be more correct to just flip the names tho... I'll try that out.

[stereosteve]

Ok I get it now... the query is ordered by seen_at desc...
so with that ordering, the row before the current row is a greater timestamp.

 seen_at | prev_seen_at ----------------------------+---------------------
2025-07-17 14:27:25.609154 | 2025-07-17 06:54:29
2025-07-17 06:54:29 | 2025-07-17 02:52:34
2025-07-17 02:52:34 | 2025-07-17 01:23:07
2025-07-17 01:23:07 | 2025-07-17 01:22:56
2025-07-17 01:22:56 | 2025-07-16 22:55:05
2025-07-16 22:55:05 | 2025-07-16 20:05:05

So I think the logic and naming is OK.

[raymondjacobson]

Existing prod:

vs golang:

What is this Un Minuto track? This data in these screenshots does look a little strange. 89 new uploads? when was the last seen at for this account?

[stereosteve]

What is this Un Minuto track? This data in these screenshots does look a little strange. 89 new uploads? when was the last seen at for this account?

This is stereosteve... I don't often open notifs drawer so there are large gaps in my notification_seen:

 2025-07-16 16:34:04
2025-04-23 20:32:11
2025-04-03 04:14:02
2025-04-02 13:37:51
2025-03-28 20:05:52
2025-03-27 14:01:45

I think all the new coop tracks between 04-23 and 7-16 get grouped into that one row in that case... which for coop records seems accurate.

Un Minuto is actually a private track... so we do notifs for private tracks... but that's existing behavior on the write side (in the triggers).