Fix stems endpoint with null original filenames - #973

Merged
raymondjacobson merged 1 commit into
mainfrom
codex/fix-null-stem-filenames
Jun 24, 2026
Merged

Fix stems endpoint with null original filenames#973
raymondjacobson merged 1 commit into
mainfrom
codex/fix-null-stem-filenames

Conversation

@raymondjacobson

Copy link
Copy Markdown
Member

Summary

  • return a stable filename string from the track stems endpoint when tracks.orig_filename is null
  • order stems by track ID for deterministic responses
  • add a regression case for a stem row with a null original filename

Verification

  • go test ./api -run TestGetTrackStems -count=1

Live investigation

  • GET /v1/tracks/qJ0RAXE/stems was returning 500: cannot scan NULL into *string for Burko's contest track
  • read-only prod query verified parent track 1960897973 has 30 current, non-deleted stem rows, 10 distinct titles, and all 30 rows have orig_filename IS NULL

@raymondjacobson
raymondjacobson merged commit 0881627 into mainJun 24, 2026
5 checks passed
@raymondjacobson
raymondjacobson deleted the codex/fix-null-stem-filenames branch June 24, 2026 01:32
dylanjeffers added a commit that referenced this pull request Jul 27, 2026
…ing (stems invisible since ~Jul 12 cutover) (#995)
## TL;DR
`/v1/tracks/{id}/stems` fails the entire request when any selected
column scans NULL into a non-pointer Go field, and every stem indexed by
the Go ETL since the ~July 12 Python→Go cutover has NULL
`orig_filename`. The result was a **silent 500** that made the stems
section / ContestStemsCard blank for post-cutover uploads — most visibly
Andrew Lux's "Alone" remix contest (parent `JBKl7R6`, 43 stems uploaded
7/20, all correct on-chain). #973 fixed the `orig_filename` case on main
(June 23), but this PR closes the remaining NULL-scan path (`stem_of`
wiped → `category`/`parent_track_id` NULL) and adds regression coverage.
## Root cause chain
1. **The Go ETL never persists `orig_filename`** — the entity-manager
create handler doesn't extract it, so only legacy Python-indexed rows
carry a value. Verified against the raw on-chain txs (core blocks
28480416–28480440): the metadata contains `orig_filename` and a correct
`stem_of`, and replaying the exact tx through the vendored ETL persists
`stem_of` fine.
2. **The endpoint scanned NULLs into non-pointer `string`/`int` fields**
(`pgx.RowToStructByName`), so one ETL-shaped row 500s the whole response
— every stem on the parent disappears, not just the affected one.
3. #973 (June 23) fixed the `orig_filename` scan via
`COALESCE(orig_filename, title, '')`. Prod is running `915c37d` today
(pods restarted 2026-07-26 08:07 UTC), which includes it — but the
incident behavior on 7/20–7/25 is consistent with the pods running a
**pre-#973 build** until that 7/26 restart. Worth confirming from deploy
history (`kubectl --context prod -n api rollout history` / image tags).
4. **Still broken until this PR:** a `stems` join row can outlive
`tracks.stem_of`. An explicit `"stem_of": null` in a client update wipes
the column (clients send the full track object on edit — same failure
class as the CID wipe fixed in OpenAudio/go-openaudio#410) while the
`stems` row survives. `category` and `parent_track_id` then come back
NULL from the jsonb and the request 500s again.
## Fix
- `COALESCE(t.stem_of->>'category', '')`, `COALESCE(t.track_cid, '')`
- `parent_track_id` now read from the `stems` join key (never NULL)
instead of the jsonb
- Regression test `TestGetTrackStemsWipedStemOf`: seeds a stems row
whose track has no `stem_of`/`orig_filename` — 500 before, 200 after
## Blast radius
Every stem uploaded after the ~July 12 cutover was invisible in the UI
while the NULL-scan bug was live (any parent with ≥1 ETL-shaped stem row
500'd). The DB rows themselves are intact — once the endpoint tolerates
NULLs, existing stems reappear with no reindex.
## Andrew Lux follow-up (support)
Andrew deleted all of his stems while debugging (one on 7/25 13:38 UTC
after 9 retries, a fresh batch uploaded 7/25 14:08–14:50, then a bulk
on-chain `Track/Delete` of everything on 7/27 12:35 UTC). Deleted tracks
can't be un-deleted on-chain, so **after this deploys he needs to
re-upload the stems once** via Edit Track → stems on "Alone" — the same
flow he used before; nothing was wrong with his uploads.
## Go ETL follow-ups (OpenAudio/go-openaudio — patches staged locally,
separate PR)
- [ ] Persist `orig_filename` on track create/update (Python parity;
never-clear like the CIDs) so new rows don't rely on the title fallback
- [ ] Ignore explicit `"stem_of": null` in track updates (same guard as
the #410 CID fix) so client edits can't unlink stems
- [ ] Upsert the `stems` join row when an update carries `stem_of` (also
gives us an on-chain repair path for lost links)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@raymondjacobson
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Fix stems endpoint with null original filenames - #973

Merged
raymondjacobson merged 1 commit into
mainfrom
codex/fix-null-stem-filenames
Jun 24, 2026
Merged

Fix stems endpoint with null original filenames#973
raymondjacobson merged 1 commit into
mainfrom
codex/fix-null-stem-filenames

Conversation

@raymondjacobson

Copy link
Copy Markdown
Member

Summary

  • return a stable filename string from the track stems endpoint when tracks.orig_filename is null
  • order stems by track ID for deterministic responses
  • add a regression case for a stem row with a null original filename

Verification

  • go test ./api -run TestGetTrackStems -count=1

Live investigation

  • GET /v1/tracks/qJ0RAXE/stems was returning 500: cannot scan NULL into *string for Burko's contest track
  • read-only prod query verified parent track 1960897973 has 30 current, non-deleted stem rows, 10 distinct titles, and all 30 rows have orig_filename IS NULL

@raymondjacobson
raymondjacobson merged commit 0881627 into mainJun 24, 2026
5 checks passed
@raymondjacobson
raymondjacobson deleted the codex/fix-null-stem-filenames branch June 24, 2026 01:32
dylanjeffers added a commit that referenced this pull request Jul 27, 2026
…ing (stems invisible since ~Jul 12 cutover) (#995)
## TL;DR
`/v1/tracks/{id}/stems` fails the entire request when any selected
column scans NULL into a non-pointer Go field, and every stem indexed by
the Go ETL since the ~July 12 Python→Go cutover has NULL
`orig_filename`. The result was a **silent 500** that made the stems
section / ContestStemsCard blank for post-cutover uploads — most visibly
Andrew Lux's "Alone" remix contest (parent `JBKl7R6`, 43 stems uploaded
7/20, all correct on-chain). #973 fixed the `orig_filename` case on main
(June 23), but this PR closes the remaining NULL-scan path (`stem_of`
wiped → `category`/`parent_track_id` NULL) and adds regression coverage.
## Root cause chain
1. **The Go ETL never persists `orig_filename`** — the entity-manager
create handler doesn't extract it, so only legacy Python-indexed rows
carry a value. Verified against the raw on-chain txs (core blocks
28480416–28480440): the metadata contains `orig_filename` and a correct
`stem_of`, and replaying the exact tx through the vendored ETL persists
`stem_of` fine.
2. **The endpoint scanned NULLs into non-pointer `string`/`int` fields**
(`pgx.RowToStructByName`), so one ETL-shaped row 500s the whole response
— every stem on the parent disappears, not just the affected one.
3. #973 (June 23) fixed the `orig_filename` scan via
`COALESCE(orig_filename, title, '')`. Prod is running `915c37d` today
(pods restarted 2026-07-26 08:07 UTC), which includes it — but the
incident behavior on 7/20–7/25 is consistent with the pods running a
**pre-#973 build** until that 7/26 restart. Worth confirming from deploy
history (`kubectl --context prod -n api rollout history` / image tags).
4. **Still broken until this PR:** a `stems` join row can outlive
`tracks.stem_of`. An explicit `"stem_of": null` in a client update wipes
the column (clients send the full track object on edit — same failure
class as the CID wipe fixed in OpenAudio/go-openaudio#410) while the
`stems` row survives. `category` and `parent_track_id` then come back
NULL from the jsonb and the request 500s again.
## Fix
- `COALESCE(t.stem_of->>'category', '')`, `COALESCE(t.track_cid, '')`
- `parent_track_id` now read from the `stems` join key (never NULL)
instead of the jsonb
- Regression test `TestGetTrackStemsWipedStemOf`: seeds a stems row
whose track has no `stem_of`/`orig_filename` — 500 before, 200 after
## Blast radius
Every stem uploaded after the ~July 12 cutover was invisible in the UI
while the NULL-scan bug was live (any parent with ≥1 ETL-shaped stem row
500'd). The DB rows themselves are intact — once the endpoint tolerates
NULLs, existing stems reappear with no reindex.
## Andrew Lux follow-up (support)
Andrew deleted all of his stems while debugging (one on 7/25 13:38 UTC
after 9 retries, a fresh batch uploaded 7/25 14:08–14:50, then a bulk
on-chain `Track/Delete` of everything on 7/27 12:35 UTC). Deleted tracks
can't be un-deleted on-chain, so **after this deploys he needs to
re-upload the stems once** via Edit Track → stems on "Alone" — the same
flow he used before; nothing was wrong with his uploads.
## Go ETL follow-ups (OpenAudio/go-openaudio — patches staged locally,
separate PR)
- [ ] Persist `orig_filename` on track create/update (Python parity;
never-clear like the CIDs) so new rows don't rely on the title fallback
- [ ] Ignore explicit `"stem_of": null` in track updates (same guard as
the #410 CID fix) so client edits can't unlink stems
- [ ] Upsert the `stems` join row when an update carries `stem_of` (also
gives us an on-chain repair path for lost links)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@raymondjacobson
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix stems endpoint with null original filenames - #973

Merged
raymondjacobson merged 1 commit into
mainfrom
codex/fix-null-stem-filenames
Jun 24, 2026
Merged

Fix stems endpoint with null original filenames#973
raymondjacobson merged 1 commit into
mainfrom
codex/fix-null-stem-filenames

Conversation

@raymondjacobson

Copy link
Copy Markdown
Member

Summary

  • return a stable filename string from the track stems endpoint when tracks.orig_filename is null
  • order stems by track ID for deterministic responses
  • add a regression case for a stem row with a null original filename

Verification

  • go test ./api -run TestGetTrackStems -count=1

Live investigation

  • GET /v1/tracks/qJ0RAXE/stems was returning 500: cannot scan NULL into *string for Burko's contest track
  • read-only prod query verified parent track 1960897973 has 30 current, non-deleted stem rows, 10 distinct titles, and all 30 rows have orig_filename IS NULL

@raymondjacobson
raymondjacobson merged commit 0881627 into mainJun 24, 2026
5 checks passed
@raymondjacobson
raymondjacobson deleted the codex/fix-null-stem-filenames branch June 24, 2026 01:32
dylanjeffers added a commit that referenced this pull request Jul 27, 2026
…ing (stems invisible since ~Jul 12 cutover) (#995)
## TL;DR
`/v1/tracks/{id}/stems` fails the entire request when any selected
column scans NULL into a non-pointer Go field, and every stem indexed by
the Go ETL since the ~July 12 Python→Go cutover has NULL
`orig_filename`. The result was a **silent 500** that made the stems
section / ContestStemsCard blank for post-cutover uploads — most visibly
Andrew Lux's "Alone" remix contest (parent `JBKl7R6`, 43 stems uploaded
7/20, all correct on-chain). #973 fixed the `orig_filename` case on main
(June 23), but this PR closes the remaining NULL-scan path (`stem_of`
wiped → `category`/`parent_track_id` NULL) and adds regression coverage.
## Root cause chain
1. **The Go ETL never persists `orig_filename`** — the entity-manager
create handler doesn't extract it, so only legacy Python-indexed rows
carry a value. Verified against the raw on-chain txs (core blocks
28480416–28480440): the metadata contains `orig_filename` and a correct
`stem_of`, and replaying the exact tx through the vendored ETL persists
`stem_of` fine.
2. **The endpoint scanned NULLs into non-pointer `string`/`int` fields**
(`pgx.RowToStructByName`), so one ETL-shaped row 500s the whole response
— every stem on the parent disappears, not just the affected one.
3. #973 (June 23) fixed the `orig_filename` scan via
`COALESCE(orig_filename, title, '')`. Prod is running `915c37d` today
(pods restarted 2026-07-26 08:07 UTC), which includes it — but the
incident behavior on 7/20–7/25 is consistent with the pods running a
**pre-#973 build** until that 7/26 restart. Worth confirming from deploy
history (`kubectl --context prod -n api rollout history` / image tags).
4. **Still broken until this PR:** a `stems` join row can outlive
`tracks.stem_of`. An explicit `"stem_of": null` in a client update wipes
the column (clients send the full track object on edit — same failure
class as the CID wipe fixed in OpenAudio/go-openaudio#410) while the
`stems` row survives. `category` and `parent_track_id` then come back
NULL from the jsonb and the request 500s again.
## Fix
- `COALESCE(t.stem_of->>'category', '')`, `COALESCE(t.track_cid, '')`
- `parent_track_id` now read from the `stems` join key (never NULL)
instead of the jsonb
- Regression test `TestGetTrackStemsWipedStemOf`: seeds a stems row
whose track has no `stem_of`/`orig_filename` — 500 before, 200 after
## Blast radius
Every stem uploaded after the ~July 12 cutover was invisible in the UI
while the NULL-scan bug was live (any parent with ≥1 ETL-shaped stem row
500'd). The DB rows themselves are intact — once the endpoint tolerates
NULLs, existing stems reappear with no reindex.
## Andrew Lux follow-up (support)
Andrew deleted all of his stems while debugging (one on 7/25 13:38 UTC
after 9 retries, a fresh batch uploaded 7/25 14:08–14:50, then a bulk
on-chain `Track/Delete` of everything on 7/27 12:35 UTC). Deleted tracks
can't be un-deleted on-chain, so **after this deploys he needs to
re-upload the stems once** via Edit Track → stems on "Alone" — the same
flow he used before; nothing was wrong with his uploads.
## Go ETL follow-ups (OpenAudio/go-openaudio — patches staged locally,
separate PR)
- [ ] Persist `orig_filename` on track create/update (Python parity;
never-clear like the CIDs) so new rows don't rely on the title fallback
- [ ] Ignore explicit `"stem_of": null` in track updates (same guard as
the #410 CID fix) so client edits can't unlink stems
- [ ] Upsert the `stems` join row when an update carries `stem_of` (also
gives us an on-chain repair path for lost links)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@raymondjacobson
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix stems endpoint with null original filenames - #973

Merged
raymondjacobson merged 1 commit into
mainfrom
codex/fix-null-stem-filenames
Jun 24, 2026
Merged

Fix stems endpoint with null original filenames#973
raymondjacobson merged 1 commit into
mainfrom
codex/fix-null-stem-filenames

Conversation

@raymondjacobson

Copy link
Copy Markdown
Member

Summary

  • return a stable filename string from the track stems endpoint when tracks.orig_filename is null
  • order stems by track ID for deterministic responses
  • add a regression case for a stem row with a null original filename

Verification

  • go test ./api -run TestGetTrackStems -count=1

Live investigation

  • GET /v1/tracks/qJ0RAXE/stems was returning 500: cannot scan NULL into *string for Burko's contest track
  • read-only prod query verified parent track 1960897973 has 30 current, non-deleted stem rows, 10 distinct titles, and all 30 rows have orig_filename IS NULL

@raymondjacobson
raymondjacobson merged commit 0881627 into mainJun 24, 2026
5 checks passed
@raymondjacobson
raymondjacobson deleted the codex/fix-null-stem-filenames branch June 24, 2026 01:32
dylanjeffers added a commit that referenced this pull request Jul 27, 2026
…ing (stems invisible since ~Jul 12 cutover) (#995)
## TL;DR
`/v1/tracks/{id}/stems` fails the entire request when any selected
column scans NULL into a non-pointer Go field, and every stem indexed by
the Go ETL since the ~July 12 Python→Go cutover has NULL
`orig_filename`. The result was a **silent 500** that made the stems
section / ContestStemsCard blank for post-cutover uploads — most visibly
Andrew Lux's "Alone" remix contest (parent `JBKl7R6`, 43 stems uploaded
7/20, all correct on-chain). #973 fixed the `orig_filename` case on main
(June 23), but this PR closes the remaining NULL-scan path (`stem_of`
wiped → `category`/`parent_track_id` NULL) and adds regression coverage.
## Root cause chain
1. **The Go ETL never persists `orig_filename`** — the entity-manager
create handler doesn't extract it, so only legacy Python-indexed rows
carry a value. Verified against the raw on-chain txs (core blocks
28480416–28480440): the metadata contains `orig_filename` and a correct
`stem_of`, and replaying the exact tx through the vendored ETL persists
`stem_of` fine.
2. **The endpoint scanned NULLs into non-pointer `string`/`int` fields**
(`pgx.RowToStructByName`), so one ETL-shaped row 500s the whole response
— every stem on the parent disappears, not just the affected one.
3. #973 (June 23) fixed the `orig_filename` scan via
`COALESCE(orig_filename, title, '')`. Prod is running `915c37d` today
(pods restarted 2026-07-26 08:07 UTC), which includes it — but the
incident behavior on 7/20–7/25 is consistent with the pods running a
**pre-#973 build** until that 7/26 restart. Worth confirming from deploy
history (`kubectl --context prod -n api rollout history` / image tags).
4. **Still broken until this PR:** a `stems` join row can outlive
`tracks.stem_of`. An explicit `"stem_of": null` in a client update wipes
the column (clients send the full track object on edit — same failure
class as the CID wipe fixed in OpenAudio/go-openaudio#410) while the
`stems` row survives. `category` and `parent_track_id` then come back
NULL from the jsonb and the request 500s again.
## Fix
- `COALESCE(t.stem_of->>'category', '')`, `COALESCE(t.track_cid, '')`
- `parent_track_id` now read from the `stems` join key (never NULL)
instead of the jsonb
- Regression test `TestGetTrackStemsWipedStemOf`: seeds a stems row
whose track has no `stem_of`/`orig_filename` — 500 before, 200 after
## Blast radius
Every stem uploaded after the ~July 12 cutover was invisible in the UI
while the NULL-scan bug was live (any parent with ≥1 ETL-shaped stem row
500'd). The DB rows themselves are intact — once the endpoint tolerates
NULLs, existing stems reappear with no reindex.
## Andrew Lux follow-up (support)
Andrew deleted all of his stems while debugging (one on 7/25 13:38 UTC
after 9 retries, a fresh batch uploaded 7/25 14:08–14:50, then a bulk
on-chain `Track/Delete` of everything on 7/27 12:35 UTC). Deleted tracks
can't be un-deleted on-chain, so **after this deploys he needs to
re-upload the stems once** via Edit Track → stems on "Alone" — the same
flow he used before; nothing was wrong with his uploads.
## Go ETL follow-ups (OpenAudio/go-openaudio — patches staged locally,
separate PR)
- [ ] Persist `orig_filename` on track create/update (Python parity;
never-clear like the CIDs) so new rows don't rely on the title fallback
- [ ] Ignore explicit `"stem_of": null` in track updates (same guard as
the #410 CID fix) so client edits can't unlink stems
- [ ] Upsert the `stems` join row when an update carries `stem_of` (also
gives us an on-chain repair path for lost links)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@raymondjacobson
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Fix stems endpoint with null original filenames - #973

Merged
raymondjacobson merged 1 commit into
mainfrom
codex/fix-null-stem-filenames
Jun 24, 2026
Merged

Fix stems endpoint with null original filenames#973
raymondjacobson merged 1 commit into
mainfrom
codex/fix-null-stem-filenames

Conversation

@raymondjacobson

Copy link
Copy Markdown
Member

Summary

  • return a stable filename string from the track stems endpoint when tracks.orig_filename is null
  • order stems by track ID for deterministic responses
  • add a regression case for a stem row with a null original filename

Verification

  • go test ./api -run TestGetTrackStems -count=1

Live investigation

  • GET /v1/tracks/qJ0RAXE/stems was returning 500: cannot scan NULL into *string for Burko's contest track
  • read-only prod query verified parent track 1960897973 has 30 current, non-deleted stem rows, 10 distinct titles, and all 30 rows have orig_filename IS NULL

@raymondjacobson
raymondjacobson merged commit 0881627 into mainJun 24, 2026
5 checks passed
@raymondjacobson
raymondjacobson deleted the codex/fix-null-stem-filenames branch June 24, 2026 01:32
dylanjeffers added a commit that referenced this pull request Jul 27, 2026
…ing (stems invisible since ~Jul 12 cutover) (#995)
## TL;DR
`/v1/tracks/{id}/stems` fails the entire request when any selected
column scans NULL into a non-pointer Go field, and every stem indexed by
the Go ETL since the ~July 12 Python→Go cutover has NULL
`orig_filename`. The result was a **silent 500** that made the stems
section / ContestStemsCard blank for post-cutover uploads — most visibly
Andrew Lux's "Alone" remix contest (parent `JBKl7R6`, 43 stems uploaded
7/20, all correct on-chain). #973 fixed the `orig_filename` case on main
(June 23), but this PR closes the remaining NULL-scan path (`stem_of`
wiped → `category`/`parent_track_id` NULL) and adds regression coverage.
## Root cause chain
1. **The Go ETL never persists `orig_filename`** — the entity-manager
create handler doesn't extract it, so only legacy Python-indexed rows
carry a value. Verified against the raw on-chain txs (core blocks
28480416–28480440): the metadata contains `orig_filename` and a correct
`stem_of`, and replaying the exact tx through the vendored ETL persists
`stem_of` fine.
2. **The endpoint scanned NULLs into non-pointer `string`/`int` fields**
(`pgx.RowToStructByName`), so one ETL-shaped row 500s the whole response
— every stem on the parent disappears, not just the affected one.
3. #973 (June 23) fixed the `orig_filename` scan via
`COALESCE(orig_filename, title, '')`. Prod is running `915c37d` today
(pods restarted 2026-07-26 08:07 UTC), which includes it — but the
incident behavior on 7/20–7/25 is consistent with the pods running a
**pre-#973 build** until that 7/26 restart. Worth confirming from deploy
history (`kubectl --context prod -n api rollout history` / image tags).
4. **Still broken until this PR:** a `stems` join row can outlive
`tracks.stem_of`. An explicit `"stem_of": null` in a client update wipes
the column (clients send the full track object on edit — same failure
class as the CID wipe fixed in OpenAudio/go-openaudio#410) while the
`stems` row survives. `category` and `parent_track_id` then come back
NULL from the jsonb and the request 500s again.
## Fix
- `COALESCE(t.stem_of->>'category', '')`, `COALESCE(t.track_cid, '')`
- `parent_track_id` now read from the `stems` join key (never NULL)
instead of the jsonb
- Regression test `TestGetTrackStemsWipedStemOf`: seeds a stems row
whose track has no `stem_of`/`orig_filename` — 500 before, 200 after
## Blast radius
Every stem uploaded after the ~July 12 cutover was invisible in the UI
while the NULL-scan bug was live (any parent with ≥1 ETL-shaped stem row
500'd). The DB rows themselves are intact — once the endpoint tolerates
NULLs, existing stems reappear with no reindex.
## Andrew Lux follow-up (support)
Andrew deleted all of his stems while debugging (one on 7/25 13:38 UTC
after 9 retries, a fresh batch uploaded 7/25 14:08–14:50, then a bulk
on-chain `Track/Delete` of everything on 7/27 12:35 UTC). Deleted tracks
can't be un-deleted on-chain, so **after this deploys he needs to
re-upload the stems once** via Edit Track → stems on "Alone" — the same
flow he used before; nothing was wrong with his uploads.
## Go ETL follow-ups (OpenAudio/go-openaudio — patches staged locally,
separate PR)
- [ ] Persist `orig_filename` on track create/update (Python parity;
never-clear like the CIDs) so new rows don't rely on the title fallback
- [ ] Ignore explicit `"stem_of": null` in track updates (same guard as
the #410 CID fix) so client edits can't unlink stems
- [ ] Upsert the `stems` join row when an update carries `stem_of` (also
gives us an on-chain repair path for lost links)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@raymondjacobson
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix stems endpoint with null original filenames - #973

Merged
raymondjacobson merged 1 commit into
mainfrom
codex/fix-null-stem-filenames
Jun 24, 2026
Merged

Fix stems endpoint with null original filenames#973
raymondjacobson merged 1 commit into
mainfrom
codex/fix-null-stem-filenames

Conversation

@raymondjacobson

Copy link
Copy Markdown
Member

Summary

  • return a stable filename string from the track stems endpoint when tracks.orig_filename is null
  • order stems by track ID for deterministic responses
  • add a regression case for a stem row with a null original filename

Verification

  • go test ./api -run TestGetTrackStems -count=1

Live investigation

  • GET /v1/tracks/qJ0RAXE/stems was returning 500: cannot scan NULL into *string for Burko's contest track
  • read-only prod query verified parent track 1960897973 has 30 current, non-deleted stem rows, 10 distinct titles, and all 30 rows have orig_filename IS NULL

@raymondjacobson
raymondjacobson merged commit 0881627 into mainJun 24, 2026
5 checks passed
@raymondjacobson
raymondjacobson deleted the codex/fix-null-stem-filenames branch June 24, 2026 01:32
dylanjeffers added a commit that referenced this pull request Jul 27, 2026
…ing (stems invisible since ~Jul 12 cutover) (#995)
## TL;DR
`/v1/tracks/{id}/stems` fails the entire request when any selected
column scans NULL into a non-pointer Go field, and every stem indexed by
the Go ETL since the ~July 12 Python→Go cutover has NULL
`orig_filename`. The result was a **silent 500** that made the stems
section / ContestStemsCard blank for post-cutover uploads — most visibly
Andrew Lux's "Alone" remix contest (parent `JBKl7R6`, 43 stems uploaded
7/20, all correct on-chain). #973 fixed the `orig_filename` case on main
(June 23), but this PR closes the remaining NULL-scan path (`stem_of`
wiped → `category`/`parent_track_id` NULL) and adds regression coverage.
## Root cause chain
1. **The Go ETL never persists `orig_filename`** — the entity-manager
create handler doesn't extract it, so only legacy Python-indexed rows
carry a value. Verified against the raw on-chain txs (core blocks
28480416–28480440): the metadata contains `orig_filename` and a correct
`stem_of`, and replaying the exact tx through the vendored ETL persists
`stem_of` fine.
2. **The endpoint scanned NULLs into non-pointer `string`/`int` fields**
(`pgx.RowToStructByName`), so one ETL-shaped row 500s the whole response
— every stem on the parent disappears, not just the affected one.
3. #973 (June 23) fixed the `orig_filename` scan via
`COALESCE(orig_filename, title, '')`. Prod is running `915c37d` today
(pods restarted 2026-07-26 08:07 UTC), which includes it — but the
incident behavior on 7/20–7/25 is consistent with the pods running a
**pre-#973 build** until that 7/26 restart. Worth confirming from deploy
history (`kubectl --context prod -n api rollout history` / image tags).
4. **Still broken until this PR:** a `stems` join row can outlive
`tracks.stem_of`. An explicit `"stem_of": null` in a client update wipes
the column (clients send the full track object on edit — same failure
class as the CID wipe fixed in OpenAudio/go-openaudio#410) while the
`stems` row survives. `category` and `parent_track_id` then come back
NULL from the jsonb and the request 500s again.
## Fix
- `COALESCE(t.stem_of->>'category', '')`, `COALESCE(t.track_cid, '')`
- `parent_track_id` now read from the `stems` join key (never NULL)
instead of the jsonb
- Regression test `TestGetTrackStemsWipedStemOf`: seeds a stems row
whose track has no `stem_of`/`orig_filename` — 500 before, 200 after
## Blast radius
Every stem uploaded after the ~July 12 cutover was invisible in the UI
while the NULL-scan bug was live (any parent with ≥1 ETL-shaped stem row
500'd). The DB rows themselves are intact — once the endpoint tolerates
NULLs, existing stems reappear with no reindex.
## Andrew Lux follow-up (support)
Andrew deleted all of his stems while debugging (one on 7/25 13:38 UTC
after 9 retries, a fresh batch uploaded 7/25 14:08–14:50, then a bulk
on-chain `Track/Delete` of everything on 7/27 12:35 UTC). Deleted tracks
can't be un-deleted on-chain, so **after this deploys he needs to
re-upload the stems once** via Edit Track → stems on "Alone" — the same
flow he used before; nothing was wrong with his uploads.
## Go ETL follow-ups (OpenAudio/go-openaudio — patches staged locally,
separate PR)
- [ ] Persist `orig_filename` on track create/update (Python parity;
never-clear like the CIDs) so new rows don't rely on the title fallback
- [ ] Ignore explicit `"stem_of": null` in track updates (same guard as
the #410 CID fix) so client edits can't unlink stems
- [ ] Upsert the `stems` join row when an update carries `stem_of` (also
gives us an on-chain repair path for lost links)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@raymondjacobson
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix stems endpoint with null original filenames - #973

Merged
raymondjacobson merged 1 commit into
mainfrom
codex/fix-null-stem-filenames
Jun 24, 2026
Merged

Fix stems endpoint with null original filenames#973
raymondjacobson merged 1 commit into
mainfrom
codex/fix-null-stem-filenames

Conversation

@raymondjacobson

Copy link
Copy Markdown
Member

Summary

  • return a stable filename string from the track stems endpoint when tracks.orig_filename is null
  • order stems by track ID for deterministic responses
  • add a regression case for a stem row with a null original filename

Verification

  • go test ./api -run TestGetTrackStems -count=1

Live investigation

  • GET /v1/tracks/qJ0RAXE/stems was returning 500: cannot scan NULL into *string for Burko's contest track
  • read-only prod query verified parent track 1960897973 has 30 current, non-deleted stem rows, 10 distinct titles, and all 30 rows have orig_filename IS NULL

@raymondjacobson
raymondjacobson merged commit 0881627 into mainJun 24, 2026
5 checks passed
@raymondjacobson
raymondjacobson deleted the codex/fix-null-stem-filenames branch June 24, 2026 01:32
dylanjeffers added a commit that referenced this pull request Jul 27, 2026
…ing (stems invisible since ~Jul 12 cutover) (#995)
## TL;DR
`/v1/tracks/{id}/stems` fails the entire request when any selected
column scans NULL into a non-pointer Go field, and every stem indexed by
the Go ETL since the ~July 12 Python→Go cutover has NULL
`orig_filename`. The result was a **silent 500** that made the stems
section / ContestStemsCard blank for post-cutover uploads — most visibly
Andrew Lux's "Alone" remix contest (parent `JBKl7R6`, 43 stems uploaded
7/20, all correct on-chain). #973 fixed the `orig_filename` case on main
(June 23), but this PR closes the remaining NULL-scan path (`stem_of`
wiped → `category`/`parent_track_id` NULL) and adds regression coverage.
## Root cause chain
1. **The Go ETL never persists `orig_filename`** — the entity-manager
create handler doesn't extract it, so only legacy Python-indexed rows
carry a value. Verified against the raw on-chain txs (core blocks
28480416–28480440): the metadata contains `orig_filename` and a correct
`stem_of`, and replaying the exact tx through the vendored ETL persists
`stem_of` fine.
2. **The endpoint scanned NULLs into non-pointer `string`/`int` fields**
(`pgx.RowToStructByName`), so one ETL-shaped row 500s the whole response
— every stem on the parent disappears, not just the affected one.
3. #973 (June 23) fixed the `orig_filename` scan via
`COALESCE(orig_filename, title, '')`. Prod is running `915c37d` today
(pods restarted 2026-07-26 08:07 UTC), which includes it — but the
incident behavior on 7/20–7/25 is consistent with the pods running a
**pre-#973 build** until that 7/26 restart. Worth confirming from deploy
history (`kubectl --context prod -n api rollout history` / image tags).
4. **Still broken until this PR:** a `stems` join row can outlive
`tracks.stem_of`. An explicit `"stem_of": null` in a client update wipes
the column (clients send the full track object on edit — same failure
class as the CID wipe fixed in OpenAudio/go-openaudio#410) while the
`stems` row survives. `category` and `parent_track_id` then come back
NULL from the jsonb and the request 500s again.
## Fix
- `COALESCE(t.stem_of->>'category', '')`, `COALESCE(t.track_cid, '')`
- `parent_track_id` now read from the `stems` join key (never NULL)
instead of the jsonb
- Regression test `TestGetTrackStemsWipedStemOf`: seeds a stems row
whose track has no `stem_of`/`orig_filename` — 500 before, 200 after
## Blast radius
Every stem uploaded after the ~July 12 cutover was invisible in the UI
while the NULL-scan bug was live (any parent with ≥1 ETL-shaped stem row
500'd). The DB rows themselves are intact — once the endpoint tolerates
NULLs, existing stems reappear with no reindex.
## Andrew Lux follow-up (support)
Andrew deleted all of his stems while debugging (one on 7/25 13:38 UTC
after 9 retries, a fresh batch uploaded 7/25 14:08–14:50, then a bulk
on-chain `Track/Delete` of everything on 7/27 12:35 UTC). Deleted tracks
can't be un-deleted on-chain, so **after this deploys he needs to
re-upload the stems once** via Edit Track → stems on "Alone" — the same
flow he used before; nothing was wrong with his uploads.
## Go ETL follow-ups (OpenAudio/go-openaudio — patches staged locally,
separate PR)
- [ ] Persist `orig_filename` on track create/update (Python parity;
never-clear like the CIDs) so new rows don't rely on the title fallback
- [ ] Ignore explicit `"stem_of": null` in track updates (same guard as
the #410 CID fix) so client edits can't unlink stems
- [ ] Upsert the `stems` join row when an update carries `stem_of` (also
gives us an on-chain repair path for lost links)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@raymondjacobson
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Fix stems endpoint with null original filenames - #973

Merged
raymondjacobson merged 1 commit into
mainfrom
codex/fix-null-stem-filenames
Jun 24, 2026
Merged

Fix stems endpoint with null original filenames#973
raymondjacobson merged 1 commit into
mainfrom
codex/fix-null-stem-filenames

Conversation

@raymondjacobson

Copy link
Copy Markdown
Member

Summary

  • return a stable filename string from the track stems endpoint when tracks.orig_filename is null
  • order stems by track ID for deterministic responses
  • add a regression case for a stem row with a null original filename

Verification

  • go test ./api -run TestGetTrackStems -count=1

Live investigation

  • GET /v1/tracks/qJ0RAXE/stems was returning 500: cannot scan NULL into *string for Burko's contest track
  • read-only prod query verified parent track 1960897973 has 30 current, non-deleted stem rows, 10 distinct titles, and all 30 rows have orig_filename IS NULL

@raymondjacobson
raymondjacobson merged commit 0881627 into mainJun 24, 2026
5 checks passed
@raymondjacobson
raymondjacobson deleted the codex/fix-null-stem-filenames branch June 24, 2026 01:32
dylanjeffers added a commit that referenced this pull request Jul 27, 2026
…ing (stems invisible since ~Jul 12 cutover) (#995)
## TL;DR
`/v1/tracks/{id}/stems` fails the entire request when any selected
column scans NULL into a non-pointer Go field, and every stem indexed by
the Go ETL since the ~July 12 Python→Go cutover has NULL
`orig_filename`. The result was a **silent 500** that made the stems
section / ContestStemsCard blank for post-cutover uploads — most visibly
Andrew Lux's "Alone" remix contest (parent `JBKl7R6`, 43 stems uploaded
7/20, all correct on-chain). #973 fixed the `orig_filename` case on main
(June 23), but this PR closes the remaining NULL-scan path (`stem_of`
wiped → `category`/`parent_track_id` NULL) and adds regression coverage.
## Root cause chain
1. **The Go ETL never persists `orig_filename`** — the entity-manager
create handler doesn't extract it, so only legacy Python-indexed rows
carry a value. Verified against the raw on-chain txs (core blocks
28480416–28480440): the metadata contains `orig_filename` and a correct
`stem_of`, and replaying the exact tx through the vendored ETL persists
`stem_of` fine.
2. **The endpoint scanned NULLs into non-pointer `string`/`int` fields**
(`pgx.RowToStructByName`), so one ETL-shaped row 500s the whole response
— every stem on the parent disappears, not just the affected one.
3. #973 (June 23) fixed the `orig_filename` scan via
`COALESCE(orig_filename, title, '')`. Prod is running `915c37d` today
(pods restarted 2026-07-26 08:07 UTC), which includes it — but the
incident behavior on 7/20–7/25 is consistent with the pods running a
**pre-#973 build** until that 7/26 restart. Worth confirming from deploy
history (`kubectl --context prod -n api rollout history` / image tags).
4. **Still broken until this PR:** a `stems` join row can outlive
`tracks.stem_of`. An explicit `"stem_of": null` in a client update wipes
the column (clients send the full track object on edit — same failure
class as the CID wipe fixed in OpenAudio/go-openaudio#410) while the
`stems` row survives. `category` and `parent_track_id` then come back
NULL from the jsonb and the request 500s again.
## Fix
- `COALESCE(t.stem_of->>'category', '')`, `COALESCE(t.track_cid, '')`
- `parent_track_id` now read from the `stems` join key (never NULL)
instead of the jsonb
- Regression test `TestGetTrackStemsWipedStemOf`: seeds a stems row
whose track has no `stem_of`/`orig_filename` — 500 before, 200 after
## Blast radius
Every stem uploaded after the ~July 12 cutover was invisible in the UI
while the NULL-scan bug was live (any parent with ≥1 ETL-shaped stem row
500'd). The DB rows themselves are intact — once the endpoint tolerates
NULLs, existing stems reappear with no reindex.
## Andrew Lux follow-up (support)
Andrew deleted all of his stems while debugging (one on 7/25 13:38 UTC
after 9 retries, a fresh batch uploaded 7/25 14:08–14:50, then a bulk
on-chain `Track/Delete` of everything on 7/27 12:35 UTC). Deleted tracks
can't be un-deleted on-chain, so **after this deploys he needs to
re-upload the stems once** via Edit Track → stems on "Alone" — the same
flow he used before; nothing was wrong with his uploads.
## Go ETL follow-ups (OpenAudio/go-openaudio — patches staged locally,
separate PR)
- [ ] Persist `orig_filename` on track create/update (Python parity;
never-clear like the CIDs) so new rows don't rely on the title fallback
- [ ] Ignore explicit `"stem_of": null` in track updates (same guard as
the #410 CID fix) so client edits can't unlink stems
- [ ] Upsert the `stems` join row when an update carries `stem_of` (also
gives us an on-chain repair path for lost links)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@raymondjacobson