Skip to content

FIx CI for feature-remove-libs - #10054

Merged
rickyrombo merged 24 commits into
feature-remove-libsfrom
mjp-fix-ci
Oct 15, 2024
Merged

FIx CI for feature-remove-libs#10054
rickyrombo merged 24 commits into
feature-remove-libsfrom
mjp-fix-ci

Conversation

@rickyrombo

@rickyromborickyrombo commented Oct 15, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Adds optional dep on @rollup/rollup-linux-x64-gnu per Error: Cannot find module @rollup/rollup-linux-x64-gnu on Docker container vitejs/vite#15532 (comment)
  • Migrates tests to vitest (turns out this was somewhat unnecessary? but kept it anyway)
  • Adds SDK node modules and build output to relevant caches in CI
  • Install openssl in the setup script to ensure we don't have to build it from source with node-gyp (which fails)
  • Adds paths to metro config for libs and eth packages
  • Moves sentry import to local node_modules
  • Update audius-cmd to use legacy
  • Add back legacy dep where needed
  • Replace audius-sdk tests with locally running test instead of dockerized version
  • Remove audius-libs tests (didn't want to futz with getting them working, we're getting rid of libs anyway)

@changeset-bot

changeset-botBot commented Oct 15, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 52526e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

rickyrombo
rickyrombo commented Oct 15, 2024
View reviewed changes
Comment threadpackages/libs/package.json
@audius-infra

audius-infra commented Oct 15, 2024

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/mjp-fix-ci

raymondjacobson
raymondjacobson approved these changes Oct 15, 2024
View reviewed changes
Comment threadpackages/mobile/metro.config.js
const sdkPath = path.resolve(__dirname, '../../packages/libs')
const libsPath = path.resolve(__dirname, '../../packages/libs')
const sdkPath = path.resolve(__dirname, '../../packages/sdk')
const ethPath = path.resolve(__dirname, '../../packages/eth')

@raymondjacobsonraymondjacobsonOct 15, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surprised this was needed

@rickyromborickyromboOct 15, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think metro doesn't follow the * deps like the rest, so all of them need to be specified?

@rickyrombo
rickyrombo merged commit 2e95862 into feature-remove-libsOct 15, 2024
@rickyrombo
rickyrombo deleted the mjp-fix-ci branch October 15, 2024 00:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondjacobsonraymondjacobsonraymondjacobson approved these changes
@schottraschottraAwaiting requested review from schottra
@sliptypesliptypeAwaiting requested review from sliptype

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rickyrombo@audius-infra@raymondjacobson