[C-5180] Comment count polling & cache updates by DejayJD · Pull Request #10157 · AudiusProject/apps

DejayJD · 2024-10-22T21:58:04Z

Description

Various changes

Stops using AggregateTrack.comment_count for comment counts, instead use a query that accounts for mutes & reports for each user
New endpoint just for track comment count
Add new tan query method & cache setup for querying the new endpoint and polling it
Make "new comments" button only show up when the comment count increases from the polling endpoint
Refactor track cache comment count usage to prefer the tan-query cache data when available

How Has This Been Tested?

web:dev

changeset-bot · 2024-10-22T21:58:08Z

⚠️ No Changeset found

Latest commit: 8f3f2ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dylanjeffers

looks great!!!

dylanjeffers · 2024-10-22T22:34:05Z

+
+ console.log({ commentCountData })
+
+ const hasNewComments = useMemo(


dont need to memoize this since its a fast compute

ah good catch, I had this in here when I was debugging some infinite rerender issues

dylanjeffers · 2024-10-22T22:35:21Z

+from src.utils.db_session import get_db_read_replica
+
+
+def get_track_comment_count(track_id, current_user_id, db_session=None):


nice work on this. i wonder if we can share code at some point

Yeah I had the same thought but I didn't want to get stuck in a big refactor at this point in the game. Ideally we share the logic between get comments, get counts, and get replies

dylanjeffers · 2024-10-22T22:35:53Z

- user[
-response_name_constants.current_user_followee_follow_count
-] = current_user_followee_follow_count_dict.get(user_id, 0)
+ user[response_name_constants.does_current_user_follow] = (


cd packages/discovery-provider && ./scripts/lint.sh

dylanjeffers · 2024-10-22T22:41:10Z


+ // Check for comment count in tanquery cache first because that value gets polled and updated more often
+ const comment_count =
+ useCachedTrackCommentCount(track_id, currentUserId)?.data?.currentValue ??


this does make me a little nervous but i suppose it's not a huge perf it as long as usCacheTrackCommentCount not firing a lot

I ended up changing this. For a few different reasons I decided to not reference tan query cache anywhere but comments and instead just keep dispatching events to the legacy cache to update it.

audius-infra · 2024-10-23T00:43:42Z

Preview this change https://demo.audius.co/jd/comment-count-polling

audius-infra · 2024-10-23T19:56:14Z

Preview this change https://demo.audius.co/jd/comment-count-polling

…jd/comment-count-polling # Conflicts: # packages/common/src/api/tan-query/comments.ts # packages/common/src/context/comments/commentsContext.tsx # packages/discovery-provider/src/queries/get_comments.py # packages/mobile/src/components/comments/CommentDrawerHeader.tsx

audius-infra · 2024-10-23T20:47:05Z

Preview this change https://demo.audius.co/jd/comment-count-polling

audius-infra · 2024-10-23T22:33:41Z

Preview this change https://demo.audius.co/jd/comment-count-polling

[982eb7f] Fix comment notification tests (#10174) Dylan Jeffers [c7ecd86] Bump chat create rate limit to unblock blasts (#10179) Andrew Mendelsohn [2e3ca0d] [C-5180] Comment count polling & cache updates (#10157) JD Francis [56e346c] [C-5259] Fix comment push notification deep links (#10167) Dylan Jeffers [f7e864e] [C-5144] Disable caching on unclaimed comment ID (#10170) Isaac Solo

* origin/main: (61 commits) Remove comment reaction notifications on web (#10190) Use replaceRecentBlockhash to fix BlockhashNotFound error (#10188) [C-5185, C-5246, C-5250, C-5254] Update web and mobile comments to respect mentions being passed back from the backend (#10185) Update metadata for comment edit to be trackId (#10187) [C-5264] Update comment specifiers (#10180) [C-5260] Add comment reaction notifications (#10175) [C-5263] Blur comment after submitting (#10178) Improve comment count queries, fix tests (#10181) [PAY-3536] Improve $AUDIO VIP Tier UI (#10154) Audius Protocol v0.7.19 Fix comment notification tests (#10174) Bump chat create rate limit to unblock blasts (#10179) [C-5180] Comment count polling & cache updates (#10157) [C-5232] Navigate to comments on comments preview click (#10176) [C-5232] Fix clipped artist popovers on comments section (#10172) new prod chain (#10173) [C-5259] Fix comment push notification deep links (#10167) [C-5144] Disable caching on unclaimed comment ID (#10170) [C-5257] Limit mentions to 10 in ComposerInput (#10171) [C-5226] [C-5225] Allow ComposerInput scrolling with mentions (#10166) ...

[4115060] [C-5276] Fix timestamp stuck on mobile comments (#10206) Sebastian Klingler [f3ab276] [C-5091] web comments analytics (#10202) Sebastian Klingler [fa4f1d7] [C-5200] Fix tombstone comments (#10203) JD Francis [2abd26e] Fix liked by artist logic error (#10195) JD Francis [3a56c51] [C-5273] Add user select to comment text (#10201) Raymond Jacobson [43f7e79] [C-5285] Fix comment notification user list title (#10200) Raymond Jacobson [2491f56] [QA-1766] Update audius careers link (#10198) Andrew Mendelsohn [9c5e3ea] Fix composer input for chats (#10194) Raymond Jacobson [031d171] [C-5277] Fix alignment of comment "artist pick" on mobile (#10197) Raymond Jacobson [a71a46b] [PAY-3553] Show chat button when unauthed (#10196) Andrew Mendelsohn [44540db] [C-5091] Mobile comments analytics (#10192) Sebastian Klingler [e3eeb11] Revert "Remove comment reaction notifications on web (#10190)" (#10191) Dylan Jeffers [b9922c8] Remove comment reaction notifications on web (#10190) Dylan Jeffers [05ab72a] [C-5185, C-5246, C-5250, C-5254] Update web and mobile comments to respect mentions being passed back from the backend (#10185) Kyle Shanks [770020f] Update metadata for comment edit to be trackId (#10187) JD Francis [54c8c64] [C-5264] Update comment specifiers (#10180) Dylan Jeffers [8ef6399] [C-5260] Add comment reaction notifications (#10175) Dylan Jeffers [4cd6d9d] [C-5263] Blur comment after submitting (#10178) Isaac Solo [fbbfd22] [PAY-3536] Improve $AUDIO VIP Tier UI (#10154) Raymond Jacobson [2e3ca0d] [C-5180] Comment count polling & cache updates (#10157) JD Francis [a01d02a] [C-5232] Navigate to comments on comments preview click (#10176) Andrew Mendelsohn [09ba221] [C-5232] Fix clipped artist popovers on comments section (#10172) Andrew Mendelsohn [a620da0] [C-5257] Limit mentions to 10 in ComposerInput (#10171) Sebastian Klingler [0aa79e2] [C-5226] [C-5225] Allow ComposerInput scrolling with mentions (#10166) Sebastian Klingler [24349bd] [C-5053] Rework desktop comment load skeletons (#10168) JD Francis [d589306] [PAY-3542] Fix bad initial data in mobile inbox settings (#10169) Andrew Mendelsohn [eeb0456] Fix issue with mentions for create/reply/edit (#10165) Dylan Jeffers [48b501d] [C-5174] Update disable comments header (#10162) Dylan Jeffers [1fc09c6] [C-5217] Fix view other remixes (#10160) Dylan Jeffers [a3e1ba1] Upgrade mobile to version 1.1.120 (#10164) Dylan Jeffers [64b4c1e] [C-5242] Remove showComments query param after scrolling into view (#10163) Dylan Jeffers [eb13f19] Fix mentions type (#10159) Dylan Jeffers [3172f5d] Remove ENABLE_SPL_AUDIO feature flag (#10153) Reed [e101c1f] Upgrade fastlane to fix update-signing-cert (#10156) Dylan Jeffers [ef74fde] [C-5168] Fix android toasts (#10147) Dylan Jeffers [bc84c1f] [C-5252] Fix external links on mobile (#10152) Andrew Mendelsohn [ca969c8] [QA-1755] Fix toggling on native genre pills (#10145) Andrew Mendelsohn [61907aa] Update dapp-store build artifacts audius-infra [c98755d] [C-5229] Fix comment input focus on android (#10141) Sebastian Klingler [e496d5e] Fix mac prod build, remove warnings (#10130) Dylan Jeffers [bd9a403] [C-5244] Comment UI tweaks (#10131) Dylan Jeffers [d6b78db] [QA-1775] Fix validation error in mobile EditCollection (#10142) Andrew Mendelsohn [d5be322] [C-5075] Fix tan-query not handling tombstone states (#10132) JD Francis [a5a0f70] [C-5218] [C-5154] Restrict mobile comment input length (#10140) Sebastian Klingler [0323673] [C-5240] Close drawer when pressing comment owner in mobile comments (#10126) Sebastian Klingler [d4fc207] [C-5230] Hide 0 react counts (#10133) JD Francis [d20b99a] [C-5215] [C-5206] Fix some issues with compose input on mobile (#10125) Sebastian Klingler [579f17d] [C-5163 Fix commenter name overflowing (#10124) Isaac Solo

[982eb7f] Fix comment notification tests (#10174) Dylan Jeffers [c7ecd86] Bump chat create rate limit to unblock blasts (#10179) Andrew Mendelsohn [2e3ca0d] [C-5180] Comment count polling & cache updates (#10157) JD Francis [56e346c] [C-5259] Fix comment push notification deep links (#10167) Dylan Jeffers [f7e864e] [C-5144] Disable caching on unclaimed comment ID (#10170) Isaac Solo

[4115060] [C-5276] Fix timestamp stuck on mobile comments (#10206) Sebastian Klingler [f3ab276] [C-5091] web comments analytics (#10202) Sebastian Klingler [fa4f1d7] [C-5200] Fix tombstone comments (#10203) JD Francis [2abd26e] Fix liked by artist logic error (#10195) JD Francis [3a56c51] [C-5273] Add user select to comment text (#10201) Raymond Jacobson [43f7e79] [C-5285] Fix comment notification user list title (#10200) Raymond Jacobson [2491f56] [QA-1766] Update audius careers link (#10198) Andrew Mendelsohn [9c5e3ea] Fix composer input for chats (#10194) Raymond Jacobson [031d171] [C-5277] Fix alignment of comment "artist pick" on mobile (#10197) Raymond Jacobson [a71a46b] [PAY-3553] Show chat button when unauthed (#10196) Andrew Mendelsohn [44540db] [C-5091] Mobile comments analytics (#10192) Sebastian Klingler [e3eeb11] Revert "Remove comment reaction notifications on web (#10190)" (#10191) Dylan Jeffers [b9922c8] Remove comment reaction notifications on web (#10190) Dylan Jeffers [05ab72a] [C-5185, C-5246, C-5250, C-5254] Update web and mobile comments to respect mentions being passed back from the backend (#10185) Kyle Shanks [770020f] Update metadata for comment edit to be trackId (#10187) JD Francis [54c8c64] [C-5264] Update comment specifiers (#10180) Dylan Jeffers [8ef6399] [C-5260] Add comment reaction notifications (#10175) Dylan Jeffers [4cd6d9d] [C-5263] Blur comment after submitting (#10178) Isaac Solo [fbbfd22] [PAY-3536] Improve $AUDIO VIP Tier UI (#10154) Raymond Jacobson [2e3ca0d] [C-5180] Comment count polling & cache updates (#10157) JD Francis [a01d02a] [C-5232] Navigate to comments on comments preview click (#10176) Andrew Mendelsohn [09ba221] [C-5232] Fix clipped artist popovers on comments section (#10172) Andrew Mendelsohn [a620da0] [C-5257] Limit mentions to 10 in ComposerInput (#10171) Sebastian Klingler [0aa79e2] [C-5226] [C-5225] Allow ComposerInput scrolling with mentions (#10166) Sebastian Klingler [24349bd] [C-5053] Rework desktop comment load skeletons (#10168) JD Francis [d589306] [PAY-3542] Fix bad initial data in mobile inbox settings (#10169) Andrew Mendelsohn [eeb0456] Fix issue with mentions for create/reply/edit (#10165) Dylan Jeffers [48b501d] [C-5174] Update disable comments header (#10162) Dylan Jeffers [1fc09c6] [C-5217] Fix view other remixes (#10160) Dylan Jeffers [a3e1ba1] Upgrade mobile to version 1.1.120 (#10164) Dylan Jeffers [64b4c1e] [C-5242] Remove showComments query param after scrolling into view (#10163) Dylan Jeffers [eb13f19] Fix mentions type (#10159) Dylan Jeffers [3172f5d] Remove ENABLE_SPL_AUDIO feature flag (#10153) Reed [e101c1f] Upgrade fastlane to fix update-signing-cert (#10156) Dylan Jeffers [ef74fde] [C-5168] Fix android toasts (#10147) Dylan Jeffers [bc84c1f] [C-5252] Fix external links on mobile (#10152) Andrew Mendelsohn [ca969c8] [QA-1755] Fix toggling on native genre pills (#10145) Andrew Mendelsohn [61907aa] Update dapp-store build artifacts audius-infra [c98755d] [C-5229] Fix comment input focus on android (#10141) Sebastian Klingler [e496d5e] Fix mac prod build, remove warnings (#10130) Dylan Jeffers [bd9a403] [C-5244] Comment UI tweaks (#10131) Dylan Jeffers [d6b78db] [QA-1775] Fix validation error in mobile EditCollection (#10142) Andrew Mendelsohn [d5be322] [C-5075] Fix tan-query not handling tombstone states (#10132) JD Francis [a5a0f70] [C-5218] [C-5154] Restrict mobile comment input length (#10140) Sebastian Klingler [0323673] [C-5240] Close drawer when pressing comment owner in mobile comments (#10126) Sebastian Klingler [d4fc207] [C-5230] Hide 0 react counts (#10133) JD Francis [d20b99a] [C-5215] [C-5206] Fix some issues with compose input on mobile (#10125) Sebastian Klingler [579f17d] [C-5163 Fix commenter name overflowing (#10124) Isaac Solo

DejayJD added 5 commits October 22, 2024 15:55

backend logic & sdk changes
e4d61c0

tan query logic
0417561

almost there
27f5dd7

tweak how I reset the comment count
e18cced

remove console logs
eab1c3d

DejayJD requested review from Kyle-Shanks, dylanjeffers, isaacsolo and sliptype October 22, 2024 21:58

pull-request-sizeBot added the size/XL label Oct 22, 2024

dylanjeffers approved these changes Oct 22, 2024
View reviewed changes

DejayJD added 3 commits October 22, 2024 19:00

Update track cache instead of trying to use tan query cache
a91da73

Use an effect instead of every poll
4b4b971

remove audius-query commetns
593fb1c

DejayJD added 2 commits October 23, 2024 13:30

lint + remove unnecessary memo
abcfb8d

refactor mishap
3cd806c

DejayJD added 2 commits October 23, 2024 15:19

merge lint
0cb17ae

DejayJD added 3 commits October 23, 2024 16:20

remove unused
dfb4a4b

Fix merge misc
88c8298

lint :(
8f3f2ba

DejayJD merged commit 2e3ca0d into mainOct 23, 2024

DejayJD deleted the jd/comment-count-polling branch October 23, 2024 23:24

samgutentag pushed a commit that referenced this pull request Nov 1, 2024
[C-5180] Comment count polling & cache updates (#10157)
4298011


		console.log({ commentCountData })

		const hasNewComments = useMemo(

		from src.utils.db_session import get_db_read_replica


		def get_track_comment_count(track_id, current_user_id, db_session=None):

Uh oh!

Conversation

DejayJD commented Oct 22, 2024

Description

How Has This Been Tested?

Uh oh!

changeset-botBot commented Oct 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

dylanjeffers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dylanjeffersOct 22, 2024

Choose a reason for hiding this comment

Uh oh!

DejayJDOct 23, 2024

Choose a reason for hiding this comment

Uh oh!

dylanjeffersOct 22, 2024

Choose a reason for hiding this comment

Uh oh!

DejayJDOct 23, 2024

Choose a reason for hiding this comment

Uh oh!

dylanjeffersOct 22, 2024

Choose a reason for hiding this comment

Uh oh!

dylanjeffersOct 22, 2024

Choose a reason for hiding this comment

Uh oh!

DejayJDOct 23, 2024

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Oct 23, 2024

Uh oh!

audius-infra commented Oct 23, 2024

Uh oh!

audius-infra commented Oct 23, 2024

Uh oh!

audius-infra commented Oct 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-botBot commented Oct 22, 2024•
edited
Loading